René's URL Explorer Experiment


Title: Language server caching over-disposes LS instances, breaks on interpreter change · Issue #11317 · microsoft/vscode-python · GitHub

Open Graph Title: Language server caching over-disposes LS instances, breaks on interpreter change · Issue #11317 · microsoft/vscode-python

X Title: Language server caching over-disposes LS instances, breaks on interpreter change · Issue #11317 · microsoft/vscode-python

Description: #8815 introduced LS caching and ref counting, such that the interactive window can reference the same language server as the regular code and keep it around until it's no longer needed. The keys are resource scoped, which are good for en...

Open Graph Description: #8815 introduced LS caching and ref counting, such that the interactive window can reference the same language server as the regular code and keep it around until it's no longer needed. The keys ar...

X Description: #8815 introduced LS caching and ref counting, such that the interactive window can reference the same language server as the regular code and keep it around until it's no longer needed. The key...

Opengraph URL: https://github.com/microsoft/vscode-python/issues/11317

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Language server caching over-disposes LS instances, breaks on interpreter change","articleBody":"#8815 introduced LS caching and ref counting, such that the interactive window can reference the same language server as the regular code and keep it around until it's no longer needed. The keys are resource scoped, which are good for ensuring things are shared and the minimum number of LSs are spawned.\r\n\r\nUnfortunately, the `activeServer` and `resource` properties are essentially \"globals\" to the extension as a whole. The current code kills LSs as the user moves around different files to save resources, however this breaks multi-root workspaces which rely on being able to navigate around and still get code completions. (e.g., I open two files, one in each workspace, and switch between them)\r\n\r\nAdditionally, I believe the current code over-disposes, leading to a scenario where on the first active LS change, the next spawned server cannot be killed and isn't configured correctly, leading both to https://github.com/microsoft/vscode-python/issues/5132#issuecomment-603571156 and a related bug where the next-spawned server's interpreter doesn't change.\r\n\r\nThe solution here is to eliminate `activeServer` and `resource` and make LSs fully resource-scoped (only accessible by key). Once a LS is no longer referenced (no handles from the interactive window, and its workspace no longer exists), the LS can be thrown away.","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2020-04-22T00:00:04Z","url":"https://github.com/microsoft/vscode-python/issues/11317"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1234e641-12e4-f86f-0e9b-0c53bf3fdf78
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA894:1DB568:831A61:B0F743:6AFE5A3C
html-safe-noncea9a7483691945b5d5a395fc6640f7438d1f7a2f9a2dd77f9640b115f65b035ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODk0OjFEQjU2ODo4MzFBNjE6QjBGNzQzOjZBRkU1QTNDIiwidmlzaXRvcl9pZCI6IjY2NzU2NDI1NjU4ODQwMDkwMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb264c5e9dd17865140d57c5905cde77a40b32d6356fec67f11e2676b4860b9d4
hovercard-subject-tagissue:604357532
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/vscode-python/11317/issue_layout
twitter:imagehttps://opengraph.githubassets.com/62aed125c4f14e7e58fffa076510ae5bfa3b3bb3e885fefabcb19fc052ffda86/microsoft/vscode-python/issues/11317
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/62aed125c4f14e7e58fffa076510ae5bfa3b3bb3e885fefabcb19fc052ffda86/microsoft/vscode-python/issues/11317
og:image:alt#8815 introduced LS caching and ref counting, such that the interactive window can reference the same language server as the regular code and keep it around until it's no longer needed. The keys ar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/microsoft/vscode-python git https://github.com/microsoft/vscode-python.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id106462765
octolytics-dimension-repository_nwomicrosoft/vscode-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id49946255
octolytics-dimension-repository_parent_nwoDonJayamanne/pythonVSCode
octolytics-dimension-repository_network_root_id49946255
octolytics-dimension-repository_network_root_nwoDonJayamanne/pythonVSCode
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/vscode-python/issues/11317#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fissues%2F11317
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fissues%2F11317
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2Fvscode-python
Reloadhttps://github.com/microsoft/vscode-python/issues/11317
Reloadhttps://github.com/microsoft/vscode-python/issues/11317
Reloadhttps://github.com/microsoft/vscode-python/issues/11317
microsofthttps://github.com/microsoft
vscode-pythonhttps://github.com/microsoft/vscode-python
Codehttps://github.com/microsoft/vscode-python
Issues344 (344)https://github.com/microsoft/vscode-python/issues
Pull requests54 (54)https://github.com/microsoft/vscode-python/pulls
Discussionshttps://github.com/microsoft/vscode-python/discussions
Actionshttps://github.com/microsoft/vscode-python/actions
Wikihttps://github.com/microsoft/vscode-python/wiki
Security and quality2 (2)https://github.com/microsoft/vscode-python/security
Insightshttps://github.com/microsoft/vscode-python/insights
https://github.com/microsoft/vscode-python
New issuehttps://github.com/login?return_to=https://github.com/microsoft/vscode-python/issues/11317
New issuehttps://github.com/login?return_to=https://github.com/microsoft/vscode-python/issues/11317
Language server caching over-disposes LS instances, breaks on interpreter changehttps://github.com/microsoft/vscode-python/issues/11317#top
bugIssue identified by VS Code Team member as probable bughttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22bug%22
regressionBug didn't exist in a previous releasehttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22regression%22
verifiedVerification succeededhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22verified%22
October 2021https://github.com/microsoft/vscode-python/milestone/75
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Apr 22, 2020https://github.com/microsoft/vscode-python/issues/11317#issue-604357532
#8815https://github.com/microsoft/vscode-python/pull/8815
#5132 (comment)https://github.com/microsoft/vscode-python/issues/5132#issuecomment-603571156
Jake Bailey (jakebailey)https://github.com/jakebailey
bugIssue identified by VS Code Team member as probable bughttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22bug%22
triage-neededNeeds assignment to the proper sub-teamhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22triage-needed%22
on Apr 22, 2020https://github.com/microsoft/vscode-python/issues/11317#event-3258311823
Karthik Nadig (karthiknadig)https://github.com/karthiknadig
needs PRhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22needs%20PR%22
on Apr 22, 2020https://github.com/microsoft/vscode-python/issues/11317#event-3261639809
triage-neededNeeds assignment to the proper sub-teamhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22triage-needed%22
on Apr 22, 2020https://github.com/microsoft/vscode-python/issues/11317#event-3261639963
https://github.com/ErwanDL
Erwan de Lépinau (ErwanDL)https://github.com/ErwanDL
on May 20, 2020https://github.com/microsoft/vscode-python/issues/11317#issuecomment-631735419
https://github.com/NikEyX
NikEyXhttps://github.com/NikEyX
on Jun 8, 2020https://github.com/microsoft/vscode-python/issues/11317#issuecomment-640900761
https://github.com/kcajf
kcajfhttps://github.com/kcajf
on Jun 8, 2020https://github.com/microsoft/vscode-python/issues/11317#issuecomment-640901008
Brett Cannon (brettcannon)https://github.com/brettcannon
reason-new featurehttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22reason-new%20feature%22
on Jun 8, 2020https://github.com/microsoft/vscode-python/issues/11317#event-3422394384
https://github.com/dixonqmg
dixonqmghttps://github.com/dixonqmg
on Jun 14, 2020https://github.com/microsoft/vscode-python/issues/11317#issuecomment-643782976
Brett Cannon (brettcannon)https://github.com/brettcannon
regressionBug didn't exist in a previous releasehttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22regression%22
reason-new featurehttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22reason-new%20feature%22
on Jul 3, 2020https://github.com/microsoft/vscode-python/issues/11317#event-3512034050
https://github.com/nfrasser
Nick Frasser (nfrasser)https://github.com/nfrasser
on Jul 17, 2020https://github.com/microsoft/vscode-python/issues/11317#issuecomment-660342087
Pylancehttps://devblogs.microsoft.com/python/announcing-pylance-fast-feature-rich-language-support-for-python-in-visual-studio-code/
https://github.com/karrtikr
Kartik Raj (karrtikr)https://github.com/karrtikr
on Oct 22, 2021https://github.com/microsoft/vscode-python/issues/11317#issuecomment-950003810
https://github.com/dixonqmg
dixonqmghttps://github.com/dixonqmg
on Oct 22, 2021https://github.com/microsoft/vscode-python/issues/11317#issuecomment-950016002
Kartik Raj (karrtikr)https://github.com/karrtikr
completedhttps://github.com/microsoft/vscode-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 22, 2021https://github.com/microsoft/vscode-python/issues/11317#event-5507536028
Kartik Raj (karrtikr)https://github.com/karrtikr
October 2021https://github.com/microsoft/vscode-python/milestone/75
on Oct 22, 2021https://github.com/microsoft/vscode-python/issues/11317#event-5507536186
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Oct 23, 2021https://github.com/microsoft/vscode-python/issues/11317#issuecomment-950027382
Kartik Raj (karrtikr)https://github.com/karrtikr
verifiedVerification succeededhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22verified%22
on Oct 25, 2021https://github.com/microsoft/vscode-python/issues/11317#event-5515934486
github-actionshttps://github.com/apps/github-actions
on Nov 26, 2021https://github.com/microsoft/vscode-python/issues/11317#event-5675051128
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/vscode-python/issues/11317
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/vscode-python/issues/11317
bugIssue identified by VS Code Team member as probable bughttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22bug%22
regressionBug didn't exist in a previous releasehttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22regression%22
verifiedVerification succeededhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22verified%22
October 2021https://github.com/microsoft/vscode-python/milestone/75
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.