René's URL Explorer Experiment


Title: Catch exceptions when importing from search paths by jakebailey · Pull Request #525 · microsoft/python-language-server · GitHub

Open Graph Title: Catch exceptions when importing from search paths by jakebailey · Pull Request #525 · microsoft/python-language-server

X Title: Catch exceptions when importing from search paths by jakebailey · Pull Request #525 · microsoft/python-language-server

Description: Fixes #522. Did this quick this morning, figured I'd PR instead of letting it sit around. @AlexanderSher Curious how you'd test this. Tried my hand for a bit but couldn't easily see a way to trigger this. I wanted to spawn a server, add a file in the test-specific root, then delete it, and then call ImportModuleAsync to see that I get ModuleNotFound, but I don't think I had the search paths setup correctly. Feel free to absorb this into a different PR if it's easier.

Open Graph Description: Fixes #522. Did this quick this morning, figured I'd PR instead of letting it sit around. @AlexanderSher Curious how you'd test this. Tried my hand for a bit but couldn't easily see a ...

X Description: Fixes #522. Did this quick this morning, figured I'd PR instead of letting it sit around. @AlexanderSher Curious how you'd test this. Tried my hand for a bit but couldn't e...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/525

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6035979a-7560-b381-918f-a732a6974f44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85E8:82F2D:16908A4:1F215CF:6A4DF2AF
html-safe-nonce1c8054b30dfafa9167ccc1d6741d343d3bc3c9a370b7bddce513c0f9625eceb2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUU4OjgyRjJEOjE2OTA4QTQ6MUYyMTVDRjo2QTRERjJBRiIsInZpc2l0b3JfaWQiOiIyNjg4NzQ2MDE5ODE0NzY1MjMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1e3fed89353e5c2ea4b51914acc199f6c23191d7e7f47dabacd4faaaf352f49f
hovercard-subject-tagpull_request:243157602
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/python-language-server/pull/525/files
twitter:imagehttps://avatars.githubusercontent.com/u/5341706?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5341706?s=400&v=4
og:image:altFixes #522. Did this quick this morning, figured I'd PR instead of letting it sit around. @AlexanderSher Curious how you'd test this. Tried my hand for a bit but couldn't easily see a ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/525/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F525%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F525%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/525/files
Reloadhttps://github.com/microsoft/python-language-server/pull/525/files
Reloadhttps://github.com/microsoft/python-language-server/pull/525/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/525/files
microsoft https://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Notifications https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Fork 131 https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Star 921 https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Code https://github.com/microsoft/python-language-server
Issues 309 https://github.com/microsoft/python-language-server/issues
Pull requests 6 https://github.com/microsoft/python-language-server/pulls
Projects https://github.com/microsoft/python-language-server/projects
Models https://github.com/microsoft/python-language-server/models
Wiki https://github.com/microsoft/python-language-server/wiki
Security and quality 0 https://github.com/microsoft/python-language-server/security
Insights https://github.com/microsoft/python-language-server/pulse
Code https://github.com/microsoft/python-language-server
Issues https://github.com/microsoft/python-language-server/issues
Pull requests https://github.com/microsoft/python-language-server/pulls
Projects https://github.com/microsoft/python-language-server/projects
Models https://github.com/microsoft/python-language-server/models
Wiki https://github.com/microsoft/python-language-server/wiki
Security and quality https://github.com/microsoft/python-language-server/security
Insights https://github.com/microsoft/python-language-server/pulse
jakebaileyhttps://github.com/jakebailey
microsoft:releasehttps://github.com/microsoft/python-language-server/tree/release
jakebailey:fix-import-exceptionshttps://github.com/jakebailey/python-language-server/tree/fix-import-exceptions
Conversation 4 https://github.com/microsoft/python-language-server/pull/525
Commits 2 https://github.com/microsoft/python-language-server/pull/525/commits
Checks 0 https://github.com/microsoft/python-language-server/pull/525/checks
Files changed https://github.com/microsoft/python-language-server/pull/525/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/525/files
Catch exceptions when importing from search paths https://github.com/microsoft/python-language-server/pull/525/files#top
Show all changes 2 commits https://github.com/microsoft/python-language-server/pull/525/files
8d43b49 catch exceptions when importing from search paths jakebailey Jan 8, 2019 https://github.com/microsoft/python-language-server/pull/525/commits/8d43b49a249111dd584ef3be600f13881ad93a14
1be9014 retry instead of not found jakebailey Jan 17, 2019 https://github.com/microsoft/python-language-server/pull/525/commits/1be90144c33e1a3648481dc609535ad26c8f21ae
Clear filters https://github.com/microsoft/python-language-server/pull/525/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/525/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/525/files
src/Analysis/Engine/Impl/Interpreter/Ast/AstModuleResolution.cshttps://github.com/microsoft/python-language-server/pull/525/files#diff-4b164b2d74aec138d5607d0931017e205d1404c837d9154e868c1947afb5d253
View file https://github.com/jakebailey/python-language-server/blob/1be90144c33e1a3648481dc609535ad26c8f21ae/src/Analysis/Engine/Impl/Interpreter/Ast/AstModuleResolution.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/525/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/525/files#diff-4b164b2d74aec138d5607d0931017e205d1404c837d9154e868c1947afb5d253
https://github.com/microsoft/python-language-server/pull/525/files#diff-4b164b2d74aec138d5607d0931017e205d1404c837d9154e868c1947afb5d253
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.