René's URL Explorer Experiment


Title: Mitigate some of #495 via MRO member selection and analysis set optimization by jakebailey · Pull Request #517 · microsoft/python-language-server · GitHub

Open Graph Title: Mitigate some of #495 via MRO member selection and analysis set optimization by jakebailey · Pull Request #517 · microsoft/python-language-server

X Title: Mitigate some of #495 via MRO member selection and analysis set optimization by jakebailey · Pull Request #517 · microsoft/python-language-server

Description: Microsoft Language Server for Python. Contribute to microsoft/python-language-server development by creating an account on GitHub.

Open Graph Description: This isn't a complete fix, but does seem to improve #495 in some cases. Adds back the early MRO return removed in #277, so now large class hierarchies won't over-propagate types (where some...

X Description: This isn't a complete fix, but does seem to improve #495 in some cases. Adds back the early MRO return removed in #277, so now large class hierarchies won't over-propagate types (wh...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/517

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:529217b0-d426-9e3f-aacf-f1e1f12383ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F4E:2C37E4:EB40CD:1588D5B:6A4E2FD9
html-safe-nonce72c13d2d92acd5da2d6049e0d678223dc3ff58dd35f113bb0eb99af64c0e94a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjRFOjJDMzdFNDpFQjQwQ0Q6MTU4OEQ1Qjo2QTRFMkZEOSIsInZpc2l0b3JfaWQiOiIzNTczNDg1NTMxNjIxNjM0MDA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac016f52733d5ecbdce0837d591469af7f90f6e759d9a6cdf01895a171d2ae8ca2
hovercard-subject-tagpull_request:241601536
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/517/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf42d364bfd1d34db9b67522f0b2698909d2dd666667ba6a6af6eab226acef91/microsoft/python-language-server/pull/517
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf42d364bfd1d34db9b67522f0b2698909d2dd666667ba6a6af6eab226acef91/microsoft/python-language-server/pull/517
og:image:altThis isn't a complete fix, but does seem to improve #495 in some cases. Adds back the early MRO return removed in #277, so now large class hierarchies won't over-propagate types (where some...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42a6d378d7587a44c93aca255096cd66b7c8eb2d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/517#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F517
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F517
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/517
Reloadhttps://github.com/microsoft/python-language-server/pull/517
Reloadhttps://github.com/microsoft/python-language-server/pull/517
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
microsoft https://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Notifications https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Fork 131 https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Star 921 https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Code https://github.com/microsoft/python-language-server
Issues 309 https://github.com/microsoft/python-language-server/issues
Pull requests 6 https://github.com/microsoft/python-language-server/pulls
Projects https://github.com/microsoft/python-language-server/projects
Models https://github.com/microsoft/python-language-server/models
Wiki https://github.com/microsoft/python-language-server/wiki
Security and quality 0 https://github.com/microsoft/python-language-server/security
Insights https://github.com/microsoft/python-language-server/pulse
Code https://github.com/microsoft/python-language-server
Issues https://github.com/microsoft/python-language-server/issues
Pull requests https://github.com/microsoft/python-language-server/pulls
Projects https://github.com/microsoft/python-language-server/projects
Models https://github.com/microsoft/python-language-server/models
Wiki https://github.com/microsoft/python-language-server/wiki
Security and quality https://github.com/microsoft/python-language-server/security
Insights https://github.com/microsoft/python-language-server/pulse
jakebaileyhttps://github.com/jakebailey
microsoft:releasehttps://github.com/microsoft/python-language-server/tree/release
jakebailey:fix-cpu-bughttps://github.com/jakebailey/python-language-server/tree/fix-cpu-bug
Conversationhttps://github.com/microsoft/python-language-server/pull/517
Commits4 (4)https://github.com/microsoft/python-language-server/pull/517/commits
Checkshttps://github.com/microsoft/python-language-server/pull/517/checks
Files changedhttps://github.com/microsoft/python-language-server/pull/517/files
Mitigate some of #495 via MRO member selection and analysis set optimizationhttps://github.com/microsoft/python-language-server/pull/517#top
jakebaileyhttps://github.com/jakebailey
microsoft:releasehttps://github.com/microsoft/python-language-server/tree/release
jakebailey:fix-cpu-bughttps://github.com/jakebailey/python-language-server/tree/fix-cpu-bug
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#issue-395032215
#495https://github.com/microsoft/python-language-server/issues/495
#277https://github.com/microsoft/python-language-server/pull/277
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
jakebaileyhttps://github.com/jakebailey
December 26, 2018 12:58https://github.com/microsoft/python-language-server/pull/517#commits-pushed-0a65305
https://github.com/jakebailey
optimize AnalysisHashSet.SetEquals a bithttps://github.com/microsoft/python-language-server/pull/517/commits/0a653057c75351eab4b7f0e24a4a04a4d0aacd8f
0a65305https://github.com/microsoft/python-language-server/pull/517/commits/0a653057c75351eab4b7f0e24a4a04a4d0aacd8f
https://github.com/jakebailey
enforce single instances of comparershttps://github.com/microsoft/python-language-server/pull/517/commits/3a7a3870ead1f9c6a2f9fb2ae63a441d49826ced
3a7a387https://github.com/microsoft/python-language-server/pull/517/commits/3a7a3870ead1f9c6a2f9fb2ae63a441d49826ced
https://github.com/jakebailey
restore early return on first MRO resulthttps://github.com/microsoft/python-language-server/pull/517/commits/75d47d1504f59702a11905d10883c31867484b83
75d47d1https://github.com/microsoft/python-language-server/pull/517/commits/75d47d1504f59702a11905d10883c31867484b83
https://github.com/jakebailey
optimize count accesseshttps://github.com/microsoft/python-language-server/pull/517/commits/93249e6e4170802060a4446dd115d094767cc772
93249e6https://github.com/microsoft/python-language-server/pull/517/commits/93249e6e4170802060a4446dd115d094767cc772
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
AlexanderSherhttps://github.com/AlexanderSher
MikhailArkhipovhttps://github.com/MikhailArkhipov
December 31, 2018 21:12https://github.com/microsoft/python-language-server/pull/517#event-2049226036
https://github.com/AlexanderSher
AlexanderSherhttps://github.com/AlexanderSher
Dec 31, 2018 https://github.com/microsoft/python-language-server/pull/517#pullrequestreview-188539003
View reviewed changes https://github.com/microsoft/python-language-server/pull/517/files/93249e6e4170802060a4446dd115d094767cc772
src/Analysis/Engine/Impl/AnalysisHashSet.cshttps://github.com/microsoft/python-language-server/pull/517/files/93249e6e4170802060a4446dd115d094767cc772#diff-0d2a49ad8abee1f00f5ee71fe9e8ff52e5a9b14dfb95f505ed43f68b91f57ad0
AlexanderSherhttps://github.com/AlexanderSher
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244620503
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
jakebaileyhttps://github.com/jakebailey
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244620632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
AlexanderSherhttps://github.com/AlexanderSher
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244621285
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
jakebaileyhttps://github.com/jakebailey
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244621472
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
AlexanderSherhttps://github.com/AlexanderSher
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244622949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@MikhailArkhipovhttps://github.com/MikhailArkhipov
Thin lockshttps://blogs.msdn.microsoft.com/seteplia/2017/09/06/managed-object-internals-part-2-object-header-layout-and-the-cost-of-locking/
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
jakebaileyhttps://github.com/jakebailey
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244623294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/Microsoft/python-language-server/blob/cb1c3dfbad1c7a521857a5dae8eea7c94225a096/src/Analysis/Engine/Impl/AnalysisHashSet.cs#L95-L106https://github.com/Microsoft/python-language-server/blob/cb1c3dfbad1c7a521857a5dae8eea7c94225a096/src/Analysis/Engine/Impl/AnalysisHashSet.cs#L95-L106
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
jakebaileyhttps://github.com/jakebailey
Dec 31, 2018https://github.com/microsoft/python-language-server/pull/517#discussion_r244623385
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
MikhailArkhipovhttps://github.com/MikhailArkhipov
Jan 2, 2019https://github.com/microsoft/python-language-server/pull/517#discussion_r244663522
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
MikhailArkhipovhttps://github.com/MikhailArkhipov
Jan 2, 2019https://github.com/microsoft/python-language-server/pull/517#discussion_r244663615
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
MikhailArkhipovhttps://github.com/MikhailArkhipov
Jan 2, 2019https://github.com/microsoft/python-language-server/pull/517#discussion_r244663652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
https://github.com/MikhailArkhipov
MikhailArkhipovhttps://github.com/MikhailArkhipov
Jan 2, 2019 https://github.com/microsoft/python-language-server/pull/517#pullrequestreview-188768817
View reviewed changes https://github.com/microsoft/python-language-server/pull/517/files/93249e6e4170802060a4446dd115d094767cc772
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
0893287https://github.com/microsoft/python-language-server/commit/0893287a5fbde3742fc7ded9e198e4a6e953f96c
Jan 2, 2019https://github.com/microsoft/python-language-server/pull/517#event-2050891531
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Dec 2018.3https://github.com/microsoft/python-language-server/milestone/8
Jan 18, 2019https://github.com/microsoft/python-language-server/pull/517#event-2083805773
AlexanderSherhttps://github.com/AlexanderSher
Feb 4, 2019 https://github.com/microsoft/python-language-server/pull/517#ref-commit-3026694
https://github.com/jakebailey
https://github.com/AlexanderSher
Mitigate some ofhttps://github.com/AlexanderSher/python-language-server/commit/3026694f75ed8e044b2369a886d17dd33408f800
microsoft#495https://github.com/microsoft/python-language-server/issues/495
via MRO member selection and analysis …https://github.com/AlexanderSher/python-language-server/commit/3026694f75ed8e044b2369a886d17dd33408f800
3026694https://github.com/AlexanderSher/python-language-server/commit/3026694f75ed8e044b2369a886d17dd33408f800
microsoft#517https://github.com/microsoft/python-language-server/pull/517
microsoft#495https://github.com/microsoft/python-language-server/issues/495
microsoft#277https://github.com/microsoft/python-language-server/pull/277
AlexanderSherhttps://github.com/AlexanderSher
Feb 4, 2019 https://github.com/microsoft/python-language-server/pull/517#ref-commit-a5b6e5e
https://github.com/AlexanderSher
Cherry pick fixes from Release branch into PTVS branch (https://github.com/microsoft/python-language-server/commit/a5b6e5e6f141b943dbbe9183863aabdbd718fccc
#578https://github.com/microsoft/python-language-server/pull/578
)https://github.com/microsoft/python-language-server/commit/a5b6e5e6f141b943dbbe9183863aabdbd718fccc
a5b6e5ehttps://github.com/microsoft/python-language-server/commit/a5b6e5e6f141b943dbbe9183863aabdbd718fccc
#470https://github.com/microsoft/python-language-server/issues/470
#478https://github.com/microsoft/python-language-server/pull/478
#498https://github.com/microsoft/python-language-server/pull/498
#495https://github.com/microsoft/python-language-server/issues/495
#517https://github.com/microsoft/python-language-server/pull/517
#495https://github.com/microsoft/python-language-server/issues/495
#277https://github.com/microsoft/python-language-server/pull/277
#509https://github.com/microsoft/python-language-server/issues/509
#519https://github.com/microsoft/python-language-server/pull/519
#510https://github.com/microsoft/python-language-server/issues/510
#525https://github.com/microsoft/python-language-server/pull/525
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
February 14, 2019 20:21https://github.com/microsoft/python-language-server/pull/517#event-2140770508
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F517
https://github.com/AlexanderSher
AlexanderSher https://github.com/AlexanderSher
https://github.com/microsoft/python-language-server/pull/517/files/93249e6e4170802060a4446dd115d094767cc772
https://github.com/MikhailArkhipov
MikhailArkhipov https://github.com/MikhailArkhipov
https://github.com/microsoft/python-language-server/pull/517/files/93249e6e4170802060a4446dd115d094767cc772
Dec 2018.3 https://github.com/microsoft/python-language-server/milestone/8
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/517
https://github.com/jakebailey
https://github.com/AlexanderSher
https://github.com/MikhailArkhipov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.