René's URL Explorer Experiment


Title: Fix various common exceptions, log on a failed directory load by jakebailey · Pull Request #498 · microsoft/python-language-server · GitHub

Open Graph Title: Fix various common exceptions, log on a failed directory load by jakebailey · Pull Request #498 · microsoft/python-language-server

X Title: Fix various common exceptions, log on a failed directory load by jakebailey · Pull Request #498 · microsoft/python-language-server

Description: Microsoft Language Server for Python. Contribute to microsoft/python-language-server development by creating an account on GitHub.

Open Graph Description: Fixes #448. Fixes #463. Fixes #440. (I didn't realize ? would short circuit. Found all mistakes with rg '\w+(\(\))?\?\.\w+\.Maybe') Also fixes the nullrefs coming from Shutdown. Opening...

X Description: Fixes #448. Fixes #463. Fixes #440. (I didn't realize ? would short circuit. Found all mistakes with rg '\w+(\(\))?\?\.\w+\.Maybe') Also fixes the nullrefs coming from Shutd...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/498

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7cf10825-2fa8-b29f-c591-e8811da5838b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE56:E1B7B:17542C:2226B0:6A4DFDA7
html-safe-nonce49543993caf44038069a52451d95e31c535142447b384c56082cfbd21e9f257a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTU2OkUxQjdCOjE3NTQyQzoyMjI2QjA6NkE0REZEQTciLCJ2aXNpdG9yX2lkIjoiOTE2MDE4ODk0NjU0NTUwNzc1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3216e63e53c39086c9f3941e98e59842fa8da08185bb4f1856897ed37b3fe95b
hovercard-subject-tagpull_request:240344926
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/498/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/36ccc9913aa8f093370666c99b2b65b15b3d6f8a0d8c6ec37ac2db676e853556/microsoft/python-language-server/pull/498
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/36ccc9913aa8f093370666c99b2b65b15b3d6f8a0d8c6ec37ac2db676e853556/microsoft/python-language-server/pull/498
og:image:altFixes #448. Fixes #463. Fixes #440. (I didn't realize ? would short circuit. Found all mistakes with rg '\w+(\(\))?\?\.\w+\.Maybe') Also fixes the nullrefs coming from Shutdown. Opening...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-cache
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4314b1df11fa8a565684f3a72dc971e3785da365
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/498#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F498
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F498
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/498
Reloadhttps://github.com/microsoft/python-language-server/pull/498
Reloadhttps://github.com/microsoft/python-language-server/pull/498
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/498
microsoft https://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Notifications https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Fork 131 https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Star 921 https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server
Code https://github.com/microsoft/python-language-server
Issues 309 https://github.com/microsoft/python-language-server/issues
Pull requests 6 https://github.com/microsoft/python-language-server/pulls
Projects https://github.com/microsoft/python-language-server/projects
Models https://github.com/microsoft/python-language-server/models
Wiki https://github.com/microsoft/python-language-server/wiki
Security and quality 0 https://github.com/microsoft/python-language-server/security
Insights https://github.com/microsoft/python-language-server/pulse
Code https://github.com/microsoft/python-language-server
Issues https://github.com/microsoft/python-language-server/issues
Pull requests https://github.com/microsoft/python-language-server/pulls
Projects https://github.com/microsoft/python-language-server/projects
Models https://github.com/microsoft/python-language-server/models
Wiki https://github.com/microsoft/python-language-server/wiki
Security and quality https://github.com/microsoft/python-language-server/security
Insights https://github.com/microsoft/python-language-server/pulse
jakebaileyhttps://github.com/jakebailey
microsoft:releasehttps://github.com/microsoft/python-language-server/tree/release
jakebailey:fix-misc-exceptionshttps://github.com/jakebailey/python-language-server/tree/fix-misc-exceptions
Conversationhttps://github.com/microsoft/python-language-server/pull/498
Commits6 (6)https://github.com/microsoft/python-language-server/pull/498/commits
Checkshttps://github.com/microsoft/python-language-server/pull/498/checks
Files changedhttps://github.com/microsoft/python-language-server/pull/498/files
Fix various common exceptions, log on a failed directory loadhttps://github.com/microsoft/python-language-server/pull/498#top
jakebaileyhttps://github.com/jakebailey
microsoft:releasehttps://github.com/microsoft/python-language-server/tree/release
jakebailey:fix-misc-exceptionshttps://github.com/jakebailey/python-language-server/tree/fix-misc-exceptions
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Dec 21, 2018https://github.com/microsoft/python-language-server/pull/498#issue-393270300
#448https://github.com/microsoft/python-language-server/issues/448
#463https://github.com/microsoft/python-language-server/issues/463
#440https://github.com/microsoft/python-language-server/issues/440
#448https://github.com/microsoft/python-language-server/issues/448
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/498
jakebaileyhttps://github.com/jakebailey
December 20, 2018 13:13https://github.com/microsoft/python-language-server/pull/498#commits-pushed-8faf545
https://github.com/jakebailey
rethrow exception after telemetry instead of disposinghttps://github.com/microsoft/python-language-server/pull/498/commits/8faf5450e4b00288c90321bd38eb931018968087
8faf545https://github.com/microsoft/python-language-server/pull/498/commits/8faf5450e4b00288c90321bd38eb931018968087
https://github.com/jakebailey
log an error instead of crashing when hitting some exceptions loading…https://github.com/microsoft/python-language-server/pull/498/commits/dfca4a0043261437e4e59511422b7085b8078923
dfca4a0https://github.com/microsoft/python-language-server/pull/498/commits/dfca4a0043261437e4e59511422b7085b8078923
https://github.com/jakebailey
fix short circuiting of question mark checks to prevent null from bei…https://github.com/microsoft/python-language-server/pull/498/commits/0c5373b6674ed81e168e1d1e3754deb79b2630d3
0c5373bhttps://github.com/microsoft/python-language-server/pull/498/commits/0c5373b6674ed81e168e1d1e3754deb79b2630d3
https://github.com/jakebailey
print name of exception instead of relying on ToStringhttps://github.com/microsoft/python-language-server/pull/498/commits/311779232b5ba446390e57eefd1899483916476b
3117792https://github.com/microsoft/python-language-server/pull/498/commits/311779232b5ba446390e57eefd1899483916476b
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
AlexanderSherhttps://github.com/AlexanderSher
MikhailArkhipovhttps://github.com/MikhailArkhipov
December 21, 2018 01:02https://github.com/microsoft/python-language-server/pull/498#event-2039753962
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
December 21, 2018 01:02https://github.com/microsoft/python-language-server/pull/498#event-2039754170
https://github.com/MikhailArkhipov
MikhailArkhipovhttps://github.com/MikhailArkhipov
Dec 21, 2018 https://github.com/microsoft/python-language-server/pull/498#pullrequestreview-187489425
View reviewed changes https://github.com/microsoft/python-language-server/pull/498/files/311779232b5ba446390e57eefd1899483916476b
src/Analysis/Engine/Impl/Values/BuiltinNamespace.cshttps://github.com/microsoft/python-language-server/pull/498/files/311779232b5ba446390e57eefd1899483916476b#diff-935b987f1c0df0182cdb9f0dec83514bbcbd2b3c8b5d409293529346a1525b73
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/498
https://github.com/MikhailArkhipov
MikhailArkhipovhttps://github.com/MikhailArkhipov
Dec 21, 2018 https://github.com/microsoft/python-language-server/pull/498#pullrequestreview-187489630
View reviewed changes https://github.com/microsoft/python-language-server/pull/498/files/311779232b5ba446390e57eefd1899483916476b
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Dec 21, 2018https://github.com/microsoft/python-language-server/pull/498#issuecomment-449459720
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/498
https://github.com/MikhailArkhipov
MikhailArkhipovhttps://github.com/MikhailArkhipov
Dec 21, 2018 https://github.com/microsoft/python-language-server/pull/498#pullrequestreview-187491480
View reviewed changes https://github.com/microsoft/python-language-server/pull/498/files/311779232b5ba446390e57eefd1899483916476b
src/LanguageServer/Impl/LanguageServer.cshttps://github.com/microsoft/python-language-server/pull/498/files/311779232b5ba446390e57eefd1899483916476b#diff-4a74b4c46f62614bf1cd2c2eb31344d77a2be2ea904df3d60fd549ee61e8a6ca
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/498
jakebaileyhttps://github.com/jakebailey
December 21, 2018 10:39https://github.com/microsoft/python-language-server/pull/498#commits-pushed-87db0fb
https://github.com/jakebailey
don't use MaybeEnumeratehttps://github.com/microsoft/python-language-server/pull/498/commits/87db0fb8e1d14321b8fd09e1949173264ffc0765
87db0fbhttps://github.com/microsoft/python-language-server/pull/498/commits/87db0fb8e1d14321b8fd09e1949173264ffc0765
https://github.com/jakebailey
upgrade message to Showhttps://github.com/microsoft/python-language-server/pull/498/commits/411ba2ccbaef4715732ecdcaf0b8edb2f5bbbfb0
411ba2chttps://github.com/microsoft/python-language-server/pull/498/commits/411ba2ccbaef4715732ecdcaf0b8edb2f5bbbfb0
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
cb1c3dfhttps://github.com/microsoft/python-language-server/commit/cb1c3dfbad1c7a521857a5dae8eea7c94225a096
Dec 22, 2018https://github.com/microsoft/python-language-server/pull/498#event-2041877233
Server remains open for requests after unhandled "noncritical" exceptions #448 https://github.com/microsoft/python-language-server/issues/448
Catch/ignore/handle exceptions from FileSystemGlobbing #463 https://github.com/microsoft/python-language-server/issues/463
Error when go to definition of PyQt5's module #440 https://github.com/microsoft/python-language-server/issues/440
AlexanderSherhttps://github.com/AlexanderSher
Feb 4, 2019 https://github.com/microsoft/python-language-server/pull/498#ref-commit-dde837b
https://github.com/jakebailey
https://github.com/AlexanderSher
Fix various common exceptions, log on a failed directory load (https://github.com/AlexanderSher/python-language-server/commit/dde837bc8c02f013496d9de4cb95b5fb9ac0998d
micros…https://github.com/microsoft/python-language-server/pull/498
dde837bhttps://github.com/AlexanderSher/python-language-server/commit/dde837bc8c02f013496d9de4cb95b5fb9ac0998d
…oft#498https://github.com/microsoft/python-language-server/pull/498
AlexanderSherhttps://github.com/AlexanderSher
Feb 4, 2019 https://github.com/microsoft/python-language-server/pull/498#ref-commit-a5b6e5e
https://github.com/AlexanderSher
Cherry pick fixes from Release branch into PTVS branch (https://github.com/microsoft/python-language-server/commit/a5b6e5e6f141b943dbbe9183863aabdbd718fccc
#578https://github.com/microsoft/python-language-server/pull/578
)https://github.com/microsoft/python-language-server/commit/a5b6e5e6f141b943dbbe9183863aabdbd718fccc
a5b6e5ehttps://github.com/microsoft/python-language-server/commit/a5b6e5e6f141b943dbbe9183863aabdbd718fccc
#470https://github.com/microsoft/python-language-server/issues/470
#478https://github.com/microsoft/python-language-server/pull/478
#498https://github.com/microsoft/python-language-server/pull/498
#495https://github.com/microsoft/python-language-server/issues/495
#517https://github.com/microsoft/python-language-server/pull/517
#495https://github.com/microsoft/python-language-server/issues/495
#277https://github.com/microsoft/python-language-server/pull/277
#509https://github.com/microsoft/python-language-server/issues/509
#519https://github.com/microsoft/python-language-server/pull/519
#510https://github.com/microsoft/python-language-server/issues/510
#525https://github.com/microsoft/python-language-server/pull/525
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
February 14, 2019 20:21https://github.com/microsoft/python-language-server/pull/498#event-2140770577
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F498
https://github.com/AlexanderSher
AlexanderSher https://github.com/AlexanderSher
https://github.com/MikhailArkhipov
MikhailArkhipov https://github.com/MikhailArkhipov
https://github.com/microsoft/python-language-server/pull/498/files/87db0fb8e1d14321b8fd09e1949173264ffc0765
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/498
https://github.com/jakebailey
https://github.com/MikhailArkhipov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.