| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5ac4415a-22ca-0b17-daf0-5123c939d336 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB54:62240:15F533:201BE5:6A4DFD60 |
| html-safe-nonce | ea0f4c899cf52a1db763384d7339d676300b41bd18d5cc54c4cc953e986ce58e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjU0OjYyMjQwOjE1RjUzMzoyMDFCRTU6NkE0REZENjAiLCJ2aXNpdG9yX2lkIjoiNDE3MTM4MDk5MjUyNTU5ODA0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0c2092d9f6d6a0601739b151127f67c4eb8c1dea8cb4e49327b079efa4fe3c38 |
| hovercard-subject-tag | pull_request:234751712 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/439/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/74e6321ed1086313b52636863c6a8c4ac4d92dfd1d8891078a463af8d5a5fe9a/microsoft/python-language-server/pull/439 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/74e6321ed1086313b52636863c6a8c4ac4d92dfd1d8891078a463af8d5a5fe9a/microsoft/python-language-server/pull/439 |
| og:image:alt | Fixes #404
Make type derive properly, i.e. IPythonType => IPythonFunction, make module a type, etc.
Move class-specific methods to IPythonClass
Simplify implementation by using proper base clas... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MikhailArkhipov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4314b1df11fa8a565684f3a72dc971e3785da365 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/python-language-server/pull/439#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F439 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F439 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server |
| Reload | https://github.com/microsoft/python-language-server/pull/439 |
| Reload | https://github.com/microsoft/python-language-server/pull/439 |
| Reload | https://github.com/microsoft/python-language-server/pull/439 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
|
microsoft
| https://github.com/microsoft |
| python-language-server | https://github.com/microsoft/python-language-server |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server |
|
Fork
131
| https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server |
|
Star
921
| https://github.com/login?return_to=%2Fmicrosoft%2Fpython-language-server |
|
Code
| https://github.com/microsoft/python-language-server |
|
Issues
309
| https://github.com/microsoft/python-language-server/issues |
|
Pull requests
6
| https://github.com/microsoft/python-language-server/pulls |
|
Projects
| https://github.com/microsoft/python-language-server/projects |
|
Models
| https://github.com/microsoft/python-language-server/models |
|
Wiki
| https://github.com/microsoft/python-language-server/wiki |
|
Security and quality
0
| https://github.com/microsoft/python-language-server/security |
|
Insights
| https://github.com/microsoft/python-language-server/pulse |
|
Code
| https://github.com/microsoft/python-language-server |
|
Issues
| https://github.com/microsoft/python-language-server/issues |
|
Pull requests
| https://github.com/microsoft/python-language-server/pulls |
|
Projects
| https://github.com/microsoft/python-language-server/projects |
|
Models
| https://github.com/microsoft/python-language-server/models |
|
Wiki
| https://github.com/microsoft/python-language-server/wiki |
|
Security and quality
| https://github.com/microsoft/python-language-server/security |
|
Insights
| https://github.com/microsoft/python-language-server/pulse |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| Conversation | https://github.com/microsoft/python-language-server/pull/439 |
| Commits34 (34) | https://github.com/microsoft/python-language-server/pull/439/commits |
| Checks | https://github.com/microsoft/python-language-server/pull/439/checks |
| Files changed | https://github.com/microsoft/python-language-server/pull/439/files |
| Clean up type system | https://github.com/microsoft/python-language-server/pull/439#top |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
|
| https://github.com/MikhailArkhipov |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
| Nov 29, 2018 | https://github.com/microsoft/python-language-server/pull/439#issue-385882093 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| #404 | https://github.com/microsoft/python-language-server/issues/404 |
| #361 | https://github.com/microsoft/python-language-server/pull/361 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| November 14, 2018 15:15 | https://github.com/microsoft/python-language-server/pull/439#commits-pushed-8bd5303 |
| Types hierarchy cleanup | https://github.com/microsoft/python-language-server/pull/439/commits/8bd5303fc2ab1699acc2077466c01b7701266ca2 |
| 8bd5303 | https://github.com/microsoft/python-language-server/pull/439/commits/8bd5303fc2ab1699acc2077466c01b7701266ca2 |
| Test fixes, part I | https://github.com/microsoft/python-language-server/pull/439/commits/7cd781f79b30d21d84b30b8c1ba324ae36693fd5 |
| 7cd781f | https://github.com/microsoft/python-language-server/pull/439/commits/7cd781f79b30d21d84b30b8c1ba324ae36693fd5 |
| Restore IPythonBoundFunction | https://github.com/microsoft/python-language-server/pull/439/commits/91bde57ef35141b8df3b91008454d966222d40d9 |
| 91bde57 | https://github.com/microsoft/python-language-server/pull/439/commits/91bde57ef35141b8df3b91008454d966222d40d9 |
| Fix function instance types | https://github.com/microsoft/python-language-server/pull/439/commits/07ec4d4f024cc80b28c7f246e0573fc1bb082076 |
| 07ec4d4 | https://github.com/microsoft/python-language-server/pull/439/commits/07ec4d4f024cc80b28c7f246e0573fc1bb082076 |
| More fixes | https://github.com/microsoft/python-language-server/pull/439/commits/1be750ca7d96ef44a2268c3c6fc24eae64c49bcc |
| 1be750c | https://github.com/microsoft/python-language-server/pull/439/commits/1be750ca7d96ef44a2268c3c6fc24eae64c49bcc |
| Fix overload handling | https://github.com/microsoft/python-language-server/pull/439/commits/0322c433cd8d1a3cbbab56d92850f0528b6a4f25 |
| 0322c43 | https://github.com/microsoft/python-language-server/pull/439/commits/0322c433cd8d1a3cbbab56d92850f0528b6a4f25 |
| Fix properties | https://github.com/microsoft/python-language-server/pull/439/commits/804a460f99c9d019e1f74fd17f679aeed929297b |
| 804a460 | https://github.com/microsoft/python-language-server/pull/439/commits/804a460f99c9d019e1f74fd17f679aeed929297b |
| Fix type factory | https://github.com/microsoft/python-language-server/pull/439/commits/b9fbe7a86478476a6fe54a94bea57e41be203f74 |
| b9fbe7a | https://github.com/microsoft/python-language-server/pull/439/commits/b9fbe7a86478476a6fe54a94bea57e41be203f74 |
| Remove class built-in type | https://github.com/microsoft/python-language-server/pull/439/commits/49afe216a0727fed6705196af5622f736815c944 |
| 49afe21 | https://github.com/microsoft/python-language-server/pull/439/commits/49afe216a0727fed6705196af5622f736815c944 |
| Simplify builtins, remove obsolete method | https://github.com/microsoft/python-language-server/pull/439/commits/3f855aca2ac44561726081d84c2eb20bfd749bbb |
| 3f855ac | https://github.com/microsoft/python-language-server/pull/439/commits/3f855aca2ac44561726081d84c2eb20bfd749bbb |
| Fix typeshed merge | https://github.com/microsoft/python-language-server/pull/439/commits/2df9c057a71c6b7a50530702b38f6bda0c45a060 |
| 2df9c05 | https://github.com/microsoft/python-language-server/pull/439/commits/2df9c057a71c6b7a50530702b38f6bda0c45a060 |
| Merge master | https://github.com/microsoft/python-language-server/pull/439/commits/c663ce87d12583d9d1561a454f436ba425bec91a |
| c663ce8 | https://github.com/microsoft/python-language-server/pull/439/commits/c663ce87d12583d9d1561a454f436ba425bec91a |
| Allow declaring module to be null | https://github.com/microsoft/python-language-server/pull/439/commits/a2eb6f2cab8e14ebbe48547f0271e520b6e39bd4 |
| a2eb6f2 | https://github.com/microsoft/python-language-server/pull/439/commits/a2eb6f2cab8e14ebbe48547f0271e520b6e39bd4 |
| Correct assertion | https://github.com/microsoft/python-language-server/pull/439/commits/133faaab68b4f9cdb349e543916a8c94d5fe4c7d |
| 133faaa | https://github.com/microsoft/python-language-server/pull/439/commits/133faaab68b4f9cdb349e543916a8c94d5fe4c7d |
| Simplify functions/methods | https://github.com/microsoft/python-language-server/pull/439/commits/3ba26fce577f47be8df8ac36e1a6a56816b41fb0 |
| 3ba26fc | https://github.com/microsoft/python-language-server/pull/439/commits/3ba26fce577f47be8df8ac36e1a6a56816b41fb0 |
| Fix stub merge tests | https://github.com/microsoft/python-language-server/pull/439/commits/4986aaf1da946b1d38359cf7195669df47d7e2bf |
| 4986aaf | https://github.com/microsoft/python-language-server/pull/439/commits/4986aaf1da946b1d38359cf7195669df47d7e2bf |
| Fix tests | https://github.com/microsoft/python-language-server/pull/439/commits/37c2830bad4d647fabe89f734efbee390d1de24d |
| 37c2830 | https://github.com/microsoft/python-language-server/pull/439/commits/37c2830bad4d647fabe89f734efbee390d1de24d |
| Merge branch 'master' of | https://github.com/microsoft/python-language-server/pull/439/commits/dccd44d2e33f25195f8295e80306224a9f17a3fb |
| https://github.com/Microsoft/python-language… | https://github.com/Microsoft/python-language-server |
| dccd44d | https://github.com/microsoft/python-language-server/pull/439/commits/dccd44d2e33f25195f8295e80306224a9f17a3fb |
| …-server | https://github.com/Microsoft/python-language-server |
| Baselines | https://github.com/microsoft/python-language-server/pull/439/commits/ad459bbc1935382ad30bbcb0ab8784cda268ad50 |
| ad459bb | https://github.com/microsoft/python-language-server/pull/439/commits/ad459bbc1935382ad30bbcb0ab8784cda268ad50 |
| Null ref | https://github.com/microsoft/python-language-server/pull/439/commits/dab1e22df9dd25864c27df0f88cb85d7b26132d0 |
| dab1e22 | https://github.com/microsoft/python-language-server/pull/439/commits/dab1e22df9dd25864c27df0f88cb85d7b26132d0 |
| Build break | https://github.com/microsoft/python-language-server/pull/439/commits/ca5aecfe3f8f883d04f9030ea9708b019f128b6a |
| ca5aecf | https://github.com/microsoft/python-language-server/pull/439/commits/ca5aecfe3f8f883d04f9030ea9708b019f128b6a |
| Overrides signatures | https://github.com/microsoft/python-language-server/pull/439/commits/bf1d77ce8949ee243c1dfe22fe61927cd4ed561f |
| bf1d77c | https://github.com/microsoft/python-language-server/pull/439/commits/bf1d77ce8949ee243c1dfe22fe61927cd4ed561f |
| Fix typeinfo tests | https://github.com/microsoft/python-language-server/pull/439/commits/90e06d7b4211df3b16e053e32243957b63d849c9 |
| 90e06d7 | https://github.com/microsoft/python-language-server/pull/439/commits/90e06d7b4211df3b16e053e32243957b63d849c9 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179973385 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/LanguageServer/Impl/Implementation/CompletionAnalysis.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-3372be58bf7d3a3d0f77bb465b43f8249406cc7026c404e50af2ff09ce529438 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179974068 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Test/FluentAssertions/MemberContainerAssertionsExtensions.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-86904c2b38812803694838a9565ba04a522e1a7786d35b84ea65264aee306c4d |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179974557 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Test/AstAnalysisTests.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-0bb991311e8c361ad41fe3f95d172d5ed2e696987f1405fb0e7a68398a30235b |
| AlexanderSher | https://github.com/AlexanderSher |
| Nov 29, 2018 | https://github.com/microsoft/python-language-server/pull/439#discussion_r237627835 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179976214 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/Values/Protocols.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-20c38e954ec036311a96b49935a25f40cf228a59eea7d75a4a32b0565f112c59 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179978933 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/Values/BuiltinInstanceInfo.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-bff3ffc6aec9cff20073d64a13ea26172f652ec36c86e10b6aacf5aeeabacebc |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179979662 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/Values/BuiltinFunctionInfo.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-8db1fe4b0a2fc29aa74aaa3a05e7eda94bc9d39c780814740d08a48607675f98 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179980675 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/Values/BuiltinClassInfo.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-e79165cb82bb796031de9ac0025d4ef291cf192b4f581b367d8270607aa8c47d |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179982484 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/PythonAnalyzer.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-ea905ac17cab7c46aaef370c1a52e60116e3681494343768d2d1b295c9a719cf |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179983027 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/OverloadResult.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-4004dd6520bfba2991231a73c333650276f78ccff759b1fc5e6f4fbd052e5517 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-179995751 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/KnownTypes.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-5040e22f7cf21bbe5438177017d50f98b82008fd36428825ae60c874cb96ca0e |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| PR feedback | https://github.com/microsoft/python-language-server/pull/439/commits/b45ed3ac3e2bc76a07181ffc76782abd2af3d368 |
| b45ed3a | https://github.com/microsoft/python-language-server/pull/439/commits/b45ed3ac3e2bc76a07181ffc76782abd2af3d368 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-180001459 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9 |
| src/Analysis/Engine/Impl/Interpreter/Ast/AstPythonMultipleMembers.cs | https://github.com/microsoft/python-language-server/pull/439/files/90e06d7b4211df3b16e053e32243957b63d849c9#diff-47aa0347dcac962275ddf84eb135bcab9007ad6f74184f8e95e74d6ad21a430f |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-180017858 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/b45ed3ac3e2bc76a07181ffc76782abd2af3d368 |
| src/Analysis/Engine/Impl/Interpreter/Ast/AstPythonClass.cs | https://github.com/microsoft/python-language-server/pull/439/files/b45ed3ac3e2bc76a07181ffc76782abd2af3d368#diff-ff5eb837ed7faef8e50a34d9cadf8aec86f0dae4a54cab738e198e0cdc4e04b4 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
|
Nov 29, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-180048935 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/b45ed3ac3e2bc76a07181ffc76782abd2af3d368 |
| src/LanguageServer/Impl/Implementation/CompletionAnalysis.cs | https://github.com/microsoft/python-language-server/pull/439/files/b45ed3ac3e2bc76a07181ffc76782abd2af3d368#diff-3372be58bf7d3a3d0f77bb465b43f8249406cc7026c404e50af2ff09ce529438 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/MikhailArkhipov |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
|
Nov 30, 2018
| https://github.com/microsoft/python-language-server/pull/439#ref-pullrequest-386283945 |
|
[WIP]: Split analysis into several assemblies
#441
| https://github.com/microsoft/python-language-server/pull/441 |
| December 1, 2018 17:17 | https://github.com/microsoft/python-language-server/pull/439#commits-pushed-b79b8c9 |
| Better handle overloads | https://github.com/microsoft/python-language-server/pull/439/commits/b79b8c9ebfd0583bbd9aa0c177d57cdb6b16d403 |
| b79b8c9 | https://github.com/microsoft/python-language-server/pull/439/commits/b79b8c9ebfd0583bbd9aa0c177d57cdb6b16d403 |
| Merge master | https://github.com/microsoft/python-language-server/pull/439/commits/b15e82134d462d57ea234f5d8dac4e08332b05b4 |
| b15e821 | https://github.com/microsoft/python-language-server/pull/439/commits/b15e82134d462d57ea234f5d8dac4e08332b05b4 |
| Build breaks | https://github.com/microsoft/python-language-server/pull/439/commits/81720efb1e29281b667c280a676f4781b3ca1807 |
| 81720ef | https://github.com/microsoft/python-language-server/pull/439/commits/81720efb1e29281b667c280a676f4781b3ca1807 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
|
Dec 4, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-181469153 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/81720efb1e29281b667c280a676f4781b3ca1807 |
| src/Analysis/Engine/Impl/Interpreter/Ast/AstBuiltinsPythonModule.cs | https://github.com/microsoft/python-language-server/pull/439/files/81720efb1e29281b667c280a676f4781b3ca1807#diff-bd6f678ed40dbe0c77c8e2e2ea95fb4110f834067f07335bb5c5ab339a050ce1 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| December 4, 2018 13:24 | https://github.com/microsoft/python-language-server/pull/439#commits-pushed-5287ff0 |
| Baselines | https://github.com/microsoft/python-language-server/pull/439/commits/5287ff06c27ca181e6d0cd0f6b95fb80a8225159 |
| 5287ff0 | https://github.com/microsoft/python-language-server/pull/439/commits/5287ff06c27ca181e6d0cd0f6b95fb80a8225159 |
| PR fix | https://github.com/microsoft/python-language-server/pull/439/commits/3dfff43a240cf5256f88b4050eaa3916cd415dfc |
| 3dfff43 | https://github.com/microsoft/python-language-server/pull/439/commits/3dfff43a240cf5256f88b4050eaa3916cd415dfc |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Dec 5, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-181887669 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/3dfff43a240cf5256f88b4050eaa3916cd415dfc |
| src/Analysis/Engine/Impl/Values/SequenceBuiltinInstanceInfo.cs | https://github.com/microsoft/python-language-server/pull/439/files/3dfff43a240cf5256f88b4050eaa3916cd415dfc#diff-ec2894a69bc038f2b382901cebac4e47a4ecf9bc9a411c154d82f72cd43ab786 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Dec 5, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-181892686 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/3dfff43a240cf5256f88b4050eaa3916cd415dfc |
| src/Analysis/Engine/Impl/Values/BuiltinInstanceInfo.cs | https://github.com/microsoft/python-language-server/pull/439/files/3dfff43a240cf5256f88b4050eaa3916cd415dfc#diff-bff3ffc6aec9cff20073d64a13ea26172f652ec36c86e10b6aacf5aeeabacebc |
| AlexanderSher | https://github.com/AlexanderSher |
| Dec 5, 2018 | https://github.com/microsoft/python-language-server/pull/439#discussion_r239173341 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
| Dec 5, 2018 | https://github.com/microsoft/python-language-server/pull/439#discussion_r239176119 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
| December 5, 2018 10:11 | https://github.com/microsoft/python-language-server/pull/439#commits-pushed-500e969 |
| PR feedback | https://github.com/microsoft/python-language-server/pull/439/commits/500e969582756b2a5bc4b897e99c5b45ed97ba05 |
| 500e969 | https://github.com/microsoft/python-language-server/pull/439/commits/500e969582756b2a5bc4b897e99c5b45ed97ba05 |
| Merge master | https://github.com/microsoft/python-language-server/pull/439/commits/dd2f1140d7882f7aab0a5fdc429fbd255de296cf |
| dd2f114 | https://github.com/microsoft/python-language-server/pull/439/commits/dd2f1140d7882f7aab0a5fdc429fbd255de296cf |
| Merge conflict | https://github.com/microsoft/python-language-server/pull/439/commits/b829969eed173e28564050a063b4f7d2dd36f69c |
| b829969 | https://github.com/microsoft/python-language-server/pull/439/commits/b829969eed173e28564050a063b4f7d2dd36f69c |
| Fix | https://github.com/microsoft/python-language-server/pull/439/commits/780757add54916958e7612bfc65d7ff5a93a2d67 |
| #446 | https://github.com/microsoft/python-language-server/issues/446 |
| 780757a | https://github.com/microsoft/python-language-server/pull/439/commits/780757add54916958e7612bfc65d7ff5a93a2d67 |
| Fix | https://github.com/microsoft/python-language-server/pull/439/commits/7bf1f384cf1599a215742fdb685ae7379c3bfb00 |
| #446 | https://github.com/microsoft/python-language-server/issues/446 |
| 7bf1f38 | https://github.com/microsoft/python-language-server/pull/439/commits/7bf1f384cf1599a215742fdb685ae7379c3bfb00 |
| https://github.com/AlexanderSher |
| AlexanderSher | https://github.com/AlexanderSher |
|
Dec 5, 2018
| https://github.com/microsoft/python-language-server/pull/439#pullrequestreview-181920062 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/439/files/7bf1f384cf1599a215742fdb685ae7379c3bfb00 |
| https://github.com/MikhailArkhipov |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
| b6eb8ff | https://github.com/microsoft/python-language-server/commit/b6eb8ffa04867894e33129cc40402b7e5a9ec505 |
| Dec 5, 2018 | https://github.com/microsoft/python-language-server/pull/439#event-2008151939 |
| https://github.com/MikhailArkhipov |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
| December 5, 2018 20:09 | https://github.com/microsoft/python-language-server/pull/439#event-2008152168 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
|
Dec 8, 2018
| https://github.com/microsoft/python-language-server/pull/439#ref-issue-388952076 |
|
Invalid cast from BuiltinFunctionInfo to BuiltinClassInfo in GetBuiltinType
#470
| https://github.com/microsoft/python-language-server/issues/470 |
| https://github.com/MikhailArkhipov |
| MikhailArkhipov | https://github.com/MikhailArkhipov |
|
Dec 10, 2018
| https://github.com/microsoft/python-language-server/pull/439#ref-pullrequest-389471930 |
|
Fix invalid cast in GetBuiltinType
#478
| https://github.com/microsoft/python-language-server/pull/478 |
| jakebailey | https://github.com/jakebailey |
|
Nov 1, 2019
| https://github.com/microsoft/python-language-server/pull/439#ref-commit-4449820 |
| Clean up type system ( | https://github.com/jakebailey/python-language-server/commit/44498200d25ced8729110c34a3e5da26f65068cb |
| microsoft#439 | https://github.com/microsoft/python-language-server/pull/439 |
| ) | https://github.com/jakebailey/python-language-server/commit/44498200d25ced8729110c34a3e5da26f65068cb |
| 4449820 | https://github.com/jakebailey/python-language-server/commit/44498200d25ced8729110c34a3e5da26f65068cb |
| microsoft#446 | https://github.com/microsoft/python-language-server/issues/446 |
| microsoft#446 | https://github.com/microsoft/python-language-server/issues/446 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F439 |
|
| https://github.com/jakebailey |
|
jakebailey
| https://github.com/jakebailey |
|
| https://github.com/microsoft/python-language-server/pull/439/files/81720efb1e29281b667c280a676f4781b3ca1807 |
|
| https://github.com/AlexanderSher |
|
AlexanderSher
| https://github.com/AlexanderSher |
|
| https://github.com/microsoft/python-language-server/pull/439/files/7bf1f384cf1599a215742fdb685ae7379c3bfb00 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/439 |
|
| https://github.com/MikhailArkhipov |
|
| https://github.com/jakebailey |
|
| https://github.com/AlexanderSher |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |