René's URL Explorer Experiment


Title: Do not lock module database when working with database files by jakebailey · Pull Request #1713 · microsoft/python-language-server · GitHub

Open Graph Title: Do not lock module database when working with database files by jakebailey · Pull Request #1713 · microsoft/python-language-server

X Title: Do not lock module database when working with database files by jakebailey · Pull Request #1713 · microsoft/python-language-server

Description: Microsoft Language Server for Python. Contribute to microsoft/python-language-server development by creating an account on GitHub.

Open Graph Description: For #1601. These locks effectively do nothing. ModuleExistsInStorage would still be affected by the ordering of DB creation and checking regardless of the lock. Realistically, the file system is p...

X Description: For #1601. These locks effectively do nothing. ModuleExistsInStorage would still be affected by the ordering of DB creation and checking regardless of the lock. Realistically, the file system is p...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/1713

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:491e62b7-ab07-2e9b-3352-cd619c38ccfd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9E0:19EC1D:445B4C:59C438:6AFE65A2
html-safe-nonceee5f76245f376c8638d149e626bf87c574e58d945b53d682664cca73680c18b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUUwOjE5RUMxRDo0NDVCNEM6NTlDNDM4OjZBRkU2NUEyIiwidmlzaXRvcl9pZCI6IjUxODI2ODkzMDc5MDY2OTY2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ba46956ffb28d34df86a3a81e712ee83111d191bbf9adee57c46a0551a683a1
hovercard-subject-tagpull_request:331087079
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/1713/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/357c354f7f0fed51a8f8e042689c625f083a0b8111a87210b4107feb93abbd51/microsoft/python-language-server/pull/1713
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/357c354f7f0fed51a8f8e042689c625f083a0b8111a87210b4107feb93abbd51/microsoft/python-language-server/pull/1713
og:image:altFor #1601. These locks effectively do nothing. ModuleExistsInStorage would still be affected by the ordering of DB creation and checking regardless of the lock. Realistically, the file system is p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/1713#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1713
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1713
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/1713
Reloadhttps://github.com/microsoft/python-language-server/pull/1713
Reloadhttps://github.com/microsoft/python-language-server/pull/1713
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
https://github.com/microsoft/python-language-server
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
jakebailey:unlock-db-file-checkhttps://github.com/jakebailey/python-language-server/tree/unlock-db-file-check
Conversationhttps://github.com/microsoft/python-language-server/pull/1713
Commits6 (6)https://github.com/microsoft/python-language-server/pull/1713/commits
Checkshttps://github.com/microsoft/python-language-server/pull/1713/checks
Files changedhttps://github.com/microsoft/python-language-server/pull/1713/files
Do not lock module database when working with database fileshttps://github.com/microsoft/python-language-server/pull/1713#top
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
jakebailey:unlock-db-file-checkhttps://github.com/jakebailey/python-language-server/tree/unlock-db-file-check
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Oct 22, 2019https://github.com/microsoft/python-language-server/pull/1713#issue-510771360
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1713
#1601https://github.com/microsoft/python-language-server/issues/1601
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1713
Jake Bailey (jakebailey)https://github.com/jakebailey
October 21, 2019 14:39https://github.com/microsoft/python-language-server/pull/1713#commits-pushed-bc308ca
https://github.com/jakebailey
Do not lock database while checking for file existencehttps://github.com/microsoft/python-language-server/pull/1713/commits/bc308ca5f749532dcc42ed111808281ec2e4b795
bc308cahttps://github.com/microsoft/python-language-server/pull/1713/commits/bc308ca5f749532dcc42ed111808281ec2e4b795
https://github.com/jakebailey
Also do not lock on writeshttps://github.com/microsoft/python-language-server/pull/1713/commits/be2c581991dc536e0b09d919c607f100f1d069d8
be2c581https://github.com/microsoft/python-language-server/pull/1713/commits/be2c581991dc536e0b09d919c607f100f1d069d8
https://github.com/jakebailey
Revert "Also do not lock on writes"https://github.com/microsoft/python-language-server/pull/1713/commits/fa022a1f7f397428ff00476b61aa4623e182ebf3
fa022a1https://github.com/microsoft/python-language-server/pull/1713/commits/fa022a1f7f397428ff00476b61aa4623e182ebf3
be2c581https://github.com/jakebailey/python-language-server/commit/be2c581991dc536e0b09d919c607f100f1d069d8
https://github.com/jakebailey
Use a second lock for file writeshttps://github.com/microsoft/python-language-server/pull/1713/commits/83c65b4a4c34497ef42112ba7147dfaeefaba93b
83c65b4https://github.com/microsoft/python-language-server/pull/1713/commits/83c65b4a4c34497ef42112ba7147dfaeefaba93b
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Oct 22, 2019https://github.com/microsoft/python-language-server/pull/1713#event-2734017863
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 22, 2019 https://github.com/microsoft/python-language-server/pull/1713#pullrequestreview-305371163
View reviewed changes https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b
src/Caching/Impl/ModuleDatabase.cshttps://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b#diff-c252251917a07872679104b869d97a7badc255a82728fc1808167a1d43e7c294
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1713
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 22, 2019 https://github.com/microsoft/python-language-server/pull/1713#pullrequestreview-305384804
View reviewed changes https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b
src/Caching/Impl/ModuleDatabase.cshttps://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b#diff-c252251917a07872679104b869d97a7badc255a82728fc1808167a1d43e7c294
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1713
https://github.com/jakebailey
Remove _writeLock, as LiteDB has its own builtin lockinghttps://github.com/microsoft/python-language-server/pull/1713/commits/949bca83d1de787cbdaa3337da86de4138750d5e
949bca8https://github.com/microsoft/python-language-server/pull/1713/commits/949bca83d1de787cbdaa3337da86de4138750d5e
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Oct 22, 2019https://github.com/microsoft/python-language-server/pull/1713#event-2734637405
https://github.com/jakebailey
Remove unused Clear methodhttps://github.com/microsoft/python-language-server/pull/1713/commits/acb477e48c5b706be2902e5d6f8db51443f5407b
acb477ehttps://github.com/microsoft/python-language-server/pull/1713/commits/acb477e48c5b706be2902e5d6f8db51443f5407b
https://github.com/bschnurr
Bill Schnurr (bschnurr)https://github.com/bschnurr
Oct 23, 2019 https://github.com/microsoft/python-language-server/pull/1713#pullrequestreview-306172999
View reviewed changes https://github.com/microsoft/python-language-server/pull/1713/files/acb477e48c5b706be2902e5d6f8db51443f5407b
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
3c1ed6dhttps://github.com/microsoft/python-language-server/commit/3c1ed6d5bf4267e60db6ec7bbc45c13050854d5a
Oct 23, 2019https://github.com/microsoft/python-language-server/pull/1713#event-2738580304
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
October 23, 2019 21:09https://github.com/microsoft/python-language-server/pull/1713#event-2738580389
Jake Bailey (jakebailey)https://github.com/jakebailey
Nov 1, 2019 https://github.com/microsoft/python-language-server/pull/1713#ref-commit-91d56a2
https://github.com/jakebailey
Do not lock module database when working with database files (https://github.com/jakebailey/python-language-server/commit/91d56a2682ef0c9aa6399021a1c93f257ab77315
microso…https://github.com/microsoft/python-language-server/pull/1713
91d56a2https://github.com/jakebailey/python-language-server/commit/91d56a2682ef0c9aa6399021a1c93f257ab77315
…ft#1713https://github.com/microsoft/python-language-server/pull/1713
be2c581https://github.com/jakebailey/python-language-server/commit/be2c581991dc536e0b09d919c607f100f1d069d8
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Nov 1, 2019 https://github.com/microsoft/python-language-server/pull/1713#ref-pullrequest-516368532
Fix caching of compiled modules, analysis hang #1737 https://github.com/microsoft/python-language-server/pull/1737
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1713
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) https://github.com/MikhailArkhipov
https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b
https://github.com/bschnurr
Bill Schnurr (bschnurr) https://github.com/bschnurr
https://github.com/microsoft/python-language-server/pull/1713/files/acb477e48c5b706be2902e5d6f8db51443f5407b
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1713
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1713
https://github.com/jakebailey
https://github.com/bschnurr
https://github.com/MikhailArkhipov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.