| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:491e62b7-ab07-2e9b-3352-cd619c38ccfd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9E0:19EC1D:445B4C:59C438:6AFE65A2 |
| html-safe-nonce | ee5f76245f376c8638d149e626bf87c574e58d945b53d682664cca73680c18b9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUUwOjE5RUMxRDo0NDVCNEM6NTlDNDM4OjZBRkU2NUEyIiwidmlzaXRvcl9pZCI6IjUxODI2ODkzMDc5MDY2OTY2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5ba46956ffb28d34df86a3a81e712ee83111d191bbf9adee57c46a0551a683a1 |
| hovercard-subject-tag | pull_request:331087079 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/1713/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/357c354f7f0fed51a8f8e042689c625f083a0b8111a87210b4107feb93abbd51/microsoft/python-language-server/pull/1713 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/357c354f7f0fed51a8f8e042689c625f083a0b8111a87210b4107feb93abbd51/microsoft/python-language-server/pull/1713 |
| og:image:alt | For #1601.
These locks effectively do nothing.
ModuleExistsInStorage would still be affected by the ordering of DB creation and checking regardless of the lock. Realistically, the file system is p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakebailey |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/python-language-server/pull/1713#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1713 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1713 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server |
| Reload | https://github.com/microsoft/python-language-server/pull/1713 |
| Reload | https://github.com/microsoft/python-language-server/pull/1713 |
| Reload | https://github.com/microsoft/python-language-server/pull/1713 |
| microsoft | https://github.com/microsoft |
| python-language-server | https://github.com/microsoft/python-language-server |
| Code | https://github.com/microsoft/python-language-server |
| Issues309 (309) | https://github.com/microsoft/python-language-server/issues |
| Pull requests6 (6) | https://github.com/microsoft/python-language-server/pulls |
| Projects | https://github.com/microsoft/python-language-server/projects |
| Wiki | https://github.com/microsoft/python-language-server/wiki |
| Security and quality | https://github.com/microsoft/python-language-server/security |
| Insights | https://github.com/microsoft/python-language-server/insights |
| https://github.com/microsoft/python-language-server |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| jakebailey:unlock-db-file-check | https://github.com/jakebailey/python-language-server/tree/unlock-db-file-check |
| Conversation | https://github.com/microsoft/python-language-server/pull/1713 |
| Commits6 (6) | https://github.com/microsoft/python-language-server/pull/1713/commits |
| Checks | https://github.com/microsoft/python-language-server/pull/1713/checks |
| Files changed | https://github.com/microsoft/python-language-server/pull/1713/files |
| Do not lock module database when working with database files | https://github.com/microsoft/python-language-server/pull/1713#top |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| jakebailey:unlock-db-file-check | https://github.com/jakebailey/python-language-server/tree/unlock-db-file-check |
|
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Oct 22, 2019 | https://github.com/microsoft/python-language-server/pull/1713#issue-510771360 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1713 |
| #1601 | https://github.com/microsoft/python-language-server/issues/1601 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1713 |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| October 21, 2019 14:39 | https://github.com/microsoft/python-language-server/pull/1713#commits-pushed-bc308ca |
|
| https://github.com/jakebailey |
| Do not lock database while checking for file existence | https://github.com/microsoft/python-language-server/pull/1713/commits/bc308ca5f749532dcc42ed111808281ec2e4b795 |
| bc308ca | https://github.com/microsoft/python-language-server/pull/1713/commits/bc308ca5f749532dcc42ed111808281ec2e4b795 |
|
| https://github.com/jakebailey |
| Also do not lock on writes | https://github.com/microsoft/python-language-server/pull/1713/commits/be2c581991dc536e0b09d919c607f100f1d069d8 |
| be2c581 | https://github.com/microsoft/python-language-server/pull/1713/commits/be2c581991dc536e0b09d919c607f100f1d069d8 |
|
| https://github.com/jakebailey |
| Revert "Also do not lock on writes" | https://github.com/microsoft/python-language-server/pull/1713/commits/fa022a1f7f397428ff00476b61aa4623e182ebf3 |
| fa022a1 | https://github.com/microsoft/python-language-server/pull/1713/commits/fa022a1f7f397428ff00476b61aa4623e182ebf3 |
| be2c581 | https://github.com/jakebailey/python-language-server/commit/be2c581991dc536e0b09d919c607f100f1d069d8 |
|
| https://github.com/jakebailey |
| Use a second lock for file writes | https://github.com/microsoft/python-language-server/pull/1713/commits/83c65b4a4c34497ef42112ba7147dfaeefaba93b |
| 83c65b4 | https://github.com/microsoft/python-language-server/pull/1713/commits/83c65b4a4c34497ef42112ba7147dfaeefaba93b |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Oct 22, 2019 | https://github.com/microsoft/python-language-server/pull/1713#event-2734017863 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Oct 22, 2019
| https://github.com/microsoft/python-language-server/pull/1713#pullrequestreview-305371163 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b |
| src/Caching/Impl/ModuleDatabase.cs | https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b#diff-c252251917a07872679104b869d97a7badc255a82728fc1808167a1d43e7c294 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1713 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Oct 22, 2019
| https://github.com/microsoft/python-language-server/pull/1713#pullrequestreview-305384804 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b |
| src/Caching/Impl/ModuleDatabase.cs | https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b#diff-c252251917a07872679104b869d97a7badc255a82728fc1808167a1d43e7c294 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1713 |
|
| https://github.com/jakebailey |
| Remove _writeLock, as LiteDB has its own builtin locking | https://github.com/microsoft/python-language-server/pull/1713/commits/949bca83d1de787cbdaa3337da86de4138750d5e |
| 949bca8 | https://github.com/microsoft/python-language-server/pull/1713/commits/949bca83d1de787cbdaa3337da86de4138750d5e |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Oct 22, 2019 | https://github.com/microsoft/python-language-server/pull/1713#event-2734637405 |
|
| https://github.com/jakebailey |
| Remove unused Clear method | https://github.com/microsoft/python-language-server/pull/1713/commits/acb477e48c5b706be2902e5d6f8db51443f5407b |
| acb477e | https://github.com/microsoft/python-language-server/pull/1713/commits/acb477e48c5b706be2902e5d6f8db51443f5407b |
| https://github.com/bschnurr |
| Bill Schnurr (bschnurr) | https://github.com/bschnurr |
|
Oct 23, 2019
| https://github.com/microsoft/python-language-server/pull/1713#pullrequestreview-306172999 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1713/files/acb477e48c5b706be2902e5d6f8db51443f5407b |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| 3c1ed6d | https://github.com/microsoft/python-language-server/commit/3c1ed6d5bf4267e60db6ec7bbc45c13050854d5a |
| Oct 23, 2019 | https://github.com/microsoft/python-language-server/pull/1713#event-2738580304 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| October 23, 2019 21:09 | https://github.com/microsoft/python-language-server/pull/1713#event-2738580389 |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
|
Nov 1, 2019
| https://github.com/microsoft/python-language-server/pull/1713#ref-commit-91d56a2 |
|
| https://github.com/jakebailey |
| Do not lock module database when working with database files ( | https://github.com/jakebailey/python-language-server/commit/91d56a2682ef0c9aa6399021a1c93f257ab77315 |
| microso… | https://github.com/microsoft/python-language-server/pull/1713 |
| 91d56a2 | https://github.com/jakebailey/python-language-server/commit/91d56a2682ef0c9aa6399021a1c93f257ab77315 |
| …ft#1713 | https://github.com/microsoft/python-language-server/pull/1713 |
| be2c581 | https://github.com/jakebailey/python-language-server/commit/be2c581991dc536e0b09d919c607f100f1d069d8 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
|
Nov 1, 2019
| https://github.com/microsoft/python-language-server/pull/1713#ref-pullrequest-516368532 |
|
Fix caching of compiled modules, analysis hang
#1737
| https://github.com/microsoft/python-language-server/pull/1737 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1713 |
|
| https://github.com/MikhailArkhipov |
|
Mikhail Arkhipov (MikhailArkhipov)
| https://github.com/MikhailArkhipov |
|
| https://github.com/microsoft/python-language-server/pull/1713/files/83c65b4a4c34497ef42112ba7147dfaeefaba93b |
|
| https://github.com/bschnurr |
|
Bill Schnurr (bschnurr)
| https://github.com/bschnurr |
|
| https://github.com/microsoft/python-language-server/pull/1713/files/acb477e48c5b706be2902e5d6f8db51443f5407b |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1713 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1713 |
|
| https://github.com/jakebailey |
|
| https://github.com/bschnurr |
|
| https://github.com/MikhailArkhipov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |