| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:41d30c21-082e-0c54-714a-5e536b2473af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D232:184DF1:59E7B6:7A9EB4:6AFE616F |
| html-safe-nonce | af9e8ae5c08ba4ffbd36a91f6315cf010895a866eccdee9707f79f52ff180817 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjMyOjE4NERGMTo1OUU3QjY6N0E5RUI0OjZBRkU2MTZGIiwidmlzaXRvcl9pZCI6IjY0ODk0NTczOTE0NTk3ODcxMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | af9e3e9dcfa8c55e39cdb5f01b040a42c8431eafc743e4d4d4c46d596ceeed8d |
| hovercard-subject-tag | pull_request:321336379 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/1584/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7373487b5a131da4f4d9a432fa85e2774883a1a22b2283b515219752e590cbe6/microsoft/python-language-server/pull/1584 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7373487b5a131da4f4d9a432fa85e2774883a1a22b2283b515219752e590cbe6/microsoft/python-language-server/pull/1584 |
| og:image:alt | This change modifies the way we handle cycle dependencies of modules.
Previously, after finding the loop, we have determined some random path to walk over those modules and walked twice over it. Wi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AlexanderSher |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/python-language-server/pull/1584#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1584 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1584 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server |
| Reload | https://github.com/microsoft/python-language-server/pull/1584 |
| Reload | https://github.com/microsoft/python-language-server/pull/1584 |
| Reload | https://github.com/microsoft/python-language-server/pull/1584 |
| microsoft | https://github.com/microsoft |
| python-language-server | https://github.com/microsoft/python-language-server |
| Code | https://github.com/microsoft/python-language-server |
| Issues309 (309) | https://github.com/microsoft/python-language-server/issues |
| Pull requests6 (6) | https://github.com/microsoft/python-language-server/pulls |
| Projects | https://github.com/microsoft/python-language-server/projects |
| Wiki | https://github.com/microsoft/python-language-server/wiki |
| Security and quality | https://github.com/microsoft/python-language-server/security |
| Insights | https://github.com/microsoft/python-language-server/insights |
| https://github.com/microsoft/python-language-server |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| AlexanderSher:Numpy | https://github.com/AlexanderSher/python-language-server/tree/Numpy |
| Conversation | https://github.com/microsoft/python-language-server/pull/1584 |
| Commits11 (11) | https://github.com/microsoft/python-language-server/pull/1584/commits |
| Checks | https://github.com/microsoft/python-language-server/pull/1584/checks |
| Files changed | https://github.com/microsoft/python-language-server/pull/1584/files |
| Fix module cycle handling | https://github.com/microsoft/python-language-server/pull/1584#top |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| AlexanderSher:Numpy | https://github.com/AlexanderSher/python-language-server/tree/Numpy |
|
| https://github.com/AlexanderSher |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| Sep 25, 2019 | https://github.com/microsoft/python-language-server/pull/1584#issue-498396230 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| September 22, 2019 00:05 | https://github.com/microsoft/python-language-server/pull/1584#commits-pushed-c9ff4e1 |
|
| https://github.com/AlexanderSher |
| Refactoring | https://github.com/microsoft/python-language-server/pull/1584/commits/c9ff4e10ccb53593c5b68b6513a1f71bbf929bff |
| c9ff4e1 | https://github.com/microsoft/python-language-server/pull/1584/commits/c9ff4e10ccb53593c5b68b6513a1f71bbf929bff |
|
| https://github.com/AlexanderSher |
| WIP | https://github.com/microsoft/python-language-server/pull/1584/commits/6ab46ad303bfe679625d67d039cd9bc7891c20e5 |
| 6ab46ad | https://github.com/microsoft/python-language-server/pull/1584/commits/6ab46ad303bfe679625d67d039cd9bc7891c20e5 |
|
| https://github.com/AlexanderSher |
| Merge commit '88762ef1a11cfddd51d382c920359c36e95f8d4d' into Numpy | https://github.com/microsoft/python-language-server/pull/1584/commits/76887fc7162aa394652d933db89e986d2380d586 |
| 76887fc | https://github.com/microsoft/python-language-server/pull/1584/commits/76887fc7162aa394652d933db89e986d2380d586 |
|
| https://github.com/AlexanderSher |
| Bug fixes | https://github.com/microsoft/python-language-server/pull/1584/commits/1068b18c3320096f22765c11a2633796d84109eb |
| 1068b18 | https://github.com/microsoft/python-language-server/pull/1584/commits/1068b18c3320096f22765c11a2633796d84109eb |
|
| https://github.com/AlexanderSher |
| Fix part of the test | https://github.com/microsoft/python-language-server/pull/1584/commits/03f004d6ba3b9278d6a9605d7d0b30349ae4ce77 |
| 03f004d | https://github.com/microsoft/python-language-server/pull/1584/commits/03f004d6ba3b9278d6a9605d7d0b30349ae4ce77 |
|
| https://github.com/AlexanderSher |
| Fully restore tests | https://github.com/microsoft/python-language-server/pull/1584/commits/43c776669a06d7be87b157fa6d64fa3760436807 |
| 43c7766 | https://github.com/microsoft/python-language-server/pull/1584/commits/43c776669a06d7be87b157fa6d64fa3760436807 |
| https://github.com/AlexanderSher |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| Sep 25, 2019 | https://github.com/microsoft/python-language-server/pull/1584#issuecomment-535105069 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Sep 26, 2019 | https://github.com/microsoft/python-language-server/pull/1584#issuecomment-535315263 |
| #1565 | https://github.com/microsoft/python-language-server/pull/1565 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Sep 26, 2019 | https://github.com/microsoft/python-language-server/pull/1584#issuecomment-535674696 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://user-images.githubusercontent.com/12820357/65722916-25f8f400-e062-11e9-8c4e-c78c68588295.png |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Sep 27, 2019
| https://github.com/microsoft/python-language-server/pull/1584#pullrequestreview-294513863 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807 |
| src/Analysis/Ast/Impl/Analyzer/Handlers/LoopImportedVariableHandler.cs | https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807#diff-a4ee8cc733c8aee2d938d54feaf5a092912bf1d015a294a67d200a7b0873af25 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Sep 27, 2019
| https://github.com/microsoft/python-language-server/pull/1584#pullrequestreview-294519617 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807 |
| src/Analysis/Ast/Impl/Analyzer/Handlers/SimpleImportedVariableHandler.cs | https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807#diff-06c5760fe80c2f22efe07699f2245ac01defa7f50951e2bb6a922fab4ab96b41 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Sep 27, 2019
| https://github.com/microsoft/python-language-server/pull/1584#pullrequestreview-294539879 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807 |
| src/Analysis/Ast/Impl/Analyzer/PythonAnalyzerSession.cs | https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
|
added some comments and renamed some variables in PathResolver and PathResolverSnapshot
#1597
| https://github.com/microsoft/python-language-server/pull/1597 |
|
Better handling of loops in dependency analysis
#1609
| https://github.com/microsoft/python-language-server/issues/1609 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Oct 8, 2019 | https://github.com/microsoft/python-language-server/pull/1584#event-2696321786 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Oct 8, 2019
| https://github.com/microsoft/python-language-server/pull/1584#ref-issue-477649727 |
|
Numpy analysis is inconsistent from run to run
#1414
| https://github.com/microsoft/python-language-server/issues/1414 |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| October 9, 2019 15:04 | https://github.com/microsoft/python-language-server/pull/1584#commits-pushed-6bed88a |
|
| https://github.com/AlexanderSher |
| Merge remote-tracking branch 'Microsoft/master' into Numpy | https://github.com/microsoft/python-language-server/pull/1584/commits/6bed88a26c816007a179ef4ebb79135a0fb62630 |
| 6bed88a | https://github.com/microsoft/python-language-server/pull/1584/commits/6bed88a26c816007a179ef4ebb79135a0fb62630 |
|
| https://github.com/AlexanderSher |
| Fix GetMemberNames | https://github.com/microsoft/python-language-server/pull/1584/commits/695dd85e88ac0d4aec55352f8defda50849e8e56 |
| 695dd85 | https://github.com/microsoft/python-language-server/pull/1584/commits/695dd85e88ac0d4aec55352f8defda50849e8e56 |
|
| https://github.com/AlexanderSher |
| Remove InvalidateAnalysis call from constructor | https://github.com/microsoft/python-language-server/pull/1584/commits/d01cb08ad2f74e08cbe58862fc64a117650d9521 |
| d01cb08 | https://github.com/microsoft/python-language-server/pull/1584/commits/d01cb08ad2f74e08cbe58862fc64a117650d9521 |
|
| https://github.com/AlexanderSher |
| Build fix | https://github.com/microsoft/python-language-server/pull/1584/commits/152a4a2ac5c1a809827a06e2afdf1bb993a3c3c9 |
| 152a4a2 | https://github.com/microsoft/python-language-server/pull/1584/commits/152a4a2ac5c1a809827a06e2afdf1bb993a3c3c9 |
|
| https://github.com/AlexanderSher |
| Merge branch 'master' into Numpy | https://github.com/microsoft/python-language-server/pull/1584/commits/bc80e5721dd8861dbcf27a5ceb916887dcf9c206 |
| bc80e57 | https://github.com/microsoft/python-language-server/pull/1584/commits/bc80e5721dd8861dbcf27a5ceb916887dcf9c206 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Oct 13, 2019 | https://github.com/microsoft/python-language-server/pull/1584#event-2708929557 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Oct 14, 2019 | https://github.com/microsoft/python-language-server/pull/1584#issuecomment-541494606 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Oct 14, 2019 | https://github.com/microsoft/python-language-server/pull/1584#event-2709156828 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Oct 14, 2019
| https://github.com/microsoft/python-language-server/pull/1584#ref-pullrequest-506871076 |
|
Improve handling of circular dependencies
#1686
| https://github.com/microsoft/python-language-server/pull/1686 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1584 |
|
| https://github.com/MikhailArkhipov |
|
Mikhail Arkhipov (MikhailArkhipov)
| https://github.com/MikhailArkhipov |
|
| https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1584 |
|
| https://github.com/AlexanderSher |
|
| https://github.com/MikhailArkhipov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |