René's URL Explorer Experiment


Title: Fix module cycle handling by AlexanderSher · Pull Request #1584 · microsoft/python-language-server · GitHub

Open Graph Title: Fix module cycle handling by AlexanderSher · Pull Request #1584 · microsoft/python-language-server

X Title: Fix module cycle handling by AlexanderSher · Pull Request #1584 · microsoft/python-language-server

Description: Microsoft Language Server for Python. Contribute to microsoft/python-language-server development by creating an account on GitHub.

Open Graph Description: This change modifies the way we handle cycle dependencies of modules. Previously, after finding the loop, we have determined some random path to walk over those modules and walked twice over it. Wi...

X Description: This change modifies the way we handle cycle dependencies of modules. Previously, after finding the loop, we have determined some random path to walk over those modules and walked twice over it. Wi...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/1584

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:41d30c21-082e-0c54-714a-5e536b2473af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD232:184DF1:59E7B6:7A9EB4:6AFE616F
html-safe-nonceaf9e8ae5c08ba4ffbd36a91f6315cf010895a866eccdee9707f79f52ff180817
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjMyOjE4NERGMTo1OUU3QjY6N0E5RUI0OjZBRkU2MTZGIiwidmlzaXRvcl9pZCI6IjY0ODk0NTczOTE0NTk3ODcxMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaf9e3e9dcfa8c55e39cdb5f01b040a42c8431eafc743e4d4d4c46d596ceeed8d
hovercard-subject-tagpull_request:321336379
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/1584/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7373487b5a131da4f4d9a432fa85e2774883a1a22b2283b515219752e590cbe6/microsoft/python-language-server/pull/1584
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7373487b5a131da4f4d9a432fa85e2774883a1a22b2283b515219752e590cbe6/microsoft/python-language-server/pull/1584
og:image:altThis change modifies the way we handle cycle dependencies of modules. Previously, after finding the loop, we have determined some random path to walk over those modules and walked twice over it. Wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexanderSher
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/1584#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1584
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1584
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/1584
Reloadhttps://github.com/microsoft/python-language-server/pull/1584
Reloadhttps://github.com/microsoft/python-language-server/pull/1584
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
https://github.com/microsoft/python-language-server
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
AlexanderSher:Numpyhttps://github.com/AlexanderSher/python-language-server/tree/Numpy
Conversationhttps://github.com/microsoft/python-language-server/pull/1584
Commits11 (11)https://github.com/microsoft/python-language-server/pull/1584/commits
Checkshttps://github.com/microsoft/python-language-server/pull/1584/checks
Files changedhttps://github.com/microsoft/python-language-server/pull/1584/files
Fix module cycle handlinghttps://github.com/microsoft/python-language-server/pull/1584#top
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
AlexanderSher:Numpyhttps://github.com/AlexanderSher/python-language-server/tree/Numpy
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 25, 2019https://github.com/microsoft/python-language-server/pull/1584#issue-498396230
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
September 22, 2019 00:05https://github.com/microsoft/python-language-server/pull/1584#commits-pushed-c9ff4e1
https://github.com/AlexanderSher
Refactoringhttps://github.com/microsoft/python-language-server/pull/1584/commits/c9ff4e10ccb53593c5b68b6513a1f71bbf929bff
c9ff4e1https://github.com/microsoft/python-language-server/pull/1584/commits/c9ff4e10ccb53593c5b68b6513a1f71bbf929bff
https://github.com/AlexanderSher
WIPhttps://github.com/microsoft/python-language-server/pull/1584/commits/6ab46ad303bfe679625d67d039cd9bc7891c20e5
6ab46adhttps://github.com/microsoft/python-language-server/pull/1584/commits/6ab46ad303bfe679625d67d039cd9bc7891c20e5
https://github.com/AlexanderSher
Merge commit '88762ef1a11cfddd51d382c920359c36e95f8d4d' into Numpyhttps://github.com/microsoft/python-language-server/pull/1584/commits/76887fc7162aa394652d933db89e986d2380d586
76887fchttps://github.com/microsoft/python-language-server/pull/1584/commits/76887fc7162aa394652d933db89e986d2380d586
https://github.com/AlexanderSher
Bug fixeshttps://github.com/microsoft/python-language-server/pull/1584/commits/1068b18c3320096f22765c11a2633796d84109eb
1068b18https://github.com/microsoft/python-language-server/pull/1584/commits/1068b18c3320096f22765c11a2633796d84109eb
https://github.com/AlexanderSher
Fix part of the testhttps://github.com/microsoft/python-language-server/pull/1584/commits/03f004d6ba3b9278d6a9605d7d0b30349ae4ce77
03f004dhttps://github.com/microsoft/python-language-server/pull/1584/commits/03f004d6ba3b9278d6a9605d7d0b30349ae4ce77
https://github.com/AlexanderSher
Fully restore testshttps://github.com/microsoft/python-language-server/pull/1584/commits/43c776669a06d7be87b157fa6d64fa3760436807
43c7766https://github.com/microsoft/python-language-server/pull/1584/commits/43c776669a06d7be87b157fa6d64fa3760436807
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 25, 2019https://github.com/microsoft/python-language-server/pull/1584#issuecomment-535105069
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 26, 2019https://github.com/microsoft/python-language-server/pull/1584#issuecomment-535315263
#1565https://github.com/microsoft/python-language-server/pull/1565
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 26, 2019https://github.com/microsoft/python-language-server/pull/1584#issuecomment-535674696
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://user-images.githubusercontent.com/12820357/65722916-25f8f400-e062-11e9-8c4e-c78c68588295.png
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 27, 2019 https://github.com/microsoft/python-language-server/pull/1584#pullrequestreview-294513863
View reviewed changes https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807
src/Analysis/Ast/Impl/Analyzer/Handlers/LoopImportedVariableHandler.cshttps://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807#diff-a4ee8cc733c8aee2d938d54feaf5a092912bf1d015a294a67d200a7b0873af25
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 27, 2019 https://github.com/microsoft/python-language-server/pull/1584#pullrequestreview-294519617
View reviewed changes https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807
src/Analysis/Ast/Impl/Analyzer/Handlers/SimpleImportedVariableHandler.cshttps://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807#diff-06c5760fe80c2f22efe07699f2245ac01defa7f50951e2bb6a922fab4ab96b41
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 27, 2019 https://github.com/microsoft/python-language-server/pull/1584#pullrequestreview-294539879
View reviewed changes https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807
src/Analysis/Ast/Impl/Analyzer/PythonAnalyzerSession.cshttps://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
added some comments and renamed some variables in PathResolver and PathResolverSnapshot #1597 https://github.com/microsoft/python-language-server/pull/1597
Better handling of loops in dependency analysis #1609 https://github.com/microsoft/python-language-server/issues/1609
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 8, 2019https://github.com/microsoft/python-language-server/pull/1584#event-2696321786
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 8, 2019 https://github.com/microsoft/python-language-server/pull/1584#ref-issue-477649727
Numpy analysis is inconsistent from run to run #1414 https://github.com/microsoft/python-language-server/issues/1414
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
October 9, 2019 15:04https://github.com/microsoft/python-language-server/pull/1584#commits-pushed-6bed88a
https://github.com/AlexanderSher
Merge remote-tracking branch 'Microsoft/master' into Numpyhttps://github.com/microsoft/python-language-server/pull/1584/commits/6bed88a26c816007a179ef4ebb79135a0fb62630
6bed88ahttps://github.com/microsoft/python-language-server/pull/1584/commits/6bed88a26c816007a179ef4ebb79135a0fb62630
https://github.com/AlexanderSher
Fix GetMemberNameshttps://github.com/microsoft/python-language-server/pull/1584/commits/695dd85e88ac0d4aec55352f8defda50849e8e56
695dd85https://github.com/microsoft/python-language-server/pull/1584/commits/695dd85e88ac0d4aec55352f8defda50849e8e56
https://github.com/AlexanderSher
Remove InvalidateAnalysis call from constructorhttps://github.com/microsoft/python-language-server/pull/1584/commits/d01cb08ad2f74e08cbe58862fc64a117650d9521
d01cb08https://github.com/microsoft/python-language-server/pull/1584/commits/d01cb08ad2f74e08cbe58862fc64a117650d9521
https://github.com/AlexanderSher
Build fixhttps://github.com/microsoft/python-language-server/pull/1584/commits/152a4a2ac5c1a809827a06e2afdf1bb993a3c3c9
152a4a2https://github.com/microsoft/python-language-server/pull/1584/commits/152a4a2ac5c1a809827a06e2afdf1bb993a3c3c9
https://github.com/AlexanderSher
Merge branch 'master' into Numpyhttps://github.com/microsoft/python-language-server/pull/1584/commits/bc80e5721dd8861dbcf27a5ceb916887dcf9c206
bc80e57https://github.com/microsoft/python-language-server/pull/1584/commits/bc80e5721dd8861dbcf27a5ceb916887dcf9c206
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 13, 2019https://github.com/microsoft/python-language-server/pull/1584#event-2708929557
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 14, 2019https://github.com/microsoft/python-language-server/pull/1584#issuecomment-541494606
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 14, 2019https://github.com/microsoft/python-language-server/pull/1584#event-2709156828
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Oct 14, 2019 https://github.com/microsoft/python-language-server/pull/1584#ref-pullrequest-506871076
Improve handling of circular dependencies #1686 https://github.com/microsoft/python-language-server/pull/1686
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1584
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) https://github.com/MikhailArkhipov
https://github.com/microsoft/python-language-server/pull/1584/files/43c776669a06d7be87b157fa6d64fa3760436807
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1584
https://github.com/AlexanderSher
https://github.com/MikhailArkhipov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.