René's URL Explorer Experiment


Title: Implement proper line split + tests by MikhailArkhipov · Pull Request #1544 · microsoft/python-language-server · GitHub

Open Graph Title: Implement proper line split + tests by MikhailArkhipov · Pull Request #1544 · microsoft/python-language-server

X Title: Implement proper line split + tests by MikhailArkhipov · Pull Request #1544 · microsoft/python-language-server

Description: Fixes #1543 Changes were applied incorrectly. Changes across line spans caused buffer corruption. Typical example is undoing multiple changes via fast Ctrl+Z. Simplified change handling: per LSP, any sequence applies * The actual content changes. The content changes describe single state changes * to the document. So if there are two content changes c1 and c2 for a document * in state S then c1 move the document to S' and c2 to S''. and we can now handle this since line splits update after each change. Implement new line location without creating extra strings Add tests for new lines as well as for multi-line edits. Remove unused flags Remove change reordering/versions.

Open Graph Description: Fixes #1543 Changes were applied incorrectly. Changes across line spans caused buffer corruption. Typical example is undoing multiple changes via fast Ctrl+Z. Simplified change handling: per LSP, ...

X Description: Fixes #1543 Changes were applied incorrectly. Changes across line spans caused buffer corruption. Typical example is undoing multiple changes via fast Ctrl+Z. Simplified change handling: per LSP, ...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/1544

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1e9c1d5d-68d9-49bb-5cd3-c2115bedb151
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE95A:B0D00:B86A43:FA2F09:6AFE6CAC
html-safe-nonce407410245397689a788ab5013693f4166030f19465baccf9c786b99c9e484502
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTVBOkIwRDAwOkI4NkE0MzpGQTJGMDk6NkFGRTZDQUMiLCJ2aXNpdG9yX2lkIjoiODUyMjY4MjE0NDc0MzM4NjI4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac237db1dd9cb761ea6ca6b7f5d8ebaa543adebf587e65eb8c95059faa350f9af3
hovercard-subject-tagpull_request:317529719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/python-language-server/pull/1544/files
twitter:imagehttps://avatars.githubusercontent.com/u/12820357?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12820357?s=400&v=4
og:image:altFixes #1543 Changes were applied incorrectly. Changes across line spans caused buffer corruption. Typical example is undoing multiple changes via fast Ctrl+Z. Simplified change handling: per LSP, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/1544/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1544%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1544%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/1544/files
Reloadhttps://github.com/microsoft/python-language-server/pull/1544/files
Reloadhttps://github.com/microsoft/python-language-server/pull/1544/files
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
masterhttps://github.com/microsoft/python-language-server/tree/master
1543-1https://github.com/microsoft/python-language-server/tree/1543-1
Conversation 6 https://github.com/microsoft/python-language-server/pull/1544
Commits 4 https://github.com/microsoft/python-language-server/pull/1544/commits
Checks 0 https://github.com/microsoft/python-language-server/pull/1544/checks
Files changed https://github.com/microsoft/python-language-server/pull/1544/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1544/files
Implement proper line split + tests https://github.com/microsoft/python-language-server/pull/1544/files#top
Show all changes 4 commits https://github.com/microsoft/python-language-server/pull/1544/files
3d39cc3 Implement proper line split + tests Sep 14, 2019 https://github.com/microsoft/python-language-server/pull/1544/commits/3d39cc3ef7a9939a195efc71999c71ef4b6a5094
0b2519b Out of order test Sep 14, 2019 https://github.com/microsoft/python-language-server/pull/1544/commits/0b2519b2aba23c24bace57114422796a6d41b6fa
5826f0f Rename method Sep 14, 2019 https://github.com/microsoft/python-language-server/pull/1544/commits/5826f0ff7b4ce157f377cf9c3caf854dc92ca548
dcea463 Unused code Sep 16, 2019 https://github.com/microsoft/python-language-server/pull/1544/commits/dcea463dc4e73cd045d32f68c9b40d929ea1d74a
Clear filters https://github.com/microsoft/python-language-server/pull/1544/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1544/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1544/files
DocumentBuffer.cs https://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
DocumentBufferTests.cs https://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
Server.Documents.cs https://github.com/microsoft/python-language-server/pull/1544/files#diff-85de6f97bb4aa597d804b064411d1fe5b1022a6629da4f0329a632fddb3df4be
LanguageServer.cs https://github.com/microsoft/python-language-server/pull/1544/files#diff-4a74b4c46f62614bf1cd2c2eb31344d77a2be2ea904df3d60fd549ee61e8a6ca
Messages.cs https://github.com/microsoft/python-language-server/pull/1544/files#diff-a675fc3f9791f97ffc38e76a84ec79ebcd1de9e32e521fc062969ec11cb1df2e
src/Analysis/Ast/Impl/Documents/DocumentBuffer.cshttps://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
View file https://github.com/microsoft/python-language-server/blob/dcea463dc4e73cd045d32f68c9b40d929ea1d74a/src/Analysis/Ast/Impl/Documents/DocumentBuffer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1544/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
https://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
https://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
https://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
https://github.com/microsoft/python-language-server/pull/1544/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
src/Analysis/Ast/Test/DocumentBufferTests.cshttps://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
View file https://github.com/microsoft/python-language-server/blob/dcea463dc4e73cd045d32f68c9b40d929ea1d74a/src/Analysis/Ast/Test/DocumentBufferTests.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1544/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
https://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
https://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
https://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
https://github.com/microsoft/python-language-server/pull/1544/files#diff-1100cf5e9bd86d3f2817334887e61e97016767540497202062b4e4c89b25d576
src/LanguageServer/Impl/Implementation/Server.Documents.cshttps://github.com/microsoft/python-language-server/pull/1544/files#diff-85de6f97bb4aa597d804b064411d1fe5b1022a6629da4f0329a632fddb3df4be
View file https://github.com/microsoft/python-language-server/blob/dcea463dc4e73cd045d32f68c9b40d929ea1d74a/src/LanguageServer/Impl/Implementation/Server.Documents.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1544/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1544/files#diff-85de6f97bb4aa597d804b064411d1fe5b1022a6629da4f0329a632fddb3df4be
https://github.com/microsoft/python-language-server/pull/1544/files#diff-85de6f97bb4aa597d804b064411d1fe5b1022a6629da4f0329a632fddb3df4be
https://github.com/microsoft/python-language-server/pull/1544/files#diff-85de6f97bb4aa597d804b064411d1fe5b1022a6629da4f0329a632fddb3df4be
src/LanguageServer/Impl/LanguageServer.cshttps://github.com/microsoft/python-language-server/pull/1544/files#diff-4a74b4c46f62614bf1cd2c2eb31344d77a2be2ea904df3d60fd549ee61e8a6ca
View file https://github.com/microsoft/python-language-server/blob/dcea463dc4e73cd045d32f68c9b40d929ea1d74a/src/LanguageServer/Impl/LanguageServer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1544/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1544/files#diff-4a74b4c46f62614bf1cd2c2eb31344d77a2be2ea904df3d60fd549ee61e8a6ca
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1544/files
https://github.com/microsoft/python-language-server/pull/1544/files#diff-4a74b4c46f62614bf1cd2c2eb31344d77a2be2ea904df3d60fd549ee61e8a6ca
src/LanguageServer/Impl/Protocol/Messages.cshttps://github.com/microsoft/python-language-server/pull/1544/files#diff-a675fc3f9791f97ffc38e76a84ec79ebcd1de9e32e521fc062969ec11cb1df2e
View file https://github.com/microsoft/python-language-server/blob/dcea463dc4e73cd045d32f68c9b40d929ea1d74a/src/LanguageServer/Impl/Protocol/Messages.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1544/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1544/files#diff-a675fc3f9791f97ffc38e76a84ec79ebcd1de9e32e521fc062969ec11cb1df2e
https://github.com/microsoft/python-language-server/pull/1544/files#diff-a675fc3f9791f97ffc38e76a84ec79ebcd1de9e32e521fc062969ec11cb1df2e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.