René's URL Explorer Experiment


Title: Synchronize text buffer access by MikhailArkhipov · Pull Request #1479 · microsoft/python-language-server · GitHub

Open Graph Title: Synchronize text buffer access by MikhailArkhipov · Pull Request #1479 · microsoft/python-language-server

X Title: Synchronize text buffer access by MikhailArkhipov · Pull Request #1479 · microsoft/python-language-server

Description: Fixes #1466 Fixes #1449 Fixes #1425 Fixes #1353 Although text buffer updates come from the same thread, it does can be read concurrently by the analysis and Reset can be called as well (although this is probably extremely rare as we do not call Reset on user files when analysis completes). Call for content by the parser or analyzer may cause conversion of the string builder to _content in the middle of the string builder update yielding odd partial results.

Open Graph Description: Fixes #1466 Fixes #1449 Fixes #1425 Fixes #1353 Although text buffer updates come from the same thread, it does can be read concurrently by the analysis and Reset can be called as well (although th...

X Description: Fixes #1466 Fixes #1449 Fixes #1425 Fixes #1353 Although text buffer updates come from the same thread, it does can be read concurrently by the analysis and Reset can be called as well (although th...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/1479

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a750bb87-39f6-9c69-08e7-e6b278cdac6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECFA:29B9B8:5C71BB:78E385:6AFE6AA6
html-safe-nonce6e24cfbc4d2b2cc3e469d542c41d42b4079147eab9bc7cfe0bac438c26f49861
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0ZBOjI5QjlCODo1QzcxQkI6NzhFMzg1OjZBRkU2QUE2IiwidmlzaXRvcl9pZCI6IjYzMDM4NjA2MDYwODAyODEyNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc6e49ca1aa6d22b4d19e339de9352e92eb7b7573f09d69f5868a01f372cfb062
hovercard-subject-tagpull_request:310585863
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/python-language-server/pull/1479/files
twitter:imagehttps://avatars.githubusercontent.com/u/12820357?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12820357?s=400&v=4
og:image:altFixes #1466 Fixes #1449 Fixes #1425 Fixes #1353 Although text buffer updates come from the same thread, it does can be read concurrently by the analysis and Reset can be called as well (although th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/1479/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1479%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1479%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/1479/files
Reloadhttps://github.com/microsoft/python-language-server/pull/1479/files
Reloadhttps://github.com/microsoft/python-language-server/pull/1479/files
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
MikhailArkhipov:desynchttps://github.com/MikhailArkhipov/python-language-server/tree/desync
Conversation 6 https://github.com/microsoft/python-language-server/pull/1479
Commits 6 https://github.com/microsoft/python-language-server/pull/1479/commits
Checks 0 https://github.com/microsoft/python-language-server/pull/1479/checks
Files changed https://github.com/microsoft/python-language-server/pull/1479/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1479/files
Synchronize text buffer access https://github.com/microsoft/python-language-server/pull/1479/files#top
Show all changes 6 commits https://github.com/microsoft/python-language-server/pull/1479/files
a848a25 Synchronize text buffer Aug 24, 2019 https://github.com/microsoft/python-language-server/pull/1479/commits/a848a257a0f04cbf044f6991d83e66c7adeaf3ed
16a75de Simplify Aug 24, 2019 https://github.com/microsoft/python-language-server/pull/1479/commits/16a75de4c86fc3840227e86cdb1f4a1e37df5b75
110ee98 One more Aug 24, 2019 https://github.com/microsoft/python-language-server/pull/1479/commits/110ee98159f4bca25e3d4d8a48d7dc77ad3e59f6
d1c0ffe Use ?? Aug 24, 2019 https://github.com/microsoft/python-language-server/pull/1479/commits/d1c0ffe6e3538f2f65e49765ab3fa61f23b20dfd
fa2abb3 Typo Aug 24, 2019 https://github.com/microsoft/python-language-server/pull/1479/commits/fa2abb3e8043515c1cfd4d2c38738472350b9e64
9c6eb91 Simplify Aug 26, 2019 https://github.com/microsoft/python-language-server/pull/1479/commits/9c6eb9195a5332775a7b0cc1af59d309851d988a
Clear filters https://github.com/microsoft/python-language-server/pull/1479/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1479/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1479/files
src/Analysis/Ast/Impl/Documents/DocumentBuffer.cshttps://github.com/microsoft/python-language-server/pull/1479/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
View file https://github.com/MikhailArkhipov/python-language-server/blob/9c6eb9195a5332775a7b0cc1af59d309851d988a/src/Analysis/Ast/Impl/Documents/DocumentBuffer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1479/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1479/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
https://github.com/microsoft/python-language-server/pull/1479/files#diff-61f4bdb13cce47dbafb6b844b131a3481647c869d617573973c821e366e7d2b5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.