René's URL Explorer Experiment


Title: Remove all references to dropped modules and force GC on reload by jakebailey · Pull Request #1402 · microsoft/python-language-server · GitHub

Open Graph Title: Remove all references to dropped modules and force GC on reload by jakebailey · Pull Request #1402 · microsoft/python-language-server

X Title: Remove all references to dropped modules and force GC on reload by jakebailey · Pull Request #1402 · microsoft/python-language-server

Description: Fixes #1408. For #1298. Pulls ModuleWalker changes from #1372, as stub merging was adding things to places it shouldn't. Drops more ASTs (compiled/stubs). Prevents adding references to the builtin module (i.e. references to object). Resets both the typeshed and main module resolution. Clears the builtin module's AST map for a future reanalysis. This needs to be reexamined; our method of modifying the scope of functions during calls to them is not right and needs to be fixed separately. Forces a GC/compact after a reload (to actually lower the memory usage after reloading) Drops [Flag] on ModuleType. Removes some dead code that would have caused reloads (but didn't need to).

Open Graph Description: Fixes #1408. For #1298. Pulls ModuleWalker changes from #1372, as stub merging was adding things to places it shouldn't. Drops more ASTs (compiled/stubs). Prevents adding references to the bui...

X Description: Fixes #1408. For #1298. Pulls ModuleWalker changes from #1372, as stub merging was adding things to places it shouldn't. Drops more ASTs (compiled/stubs). Prevents adding references to the...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/1402

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af2ddd4f-38a7-1839-0b0b-ade5cfe99ce9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA84:D8CB1:659F2B:8A9191:6AFE6489
html-safe-noncebd38a0a649f13ba94cc31d749a5a998c19eb0f7e1a1fe15e545956d36b779f87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTg0OkQ4Q0IxOjY1OUYyQjo4QTkxOTE6NkFGRTY0ODkiLCJ2aXNpdG9yX2lkIjoiMzc3NDQ2NDg5NzAwMjEzNjcxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac96709e5049f541d68c0fd69a782051e33a95e437fd04605c4f14ff8fc8a4a87d
hovercard-subject-tagpull_request:303952773
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/python-language-server/pull/1402/files
twitter:imagehttps://avatars.githubusercontent.com/u/5341706?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5341706?s=400&v=4
og:image:altFixes #1408. For #1298. Pulls ModuleWalker changes from #1372, as stub merging was adding things to places it shouldn't. Drops more ASTs (compiled/stubs). Prevents adding references to the bui...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/1402/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1402%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1402%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/1402/files
Reloadhttps://github.com/microsoft/python-language-server/pull/1402/files
Reloadhttps://github.com/microsoft/python-language-server/pull/1402/files
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
jakebailey:reload-memory-usagehttps://github.com/jakebailey/python-language-server/tree/reload-memory-usage
Conversation 15 https://github.com/microsoft/python-language-server/pull/1402
Commits 14 https://github.com/microsoft/python-language-server/pull/1402/commits
Checks 0 https://github.com/microsoft/python-language-server/pull/1402/checks
Files changed https://github.com/microsoft/python-language-server/pull/1402/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
Remove all references to dropped modules and force GC on reload https://github.com/microsoft/python-language-server/pull/1402/files#top
Show all changes 14 commits https://github.com/microsoft/python-language-server/pull/1402/files
521eb47 First attempt at ensuring moduled dropped during reload are GC'd jakebailey Jul 30, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/521eb47dfa68099e87cd06183d8c06acb5cc122f
74dec25 Make sure AST is set after content is cleared jakebailey Jul 31, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/74dec25c5a1782237ba319a7c2da6649bde01ade
6abeb90 More tests passing jakebailey Jul 31, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/6abeb90b0c35f4b3230451210513a796ac5394f5
ddfb305 ModuleWalker updates jakebailey Jul 31, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/ddfb30538f86ae023d5ca0e4f7246f1a4253d51e
bfc4955 Also don't merge against specialized modules, do builtin _astMap rese… jakebailey Aug 1, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/bfc49557a4becac35b8e1a2d4578e69fe2708841
2425d1e Don't call dispose directly, it's done elsewhere and has no effect jakebailey Aug 1, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/2425d1e28b46ef6c599252c23bd36df167d1a81a
e843a60 Force GC via normal session instead of waiting for a hardcoded time jakebailey Aug 2, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/e843a6032e9e1a5b2bd11bfae9c1008ea1905d2f
30bd001 Un-refactor function since it's not being called externally anymore jakebailey Aug 2, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/30bd0019709528da8062bcd844cfdb340a951a2f
0336dfb Formatting/usings jakebailey Aug 2, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/0336dfbfc7169dcbf7f85c381ea9937ffef2e2f3
4c51603 PR feedback jakebailey Aug 2, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/4c516036bc16b4ebb94e8cda9497d9070610cc6c
fbed27b Undo IsBuiltin, some things continued to be referenced with that changed jakebailey Aug 5, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/fbed27b2b940cc384689ea0b6561be8487391bbb
540676f Move reload logic down into PythonAnalyzer, remove added public infer… jakebailey Aug 5, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/540676fdf1253b4d156c25b6a99ea409b32a640b
490991b Mode AddReference to PythonType as override jakebailey Aug 5, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/490991b3b4fcdb1d7e203738a08e89b1c73dd730
ac2bb01 Remove dead code, make all ResetAnalyzer calls full jakebailey Aug 5, 2019 https://github.com/microsoft/python-language-server/pull/1402/commits/ac2bb01f98056d089cb6253649f181fae926ef7b
Clear filters https://github.com/microsoft/python-language-server/pull/1402/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
IPythonAnalyzer.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-3761f8021d125e32225294b58db22acb9b9253a8ef204ac46df6842c02a35b2d
ModuleWalker.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-59dde190392895b108211d3dbcb326b89a12eeef522d5653f476f7616ae8188c
PythonAnalyzer.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
PythonAnalyzerSession.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
ModuleType.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-f03895a7d85c13fba12b84ee9c70553477a9163cef26a5ae227520aea923fe47
PythonType.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-a1c0cec1ac0e2936960d8dfa186eba8eacde1dd05a1401fd75b4217b4e070b31
Server.cs https://github.com/microsoft/python-language-server/pull/1402/files#diff-61776581664148d97359dd5bfaf6a4c58902b516e1ae0efb3921a5804bc853b5
src/Analysis/Ast/Impl/Analyzer/Definitions/IPythonAnalyzer.cshttps://github.com/microsoft/python-language-server/pull/1402/files#diff-3761f8021d125e32225294b58db22acb9b9253a8ef204ac46df6842c02a35b2d
View file https://github.com/jakebailey/python-language-server/blob/ac2bb01f98056d089cb6253649f181fae926ef7b/src/Analysis/Ast/Impl/Analyzer/Definitions/IPythonAnalyzer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1402/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1402/files#diff-3761f8021d125e32225294b58db22acb9b9253a8ef204ac46df6842c02a35b2d
https://github.com/microsoft/python-language-server/pull/1402/files#diff-3761f8021d125e32225294b58db22acb9b9253a8ef204ac46df6842c02a35b2d
src/Analysis/Ast/Impl/Analyzer/ModuleWalker.cshttps://github.com/microsoft/python-language-server/pull/1402/files#diff-59dde190392895b108211d3dbcb326b89a12eeef522d5653f476f7616ae8188c
View file https://github.com/jakebailey/python-language-server/blob/ac2bb01f98056d089cb6253649f181fae926ef7b/src/Analysis/Ast/Impl/Analyzer/ModuleWalker.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1402/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1402/files#diff-59dde190392895b108211d3dbcb326b89a12eeef522d5653f476f7616ae8188c
https://github.com/microsoft/python-language-server/pull/1402/files#diff-59dde190392895b108211d3dbcb326b89a12eeef522d5653f476f7616ae8188c
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
src/Analysis/Ast/Impl/Analyzer/PythonAnalyzer.cshttps://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
View file https://github.com/jakebailey/python-language-server/blob/ac2bb01f98056d089cb6253649f181fae926ef7b/src/Analysis/Ast/Impl/Analyzer/PythonAnalyzer.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1402/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Aug 5, 2019https://github.com/microsoft/python-language-server/pull/1402/files#r310810816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 5, 2019https://github.com/microsoft/python-language-server/pull/1402/files#r310812429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
https://github.com/microsoft/python-language-server/pull/1402/files#diff-5136b167edcf9d5cac544aa19f13fea3e386eb853004665b66b4d03040fca477
src/Analysis/Ast/Impl/Analyzer/PythonAnalyzerSession.cshttps://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
View file https://github.com/jakebailey/python-language-server/blob/ac2bb01f98056d089cb6253649f181fae926ef7b/src/Analysis/Ast/Impl/Analyzer/PythonAnalyzerSession.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1402/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
https://github.com/microsoft/python-language-server/pull/1402/files#diff-626c2f854bdc71d5a7946f069a00df508954dcb06ddcca6822604cad91b7a5a1
src/Analysis/Ast/Impl/Modules/Definitions/ModuleType.cshttps://github.com/microsoft/python-language-server/pull/1402/files#diff-f03895a7d85c13fba12b84ee9c70553477a9163cef26a5ae227520aea923fe47
View file https://github.com/jakebailey/python-language-server/blob/ac2bb01f98056d089cb6253649f181fae926ef7b/src/Analysis/Ast/Impl/Modules/Definitions/ModuleType.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1402/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1402/files#diff-f03895a7d85c13fba12b84ee9c70553477a9163cef26a5ae227520aea923fe47
https://github.com/microsoft/python-language-server/pull/1402/files#diff-f03895a7d85c13fba12b84ee9c70553477a9163cef26a5ae227520aea923fe47
src/Analysis/Ast/Impl/Types/PythonType.cshttps://github.com/microsoft/python-language-server/pull/1402/files#diff-a1c0cec1ac0e2936960d8dfa186eba8eacde1dd05a1401fd75b4217b4e070b31
View file https://github.com/jakebailey/python-language-server/blob/ac2bb01f98056d089cb6253649f181fae926ef7b/src/Analysis/Ast/Impl/Types/PythonType.cs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/1402/{{ revealButtonHref }}
https://github.com/microsoft/python-language-server/pull/1402/files#diff-a1c0cec1ac0e2936960d8dfa186eba8eacde1dd05a1401fd75b4217b4e070b31
https://github.com/microsoft/python-language-server/pull/1402/files#diff-a1c0cec1ac0e2936960d8dfa186eba8eacde1dd05a1401fd75b4217b4e070b31
https://github.com/microsoft/python-language-server/pull/1402/files#diff-a1c0cec1ac0e2936960d8dfa186eba8eacde1dd05a1401fd75b4217b4e070b31
https://github.com/microsoft/python-language-server/pull/1402/files#diff-a1c0cec1ac0e2936960d8dfa186eba8eacde1dd05a1401fd75b4217b4e070b31
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/1402/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.