| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:015bc834-a286-2347-8c0d-428b753fe3ba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E58E:11F29A:1D1186:26154D:6AFE5708 |
| html-safe-nonce | 1b1333ca89df0a45e79342bc7c569cf27d98f646b891be7e39ce03de68165ecb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNThFOjExRjI5QToxRDExODY6MjYxNTREOjZBRkU1NzA4IiwidmlzaXRvcl9pZCI6Ijg5MDU4MDU1ODg0NjI0NTg2MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 19853f27a9feec11fea549162a850b86a6561fbb2b305cb9e43542d44ed74ceb |
| hovercard-subject-tag | pull_request:300895257 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/1380/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/93f8a984d97336e5fe73f3070676a48868f87961e7e0de5148767edd635054ec/microsoft/python-language-server/pull/1380 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/93f8a984d97336e5fe73f3070676a48868f87961e7e0de5148767edd635054ec/microsoft/python-language-server/pull/1380 |
| og:image:alt | Closes #1376
Add handling of 'else' to platform and language version
Make methods into extensions so they can be reused
Make symbol collector to properly walk conditions using the above |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MikhailArkhipov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3ad2b58e42f481583284b895305360b61b0223636c9dde6d696b575347163a26 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8df44dbe1c8091b38c3e0165c05a1e5c1563762e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/python-language-server/pull/1380#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1380 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1380 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server |
| Reload | https://github.com/microsoft/python-language-server/pull/1380 |
| Reload | https://github.com/microsoft/python-language-server/pull/1380 |
| Reload | https://github.com/microsoft/python-language-server/pull/1380 |
| microsoft | https://github.com/microsoft |
| python-language-server | https://github.com/microsoft/python-language-server |
| Code | https://github.com/microsoft/python-language-server |
| Issues309 (309) | https://github.com/microsoft/python-language-server/issues |
| Pull requests6 (6) | https://github.com/microsoft/python-language-server/pulls |
| Projects | https://github.com/microsoft/python-language-server/projects |
| Wiki | https://github.com/microsoft/python-language-server/wiki |
| Security and quality | https://github.com/microsoft/python-language-server/security |
| Insights | https://github.com/microsoft/python-language-server/insights |
| https://github.com/microsoft/python-language-server |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| MikhailArkhipov:1376 | https://github.com/MikhailArkhipov/python-language-server/tree/1376 |
| Conversation | https://github.com/microsoft/python-language-server/pull/1380 |
| Commits8 (8) | https://github.com/microsoft/python-language-server/pull/1380/commits |
| Checks | https://github.com/microsoft/python-language-server/pull/1380/checks |
| Files changed | https://github.com/microsoft/python-language-server/pull/1380/files |
| Handle else in platform and version clauses + handle it in symbol collector | https://github.com/microsoft/python-language-server/pull/1380#top |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| MikhailArkhipov:1376 | https://github.com/MikhailArkhipov/python-language-server/tree/1376 |
|
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Jul 24, 2019 | https://github.com/microsoft/python-language-server/pull/1380#issue-472527913 |
| #1376 | https://github.com/microsoft/python-language-server/issues/1376 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1380 |
| July 24, 2019 14:03 | https://github.com/microsoft/python-language-server/pull/1380#commits-pushed-28f5b6c |
| Handle else in platform and version clauses + handle it in symbol col… | https://github.com/microsoft/python-language-server/pull/1380/commits/28f5b6c98085c045a50c72c88ee94aedccce899e |
| 28f5b6c | https://github.com/microsoft/python-language-server/pull/1380/commits/28f5b6c98085c045a50c72c88ee94aedccce899e |
| Formatting | https://github.com/microsoft/python-language-server/pull/1380/commits/8fdf7691b4a76967c001105c1b65dd91645bc7f4 |
| 8fdf769 | https://github.com/microsoft/python-language-server/pull/1380/commits/8fdf7691b4a76967c001105c1b65dd91645bc7f4 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Jul 24, 2019 | https://github.com/microsoft/python-language-server/pull/1380#event-2507885116 |
| July 24, 2019 16:14 | https://github.com/microsoft/python-language-server/pull/1380#commits-pushed-08b5971 |
| Fix walk of multi-level if statement | https://github.com/microsoft/python-language-server/pull/1380/commits/08b59711d6e7536d414d795c960aa430131e26e6 |
| 08b5971 | https://github.com/microsoft/python-language-server/pull/1380/commits/08b59711d6e7536d414d795c960aa430131e26e6 |
| Unify package search in imports | https://github.com/microsoft/python-language-server/pull/1380/commits/67fed10d1c892de07a9a920b5396d53d7473b977 |
| 67fed10 | https://github.com/microsoft/python-language-server/pull/1380/commits/67fed10d1c892de07a9a920b5396d53d7473b977 |
| Fix tests | https://github.com/microsoft/python-language-server/pull/1380/commits/247a8c38741324452cc5a8eeb412a9784441bd8b |
| 247a8c3 | https://github.com/microsoft/python-language-server/pull/1380/commits/247a8c38741324452cc5a8eeb412a9784441bd8b |
| Undo change | https://github.com/microsoft/python-language-server/pull/1380/commits/2bd4749e1b217d10e18c20b7079fb464fc9807b7 |
| 2bd4749 | https://github.com/microsoft/python-language-server/pull/1380/commits/2bd4749e1b217d10e18c20b7079fb464fc9807b7 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Jul 25, 2019 | https://github.com/microsoft/python-language-server/pull/1380#event-2510582616 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| August 5, 2019 20:03 | https://github.com/microsoft/python-language-server/pull/1380#event-2534631907 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
|
Aug 5, 2019
| https://github.com/microsoft/python-language-server/pull/1380#ref-pullrequest-472004764 |
|
Multiple fixes and additional tests for persistence
#1372
| https://github.com/microsoft/python-language-server/pull/1372 |
| August 6, 2019 20:20 | https://github.com/microsoft/python-language-server/pull/1380#commits-pushed-1d86086 |
| Revert "Fix tests" | https://github.com/microsoft/python-language-server/pull/1380/commits/1d86086728b80dca59e23666448ddd7223df8e27 |
| 1d86086 | https://github.com/microsoft/python-language-server/pull/1380/commits/1d86086728b80dca59e23666448ddd7223df8e27 |
| 247a8c3 | https://github.com/MikhailArkhipov/python-language-server/commit/247a8c38741324452cc5a8eeb412a9784441bd8b |
| Revert "Unify package search in imports" | https://github.com/microsoft/python-language-server/pull/1380/commits/67350e388853e26e2c6ac7c313b0cbdfe76603fd |
| 67350e3 | https://github.com/microsoft/python-language-server/pull/1380/commits/67350e388853e26e2c6ac7c313b0cbdfe76603fd |
| 67fed10 | https://github.com/MikhailArkhipov/python-language-server/commit/67fed10d1c892de07a9a920b5396d53d7473b977 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
| August 7, 2019 19:18 | https://github.com/microsoft/python-language-server/pull/1380#event-2541137367 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Aug 7, 2019 | https://github.com/microsoft/python-language-server/pull/1380#issuecomment-519233686 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1380 |
| https://github.com/AlexanderSher |
| Alexander Sher (AlexanderSher) | https://github.com/AlexanderSher |
|
Aug 7, 2019
| https://github.com/microsoft/python-language-server/pull/1380#pullrequestreview-272202714 |
|
View reviewed changes
| https://github.com/microsoft/python-language-server/pull/1380/files/67350e388853e26e2c6ac7c313b0cbdfe76603fd |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| bd54c74 | https://github.com/microsoft/python-language-server/commit/bd54c7409f776dfbc4b53523f3b966528feb480f |
| Aug 7, 2019 | https://github.com/microsoft/python-language-server/pull/1380#event-2541284984 |
| https://github.com/MikhailArkhipov |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| August 7, 2019 20:17 | https://github.com/microsoft/python-language-server/pull/1380#event-2541285404 |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
|
Nov 1, 2019
| https://github.com/microsoft/python-language-server/pull/1380#ref-commit-02f1460 |
| Handle else in platform and version clauses + handle it in symbol col… | https://github.com/jakebailey/python-language-server/commit/02f1460893ef920d59fd069bbd745668a2ac0483 |
| 02f1460 | https://github.com/jakebailey/python-language-server/commit/02f1460893ef920d59fd069bbd745668a2ac0483 |
| microsoft#1380 | https://github.com/microsoft/python-language-server/pull/1380 |
| 247a8c3 | https://github.com/jakebailey/python-language-server/commit/247a8c38741324452cc5a8eeb412a9784441bd8b |
| 67fed10 | https://github.com/jakebailey/python-language-server/commit/67fed10d1c892de07a9a920b5396d53d7473b977 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F1380 |
|
| https://github.com/jakebailey |
|
Jake Bailey (jakebailey)
| https://github.com/jakebailey |
|
| https://github.com/AlexanderSher |
|
Alexander Sher (AlexanderSher)
| https://github.com/AlexanderSher |
|
| https://github.com/microsoft/python-language-server/pull/1380/files/67350e388853e26e2c6ac7c313b0cbdfe76603fd |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1380 |
|
Functions collector does not handle language version
| https://github.com/microsoft/python-language-server/issues/1376 |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/1380 |
|
| https://github.com/MikhailArkhipov |
|
| https://github.com/AlexanderSher |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |