| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:537d1f02-7a3e-d341-b34a-d81cc478169c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ACBE:41486:7507C7:9978CB:6AFE7482 |
| html-safe-nonce | 89fdf3cb06e49c172f028a2b720081016637b1afe6e6bd30a5ad9bceef00622e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0JFOjQxNDg2Ojc1MDdDNzo5OTc4Q0I6NkFGRTc0ODIiLCJ2aXNpdG9yX2lkIjoiMzQ0MzE0NDE0NDc2MTgxMjA5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ed4af8e036236b2eb45a2820cddad62e92268ba03c7db5c8af4aa7e55101d1e1 |
| hovercard-subject-tag | pull_request:217760468 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/python-language-server/pull/126/files |
| twitter:image | https://avatars.githubusercontent.com/u/5341706?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5341706?s=400&v=4 |
| og:image:alt | This PR implements line formatting via on-type formatting, triggering on newline and semicolon. It only tokenizes the code to be formatted, and does not require parsing.
This covers all of the exis... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/python-language-server/pull/126/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F126%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F126%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fpython-language-server |
| Reload | https://github.com/microsoft/python-language-server/pull/126/files |
| Reload | https://github.com/microsoft/python-language-server/pull/126/files |
| Reload | https://github.com/microsoft/python-language-server/pull/126/files |
| microsoft | https://github.com/microsoft |
| python-language-server | https://github.com/microsoft/python-language-server |
| Code | https://github.com/microsoft/python-language-server |
| Issues309 (309) | https://github.com/microsoft/python-language-server/issues |
| Pull requests6 (6) | https://github.com/microsoft/python-language-server/pulls |
| Projects | https://github.com/microsoft/python-language-server/projects |
| Wiki | https://github.com/microsoft/python-language-server/wiki |
| Security and quality | https://github.com/microsoft/python-language-server/security |
| Insights | https://github.com/microsoft/python-language-server/insights |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| microsoft:master | https://github.com/microsoft/python-language-server/tree/master |
| jakebailey:on-type-formatting | https://github.com/jakebailey/python-language-server/tree/on-type-formatting |
|
Conversation
66
| https://github.com/microsoft/python-language-server/pull/126 |
|
Commits
45
| https://github.com/microsoft/python-language-server/pull/126/commits |
|
Checks
0
| https://github.com/microsoft/python-language-server/pull/126/checks |
|
Files changed
| https://github.com/microsoft/python-language-server/pull/126/files |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
|
On type formatting
| https://github.com/microsoft/python-language-server/pull/126/files#top |
|
Show all changes
45 commits
| https://github.com/microsoft/python-language-server/pull/126/files |
|
4f3434b
Working line formatter based on VS Code implementation, without tests
jakebailey Sep 11, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/4f3434bdf7bc96b28f9fd5c6be79543b05a80c9e |
|
c52b83d
fix namespace change, rename file
jakebailey Sep 11, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/c52b83d055753b0a7753f70d6ed2b2c5767a9539 |
|
d8d1a74
move LineFormatter, add basic OnTypeFormatting tests, add LineFormatt…
jakebailey Sep 12, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/d8d1a7429f7058c8e038371f4b49d32cdcf3dc4f |
|
410b13f
mostly complete line formatter
jakebailey Sep 14, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/410b13f1edabdf20b5f8bd36db599149be73b123 |
|
1a4c2db
rewrite formatter from scratch, fully passes existing tests with slig…
jakebailey Sep 17, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/1a4c2dbcd1615875406d531bb1ad8d89490218a8 |
|
cdbc45a
cleanup argument/lambda inside logic, remove leftover debugging state…
jakebailey Sep 17, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/cdbc45a9852562e480d7a2056862a6b6b72eaaa9 |
|
32bae79
fix various formatting issues from vscode-python
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/32bae79cc7b1f7d33dab62a1485f0970ebedba8d |
|
659075b
fix half-comment
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/659075b1921157dbae722bc124ff1f68ad78ccfd |
|
5ad26bc
add a few more unary operator tests for slicing
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/5ad26bcee9c385f979af590dfac772929f560628 |
|
17656b9
tweak test names, ellipsis test
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/17656b9af0d72f3c07d7d0ca317d6e5280f8f3b3 |
|
ca86bd3
test cleanups
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/ca86bd37f5ebf4ffb328d96c5f5e49c4fc7bc396 |
|
a506a8c
test unary ops inside function args
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/a506a8cd1ef869a4247b0868a6992559be4d9270 |
|
c3ce7b9
test a few edge cases
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/c3ce7b99eb76a4c3a72ab1154ac840b70d3e18cb |
|
b956846
test against PEP448 unpacking, cleanup testing helpers, naming tweaks
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/b95684682194f649bb5d0022a4b2766521aaecdc |
|
e5989df
remove stray comment
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/e5989df1627109ebf010d09418cb3a91ab884666 |
|
ab1798d
simplify checking token kinds
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/ab1798d5d5b66c16012377bdf1f84f0ecbe9f589 |
|
770aa4e
catch bad trigger character for OnTypeFormatting call
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/770aa4e95010ad1ccf37bd9347912b7e864aa811 |
|
b19ad65
instead of reading one extra line arbitrarily, tokenize ahead to the …
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/b19ad655676fcb3dd5654ce7b186659e88122465 |
|
eab9e6a
more consistent ArgumentNullException usage
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/eab9e6a32b6c70e7d0df190f42843a73ec75a4ef |
|
65842a2
remove async stuff from test cases
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/65842a28e30058377bf7bc7a026a1c1028ee7c1b |
|
a9f82ba
remove _reader member, document LineFormatter class/constructor
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/a9f82ba6d5758d702f635d860b4be4132b648529 |
|
a9d219b
documentation fixes
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/a9d219b7cfc38e2097a9dbb22be774d86930ec41 |
|
9027d4b
check lines first, as most tokens won't span multiple lines
jakebailey Sep 18, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/9027d4b345931e5aac427401143f48c740d94097 |
|
5c00a04
fix multiline string assignment and function defaults/named args
jakebailey Sep 19, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/5c00a04184a899d901283dfdee89588fe3ccbc7d |
|
6630e87
simplify multiline string logic
jakebailey Sep 19, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/6630e87ced3f152cc71fc88529076e79505a4b47 |
|
1fab534
directly test line continuations, fix commas inside brackets
jakebailey Sep 19, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/1fab534219651e138b86594669baf284a734629c |
|
cae62a5
a few code analyzer fixes
jakebailey Sep 19, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/cae62a5f84d83af5b8ae23b14d14276974320c12 |
|
54556e3
simplify multiline string logic
jakebailey Sep 20, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/54556e3b20a3f6792c6e36df03357010b9e0227e |
|
0892c5b
re-add soft space after multiline string
jakebailey Sep 20, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/0892c5b4aa3406f3e93bb612c58105d3c9d31cb3 |
|
73c6ff9
remove exception for unknown tokens, handle older python 2 features (…
jakebailey Sep 20, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/73c6ff9c9347ba12908795d834ffa0bc37b81399 |
|
3c6a024
shuffle token get, fix AddToken typo
jakebailey Sep 20, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/3c6a0245b9bb21de385321227a6a09e3066e8ab9 |
|
e182904
explain non-comprehensive language server formatting tests
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/e1829041949f5225937e5897a73a8d133cabc9a9 |
|
37d1348
add context, dispose of server
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/37d1348a12ea9715a48f78ff6e103afb85c5d9d4 |
|
ee32c09
accessor formatting
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/ee32c09851ea9aa458145ba270fcacb757464d88 |
|
edaca3f
use Check class
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/edaca3f2ad9c417df2536044591125b4d8e182c9 |
|
4df670f
fix failing test
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/4df670f0313d7d122dba08ef31fdc66acb5ffb09 |
|
2e604ae
use DataRow/DataTestMethod style tests to show results for each
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/2e604ae7486b6bdbe8696603f2a930e5f8c95330 |
|
4177069
fix missing DataTestMethod
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/4177069fe3cb6bbe72bc722ae8ce01e3682dbf2f |
|
d2a6423
add a single string of whitespace instead of many single spaces
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/d2a6423af97d094441d22f6e02aa058a9b3f4960 |
|
96f3652
remove string specialization
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/96f3652113890135aa9afebbd26b6f860c36f1ff |
|
87d3392
move filtering into TokenizeLine
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/87d339240b9a3c8f576a430544c04ee3ce647f83 |
|
94c18a0
simplify grammar file unchanged line checks
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/94c18a0ee0dbef00cdb3d29c78bacb579a2315a7 |
|
f1cec62
remove test helpers, use server extension
jakebailey Sep 24, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/f1cec620ee8084692477c885e53ad033030a59cb |
|
874a620
remove TextBuilder in favor of StringBuilder extension
jakebailey Sep 25, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/874a620e1f3dda9ef3bf6b2309a6509a4d432180 |
|
699b130
Merge remote-tracking branch 'upstream/master' into on-type-formatting
jakebailey Sep 25, 2018
| https://github.com/microsoft/python-language-server/pull/126/commits/699b1305c318f58b348acc30fb52eb9aa72089e4 |
|
Clear filters
| https://github.com/microsoft/python-language-server/pull/126/files |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
|
StringBuilderExtensions.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-7a1fb2cf4252d94a6e99133c9dd5eaa755ac1d502b63beeda8c2bdb072138b1d |
|
LanguageServerTests.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-28ade1f8acb753fc60e7a11c41e7c9e7bc736d9985e0666ffa72925cb5552bdd |
|
LineFormatterTests.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-5b6c3f3556c58a6f49ade4a00e3d5cc280becbe585b5e094aed76905d528c2a4 |
|
ServerExtensions.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-16858bae94e72b08d2d41161130f9389593e95a3f10241b15ba1597c99a41ecf |
|
LineFormatter.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-e040affd5dcb35abea2f48e81f60d09ed9f32e4a9e890db23a3fb66ef45da53a |
|
Server.OnTypeFormatting.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-7334a49c7855f952068ff209a7b59600dc667830cb2c474a61fee6310ed3be8f |
|
Server.cs
| https://github.com/microsoft/python-language-server/pull/126/files#diff-61776581664148d97359dd5bfaf6a4c58902b516e1ae0efb3921a5804bc853b5 |
|
pythonGrammar.py
| https://github.com/microsoft/python-language-server/pull/126/files#diff-31fa460d7ae74112cf3a9c8f9ba511fea300fd98000bff18fa8347cc0fdaea1c |
| src/Analysis/Engine/Impl/Infrastructure/Extensions/StringBuilderExtensions.cs | https://github.com/microsoft/python-language-server/pull/126/files#diff-7a1fb2cf4252d94a6e99133c9dd5eaa755ac1d502b63beeda8c2bdb072138b1d |
|
View file
| https://github.com/jakebailey/python-language-server/blob/699b1305c318f58b348acc30fb52eb9aa72089e4/src/Analysis/Engine/Impl/Infrastructure/Extensions/StringBuilderExtensions.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/python-language-server/pull/126/{{ revealButtonHref }} |
|
| https://github.com/microsoft/python-language-server/pull/126/files#diff-7a1fb2cf4252d94a6e99133c9dd5eaa755ac1d502b63beeda8c2bdb072138b1d |
| src/Analysis/Engine/Test/LanguageServerTests.cs | https://github.com/microsoft/python-language-server/pull/126/files#diff-28ade1f8acb753fc60e7a11c41e7c9e7bc736d9985e0666ffa72925cb5552bdd |
|
View file
| https://github.com/jakebailey/python-language-server/blob/699b1305c318f58b348acc30fb52eb9aa72089e4/src/Analysis/Engine/Test/LanguageServerTests.cs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/python-language-server/pull/126/{{ revealButtonHref }} |
|
| https://github.com/microsoft/python-language-server/pull/126/files#diff-28ade1f8acb753fc60e7a11c41e7c9e7bc736d9985e0666ffa72925cb5552bdd |
| Mikhail Arkhipov (MikhailArkhipov) | https://github.com/MikhailArkhipov |
| Sep 24, 2018 | https://github.com/microsoft/python-language-server/pull/126/files#r219962368 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
| Sep 24, 2018 | https://github.com/microsoft/python-language-server/pull/126/files#r220010203 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
|
| https://github.com/microsoft/python-language-server/pull/126/files#diff-28ade1f8acb753fc60e7a11c41e7c9e7bc736d9985e0666ffa72925cb5552bdd |
| Please reload this page | https://github.com/microsoft/python-language-server/pull/126/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |