René's URL Explorer Experiment


Title: On type formatting by jakebailey · Pull Request #126 · microsoft/python-language-server · GitHub

Open Graph Title: On type formatting by jakebailey · Pull Request #126 · microsoft/python-language-server

X Title: On type formatting by jakebailey · Pull Request #126 · microsoft/python-language-server

Description: Microsoft Language Server for Python. Contribute to microsoft/python-language-server development by creating an account on GitHub.

Open Graph Description: This PR implements line formatting via on-type formatting, triggering on newline and semicolon. It only tokenizes the code to be formatted, and does not require parsing. This covers all of the exis...

X Description: This PR implements line formatting via on-type formatting, triggering on newline and semicolon. It only tokenizes the code to be formatted, and does not require parsing. This covers all of the exis...

Opengraph URL: https://github.com/microsoft/python-language-server/pull/126

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b31bfaa1-eb69-821c-8198-1706b91b47be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5FA:22BB81:6E85A5:90961C:6AFE6F66
html-safe-nonceaf0041c1b679cf2d0d77f7b8f2baf88e43b16b553bf632507de794673c2065a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUZBOjIyQkI4MTo2RTg1QTU6OTA5NjFDOjZBRkU2RjY2IiwidmlzaXRvcl9pZCI6IjM5MDU2NDMwNjgwNTY4MjU3MDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac481f9b62dea1a815aeeadd93e9e23a827f0e0be7ceed889ac87c376a49e76404
hovercard-subject-tagpull_request:217760468
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/python-language-server/126/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b301f2769b24ebb320d991d14112391bba7e54ebfd5fc9ff545d8fb95c843fad/microsoft/python-language-server/pull/126
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b301f2769b24ebb320d991d14112391bba7e54ebfd5fc9ff545d8fb95c843fad/microsoft/python-language-server/pull/126
og:image:altThis PR implements line formatting via on-type formatting, triggering on newline and semicolon. It only tokenizes the code to be formatted, and does not require parsing. This covers all of the exis...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/pull/126#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F126
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F126
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/pull/126
Reloadhttps://github.com/microsoft/python-language-server/pull/126
Reloadhttps://github.com/microsoft/python-language-server/pull/126
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
https://github.com/microsoft/python-language-server
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
jakebailey:on-type-formattinghttps://github.com/jakebailey/python-language-server/tree/on-type-formatting
Conversationhttps://github.com/microsoft/python-language-server/pull/126
Commits45 (45)https://github.com/microsoft/python-language-server/pull/126/commits
Checkshttps://github.com/microsoft/python-language-server/pull/126/checks
Files changedhttps://github.com/microsoft/python-language-server/pull/126/files
On type formattinghttps://github.com/microsoft/python-language-server/pull/126#top
Jake Bailey (jakebailey)https://github.com/jakebailey
microsoft:masterhttps://github.com/microsoft/python-language-server/tree/master
jakebailey:on-type-formattinghttps://github.com/jakebailey/python-language-server/tree/on-type-formatting
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Sep 24, 2018https://github.com/microsoft/python-language-server/pull/126#issue-363284974
microsoft/vscode-python#1799https://github.com/microsoft/vscode-python/issues/1799
microsoft/vscode-python#1784https://github.com/microsoft/vscode-python/issues/1784
microsoft/vscode-python#1792https://github.com/microsoft/vscode-python/issues/1792
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
Jake Bailey (jakebailey)https://github.com/jakebailey
September 24, 2018 11:06https://github.com/microsoft/python-language-server/pull/126#commits-pushed-4f3434b
https://github.com/jakebailey
Working line formatter based on VS Code implementation, without testshttps://github.com/microsoft/python-language-server/pull/126/commits/4f3434bdf7bc96b28f9fd5c6be79543b05a80c9e
4f3434bhttps://github.com/microsoft/python-language-server/pull/126/commits/4f3434bdf7bc96b28f9fd5c6be79543b05a80c9e
https://github.com/jakebailey
fix namespace change, rename filehttps://github.com/microsoft/python-language-server/pull/126/commits/c52b83d055753b0a7753f70d6ed2b2c5767a9539
c52b83dhttps://github.com/microsoft/python-language-server/pull/126/commits/c52b83d055753b0a7753f70d6ed2b2c5767a9539
https://github.com/jakebailey
move LineFormatter, add basic OnTypeFormatting tests, add LineFormatt…https://github.com/microsoft/python-language-server/pull/126/commits/d8d1a7429f7058c8e038371f4b49d32cdcf3dc4f
d8d1a74https://github.com/microsoft/python-language-server/pull/126/commits/d8d1a7429f7058c8e038371f4b49d32cdcf3dc4f
https://github.com/jakebailey
mostly complete line formatterhttps://github.com/microsoft/python-language-server/pull/126/commits/410b13f1edabdf20b5f8bd36db599149be73b123
410b13fhttps://github.com/microsoft/python-language-server/pull/126/commits/410b13f1edabdf20b5f8bd36db599149be73b123
https://github.com/jakebailey
rewrite formatter from scratch, fully passes existing tests with slig…https://github.com/microsoft/python-language-server/pull/126/commits/1a4c2dbcd1615875406d531bb1ad8d89490218a8
1a4c2dbhttps://github.com/microsoft/python-language-server/pull/126/commits/1a4c2dbcd1615875406d531bb1ad8d89490218a8
https://github.com/jakebailey
cleanup argument/lambda inside logic, remove leftover debugging state…https://github.com/microsoft/python-language-server/pull/126/commits/cdbc45a9852562e480d7a2056862a6b6b72eaaa9
cdbc45ahttps://github.com/microsoft/python-language-server/pull/126/commits/cdbc45a9852562e480d7a2056862a6b6b72eaaa9
https://github.com/jakebailey
fix various formatting issues from vscode-pythonhttps://github.com/microsoft/python-language-server/pull/126/commits/32bae79cc7b1f7d33dab62a1485f0970ebedba8d
32bae79https://github.com/microsoft/python-language-server/pull/126/commits/32bae79cc7b1f7d33dab62a1485f0970ebedba8d
https://github.com/jakebailey
fix half-commenthttps://github.com/microsoft/python-language-server/pull/126/commits/659075b1921157dbae722bc124ff1f68ad78ccfd
659075bhttps://github.com/microsoft/python-language-server/pull/126/commits/659075b1921157dbae722bc124ff1f68ad78ccfd
https://github.com/jakebailey
add a few more unary operator tests for slicinghttps://github.com/microsoft/python-language-server/pull/126/commits/5ad26bcee9c385f979af590dfac772929f560628
5ad26bchttps://github.com/microsoft/python-language-server/pull/126/commits/5ad26bcee9c385f979af590dfac772929f560628
https://github.com/jakebailey
tweak test names, ellipsis testhttps://github.com/microsoft/python-language-server/pull/126/commits/17656b9af0d72f3c07d7d0ca317d6e5280f8f3b3
17656b9https://github.com/microsoft/python-language-server/pull/126/commits/17656b9af0d72f3c07d7d0ca317d6e5280f8f3b3
https://github.com/jakebailey
test cleanupshttps://github.com/microsoft/python-language-server/pull/126/commits/ca86bd37f5ebf4ffb328d96c5f5e49c4fc7bc396
ca86bd3https://github.com/microsoft/python-language-server/pull/126/commits/ca86bd37f5ebf4ffb328d96c5f5e49c4fc7bc396
https://github.com/jakebailey
test unary ops inside function argshttps://github.com/microsoft/python-language-server/pull/126/commits/a506a8cd1ef869a4247b0868a6992559be4d9270
a506a8chttps://github.com/microsoft/python-language-server/pull/126/commits/a506a8cd1ef869a4247b0868a6992559be4d9270
https://github.com/jakebailey
test a few edge caseshttps://github.com/microsoft/python-language-server/pull/126/commits/c3ce7b99eb76a4c3a72ab1154ac840b70d3e18cb
c3ce7b9https://github.com/microsoft/python-language-server/pull/126/commits/c3ce7b99eb76a4c3a72ab1154ac840b70d3e18cb
https://github.com/jakebailey
test against PEP448 unpacking, cleanup testing helpers, naming tweakshttps://github.com/microsoft/python-language-server/pull/126/commits/b95684682194f649bb5d0022a4b2766521aaecdc
b956846https://github.com/microsoft/python-language-server/pull/126/commits/b95684682194f649bb5d0022a4b2766521aaecdc
https://github.com/jakebailey
remove stray commenthttps://github.com/microsoft/python-language-server/pull/126/commits/e5989df1627109ebf010d09418cb3a91ab884666
e5989dfhttps://github.com/microsoft/python-language-server/pull/126/commits/e5989df1627109ebf010d09418cb3a91ab884666
https://github.com/jakebailey
simplify checking token kindshttps://github.com/microsoft/python-language-server/pull/126/commits/ab1798d5d5b66c16012377bdf1f84f0ecbe9f589
ab1798dhttps://github.com/microsoft/python-language-server/pull/126/commits/ab1798d5d5b66c16012377bdf1f84f0ecbe9f589
https://github.com/jakebailey
catch bad trigger character for OnTypeFormatting callhttps://github.com/microsoft/python-language-server/pull/126/commits/770aa4e95010ad1ccf37bd9347912b7e864aa811
770aa4ehttps://github.com/microsoft/python-language-server/pull/126/commits/770aa4e95010ad1ccf37bd9347912b7e864aa811
https://github.com/jakebailey
instead of reading one extra line arbitrarily, tokenize ahead to the …https://github.com/microsoft/python-language-server/pull/126/commits/b19ad655676fcb3dd5654ce7b186659e88122465
b19ad65https://github.com/microsoft/python-language-server/pull/126/commits/b19ad655676fcb3dd5654ce7b186659e88122465
https://github.com/jakebailey
more consistent ArgumentNullException usagehttps://github.com/microsoft/python-language-server/pull/126/commits/eab9e6a32b6c70e7d0df190f42843a73ec75a4ef
eab9e6ahttps://github.com/microsoft/python-language-server/pull/126/commits/eab9e6a32b6c70e7d0df190f42843a73ec75a4ef
https://github.com/jakebailey
remove async stuff from test caseshttps://github.com/microsoft/python-language-server/pull/126/commits/65842a28e30058377bf7bc7a026a1c1028ee7c1b
65842a2https://github.com/microsoft/python-language-server/pull/126/commits/65842a28e30058377bf7bc7a026a1c1028ee7c1b
https://github.com/jakebailey
remove _reader member, document LineFormatter class/constructorhttps://github.com/microsoft/python-language-server/pull/126/commits/a9f82ba6d5758d702f635d860b4be4132b648529
a9f82bahttps://github.com/microsoft/python-language-server/pull/126/commits/a9f82ba6d5758d702f635d860b4be4132b648529
https://github.com/jakebailey
documentation fixeshttps://github.com/microsoft/python-language-server/pull/126/commits/a9d219b7cfc38e2097a9dbb22be774d86930ec41
a9d219bhttps://github.com/microsoft/python-language-server/pull/126/commits/a9d219b7cfc38e2097a9dbb22be774d86930ec41
https://github.com/jakebailey
check lines first, as most tokens won't span multiple lineshttps://github.com/microsoft/python-language-server/pull/126/commits/9027d4b345931e5aac427401143f48c740d94097
9027d4bhttps://github.com/microsoft/python-language-server/pull/126/commits/9027d4b345931e5aac427401143f48c740d94097
https://github.com/jakebailey
fix multiline string assignment and function defaults/named argshttps://github.com/microsoft/python-language-server/pull/126/commits/5c00a04184a899d901283dfdee89588fe3ccbc7d
5c00a04https://github.com/microsoft/python-language-server/pull/126/commits/5c00a04184a899d901283dfdee89588fe3ccbc7d
https://github.com/jakebailey
simplify multiline string logichttps://github.com/microsoft/python-language-server/pull/126/commits/6630e87ced3f152cc71fc88529076e79505a4b47
6630e87https://github.com/microsoft/python-language-server/pull/126/commits/6630e87ced3f152cc71fc88529076e79505a4b47
https://github.com/jakebailey
directly test line continuations, fix commas inside bracketshttps://github.com/microsoft/python-language-server/pull/126/commits/1fab534219651e138b86594669baf284a734629c
1fab534https://github.com/microsoft/python-language-server/pull/126/commits/1fab534219651e138b86594669baf284a734629c
https://github.com/jakebailey
a few code analyzer fixeshttps://github.com/microsoft/python-language-server/pull/126/commits/cae62a5f84d83af5b8ae23b14d14276974320c12
cae62a5https://github.com/microsoft/python-language-server/pull/126/commits/cae62a5f84d83af5b8ae23b14d14276974320c12
https://github.com/jakebailey
simplify multiline string logichttps://github.com/microsoft/python-language-server/pull/126/commits/54556e3b20a3f6792c6e36df03357010b9e0227e
54556e3https://github.com/microsoft/python-language-server/pull/126/commits/54556e3b20a3f6792c6e36df03357010b9e0227e
https://github.com/jakebailey
re-add soft space after multiline stringhttps://github.com/microsoft/python-language-server/pull/126/commits/0892c5b4aa3406f3e93bb612c58105d3c9d31cb3
0892c5bhttps://github.com/microsoft/python-language-server/pull/126/commits/0892c5b4aa3406f3e93bb612c58105d3c9d31cb3
https://github.com/jakebailey
remove exception for unknown tokens, handle older python 2 features (…https://github.com/microsoft/python-language-server/pull/126/commits/73c6ff9c9347ba12908795d834ffa0bc37b81399
73c6ff9https://github.com/microsoft/python-language-server/pull/126/commits/73c6ff9c9347ba12908795d834ffa0bc37b81399
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158267416
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9
src/LanguageServer/Impl/Implementation/LineFormatter.cshttps://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9#diff-e040affd5dcb35abea2f48e81f60d09ed9f32e4a9e890db23a3fb66ef45da53a
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158270426
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9
src/LanguageServer/Impl/Implementation/LineFormatter.cshttps://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9#diff-e040affd5dcb35abea2f48e81f60d09ed9f32e4a9e890db23a3fb66ef45da53a
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158270903
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9
src/LanguageServer/Impl/Implementation/LineFormatter.cshttps://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9#diff-e040affd5dcb35abea2f48e81f60d09ed9f32e4a9e890db23a3fb66ef45da53a
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158273070
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9
src/Analysis/Engine/Test/LineFormatterTests.cshttps://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9#diff-5b6c3f3556c58a6f49ade4a00e3d5cc280becbe585b5e094aed76905d528c2a4
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158273888
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9
src/Analysis/Engine/Test/LineFormatterTests.cshttps://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9#diff-5b6c3f3556c58a6f49ade4a00e3d5cc280becbe585b5e094aed76905d528c2a4
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158274761
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9
src/Analysis/Engine/Test/LineFormatterTests.cshttps://github.com/microsoft/python-language-server/pull/126/files/e1829041949f5225937e5897a73a8d133cabc9a9#diff-5b6c3f3556c58a6f49ade4a00e3d5cc280becbe585b5e094aed76905d528c2a4
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
Jake Bailey (jakebailey)https://github.com/jakebailey
September 24, 2018 13:17https://github.com/microsoft/python-language-server/pull/126#commits-pushed-37d1348
https://github.com/jakebailey
add context, dispose of serverhttps://github.com/microsoft/python-language-server/pull/126/commits/37d1348a12ea9715a48f78ff6e103afb85c5d9d4
37d1348https://github.com/microsoft/python-language-server/pull/126/commits/37d1348a12ea9715a48f78ff6e103afb85c5d9d4
https://github.com/jakebailey
accessor formattinghttps://github.com/microsoft/python-language-server/pull/126/commits/ee32c09851ea9aa458145ba270fcacb757464d88
ee32c09https://github.com/microsoft/python-language-server/pull/126/commits/ee32c09851ea9aa458145ba270fcacb757464d88
https://github.com/jakebailey
use Check classhttps://github.com/microsoft/python-language-server/pull/126/commits/edaca3f2ad9c417df2536044591125b4d8e182c9
edaca3fhttps://github.com/microsoft/python-language-server/pull/126/commits/edaca3f2ad9c417df2536044591125b4d8e182c9
https://github.com/jakebailey
fix failing testhttps://github.com/microsoft/python-language-server/pull/126/commits/4df670f0313d7d122dba08ef31fdc66acb5ffb09
4df670fhttps://github.com/microsoft/python-language-server/pull/126/commits/4df670f0313d7d122dba08ef31fdc66acb5ffb09
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158287492
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/4df670f0313d7d122dba08ef31fdc66acb5ffb09
src/LanguageServer/Impl/Implementation/LineFormatter.cshttps://github.com/microsoft/python-language-server/pull/126/files/4df670f0313d7d122dba08ef31fdc66acb5ffb09#diff-e040affd5dcb35abea2f48e81f60d09ed9f32e4a9e890db23a3fb66ef45da53a
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 24, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158296582
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/4df670f0313d7d122dba08ef31fdc66acb5ffb09
src/Analysis/Engine/Test/LineFormatterTests.cshttps://github.com/microsoft/python-language-server/pull/126/files/4df670f0313d7d122dba08ef31fdc66acb5ffb09#diff-5b6c3f3556c58a6f49ade4a00e3d5cc280becbe585b5e094aed76905d528c2a4
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
Jake Bailey (jakebailey)https://github.com/jakebailey
September 24, 2018 14:35https://github.com/microsoft/python-language-server/pull/126#commits-pushed-2e604ae
https://github.com/jakebailey
use DataRow/DataTestMethod style tests to show results for eachhttps://github.com/microsoft/python-language-server/pull/126/commits/2e604ae7486b6bdbe8696603f2a930e5f8c95330
2e604aehttps://github.com/microsoft/python-language-server/pull/126/commits/2e604ae7486b6bdbe8696603f2a930e5f8c95330
https://github.com/jakebailey
fix missing DataTestMethodhttps://github.com/microsoft/python-language-server/pull/126/commits/4177069fe3cb6bbe72bc722ae8ce01e3682dbf2f
4177069https://github.com/microsoft/python-language-server/pull/126/commits/4177069fe3cb6bbe72bc722ae8ce01e3682dbf2f
https://github.com/jakebailey
add a single string of whitespace instead of many single spaceshttps://github.com/microsoft/python-language-server/pull/126/commits/d2a6423af97d094441d22f6e02aa058a9b3f4960
d2a6423https://github.com/microsoft/python-language-server/pull/126/commits/d2a6423af97d094441d22f6e02aa058a9b3f4960
https://github.com/jakebailey
remove string specializationhttps://github.com/microsoft/python-language-server/pull/126/commits/96f3652113890135aa9afebbd26b6f860c36f1ff
96f3652https://github.com/microsoft/python-language-server/pull/126/commits/96f3652113890135aa9afebbd26b6f860c36f1ff
https://github.com/jakebailey
move filtering into TokenizeLinehttps://github.com/microsoft/python-language-server/pull/126/commits/87d339240b9a3c8f576a430544c04ee3ce647f83
87d3392https://github.com/microsoft/python-language-server/pull/126/commits/87d339240b9a3c8f576a430544c04ee3ce647f83
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
Sep 24, 2018https://github.com/microsoft/python-language-server/pull/126#issuecomment-424139877
Alexander Sher (@AlexanderSher)https://github.com/AlexanderSher
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
Jake Bailey (jakebailey)https://github.com/jakebailey
September 24, 2018 15:33https://github.com/microsoft/python-language-server/pull/126#commits-pushed-94c18a0
https://github.com/jakebailey
simplify grammar file unchanged line checkshttps://github.com/microsoft/python-language-server/pull/126/commits/94c18a0ee0dbef00cdb3d29c78bacb579a2315a7
94c18a0https://github.com/microsoft/python-language-server/pull/126/commits/94c18a0ee0dbef00cdb3d29c78bacb579a2315a7
https://github.com/jakebailey
remove test helpers, use server extensionhttps://github.com/microsoft/python-language-server/pull/126/commits/f1cec620ee8084692477c885e53ad033030a59cb
f1cec62https://github.com/microsoft/python-language-server/pull/126/commits/f1cec620ee8084692477c885e53ad033030a59cb
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 25, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158534617
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb
src/Analysis/Engine/Impl/Infrastructure/TextBuilder.cshttps://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb#diff-e084f01bd2e126f28971ebb42e5e092669d3700d42157353bc617beea8f78bb5
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 25, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158535220
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb
src/Analysis/Engine/Impl/Infrastructure/TextBuilder.cshttps://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb#diff-e084f01bd2e126f28971ebb42e5e092669d3700d42157353bc617beea8f78bb5
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 25, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158536192
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb
src/Analysis/Engine/Test/LanguageServerTests.cshttps://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb#diff-28ade1f8acb753fc60e7a11c41e7c9e7bc736d9985e0666ffa72925cb5552bdd
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
Jake Bailey (jakebailey)https://github.com/jakebailey
September 25, 2018 10:21https://github.com/microsoft/python-language-server/pull/126#commits-pushed-874a620
https://github.com/jakebailey
remove TextBuilder in favor of StringBuilder extensionhttps://github.com/microsoft/python-language-server/pull/126/commits/874a620e1f3dda9ef3bf6b2309a6509a4d432180
874a620https://github.com/microsoft/python-language-server/pull/126/commits/874a620e1f3dda9ef3bf6b2309a6509a4d432180
https://github.com/jakebailey
Merge remote-tracking branch 'upstream/master' into on-type-formattinghttps://github.com/microsoft/python-language-server/pull/126/commits/699b1305c318f58b348acc30fb52eb9aa72089e4
699b130https://github.com/microsoft/python-language-server/pull/126/commits/699b1305c318f58b348acc30fb52eb9aa72089e4
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher)https://github.com/AlexanderSher
Sep 25, 2018 https://github.com/microsoft/python-language-server/pull/126#pullrequestreview-158744750
View reviewed changes https://github.com/microsoft/python-language-server/pull/126/files/699b1305c318f58b348acc30fb52eb9aa72089e4
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
7c9de6chttps://github.com/microsoft/python-language-server/commit/7c9de6c79f9a2d275a851c163324121f60ad45ac
Sep 25, 2018https://github.com/microsoft/python-language-server/pull/126#event-1866891868
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Sep 25, 2018 https://github.com/microsoft/python-language-server/pull/126#ref-issue-356064076
Implement format on type #5 https://github.com/microsoft/python-language-server/issues/5
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
February 14, 2019 20:12https://github.com/microsoft/python-language-server/pull/126#event-2140749726
Jake Bailey (jakebailey)https://github.com/jakebailey
Nov 1, 2019 https://github.com/microsoft/python-language-server/pull/126#ref-commit-d6b8a0d
https://github.com/jakebailey
On type formatting (https://github.com/jakebailey/python-language-server/commit/d6b8a0d74fd1f46a8df2b3cc78dc4bb7b2729e61
microsoft#126https://github.com/microsoft/python-language-server/pull/126
)https://github.com/jakebailey/python-language-server/commit/d6b8a0d74fd1f46a8df2b3cc78dc4bb7b2729e61
d6b8a0dhttps://github.com/jakebailey/python-language-server/commit/d6b8a0d74fd1f46a8df2b3cc78dc4bb7b2729e61
https://github.co/hiddenchars
https://github.com/microsoft/python-language-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fpull%2F126
https://github.com/MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) https://github.com/MikhailArkhipov
https://github.com/microsoft/python-language-server/pull/126/files/f1cec620ee8084692477c885e53ad033030a59cb
https://github.com/AlexanderSher
Alexander Sher (AlexanderSher) https://github.com/AlexanderSher
https://github.com/microsoft/python-language-server/pull/126/files/699b1305c318f58b348acc30fb52eb9aa72089e4
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
Please reload this pagehttps://github.com/microsoft/python-language-server/pull/126
https://github.com/jakebailey
https://github.com/MikhailArkhipov
https://github.com/AlexanderSher
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.