René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PLS does not resolve base class expressions in correct scope","articleBody":"Consider the following Python code:\r\n\r\n```\r\nclass ContainerClass():\r\n    class BaseClass(object):\r\n        def __init__(self, name):\r\n            self.name = name\r\n\r\n    class SubClass(BaseClass):\r\n        def __init__(self): \r\n            super().__init__('')\r\n```\r\n\r\nThe PLS analyzer logic incorrectly reports that `BaseClass` is referenced before being defined. In looking at the PLS code, `AnalysisUnit.AnalyzeWorker` is calling `EvaluateBaseClass` from within the scope of the subclass rather than its outer (containing) class.\r\n\r\nI think this can be fixed by modifying `AnalysisUnit.AnalyzeWorker` to temporarily set the scope of the ddg to the outer scope before calling `EvaluateBaseClass`. Something like this:\r\n```\r\n// Evaluate base classes in the outer scope.\r\nif (_outerUnit.Scope is InterpreterScope) {\r\n    ddg.Scope = _outerUnit.Scope as InterpreterScope;\r\n}\r\nbases.Add(EvaluateBaseClass(ddg, classInfo, i, baseClassArg.Expression));\r\nddg.Scope = InterpreterScope;\r\n```\r\n","author":{"url":"https://github.com/erictraut","@type":"Person","name":"erictraut"},"datePublished":"2018-12-26T00:54:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/508/python-language-server/issues/508"}