René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Catch/ignore/handle exceptions from FileSystemGlobbing","articleBody":"There seem to be quite a few of exceptions coming out of `FileSystemGlobbing`, which is only used inside of `LoadDirectoryFiles`. Most frequent is an `UnauthorizedAccessException`:\r\n\r\n```\r\n at System.IO.Enumeration.FileSystemEnumerator`1.CreateDirectoryHandle(String path, Boolean ignoreNotFound)\r\n at System.IO.Enumeration.FileSystemEnumerator`1..ctor(String directory, EnumerationOptions options)\r\n at System.IO.Enumeration.FileSystemEnumerable`1..ctor(String directory, FindTransform transform, EnumerationOptions options)\r\n at System.IO.Enumeration.FileSystemEnumerableFactory.FileSystemInfos(String directory, String expression, EnumerationOptions options)\r\n at System.IO.DirectoryInfo.InternalEnumerateInfos(String path, String searchPattern, SearchTarget searchTarget, EnumerationOptions options)\r\n at Microsoft.Extensions.FileSystemGlobbing.Abstractions.DirectoryInfoWrapper.EnumerateFileSystemInfos()+MoveNext()\r\n at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)\r\n at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)\r\n at Microsoft.Extensions.FileSystemGlobbing.Internal.MatcherContext.Match(DirectoryInfoBase directory, S\r\n```\r\n\r\nBut we also see `DirectoryNotFoundException`, `IOException`, `PathTooLongException`, and `FileNotFoundException`.\r\n\r\nRight now, these exceptions during `workspace/didChangeConfiguration` go unhandled, produce an error message for the user via RPC, and record the exception.\r\n\r\nLooking at the call site:\r\n\r\n```csharp\r\nif (!_filesLoaded) {\r\n    await LoadDirectoryFiles();\r\n}\r\n_filesLoaded = true;\r\n```\r\n\r\nIt may be better idea to do something on the order of:\r\n\r\n```csharp\r\nif (!_filesLoaded) {\r\n    try {\r\n        await LoadDirectoryFiles();\r\n        _filesLoaded = true;\r\n    } catch (Exception ex) when (!ex.IsCriticalException()) {\r\n        // Log something to the user\r\n    }\r\n}\r\n```\r\n\r\nThat way, we don't record events that are really just errors in the user's configuration and also give feedback as to what's wrong.","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2018-12-06T19:25:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/463/python-language-server/issues/463"}