Title: nullref in SpecializedNamespace.get_Overloads · Issue #449 · microsoft/python-language-server · GitHub
Open Graph Title: nullref in SpecializedNamespace.get_Overloads · Issue #449 · microsoft/python-language-server
X Title: nullref in SpecializedNamespace.get_Overloads · Issue #449 · microsoft/python-language-server
Description: Seeing this one pop up. It looks like the checks on _original being null are not consistent in this file. Also, the statements ending in ?.MaybeEnumerate() are likely not needed either. ripgrepping shows: $ rg '\?\.MaybeEnumerate' src\An...
Open Graph Description: Seeing this one pop up. It looks like the checks on _original being null are not consistent in this file. Also, the statements ending in ?.MaybeEnumerate() are likely not needed either. ripgrepping...
X Description: Seeing this one pop up. It looks like the checks on _original being null are not consistent in this file. Also, the statements ending in ?.MaybeEnumerate() are likely not needed either. ripgrepping...
Opengraph URL: https://github.com/microsoft/python-language-server/issues/449
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"nullref in SpecializedNamespace.get_Overloads","articleBody":"Seeing this one pop up. It looks like the checks on `_original` being null are not consistent in this file.\r\n\r\nAlso, the statements ending in `?.MaybeEnumerate()` are likely not needed either. ripgrepping shows:\r\n\r\n```\r\n$ rg '\\?\\.MaybeEnumerate'\r\nsrc\\Analysis\\Engine\\Impl\\ModuleAnalysis.cs\r\n356: if (v.Variable?.Types?.MaybeEnumerate().FirstOrDefault() is ParameterInfo) {\r\n\r\nsrc\\Analysis\\Engine\\Impl\\Values\\SpecializedNamespace.cs\r\n212: public override IEnumerable\u003cILocationInfo\u003e Locations =\u003e _original?.Locations?.MaybeEnumerate();\r\n220: internal override IEnumerable\u003cILocationInfo\u003e References =\u003e _original.References?.MaybeEnumerate();\r\n```\r\n\r\nI have a fix ready, just making this for tracking.","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2018-12-03T20:37:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/449/python-language-server/issues/449"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8a58d0f9-56e5-a421-2c5b-68ac80ffc8f5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DB70:3F4811:E8509C:154048B:6A4E3163 |
| html-safe-nonce | 2a3fdd187b6f09511b56cdabe9d81f1a2d8e06df75437972334e54b9ae00c285 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjcwOjNGNDgxMTpFODUwOUM6MTU0MDQ4Qjo2QTRFMzE2MyIsInZpc2l0b3JfaWQiOiI4MjQ2NDkxMzY1MDY5Njk3Mzc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c475e397d5b9e5214ae1d29e197ab3b01b2c540585d751fcc873a7cc333a7262 |
| hovercard-subject-tag | issue:386994636 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/python-language-server/449/issue_layout |
| twitter:image | https://opengraph.githubassets.com/13dfde5eeaa2dd7d8cda4312f72f0e3f81fca2785731e3e913f483abaf40ede3/microsoft/python-language-server/issues/449 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/13dfde5eeaa2dd7d8cda4312f72f0e3f81fca2785731e3e913f483abaf40ede3/microsoft/python-language-server/issues/449 |
| og:image:alt | Seeing this one pop up. It looks like the checks on _original being null are not consistent in this file. Also, the statements ending in ?.MaybeEnumerate() are likely not needed either. ripgrepping... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakebailey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 42a6d378d7587a44c93aca255096cd66b7c8eb2d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width