Title: Server remains open for requests after unhandled "noncritical" exceptions · Issue #448 · microsoft/python-language-server · GitHub
Open Graph Title: Server remains open for requests after unhandled "noncritical" exceptions · Issue #448 · microsoft/python-language-server
X Title: Server remains open for requests after unhandled "noncritical" exceptions · Issue #448 · microsoft/python-language-server
Description: https://github.com/Microsoft/python-language-server/blob/4a00ee80cb2d7b3e736329e82b2ed441ae70b5ca/src/Analysis/Engine/Impl/Intellisense/AnalysisQueue.cs#L60-L71 When an unhandled exception occurs, and it's deemed "noncritical", the error...
Open Graph Description: https://github.com/Microsoft/python-language-server/blob/4a00ee80cb2d7b3e736329e82b2ed441ae70b5ca/src/Analysis/Engine/Impl/Intellisense/AnalysisQueue.cs#L60-L71 When an unhandled exception occurs, ...
X Description: https://github.com/Microsoft/python-language-server/blob/4a00ee80cb2d7b3e736329e82b2ed441ae70b5ca/src/Analysis/Engine/Impl/Intellisense/AnalysisQueue.cs#L60-L71 When an unhandled exception occurs, ...
Opengraph URL: https://github.com/microsoft/python-language-server/issues/448
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Server remains open for requests after unhandled \"noncritical\" exceptions","articleBody":"https://github.com/Microsoft/python-language-server/blob/4a00ee80cb2d7b3e736329e82b2ed441ae70b5ca/src/Analysis/Engine/Impl/Intellisense/AnalysisQueue.cs#L60-L71\r\n\r\nWhen an unhandled exception occurs, and it's deemed \"noncritical\", the error is logged and then the AnalysisQueue gets disposed. However, the users of the queue have no idea this is happening and will continue to use it. Specifically, the language server will get requests which only lead to ObjectDisposedException.\r\n\r\nI'm not sure what the correct behavior is here, but if an exception occurs and we are choosing to dispose of the queue, then I feel like either a new queue needs to be created or the server needs to shut down.\r\n\r\n#446 related.","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2018-12-03T19:57:23.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/448/python-language-server/issues/448"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4d3f50ec-ed38-9f81-42d0-7e65ea0de4a8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DB88:1723ED:DBDE96:14235E0:6A4E3168 |
| html-safe-nonce | 7f9b8cd3316f25d48e9a633fc887e2886833f6bd412444f721f33342acdc0326 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjg4OjE3MjNFRDpEQkRFOTY6MTQyMzVFMDo2QTRFMzE2OCIsInZpc2l0b3JfaWQiOiI1MzIwNDA3NzYzODI1NTg1NjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 62f57c4f9dfa505022f3cbbffb3b5db59f20b21d8195202ef45f162f4c7866cd |
| hovercard-subject-tag | issue:386980147 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/python-language-server/448/issue_layout |
| twitter:image | https://opengraph.githubassets.com/071d45e5c74da5f1d0d895194f6c36d87f0856541bf464b3c3af07b495bd368d/microsoft/python-language-server/issues/448 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/071d45e5c74da5f1d0d895194f6c36d87f0856541bf464b3c3af07b495bd368d/microsoft/python-language-server/issues/448 |
| og:image:alt | https://github.com/Microsoft/python-language-server/blob/4a00ee80cb2d7b3e736329e82b2ed441ae70b5ca/src/Analysis/Engine/Impl/Intellisense/AnalysisQueue.cs#L60-L71 When an unhandled exception occurs, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakebailey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 42a6d378d7587a44c93aca255096cd66b7c8eb2d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width