Title: Don't leave parameters in function's original scope when call evaluation is complete · Issue #1407 · microsoft/python-language-server · GitHub
Open Graph Title: Don't leave parameters in function's original scope when call evaluation is complete · Issue #1407 · microsoft/python-language-server
X Title: Don't leave parameters in function's original scope when call evaluation is complete · Issue #1407 · microsoft/python-language-server
Description: Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (DeclareParametersInScope) before evaluating it, but never "undo" that work. This means that we may leave traces of an o...
Open Graph Description: Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (DeclareParametersInScope) before evaluating it, but never "undo" that work. Thi...
X Description: Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (DeclareParametersInScope) before evaluating it, but never "undo" that...
Opengraph URL: https://github.com/microsoft/python-language-server/issues/1407
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Don't leave parameters in function's original scope when call evaluation is complete","articleBody":"Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (`DeclareParametersInScope`) before evaluating it, but never \"undo\" that work. This means that we may leave traces of an old analysis around. This is particularly bad for the builtins module, whose scopes are never cleared.\r\n\r\nThe way we evaluate functions with parameters should be modified to either:\r\n- Restore the old parameters or remove the parameters after calling. This will likely need to be locked so two parallel calls to the same function don't cause weirdness.\r\n- Create a wrapper scope to evaluate the function body in that can be thrown away. This would lack the locking requirement, but many places do casts from `IScope` to concrete types and would break.","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2019-08-05T21:39:52Z","url":"https://github.com/microsoft/python-language-server/issues/1407"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2ba14b62-fbc4-203c-5ca3-e7be31941407 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E29C:1127A8:1DE50D:272D48:6AFE57CD |
| html-safe-nonce | ceef74a8a13fb5ab861ba0bce2ccdfc1f36d0c2e5dbdc551078a4f07a7c7db58 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjlDOjExMjdBODoxREU1MEQ6MjcyRDQ4OjZBRkU1N0NEIiwidmlzaXRvcl9pZCI6IjUyNDE2ODYyOTYyMTUxMjE0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cb32521f0e79c2590ac71afbb551a0d076d2632d19763bd4bd5ca7639d8b9ba4 |
| hovercard-subject-tag | issue:477070411 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/python-language-server/1407/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8c3801058bc6b8a6058824eb147d91cf06386b1118378a4e6f7aa6eb26d16ef9/microsoft/python-language-server/issues/1407 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8c3801058bc6b8a6058824eb147d91cf06386b1118378a4e6f7aa6eb26d16ef9/microsoft/python-language-server/issues/1407 |
| og:image:alt | Part of #1402 masks the fact that when we call a function, we declare parameters inside of the scope of the function (DeclareParametersInScope) before evaluating it, but never "undo" that work. Thi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakebailey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3ad2b58e42f481583284b895305360b61b0223636c9dde6d696b575347163a26 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8df44dbe1c8091b38c3e0165c05a1e5c1563762e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width