Title: Fix path watcher to watch only library paths · Issue #1216 · microsoft/python-language-server · GitHub
Open Graph Title: Fix path watcher to watch only library paths · Issue #1216 · microsoft/python-language-server
X Title: Fix path watcher to watch only library paths · Issue #1216 · microsoft/python-language-server
Description: A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python to get the interpreter paths (duplicate w...
Open Graph Description: A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python t...
X Description: A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python t...
Opengraph URL: https://github.com/microsoft/python-language-server/issues/1216
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix path watcher to watch only library paths","articleBody":"A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python to get the interpreter paths (duplicate work), but the code for the paths watcher relied on that info being there:\r\n\r\n\r\n```csharp\r\n_pathsWatcher?.Dispose();\r\n_pathsWatcher = new PathsWatcher(\r\n _initParams.initializationOptions.searchPaths, // \u003c--\r\n () =>_server.NotifyPackagesChanged(cancellationToken),\r\n _services.GetService\u003cILogger>()\r\n );\r\n\r\n_watchSearchPaths = true;\r\n_searchPaths = _initParams.initializationOptions.searchPaths;\r\n```\r\n\r\nSo, all the paths watcher does at the moment is watch the user-provided search paths, which can be a bad idea now that `extraPaths` is the recommended way to configure directories in an editable-installed package.\r\n\r\nThis code should instead be watching the interpreter paths only. However, that is only available later, since that logic is completed in `ReloadModules` (which this code also calls).\r\n\r\nLikely needs #1213 to be completed first, but this is a motivating example to move the logic for search path analysis earlier (and just have an event which can be used to re-run it and reload everything).","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2019-06-17T22:45:28Z","url":"https://github.com/microsoft/python-language-server/issues/1216"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:82fbe4fe-8feb-89e1-b97d-d7d5b1b8da96 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DA76:15051E:4FE662:68A01C:6AFE665E |
| html-safe-nonce | bfa7a0ca41e881c4dccc42788fdbf886e762c82f71871ecb964ad7a8de5b9dd2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTc2OjE1MDUxRTo0RkU2NjI6NjhBMDFDOjZBRkU2NjVFIiwidmlzaXRvcl9pZCI6IjI2MzQ4MTA5NjcyNzk0MjkyMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 13a79c45dc4475148650de75033962eecbadafcc18a863a76b1e06edc0a2da99 |
| hovercard-subject-tag | issue:457181267 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/python-language-server/1216/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fcc4aa50de5997c80cae8472261eee4ba35d7496454570bbafb556600009c1e2/microsoft/python-language-server/issues/1216 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fcc4aa50de5997c80cae8472261eee4ba35d7496454570bbafb556600009c1e2/microsoft/python-language-server/issues/1216 |
| og:image:alt | A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakebailey |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 145901977 |
| octolytics-dimension-repository_nwo | microsoft/python-language-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145901977 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-language-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width