René's URL Explorer Experiment


Title: Fix path watcher to watch only library paths · Issue #1216 · microsoft/python-language-server · GitHub

Open Graph Title: Fix path watcher to watch only library paths · Issue #1216 · microsoft/python-language-server

X Title: Fix path watcher to watch only library paths · Issue #1216 · microsoft/python-language-server

Description: A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python to get the interpreter paths (duplicate w...

Open Graph Description: A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python t...

X Description: A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python t...

Opengraph URL: https://github.com/microsoft/python-language-server/issues/1216

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix path watcher to watch only library paths","articleBody":"A few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python to get the interpreter paths (duplicate work), but the code for the paths watcher relied on that info being there:\r\n\r\n\r\n```csharp\r\n_pathsWatcher?.Dispose();\r\n_pathsWatcher = new PathsWatcher(\r\n    _initParams.initializationOptions.searchPaths,  // \u003c--\r\n    () =>_server.NotifyPackagesChanged(cancellationToken),\r\n        _services.GetService\u003cILogger>()\r\n    );\r\n\r\n_watchSearchPaths = true;\r\n_searchPaths = _initParams.initializationOptions.searchPaths;\r\n```\r\n\r\nSo, all the paths watcher does at the moment is watch the user-provided search paths, which can be a bad idea now that `extraPaths` is the recommended way to configure directories in an editable-installed package.\r\n\r\nThis code should instead be watching the interpreter paths only. However, that is only available later, since that logic is completed in `ReloadModules` (which this code also calls).\r\n\r\nLikely needs #1213 to be completed first, but this is a motivating example to move the logic for search path analysis earlier (and just have an event which can be used to re-run it and reload everything).","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2019-06-17T22:45:28Z","url":"https://github.com/microsoft/python-language-server/issues/1216"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:82fbe4fe-8feb-89e1-b97d-d7d5b1b8da96
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDA76:15051E:4FE662:68A01C:6AFE665E
html-safe-noncebfa7a0ca41e881c4dccc42788fdbf886e762c82f71871ecb964ad7a8de5b9dd2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTc2OjE1MDUxRTo0RkU2NjI6NjhBMDFDOjZBRkU2NjVFIiwidmlzaXRvcl9pZCI6IjI2MzQ4MTA5NjcyNzk0MjkyMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac13a79c45dc4475148650de75033962eecbadafcc18a863a76b1e06edc0a2da99
hovercard-subject-tagissue:457181267
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/python-language-server/1216/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fcc4aa50de5997c80cae8472261eee4ba35d7496454570bbafb556600009c1e2/microsoft/python-language-server/issues/1216
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fcc4aa50de5997c80cae8472261eee4ba35d7496454570bbafb556600009c1e2/microsoft/python-language-server/issues/1216
og:image:altA few months ago, I made some changes to clean up the search path logic in the initialization for the LS and in the extension. This had the effect of the extension no longer calling out to python t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/microsoft/python-language-server git https://github.com/microsoft/python-language-server.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id145901977
octolytics-dimension-repository_nwomicrosoft/python-language-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145901977
octolytics-dimension-repository_network_root_nwomicrosoft/python-language-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/python-language-server/issues/1216#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fissues%2F1216
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpython-language-server%2Fissues%2F1216
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2Fpython-language-server
Reloadhttps://github.com/microsoft/python-language-server/issues/1216
Reloadhttps://github.com/microsoft/python-language-server/issues/1216
Reloadhttps://github.com/microsoft/python-language-server/issues/1216
microsofthttps://github.com/microsoft
python-language-serverhttps://github.com/microsoft/python-language-server
Codehttps://github.com/microsoft/python-language-server
Issues309 (309)https://github.com/microsoft/python-language-server/issues
Pull requests6 (6)https://github.com/microsoft/python-language-server/pulls
Projectshttps://github.com/microsoft/python-language-server/projects
Wikihttps://github.com/microsoft/python-language-server/wiki
Security and qualityhttps://github.com/microsoft/python-language-server/security
Insightshttps://github.com/microsoft/python-language-server/insights
https://github.com/microsoft/python-language-server
#1306https://github.com/microsoft/python-language-server/pull/1306
Fix path watcher to watch only library pathshttps://github.com/microsoft/python-language-server/issues/1216#top
#1306https://github.com/microsoft/python-language-server/pull/1306
https://github.com/jakebailey
June 2019.2https://github.com/microsoft/python-language-server/milestone/20
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Jun 17, 2019https://github.com/microsoft/python-language-server/issues/1216#issue-457181267
#1213https://github.com/microsoft/python-language-server/issues/1213
Mikhail Arkhipov (MikhailArkhipov)https://github.com/MikhailArkhipov
June 2019.2https://github.com/microsoft/python-language-server/milestone/20
on Jun 18, 2019https://github.com/microsoft/python-language-server/issues/1216#event-2422267371
Jake Bailey (jakebailey)https://github.com/jakebailey
on Jun 18, 2019https://github.com/microsoft/python-language-server/issues/1216#event-2422490638
Jake Bailey (jakebailey)https://github.com/jakebailey
completedhttps://github.com/microsoft/python-language-server/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1306https://github.com/microsoft/python-language-server/pull/1306
on Jul 15, 2019https://github.com/microsoft/python-language-server/issues/1216#event-2484382680
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/python-language-server/issues/1216
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/python-language-server/issues/1216
Jake Bailey (jakebailey)https://github.com/jakebailey
June 2019.2https://github.com/microsoft/python-language-server/milestone/20
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.