Title: chore: fix all clippy issues and strengthen CI lint coverage (Fixes #481) by karthiknadig · Pull Request #482 · microsoft/python-environment-tools · GitHub
Open Graph Title: chore: fix all clippy issues and strengthen CI lint coverage (Fixes #481) by karthiknadig · Pull Request #482 · microsoft/python-environment-tools
X Title: chore: fix all clippy issues and strengthen CI lint coverage (Fixes #481) by karthiknadig · Pull Request #482 · microsoft/python-environment-tools
Description: Summary Makes the whole workspace pass cargo clippy --workspace --all-targets --all-features -- -D warnings and closes the CI gap that let these slip through: the lint job ran cargo clippy --all-features without --all-targets and only on Linux, so test code and platform-gated code were never linted. Clippy fixes crates/pet-hatch/src/lib.rs — remove four needless & borrows in norm_case(&path.join(...)) (needless_borrows_for_generic_args). crates/pet/tests/jsonrpc_server_test.rs — drop a needless return (needless_return). crates/pet/tests/e2e_performance.rs — replace .expect(&format!(...)) with .unwrap_or_else(|_| panic!(...)) to avoid eager formatting (expect_fun_call). CI lint changes (lint.yml) Run cargo clippy --workspace --all-targets --all-features -- -D warnings so tests and feature-gated code are linted. Add a Windows runner alongside Linux (matrix) so platform-gated code is covered. Split the format check into its own job. Toolchain stays on dtolnay/rust-toolchain@stable (latest stable); local is already on the latest stable. Verification cargo clippy --workspace --all-targets --all-features -- -D warnings — clean (Linux + Windows; verified Windows locally). cargo fmt --all --check — clean. cargo test -p pet-hatch — 33 passing; pet test targets compile. Note: the new lint matrix does not yet include macOS to avoid surfacing unverifiable pre-existing macOS-gated findings in this PR; that can be a follow-up. Fixes #481
Open Graph Description: Summary Makes the whole workspace pass cargo clippy --workspace --all-targets --all-features -- -D warnings and closes the CI gap that let these slip through: the lint job ran cargo clippy --all-fe...
X Description: Summary Makes the whole workspace pass cargo clippy --workspace --all-targets --all-features -- -D warnings and closes the CI gap that let these slip through: the lint job ran cargo clippy --all-fe...
Opengraph URL: https://github.com/microsoft/python-environment-tools/pull/482
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:549a2c55-eaa3-cfae-e885-cb799fa03398 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 923E:25F708:A57B80:DCD02B:6A52B7C8 |
| html-safe-nonce | c516033227a808c1b944ef4ce34aaba0913085ef8e1d112f78ecc9ce03c98c91 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjNFOjI1RjcwODpBNTdCODA6RENEMDJCOjZBNTJCN0M4IiwidmlzaXRvcl9pZCI6Ijg3ODg3NzY2NDE2OTIzNTA0MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f1e46a51616e37ac3cc51f0dc330420743868ac04ebfbe00d27625aea42c5e27 |
| hovercard-subject-tag | pull_request:3939937286 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/python-environment-tools/pull/482/files |
| twitter:image | https://avatars.githubusercontent.com/u/3840081?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3840081?s=400&v=4 |
| og:image:alt | Summary Makes the whole workspace pass cargo clippy --workspace --all-targets --all-features -- -D warnings and closes the CI gap that let these slip through: the lint job ran cargo clippy --all-fe... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/python-environment-tools git https://github.com/microsoft/python-environment-tools.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 808419207 |
| octolytics-dimension-repository_nwo | microsoft/python-environment-tools |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 808419207 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-environment-tools |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width