Title: chore: fix all clippy issues and strengthen CI lint coverage · Issue #481 · microsoft/python-environment-tools · GitHub
Open Graph Title: chore: fix all clippy issues and strengthen CI lint coverage · Issue #481 · microsoft/python-environment-tools
X Title: chore: fix all clippy issues and strengthen CI lint coverage · Issue #481 · microsoft/python-environment-tools
Description: Problem cargo clippy --workspace --all-targets --all-features -- -D warnings fails on test code that the CI lint job never checks, because lint.yml runs cargo clippy --all-features without --all-targets and only on Linux. Issues found: c...
Open Graph Description: Problem cargo clippy --workspace --all-targets --all-features -- -D warnings fails on test code that the CI lint job never checks, because lint.yml runs cargo clippy --all-features without --all-ta...
X Description: Problem cargo clippy --workspace --all-targets --all-features -- -D warnings fails on test code that the CI lint job never checks, because lint.yml runs cargo clippy --all-features without --all-ta...
Opengraph URL: https://github.com/microsoft/python-environment-tools/issues/481
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"chore: fix all clippy issues and strengthen CI lint coverage","articleBody":"## Problem\n\n`cargo clippy --workspace --all-targets --all-features -- -D warnings` fails on test code that the CI lint job never checks, because `lint.yml` runs `cargo clippy --all-features` **without** `--all-targets` and only on Linux. Issues found:\n\n- `crates/pet-hatch/src/lib.rs` (x4) — `needless_borrows_for_generic_args` (`norm_case(\u0026path.join(...))`)\n- `crates/pet/tests/jsonrpc_server_test.rs:70` — `needless_return`\n- `crates/pet/tests/e2e_performance.rs:764` — `expect_fun_call` (`.expect(\u0026format!(...))`)\n\nThese never failed CI because the lint job skips test targets.\n\n## Fix\n\n- Fix all of the above clippy findings.\n- Strengthen the CI lint job (`lint.yml`) to run `cargo clippy --workspace --all-targets --all-features -- -D warnings` so test code and feature-gated code are linted.\n- Run clippy on both Linux and Windows runners so platform-gated code is covered.\n\n## Context\n\nDiscovered while fixing #432.\r\n","author":{"url":"https://github.com/karthiknadig","@type":"Person","name":"karthiknadig"},"datePublished":"2026-06-26T04:42:50.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/481/python-environment-tools/issues/481"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7e2c1bea-90d0-3b55-cc4c-16333a410dc8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E9EA:32604D:2849A:34CFC:6A51CC12 |
| html-safe-nonce | 80c66dc0f546ddd617fc4093bddc3ccc206b8e1ff423fa5c77645b0dcf8c8114 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUVBOjMyNjA0RDoyODQ5QTozNENGQzo2QTUxQ0MxMiIsInZpc2l0b3JfaWQiOiI1NzM5OTU4Nzk3NzAwNTQ5NjUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e862c223e29dd5d96a909d34989d0aa4ef7a278bec4f032d62567fd30bd6ce79 |
| hovercard-subject-tag | issue:4749302642 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/python-environment-tools/481/issue_layout |
| twitter:image | https://opengraph.githubassets.com/321549ad41edb56941028ddeda3ff29debf1ea2f4fe245a4ba42f82dcdb944d2/microsoft/python-environment-tools/issues/481 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/321549ad41edb56941028ddeda3ff29debf1ea2f4fe245a4ba42f82dcdb944d2/microsoft/python-environment-tools/issues/481 |
| og:image:alt | Problem cargo clippy --workspace --all-targets --all-features -- -D warnings fails on test code that the CI lint job never checks, because lint.yml runs cargo clippy --all-features without --all-ta... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | karthiknadig |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/python-environment-tools git https://github.com/microsoft/python-environment-tools.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 808419207 |
| octolytics-dimension-repository_nwo | microsoft/python-environment-tools |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 808419207 |
| octolytics-dimension-repository_network_root_nwo | microsoft/python-environment-tools |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width