Title: sourcePaths no longer work after #354 · Issue #455 · microsoft/java-debug · GitHub
Open Graph Title: sourcePaths no longer work after #354 · Issue #455 · microsoft/java-debug
X Title: sourcePaths no longer work after #354 · Issue #455 · microsoft/java-debug
Description: I submitted a detailed review on #354 Essentially it seems that user-specified sourcePaths are no longer used when resolving the filesystem path for a file in the stack trace after the above patch. The result is that we always return jdt...
Open Graph Description: I submitted a detailed review on #354 Essentially it seems that user-specified sourcePaths are no longer used when resolving the filesystem path for a file in the stack trace after the above patch....
X Description: I submitted a detailed review on #354 Essentially it seems that user-specified sourcePaths are no longer used when resolving the filesystem path for a file in the stack trace after the above patch....
Opengraph URL: https://github.com/microsoft/java-debug/issues/455
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"sourcePaths no longer work after #354","articleBody":"I submitted a detailed review on https://github.com/microsoft/java-debug/pull/354\r\n\r\nEssentially it seems that user-specified `sourcePaths` are no longer used when resolving the filesystem path for a file in the stack trace after the above patch. The result is that we always return `jdt://` paths which not all clients know how to handle. \r\n\r\nIt seems to me that we should always prefer filesystem paths (having applied user `sourcePaths`) over \"internal\" `jdt://` paths.","author":{"url":"https://github.com/puremourning","@type":"Person","name":"puremourning"},"datePublished":"2022-11-07T12:41:14.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/455/java-debug/issues/455"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:66861482-5164-66a0-bb2a-c314cccd71af |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C1E2:1485C3:F423D:13C85E:6A5AB123 |
| html-safe-nonce | 5378d37d3634ff256fcf0aebce81a8534d036348d2701ada298951d3f465b45f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUUyOjE0ODVDMzpGNDIzRDoxM0M4NUU6NkE1QUIxMjMiLCJ2aXNpdG9yX2lkIjoiMTU0NDE5ODMzMTM0MTM4NjAxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6512b5e547bc2ac3909a56ca08b9e4842d0c287fcc842024ea19c7614e481427 |
| hovercard-subject-tag | issue:1438302111 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/java-debug/455/issue_layout |
| twitter:image | https://opengraph.githubassets.com/182b2282dd71f50302d7c3347feda2c3ff3249c1836593a85ad6ddd72d75cca5/microsoft/java-debug/issues/455 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/182b2282dd71f50302d7c3347feda2c3ff3249c1836593a85ad6ddd72d75cca5/microsoft/java-debug/issues/455 |
| og:image:alt | I submitted a detailed review on #354 Essentially it seems that user-specified sourcePaths are no longer used when resolving the filesystem path for a file in the stack trace after the above patch.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | puremourning |
| hostname | github.com |
| expected-hostname | github.com |
| None | 21c53da6db0c40484841ba32fe19ecf485e7e734334faab487cd59d884d2bb33 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/java-debug git https://github.com/microsoft/java-debug.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 102583752 |
| octolytics-dimension-repository_nwo | microsoft/java-debug |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 102583752 |
| octolytics-dimension-repository_network_root_nwo | microsoft/java-debug |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6e85f20f54e1147d8162094880590864abefff6b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width