René's URL Explorer Experiment


Title: Fix when_all to wait for all tasks before surfacing failures by andystaples · Pull Request #173 · microsoft/durabletask-python · GitHub

Open Graph Title: Fix when_all to wait for all tasks before surfacing failures by andystaples · Pull Request #173 · microsoft/durabletask-python

X Title: Fix when_all to wait for all tasks before surfacing failures by andystaples · Pull Request #173 · microsoft/durabletask-python

Description: Summary task.when_all() previously failed fast: as soon as one of its child tasks failed, the composite task was marked complete and the failure was surfaced immediately, even while sibling tasks were still running. This does not match the .NET SDK (durabletask-dotnet), which relies on the framework's Task.WhenAll. That contract is: the returned task completes only after all supplied tasks finish, and then surfaces the first fault. This PR changes WhenAllTask.on_child_completed to record the first exception but only complete once every child task has completed — surfacing the first failure at that point (or building the ordered result list if none failed). Behavior change An orchestration that fans out and hits a failure now waits for the remaining sibling tasks to finish before failing, instead of failing immediately. This is a deliberate change to match .NET semantics. Changes durabletask/task.py — WhenAllTask.on_child_completed no longer sets _is_complete on the first failure; it completes (with the first exception, if any) only after all children complete. tests/durabletask/test_orchestration_executor.py — updated test_fan_in_with_single_failure to assert the orchestration keeps running (zero actions) while tasks are outstanding, then fails once all children complete. CHANGELOG.md — added a FIXED entry. Testing pytest tests/durabletask/test_orchestration_executor.py — all pass flake8 clean on changed files

Open Graph Description: Summary task.when_all() previously failed fast: as soon as one of its child tasks failed, the composite task was marked complete and the failure was surfaced immediately, even while sibling tasks w...

X Description: Summary task.when_all() previously failed fast: as soon as one of its child tasks failed, the composite task was marked complete and the failure was surfaced immediately, even while sibling tasks w...

Opengraph URL: https://github.com/microsoft/durabletask-python/pull/173

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ffea3127-3649-58af-255e-41e1bc001836
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5B8:61466:458E9C:5EA1CF:6AFE5919
html-safe-noncecbfdac146637c791c8227d6d4400380da88081bc5e4381b3268f861da9707fc4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUI4OjYxNDY2OjQ1OEU5Qzo1RUExQ0Y6NkFGRTU5MTkiLCJ2aXNpdG9yX2lkIjoiMzMzMTYxMzUzNjgwMTQ4NzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccdc29cf83402cfc740a343ae0aa777835e899af879e35f84c6ac29043d023bf5
hovercard-subject-tagpull_request:4054430513
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/durabletask-python/pull/173/files
twitter:imagehttps://avatars.githubusercontent.com/u/77818326?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/77818326?s=400&v=4
og:image:altSummary task.when_all() previously failed fast: as soon as one of its child tasks failed, the composite task was marked complete and the failure was surfaced immediately, even while sibling tasks w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/durabletask-python git https://github.com/microsoft/durabletask-python.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id627664515
octolytics-dimension-repository_nwomicrosoft/durabletask-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id627664515
octolytics-dimension-repository_network_root_nwomicrosoft/durabletask-python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/durabletask-python/pull/173/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdurabletask-python%2Fpull%2F173%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdurabletask-python%2Fpull%2F173%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fdurabletask-python
Reloadhttps://github.com/microsoft/durabletask-python/pull/173/files
Reloadhttps://github.com/microsoft/durabletask-python/pull/173/files
Reloadhttps://github.com/microsoft/durabletask-python/pull/173/files
microsofthttps://github.com/microsoft
durabletask-pythonhttps://github.com/microsoft/durabletask-python
Codehttps://github.com/microsoft/durabletask-python
Issues15 (15)https://github.com/microsoft/durabletask-python/issues
Pull requests12 (12)https://github.com/microsoft/durabletask-python/pulls
Actionshttps://github.com/microsoft/durabletask-python/actions
Projectshttps://github.com/microsoft/durabletask-python/projects
Security and qualityhttps://github.com/microsoft/durabletask-python/security
Insightshttps://github.com/microsoft/durabletask-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2Fdurabletask-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2Fdurabletask-python%2Fissues%2Fnew%2Fchoose
Bernd Verst (berndverst)https://github.com/berndverst
microsoft:mainhttps://github.com/microsoft/durabletask-python/tree/main
andystaples:andystaples/fix-when-all-error-handlinghttps://github.com/andystaples/durabletask-python/tree/andystaples/fix-when-all-error-handling
Conversation 4 https://github.com/microsoft/durabletask-python/pull/173
Commits 5 https://github.com/microsoft/durabletask-python/pull/173/commits
Checks 16 https://github.com/microsoft/durabletask-python/pull/173/checks
Files changed https://github.com/microsoft/durabletask-python/pull/173/files
Please reload this pagehttps://github.com/microsoft/durabletask-python/pull/173/files
Fix when_all to wait for all tasks before surfacing failures https://github.com/microsoft/durabletask-python/pull/173/files#top
Show all changes 5 commits https://github.com/microsoft/durabletask-python/pull/173/files
64b688a Fix when_all to wait for all tasks before surfacing failures andystaples Jul 14, 2026 https://github.com/microsoft/durabletask-python/pull/173/commits/64b688a382f2a6d5e2dda24284a02307f3bb5e28
3a890a9 Fix is_failed guard by storing exception andystaples Jul 14, 2026 https://github.com/microsoft/durabletask-python/pull/173/commits/3a890a9a9c8dc4391663bfbc0c6efca408b9a197
e23ed70 Constructor ordering to prevent AttributeError andystaples Jul 14, 2026 https://github.com/microsoft/durabletask-python/pull/173/commits/e23ed70d853f3470063f1a41ecf6dee38634fc31
f780173 Merge branch 'main' into andystaples/fix-when-all-error-handling andystaples Jul 14, 2026 https://github.com/microsoft/durabletask-python/pull/173/commits/f7801734a70039683f4ef96e667f801990887c53
42b8b13 Update CHANGELOG.md andystaples Jul 14, 2026 https://github.com/microsoft/durabletask-python/pull/173/commits/42b8b13efab5bf94fe5a18bc7b4b97e6a57bb465
Clear filters https://github.com/microsoft/durabletask-python/pull/173/files
Please reload this pagehttps://github.com/microsoft/durabletask-python/pull/173/files
Please reload this pagehttps://github.com/microsoft/durabletask-python/pull/173/files
CHANGELOG.md https://github.com/microsoft/durabletask-python/pull/173/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
task.py https://github.com/microsoft/durabletask-python/pull/173/files#diff-36492640add0941ee3934088b514e433cd929fa6120e74f93e37e5484bfe7981
test_orchestration_executor.py https://github.com/microsoft/durabletask-python/pull/173/files#diff-3d6b06ac4db653818f8956dc727c6b691775880aca64ddd2e3342c04b8ec0b8e
CHANGELOG.mdhttps://github.com/microsoft/durabletask-python/pull/173/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
View file https://github.com/andystaples/durabletask-python/blob/42b8b13efab5bf94fe5a18bc7b4b97e6a57bb465/CHANGELOG.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/durabletask-python/pull/173/{{ revealButtonHref }}
https://github.com/microsoft/durabletask-python/pull/173/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
https://github.com/microsoft/durabletask-python/pull/173/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
durabletask/task.pyhttps://github.com/microsoft/durabletask-python/pull/173/files#diff-36492640add0941ee3934088b514e433cd929fa6120e74f93e37e5484bfe7981
View file https://github.com/andystaples/durabletask-python/blob/42b8b13efab5bf94fe5a18bc7b4b97e6a57bb465/durabletask/task.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/durabletask-python/pull/173/{{ revealButtonHref }}
https://github.com/microsoft/durabletask-python/pull/173/files#diff-36492640add0941ee3934088b514e433cd929fa6120e74f93e37e5484bfe7981
https://github.com/microsoft/durabletask-python/pull/173/files#diff-36492640add0941ee3934088b514e433cd929fa6120e74f93e37e5484bfe7981
Please reload this pagehttps://github.com/microsoft/durabletask-python/pull/173/files
https://github.com/microsoft/durabletask-python/pull/173/files#diff-36492640add0941ee3934088b514e433cd929fa6120e74f93e37e5484bfe7981
Please reload this pagehttps://github.com/microsoft/durabletask-python/pull/173/files
https://github.com/microsoft/durabletask-python/pull/173/files#diff-36492640add0941ee3934088b514e433cd929fa6120e74f93e37e5484bfe7981
tests/durabletask/test_orchestration_executor.pyhttps://github.com/microsoft/durabletask-python/pull/173/files#diff-3d6b06ac4db653818f8956dc727c6b691775880aca64ddd2e3342c04b8ec0b8e
View file https://github.com/andystaples/durabletask-python/blob/42b8b13efab5bf94fe5a18bc7b4b97e6a57bb465/tests/durabletask/test_orchestration_executor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/durabletask-python/pull/173/{{ revealButtonHref }}
https://github.com/microsoft/durabletask-python/pull/173/files#diff-3d6b06ac4db653818f8956dc727c6b691775880aca64ddd2e3342c04b8ec0b8e
https://github.com/microsoft/durabletask-python/pull/173/files#diff-3d6b06ac4db653818f8956dc727c6b691775880aca64ddd2e3342c04b8ec0b8e
https://github.com/microsoft/durabletask-python/pull/173/files#diff-3d6b06ac4db653818f8956dc727c6b691775880aca64ddd2e3342c04b8ec0b8e
Please reload this pagehttps://github.com/microsoft/durabletask-python/pull/173/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.