René's URL Explorer Experiment


Title: Preserve dispatch outcomes on teardown cancellation and document generator cleanup semantics · Issue #301 · microsoft/durabletask-python · GitHub

Open Graph Title: Preserve dispatch outcomes on teardown cancellation and document generator cleanup semantics · Issue #301 · microsoft/durabletask-python

X Title: Preserve dispatch outcomes on teardown cancellation and document generator cleanup semantics · Issue #301 · microsoft/durabletask-python

Description: Context Follow-up to merged PR #300. These items were raised in the review and remain follow-ups after merge. Closing the generator at the dispatch boundary is compatible with replay: the next dispatch reconstructs a fresh context and ge...

Open Graph Description: Context Follow-up to merged PR #300. These items were raised in the review and remain follow-ups after merge. Closing the generator at the dispatch boundary is compatible with replay: the next disp...

X Description: Context Follow-up to merged PR #300. These items were raised in the review and remain follow-ups after merge. Closing the generator at the dispatch boundary is compatible with replay: the next disp...

Opengraph URL: https://github.com/microsoft/durabletask-python/issues/301

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Preserve dispatch outcomes on teardown cancellation and document generator cleanup semantics","articleBody":"## Context\n\nFollow-up to merged PR [#300](https://github.com/microsoft/durabletask-python/pull/300). These items were raised in [the review](https://github.com/microsoft/durabletask-python/pull/300#pullrequestreview-5588884189) and remain follow-ups after merge.\n\nClosing the generator at the dispatch boundary is compatible with replay: the next dispatch reconstructs a fresh context and generator from history. The remaining work is to preserve dispatch outcomes when teardown raises cancellation and make the customer-visible finalizer contract explicit.\n\n## 1. Handle cancellation raised by generator teardown\n\nOriginal [inline comment](https://github.com/microsoft/durabletask-python/pull/300#discussion_r4328008675); [code at the reviewed commit](https://github.com/microsoft/durabletask-python/blob/2f85f4c535a7c723519c91a7c0431b446e99a672/durabletask/worker.py#L2354-L2368).\n\nThe handler around `ctx._generator.close()` catches `Exception`, but `asyncio.CancelledError` inherits from `BaseException`. An async bridge's finalizer can call `root.cancel()` followed by `loop.run_until_complete(root)`, causing cancellation to escape from `close()`.\n\nThat exception overrides the already-constructed `ExecutionResults`. The worker's outer `except Exception` also misses it, so it sends neither `CompleteOrchestratorTask` nor an abandonment request. Teardown cancellation can also mask a pending version-rejection `AbandonOrchestrationError`.\n\n- [ ] Handle `asyncio.CancelledError` raised by teardown explicitly, without indiscriminately swallowing `SystemExit` or `KeyboardInterrupt`.\n- [ ] Add regression coverage showing that teardown cancellation preserves a normal dispatch response and its delivery to the scheduler.\n- [ ] Add regression coverage showing that teardown cancellation does not replace version-rejection abandonment.\n\n## 2. Document the customer-visible finalizer semantics\n\nOriginal [inline comment](https://github.com/microsoft/durabletask-python/pull/300#discussion_r4328008685).\n\nAdd orchestration documentation, rather than relying only on the implementation comment, covering each of these nuances:\n\n- `close()` injects `GeneratorExit`, running active `finally` blocks and context-manager exits when a dispatch suspends, before its durable task completes. This can happen again on subsequent dispatches. These are per-dispatch resource-cleanup hooks, not orchestration-completion or exactly-once compensation hooks. Releasing an external resource here can affect an activity that is still running.\n- `ctx.is_replaying` is normally false during teardown after processing new events. Guarding a finalizer with `not ctx.is_replaying`, or using a replay-safe logger, does not make it run only at orchestration completion.\n- Durable actions, timer cancellation, custom-status changes, and `continue_as_new()` invoked only by forced teardown do not alter the saved response. Durable cleanup must remain in normal orchestration control flow.\n- Yielding a task while handling `GeneratorExit` raises `RuntimeError: generator ignored GeneratorExit`. Logging that warning does not mean the generator finished closing: it can remain suspended and retain resources. Distinguish forced teardown from a finalizer reached through normal replay/completion, where yielding durable cleanup can still work.\n- Garbage collection could already trigger finalization, so completion-only finalizer timing was never reliable. This change makes dispatch-boundary teardown explicit and synchronous; it does not provide a durable cleanup guarantee across process failure.\n\n- [ ] Document all of the above in the orchestration documentation.\n- [ ] Include a short example contrasting local resource teardown with workflow-level cleanup.\n\n## 3. Clarify the wording in all three changelogs\n\nOriginal [inline comment](https://github.com/microsoft/durabletask-python/pull/300#discussion_r4328008688).\n\nMatching `Unreleased` entries were added to all three affected packages before merge, so changelog coverage is already addressed. The remaining request is to align their wording with the documented lifecycle contract:\n\n- `CHANGELOG.md`\n- `durabletask-azuremanaged/CHANGELOG.md`\n- `azure-functions-durable/CHANGELOG.md`\n\nThe current phrase \"runs deterministically\" could be read as a guarantee of orchestration-level or exactly-once cleanup. State explicitly that generators close after each dispatch, including while waiting for durable work, so finalizers and context-manager exits can run before orchestration completion and repeat across dispatches.\n\n- [ ] Clarify the per-dispatch scope consistently in all three `Unreleased` entries.\n- [ ] Link to the finalizer-semantics documentation for the caveats about discarded teardown actions/status and yielding during close.","author":{"url":"https://github.com/andystaples","@type":"Person","name":"andystaples"},"datePublished":"2026-10-20T17:22:53Z","url":"https://github.com/microsoft/durabletask-python/issues/301"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ca8bc01d-408e-c566-b665-b7b1d86a3f7a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE054:1FBC18:C81280:118F871:6AFE2CD6
html-safe-noncef61718eb0d579006ee4b5dd1de9a85d467e2dbe60533a1326820af41e4c393d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDU0OjFGQkMxODpDODEyODA6MTE4Rjg3MTo2QUZFMkNENiIsInZpc2l0b3JfaWQiOiI3NTIxMzQxNDA0NzkwNzk1NDc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac175343c3848e9c2aacc0c6617f87f41a1b0e29f0acc955988a027598bf08baee
hovercard-subject-tagissue:5946302777
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/durabletask-python/301/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4b14d021832b2110fa5bb96ea258f1a2f9a273032181844f678e82e482724f93/microsoft/durabletask-python/issues/301
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b14d021832b2110fa5bb96ea258f1a2f9a273032181844f678e82e482724f93/microsoft/durabletask-python/issues/301
og:image:altContext Follow-up to merged PR #300. These items were raised in the review and remain follow-ups after merge. Closing the generator at the dispatch boundary is compatible with replay: the next disp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandystaples
hostnamegithub.com
expected-hostnamegithub.com
Nonee973f9ec3625f3faad8cac5c2d11a214b7ffe45f3cc563b828459b290ecaeed3
turbo-cache-controlno-preview
go-importgithub.com/microsoft/durabletask-python git https://github.com/microsoft/durabletask-python.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id627664515
octolytics-dimension-repository_nwomicrosoft/durabletask-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id627664515
octolytics-dimension-repository_network_root_nwomicrosoft/durabletask-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1f92c367595b9190e0be293896078033886b1913
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/durabletask-python/issues/301#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdurabletask-python%2Fissues%2F301
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdurabletask-python%2Fissues%2F301
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2Fdurabletask-python
Reloadhttps://github.com/microsoft/durabletask-python/issues/301
Reloadhttps://github.com/microsoft/durabletask-python/issues/301
Reloadhttps://github.com/microsoft/durabletask-python/issues/301
microsofthttps://github.com/microsoft
durabletask-pythonhttps://github.com/microsoft/durabletask-python
Codehttps://github.com/microsoft/durabletask-python
Issues15 (15)https://github.com/microsoft/durabletask-python/issues
Pull requests12 (12)https://github.com/microsoft/durabletask-python/pulls
Actionshttps://github.com/microsoft/durabletask-python/actions
Projectshttps://github.com/microsoft/durabletask-python/projects
Security and qualityhttps://github.com/microsoft/durabletask-python/security
Insightshttps://github.com/microsoft/durabletask-python/insights
https://github.com/microsoft/durabletask-python
New issuehttps://github.com/login?return_to=https://github.com/microsoft/durabletask-python/issues/301
New issuehttps://github.com/login?return_to=https://github.com/microsoft/durabletask-python/issues/301
#303https://github.com/microsoft/durabletask-python/pull/303
Preserve dispatch outcomes on teardown cancellation and document generator cleanup semanticshttps://github.com/microsoft/durabletask-python/issues/301#top
#303https://github.com/microsoft/durabletask-python/pull/303
https://github.com/tamirdresher
bugSomething isn't workinghttps://github.com/microsoft/durabletask-python/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/andystaples
andystapleshttps://github.com/andystaples
on Oct 20, 2026https://github.com/microsoft/durabletask-python/issues/301#issue-5946302777
#300https://github.com/microsoft/durabletask-python/pull/300
the reviewhttps://github.com/microsoft/durabletask-python/pull/300#pullrequestreview-5588884189
inline commenthttps://github.com/microsoft/durabletask-python/pull/300#discussion_r4328008675
code at the reviewed commithttps://github.com/microsoft/durabletask-python/blob/2f85f4c535a7c723519c91a7c0431b446e99a672/durabletask/worker.py#L2354-L2368
inline commenthttps://github.com/microsoft/durabletask-python/pull/300#discussion_r4328008685
inline commenthttps://github.com/microsoft/durabletask-python/pull/300#discussion_r4328008688
andystapleshttps://github.com/andystaples
Tamir Dresher (tamirdresher)https://github.com/tamirdresher
on Oct 20, 2026https://github.com/microsoft/durabletask-python/issues/301#event-33766982745
andystapleshttps://github.com/andystaples
bugSomething isn't workinghttps://github.com/microsoft/durabletask-python/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 20, 2026https://github.com/microsoft/durabletask-python/issues/301#event-33766985549
Tamir Dresher (tamirdresher)https://github.com/tamirdresher
completedhttps://github.com/microsoft/durabletask-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#303https://github.com/microsoft/durabletask-python/pull/303
on Oct 21, 2026https://github.com/microsoft/durabletask-python/issues/301#event-33864978418
Hardik K (hardikkaurani)https://github.com/hardikkaurani
on Oct 22, 2026https://github.com/microsoft/durabletask-python/issues/301#event-33911129791
fix(worker): preserve dispatch outcomes when generator teardown raise…https://github.com/hardikkaurani/durabletask-python/commit/14e75af2a1bb1edff4615550549550cb94b5a74f
https://docs.github.com/articles/closing-issues-via-commit-messages
14e75afhttps://github.com/hardikkaurani/durabletask-python/commit/14e75af2a1bb1edff4615550549550cb94b5a74f
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/durabletask-python/issues/301
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/durabletask-python/issues/301
Tamir Dresher (tamirdresher)https://github.com/tamirdresher
bugSomething isn't workinghttps://github.com/microsoft/durabletask-python/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.