René's URL Explorer Experiment


Title: Add context manager support to `TaskHubGrpcClient` to prevent gRPC channel leaks · Issue #134 · microsoft/durabletask-python · GitHub

Open Graph Title: Add context manager support to `TaskHubGrpcClient` to prevent gRPC channel leaks · Issue #134 · microsoft/durabletask-python

X Title: Add context manager support to `TaskHubGrpcClient` to prevent gRPC channel leaks · Issue #134 · microsoft/durabletask-python

Description: Problem TaskHubGrpcClient has a close() method but does not implement __enter__/__exit__, so it cannot be used as a context manager. This means callers must remember to call close() manually (typically in a try/finally block), but no exi...

Open Graph Description: Problem TaskHubGrpcClient has a close() method but does not implement __enter__/__exit__, so it cannot be used as a context manager. This means callers must remember to call close() manually (typic...

X Description: Problem TaskHubGrpcClient has a close() method but does not implement __enter__/__exit__, so it cannot be used as a context manager. This means callers must remember to call close() manually (typic...

Opengraph URL: https://github.com/microsoft/durabletask-python/issues/134

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add context manager support to `TaskHubGrpcClient` to prevent gRPC channel leaks","articleBody":"## Problem\n\n`TaskHubGrpcClient` has a `close()` method but does not implement `__enter__`/`__exit__`, so it cannot be used as a context manager. This means callers must remember to call `close()` manually (typically in a `try/finally` block), but no existing tests or examples do this — every callsite creates the client and never closes it, leaking the underlying gRPC channel.\n\n`AsyncTaskHubGrpcClient` already has `__aenter__`/`__aexit__`, so there is an asymmetry between the sync and async clients.\n\n## Scope\n\nThis affects ~40+ callsites across the repository:\n\n| File | Unclosed usages |\n|---|---|\n| `tests/durabletask/test_orchestration_e2e.py` | ~21 |\n| `tests/durabletask/entities/test_function_based_entities_e2e.py` | ~10 |\n| `tests/durabletask/entities/test_entity_failure_handling.py` | ~5 |\n| `tests/durabletask/entities/test_class_based_entities_e2e.py` | ~4 |\n| `examples/in_memory_backend_example/test/test_workflows.py` | ~8 |\n| `examples/human_interaction.py` | 1 |\n\n## Proposed Fix\n\n1. Add `__enter__`/`__exit__` to `TaskHubGrpcClient` (mirrors the existing async pattern):\n\n```python\ndef __enter__(self):\n    return self\n\ndef __exit__(self, exc_type, exc_val, exc_tb):\n    self.close()\n```\n\n2. Update all test and example callsites to use the `with` statement:\n\n```python\n# Before\ntask_hub_client = client.TaskHubGrpcClient(host_address=HOST)\nid = task_hub_client.schedule_new_orchestration(...)\nstate = task_hub_client.wait_for_orchestration_completion(id, timeout=30)\n\n# After\nwith client.TaskHubGrpcClient(host_address=HOST) as task_hub_client:\n    id = task_hub_client.schedule_new_orchestration(...)\n    state = task_hub_client.wait_for_orchestration_completion(id, timeout=30)\n```\n\nThis also improves the getting-started experience and aligns with the `TaskHubGrpcWorker` pattern already used throughout the codebase.\n\n## Notes\n\n- Adding `__enter__`/`__exit__` is a non-breaking additive change\n- The channel leak is benign in short-lived test processes but is a real concern in long-running applications or test suites that run many tests\n- This issue was surfaced by a reviewer comment on PR #133","author":{"url":"https://github.com/andystaples","@type":"Person","name":"andystaples"},"datePublished":"2026-04-14T17:59:06Z","url":"https://github.com/microsoft/durabletask-python/issues/134"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d9a45445-0295-8ed5-2c73-366f1d4b8e2c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9D3C:38CE1B:4059E:56833:6AFE413D
html-safe-nonce0fdf38613fb4dcda169eeb72d42eaa9dd4fbf2c4b9aab475e5e65ad7a5e0099d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDNDOjM4Q0UxQjo0MDU5RTo1NjgzMzo2QUZFNDEzRCIsInZpc2l0b3JfaWQiOiI2MTYzMDgxMTU1ODk0NDYwNzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9312f5dcef6d56daf02db27369480bfcf2d79a042329191f7b0c366660c09566
hovercard-subject-tagissue:4263870751
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/durabletask-python/134/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a91f8044a9589a4f9d61326e6433a8f3691009a7047d0d59ea760831b74add48/microsoft/durabletask-python/issues/134
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a91f8044a9589a4f9d61326e6433a8f3691009a7047d0d59ea760831b74add48/microsoft/durabletask-python/issues/134
og:image:altProblem TaskHubGrpcClient has a close() method but does not implement __enter__/__exit__, so it cannot be used as a context manager. This means callers must remember to call close() manually (typic...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandystaples
hostnamegithub.com
expected-hostnamegithub.com
Nonef1a5901e2377b0af2a0b303f9528678f1475d04b9219dca1e993344196eaa07c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/durabletask-python git https://github.com/microsoft/durabletask-python.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id627664515
octolytics-dimension-repository_nwomicrosoft/durabletask-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id627664515
octolytics-dimension-repository_network_root_nwomicrosoft/durabletask-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec4447fdce9ed0f33af959d2b6680d0bc18212a6a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/durabletask-python/issues/134#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdurabletask-python%2Fissues%2F134
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fdurabletask-python%2Fissues%2F134
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2Fdurabletask-python
Reloadhttps://github.com/microsoft/durabletask-python/issues/134
Reloadhttps://github.com/microsoft/durabletask-python/issues/134
Reloadhttps://github.com/microsoft/durabletask-python/issues/134
microsofthttps://github.com/microsoft
durabletask-pythonhttps://github.com/microsoft/durabletask-python
Codehttps://github.com/microsoft/durabletask-python
Issues15 (15)https://github.com/microsoft/durabletask-python/issues
Pull requests12 (12)https://github.com/microsoft/durabletask-python/pulls
Actionshttps://github.com/microsoft/durabletask-python/actions
Projectshttps://github.com/microsoft/durabletask-python/projects
Security and qualityhttps://github.com/microsoft/durabletask-python/security
Insightshttps://github.com/microsoft/durabletask-python/insights
https://github.com/microsoft/durabletask-python
New issuehttps://github.com/login?return_to=https://github.com/microsoft/durabletask-python/issues/134
New issuehttps://github.com/login?return_to=https://github.com/microsoft/durabletask-python/issues/134
#145https://github.com/microsoft/durabletask-python/pull/145
Add context manager support to TaskHubGrpcClient to prevent gRPC channel leakshttps://github.com/microsoft/durabletask-python/issues/134#top
#145https://github.com/microsoft/durabletask-python/pull/145
https://github.com/andystaples
andystapleshttps://github.com/andystaples
on Apr 14, 2026https://github.com/microsoft/durabletask-python/issues/134#issue-4263870751
Add history retrieval and terminal instance ID paging APIs #133https://github.com/microsoft/durabletask-python/pull/133
https://github.com/berndverst
Bernd Verst (berndverst)https://github.com/berndverst
on May 26, 2026https://github.com/microsoft/durabletask-python/issues/134#issuecomment-4547252364
Bernd Verst (@berndverst)https://github.com/berndverst
#135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
#135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
#135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Add gRPC client and worker connection resiliency #135https://github.com/microsoft/durabletask-python/pull/135
Bernd Verst (berndverst)https://github.com/berndverst
completedhttps://github.com/microsoft/durabletask-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#145https://github.com/microsoft/durabletask-python/pull/145
on May 26, 2026https://github.com/microsoft/durabletask-python/issues/134#event-25984993568
andystapleshttps://github.com/andystaples
on Jun 3, 2026https://github.com/microsoft/durabletask-python/issues/134#event-26296965861
Add context manager support to TaskHubGrpcClient (microsoft#145)https://github.com/andystaples/durabletask-python/commit/1cb30b05d20cc6126127f964946b6b844d528fd5
microsoft#145https://github.com/microsoft/durabletask-python/pull/145
1cb30b0https://github.com/andystaples/durabletask-python/commit/1cb30b05d20cc6126127f964946b6b844d528fd5
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/durabletask-python/issues/134
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/durabletask-python/issues/134
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.