René's URL Explorer Experiment


Title: Remove obsolete warning disables from base_macros.h by DanielJump · Pull Request #1625 · microsoft/cppwinrt · GitHub

Open Graph Title: Remove obsolete warning disables from base_macros.h by DanielJump · Pull Request #1625 · microsoft/cppwinrt

X Title: Remove obsolete warning disables from base_macros.h by DanielJump · Pull Request #1625 · microsoft/cppwinrt

Description: C++/WinRT. Contribute to microsoft/cppwinrt development by creating an account on GitHub.

Open Graph Description: Fixes #1624. base_macros.h globally disables C5046, C4268, C4499 and C4630, so every translation unit that includes <winrt/base.h> also loses those diagnostics in its own code. The first two ...

X Description: Fixes #1624. base_macros.h globally disables C5046, C4268, C4499 and C4630, so every translation unit that includes &lt;winrt/base.h&gt; also loses those diagnostics in its own code. The fi...

Opengraph URL: https://github.com/microsoft/cppwinrt/pull/1625

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5335bb39-6e3b-548e-28c0-22806ccf5094
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD588:7F150:2400D53:2FD3F88:6B0052FA
html-safe-noncec4d40220d7608d20ee2c3afbf241fccd15bb95bf8e5b2ee52258065c8734ac53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTg4OjdGMTUwOjI0MDBENTM6MkZEM0Y4ODo2QjAwNTJGQSIsInZpc2l0b3JfaWQiOiI3NDYzNDg0NjEzMzExMDkxNDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace2e7894468e395d514566c7f1413140e8e9c69d01550b2c1615ceb22198358a8
hovercard-subject-tagpull_request:4416251506
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1625/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/86d1a1d16dfbe0b4c70793a52bcf22057430054718c707d97f875ea1116370c4/microsoft/cppwinrt/pull/1625
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86d1a1d16dfbe0b4c70793a52bcf22057430054718c707d97f875ea1116370c4/microsoft/cppwinrt/pull/1625
og:image:altFixes #1624. base_macros.h globally disables C5046, C4268, C4499 and C4630, so every translation unit that includes <winrt/base.h> also loses those diagnostics in its own code. The first two ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielJump
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id68223326
octolytics-dimension-repository_nwomicrosoft/cppwinrt
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68223326
octolytics-dimension-repository_network_root_nwomicrosoft/cppwinrt
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/cppwinrt/pull/1625#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1625
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1625
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt
Reloadhttps://github.com/microsoft/cppwinrt/pull/1625
Reloadhttps://github.com/microsoft/cppwinrt/pull/1625
Reloadhttps://github.com/microsoft/cppwinrt/pull/1625
microsofthttps://github.com/microsoft
cppwinrthttps://github.com/microsoft/cppwinrt
Codehttps://github.com/microsoft/cppwinrt
Issues16 (16)https://github.com/microsoft/cppwinrt/issues
Pull requests37 (37)https://github.com/microsoft/cppwinrt/pulls
Discussionshttps://github.com/microsoft/cppwinrt/discussions
Actionshttps://github.com/microsoft/cppwinrt/actions
Security and qualityhttps://github.com/microsoft/cppwinrt/security
Insightshttps://github.com/microsoft/cppwinrt/insights
https://github.com/microsoft/cppwinrt
Daniel Jump (DanielJump)https://github.com/DanielJump
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
DanielJump:warnings-macro-pragma-leakhttps://github.com/DanielJump/cppwinrt/tree/warnings-macro-pragma-leak
Conversationhttps://github.com/microsoft/cppwinrt/pull/1625
Commits3 (3)https://github.com/microsoft/cppwinrt/pull/1625/commits
Checkshttps://github.com/microsoft/cppwinrt/pull/1625/checks
Files changedhttps://github.com/microsoft/cppwinrt/pull/1625/files
Remove obsolete warning disables from base_macros.hhttps://github.com/microsoft/cppwinrt/pull/1625#top
Daniel Jump (DanielJump)https://github.com/DanielJump
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
DanielJump:warnings-macro-pragma-leakhttps://github.com/DanielJump/cppwinrt/tree/warnings-macro-pragma-leak
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 1, 2026https://github.com/microsoft/cppwinrt/pull/1625#issue-5316754080
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
#1624https://github.com/microsoft/cppwinrt/issues/1624
https://learn.microsoft.com/cpp/build/reference/compiler-option-warning-levelhttps://learn.microsoft.com/cpp/build/reference/compiler-option-warning-level
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/DanielJump
Scope the base_macros.h warning disables to base.hhttps://github.com/microsoft/cppwinrt/pull/1625/commits/a3eeef792ee832445e8ca0b3ce02fa7c1e44d3ca
a3eeef7https://github.com/microsoft/cppwinrt/pull/1625/commits/a3eeef792ee832445e8ca0b3ce02fa7c1e44d3ca
Bug: headers cannot be compiled at high warning levels (MSVC /Wall, clang) #1620 https://github.com/microsoft/cppwinrt/issues/1620
base_macros.h disables warnings without push/pop, leaking them into consumer translation units #1624 https://github.com/microsoft/cppwinrt/issues/1624
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Copilothttps://github.com/apps/copilot-pull-request-reviewer
September 3, 2026 19:44https://github.com/microsoft/cppwinrt/pull/1625#event-30512391539
started reviewinghttps://github.com/microsoft/cppwinrt/sessions/c8c8824c-bf65-41ce-b39d-7807e5147748
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
September 3, 2026 19:45https://github.com/microsoft/cppwinrt/pull/1625#event-30512436056
View session https://github.com/microsoft/cppwinrt/sessions/c8c8824c-bf65-41ce-b39d-7807e5147748
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Sep 3, 2026 https://github.com/microsoft/cppwinrt/pull/1625#pullrequestreview-5106141718
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1625/files/a3eeef792ee832445e8ca0b3ce02fa7c1e44d3ca
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cppwinrt/pull/1625#pullrequestreview-5106141718
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add a code-review agent skillhttps://github.com/microsoft/cppwinrt/new/master?filename=.github/skills/code-review/SKILL.md
Learn more in the docs.https://docs.github.com/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review?tool=webui#mcp-servers-and-agent-skills
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
strings/base_macros.hhttps://github.com/microsoft/cppwinrt/pull/1625/files/a3eeef792ee832445e8ca0b3ce02fa7c1e44d3ca#diff-fea97c123e90669041b9888cd3edee86348543e7b39d8406d811ed4fc65c5fd2
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/sylveon
Charles Milette (sylveon)https://github.com/sylveon
Sep 6, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5562171470
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/YexuanXiao
Yexuan Xiao (YexuanXiao)https://github.com/YexuanXiao
Sep 6, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5562245681
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
Daniel Jump (DanielJump)https://github.com/DanielJump
September 7, 2026 08:47https://github.com/microsoft/cppwinrt/pull/1625#commits-pushed-bd4b70c
https://github.com/DanielJump
https://github.com/apps/copilot-pull-request-reviewer
Clean up comments in base_macros.hhttps://github.com/microsoft/cppwinrt/pull/1625/commits/bd4b70c40e85e28cf09b4954e9d58802ce9b0cfc
bd4b70chttps://github.com/microsoft/cppwinrt/pull/1625/commits/bd4b70c40e85e28cf09b4954e9d58802ce9b0cfc
https://github.com/DanielJump
Remove obsolete base macro warning disableshttps://github.com/microsoft/cppwinrt/pull/1625/commits/640e8d4e338c94c05be333b86b3ef223b5214d9f
640e8d4https://github.com/microsoft/cppwinrt/pull/1625/commits/640e8d4e338c94c05be333b86b3ef223b5214d9f
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 7, 2026https://github.com/microsoft/cppwinrt/pull/1625#event-30705396214
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 7, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5573697569
Charles Milette (@sylveon)https://github.com/sylveon
Yexuan Xiao (@YexuanXiao)https://github.com/YexuanXiao
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 7, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5573875372
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/YexuanXiao
Yexuan Xiao (YexuanXiao)https://github.com/YexuanXiao
Sep 7, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5573941671
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/YexuanXiao
Yexuan Xiao (YexuanXiao)https://github.com/YexuanXiao
Sep 7, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5574041908
https://godbolt.org/z/jajMTveT5https://godbolt.org/z/jajMTveT5
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 8, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-5589630821
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Copilothttps://github.com/apps/copilot-pull-request-reviewer
October 29, 2026 18:02https://github.com/microsoft/cppwinrt/pull/1625#event-34617357022
started reviewinghttps://github.com/microsoft/cppwinrt/sessions/b54b6e54-13ab-4cb4-993c-f2d070a55c78
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
October 29, 2026 18:02https://github.com/microsoft/cppwinrt/pull/1625#event-34617407331
View session https://github.com/microsoft/cppwinrt/sessions/b54b6e54-13ab-4cb4-993c-f2d070a55c78
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Oct 29, 2026 https://github.com/microsoft/cppwinrt/pull/1625#pullrequestreview-5702620189
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1625/files/640e8d4e338c94c05be333b86b3ef223b5214d9f
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cppwinrt/pull/1625#pullrequestreview-5702620189
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
The new comment implies every including file opens a matching #pragma warning(push) and pops it…https://github.com/microsoft/cppwinrt/pull/1625#discussion_r3928123935
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Oct 30, 2026 https://github.com/microsoft/cppwinrt/pull/1625#ref-pullrequest-6102488070
Enable all warnings for cppwinrt CI #1640 https://github.com/microsoft/cppwinrt/pull/1640
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Nov 5, 2026https://github.com/microsoft/cppwinrt/pull/1625#issuecomment-6665524623
Daniel Jump (@DanielJump)https://github.com/DanielJump
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.co/hiddenchars
https://github.com/microsoft/cppwinrt/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1625
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/microsoft/cppwinrt/pull/1625/files/640e8d4e338c94c05be333b86b3ef223b5214d9f
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
base_macros.h disables warnings without push/pop, leaking them into consumer translation units https://github.com/microsoft/cppwinrt/issues/1624
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1625
https://github.com/DanielJump
https://github.com/sylveon
https://github.com/YexuanXiao
https://github.com/DefaultRyan
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.