René's URL Explorer Experiment


Title: Suppress non-virtual destructor warnings in the generated headers by DanielJump · Pull Request #1623 · microsoft/cppwinrt · GitHub

Open Graph Title: Suppress non-virtual destructor warnings in the generated headers by DanielJump · Pull Request #1623 · microsoft/cppwinrt

X Title: Suppress non-virtual destructor warnings in the generated headers by DanielJump · Pull Request #1623 · microsoft/cppwinrt

Description: C++/WinRT. Contribute to microsoft/cppwinrt development by creating an account on GitHub.

Open Graph Description: Part of #1620. -Wnon-virtual-dtor (clang) and C4265/C5204 (MSVC) fire on the ABI interface structs, the delegate structs, and the produce<D, I> vtable adapters. That is about 200 warnings in ...

X Description: Part of #1620. -Wnon-virtual-dtor (clang) and C4265/C5204 (MSVC) fire on the ABI interface structs, the delegate structs, and the produce&lt;D, I&gt; vtable adapters. That is about 200 warn...

Opengraph URL: https://github.com/microsoft/cppwinrt/pull/1623

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0e04d311-a657-c50d-28ed-63cb586f92f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA10:3E987B:C7B1CE:10C1787:6B0052F1
html-safe-nonceb477a208007e160fefcc0266dbef5b4935e72c9f9aea9f6a7fe9ce30dc4d7a63
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTEwOjNFOTg3QjpDN0IxQ0U6MTBDMTc4Nzo2QjAwNTJGMSIsInZpc2l0b3JfaWQiOiI0MjU4NzA5NTgzMzE0MzA5ODc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac986a9febe29657123c593be118b1266d7007b9733d569075f172cf20b972c671
hovercard-subject-tagpull_request:4414054482
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1623/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cbd1fbdbab012fe7ad797d2dd7d5ce4fad8090486e5143fdf5fd2ebf00a7230d/microsoft/cppwinrt/pull/1623
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cbd1fbdbab012fe7ad797d2dd7d5ce4fad8090486e5143fdf5fd2ebf00a7230d/microsoft/cppwinrt/pull/1623
og:image:altPart of #1620. -Wnon-virtual-dtor (clang) and C4265/C5204 (MSVC) fire on the ABI interface structs, the delegate structs, and the produce<D, I> vtable adapters. That is about 200 warnings in ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielJump
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id68223326
octolytics-dimension-repository_nwomicrosoft/cppwinrt
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68223326
octolytics-dimension-repository_network_root_nwomicrosoft/cppwinrt
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/cppwinrt/pull/1623#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1623
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1623
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt
Reloadhttps://github.com/microsoft/cppwinrt/pull/1623
Reloadhttps://github.com/microsoft/cppwinrt/pull/1623
Reloadhttps://github.com/microsoft/cppwinrt/pull/1623
microsofthttps://github.com/microsoft
cppwinrthttps://github.com/microsoft/cppwinrt
Codehttps://github.com/microsoft/cppwinrt
Issues16 (16)https://github.com/microsoft/cppwinrt/issues
Pull requests37 (37)https://github.com/microsoft/cppwinrt/pulls
Discussionshttps://github.com/microsoft/cppwinrt/discussions
Actionshttps://github.com/microsoft/cppwinrt/actions
Security and qualityhttps://github.com/microsoft/cppwinrt/security
Insightshttps://github.com/microsoft/cppwinrt/insights
https://github.com/microsoft/cppwinrt
Daniel Jump (DanielJump)https://github.com/DanielJump
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
DanielJump:warnings-protected-abi-destructorshttps://github.com/DanielJump/cppwinrt/tree/warnings-protected-abi-destructors
Conversationhttps://github.com/microsoft/cppwinrt/pull/1623
Commits1 (1)https://github.com/microsoft/cppwinrt/pull/1623/commits
Checkshttps://github.com/microsoft/cppwinrt/pull/1623/checks
Files changedhttps://github.com/microsoft/cppwinrt/pull/1623/files
Suppress non-virtual destructor warnings in the generated headershttps://github.com/microsoft/cppwinrt/pull/1623#top
Daniel Jump (DanielJump)https://github.com/DanielJump
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
DanielJump:warnings-protected-abi-destructorshttps://github.com/DanielJump/cppwinrt/tree/warnings-protected-abi-destructors
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 1, 2026https://github.com/microsoft/cppwinrt/pull/1623#issue-5314146082
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
#1620https://github.com/microsoft/cppwinrt/issues/1620
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
https://github.com/sylveon
Charles Milette (sylveon)https://github.com/sylveon
Sep 1, 2026https://github.com/microsoft/cppwinrt/pull/1623#issuecomment-5497350961
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
force-pushedhttps://github.com/microsoft/cppwinrt/compare/13b4ca34c74fd32b535936af43cad10e763052eb..9aa93b22d705aa1ad569f78746d4e1beca29057c
13b4ca3https://github.com/microsoft/cppwinrt/commit/13b4ca34c74fd32b535936af43cad10e763052eb
9aa93b2https://github.com/microsoft/cppwinrt/commit/9aa93b22d705aa1ad569f78746d4e1beca29057c
Compare https://github.com/microsoft/cppwinrt/compare/13b4ca34c74fd32b535936af43cad10e763052eb..9aa93b22d705aa1ad569f78746d4e1beca29057c
September 1, 2026 19:35https://github.com/microsoft/cppwinrt/pull/1623#event-30369654823
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 1, 2026https://github.com/microsoft/cppwinrt/pull/1623#event-30369696360
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Sep 1, 2026https://github.com/microsoft/cppwinrt/pull/1623#issuecomment-5499377342
#1499https://github.com/microsoft/cppwinrt/issues/1499
#1499https://github.com/microsoft/cppwinrt/issues/1499
#1585https://github.com/microsoft/cppwinrt/issues/1585
#1621https://github.com/microsoft/cppwinrt/pull/1621
#1622https://github.com/microsoft/cppwinrt/pull/1622
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
https://github.com/DanielJump
Suppress non-virtual destructor warnings in the generated headershttps://github.com/microsoft/cppwinrt/pull/1623/commits/f38229977655d505d84497cc651c2da49af364c8
f382299https://github.com/microsoft/cppwinrt/pull/1623/commits/f38229977655d505d84497cc651c2da49af364c8
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
force-pushedhttps://github.com/microsoft/cppwinrt/compare/9aa93b22d705aa1ad569f78746d4e1beca29057c..f38229977655d505d84497cc651c2da49af364c8
9aa93b2https://github.com/microsoft/cppwinrt/commit/9aa93b22d705aa1ad569f78746d4e1beca29057c
f382299https://github.com/microsoft/cppwinrt/commit/f38229977655d505d84497cc651c2da49af364c8
Compare https://github.com/microsoft/cppwinrt/compare/9aa93b22d705aa1ad569f78746d4e1beca29057c..f38229977655d505d84497cc651c2da49af364c8
September 1, 2026 20:27https://github.com/microsoft/cppwinrt/pull/1623#event-30372370300
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
September 1, 2026 20:41https://github.com/microsoft/cppwinrt/pull/1623#event-30373129055
base_macros.h disables warnings without push/pop, leaking them into consumer translation units #1624 https://github.com/microsoft/cppwinrt/issues/1624
Bug: headers cannot be compiled at high warning levels (MSVC /Wall, clang) #1620 https://github.com/microsoft/cppwinrt/issues/1620
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Copilothttps://github.com/apps/copilot-pull-request-reviewer
October 19, 2026 20:29https://github.com/microsoft/cppwinrt/pull/1623#event-33682893821
started reviewinghttps://github.com/microsoft/cppwinrt/sessions/7c3578b9-2471-430e-8776-d6264a885f88
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
October 19, 2026 20:29https://github.com/microsoft/cppwinrt/pull/1623#event-33682943146
View session https://github.com/microsoft/cppwinrt/sessions/7c3578b9-2471-430e-8776-d6264a885f88
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Oct 19, 2026 https://github.com/microsoft/cppwinrt/pull/1623#pullrequestreview-5577388048
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1623/files/f38229977655d505d84497cc651c2da49af364c8
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cppwinrt/pull/1623#pullrequestreview-5577388048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Namespace headers leave diagnostic pragmas unbalanced under WINRT_IMPORT_MODULEhttps://github.com/microsoft/cppwinrt/pull/1623#discussion_r4318557123
#1620https://github.com/microsoft/cppwinrt/issues/1620
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
cppwinrt/code_writers.hhttps://github.com/microsoft/cppwinrt/pull/1623/files/f38229977655d505d84497cc651c2da49af364c8#diff-dc5eb6a56812668d9c451d63ce9191f1468b5386f98dd655b10242b5a18e10b1
https://github.com/DanielJump
Daniel Jump (DanielJump)https://github.com/DanielJump
Oct 30, 2026 https://github.com/microsoft/cppwinrt/pull/1623#ref-pullrequest-6102488070
Enable all warnings for cppwinrt CI #1640 https://github.com/microsoft/cppwinrt/pull/1640
https://github.co/hiddenchars
https://github.com/microsoft/cppwinrt/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1623
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/microsoft/cppwinrt/pull/1623/files/f38229977655d505d84497cc651c2da49af364c8
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1623
https://github.com/DanielJump
https://github.com/sylveon
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.