| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0e04d311-a657-c50d-28ed-63cb586f92f0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA10:3E987B:C7B1CE:10C1787:6B0052F1 |
| html-safe-nonce | b477a208007e160fefcc0266dbef5b4935e72c9f9aea9f6a7fe9ce30dc4d7a63 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTEwOjNFOTg3QjpDN0IxQ0U6MTBDMTc4Nzo2QjAwNTJGMSIsInZpc2l0b3JfaWQiOiI0MjU4NzA5NTgzMzE0MzA5ODc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 986a9febe29657123c593be118b1266d7007b9733d569075f172cf20b972c671 |
| hovercard-subject-tag | pull_request:4414054482 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1623/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cbd1fbdbab012fe7ad797d2dd7d5ce4fad8090486e5143fdf5fd2ebf00a7230d/microsoft/cppwinrt/pull/1623 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cbd1fbdbab012fe7ad797d2dd7d5ce4fad8090486e5143fdf5fd2ebf00a7230d/microsoft/cppwinrt/pull/1623 |
| og:image:alt | Part of #1620.
-Wnon-virtual-dtor (clang) and C4265/C5204 (MSVC) fire on the ABI interface structs, the
delegate structs, and the produce<D, I> vtable adapters. That is about 200 warnings in ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielJump |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 68223326 |
| octolytics-dimension-repository_nwo | microsoft/cppwinrt |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68223326 |
| octolytics-dimension-repository_network_root_nwo | microsoft/cppwinrt |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/cppwinrt/pull/1623#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1623 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1623 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt |
| Reload | https://github.com/microsoft/cppwinrt/pull/1623 |
| Reload | https://github.com/microsoft/cppwinrt/pull/1623 |
| Reload | https://github.com/microsoft/cppwinrt/pull/1623 |
| microsoft | https://github.com/microsoft |
| cppwinrt | https://github.com/microsoft/cppwinrt |
| Code | https://github.com/microsoft/cppwinrt |
| Issues16 (16) | https://github.com/microsoft/cppwinrt/issues |
| Pull requests37 (37) | https://github.com/microsoft/cppwinrt/pulls |
| Discussions | https://github.com/microsoft/cppwinrt/discussions |
| Actions | https://github.com/microsoft/cppwinrt/actions |
| Security and quality | https://github.com/microsoft/cppwinrt/security |
| Insights | https://github.com/microsoft/cppwinrt/insights |
| https://github.com/microsoft/cppwinrt |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| microsoft:master | https://github.com/microsoft/cppwinrt/tree/master |
| DanielJump:warnings-protected-abi-destructors | https://github.com/DanielJump/cppwinrt/tree/warnings-protected-abi-destructors |
| Conversation | https://github.com/microsoft/cppwinrt/pull/1623 |
| Commits1 (1) | https://github.com/microsoft/cppwinrt/pull/1623/commits |
| Checks | https://github.com/microsoft/cppwinrt/pull/1623/checks |
| Files changed | https://github.com/microsoft/cppwinrt/pull/1623/files |
| Suppress non-virtual destructor warnings in the generated headers | https://github.com/microsoft/cppwinrt/pull/1623#top |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| microsoft:master | https://github.com/microsoft/cppwinrt/tree/master |
| DanielJump:warnings-protected-abi-destructors | https://github.com/DanielJump/cppwinrt/tree/warnings-protected-abi-destructors |
|
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| Sep 1, 2026 | https://github.com/microsoft/cppwinrt/pull/1623#issue-5314146082 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
| #1620 | https://github.com/microsoft/cppwinrt/issues/1620 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
| https://github.com/sylveon |
| Charles Milette (sylveon) | https://github.com/sylveon |
| Sep 1, 2026 | https://github.com/microsoft/cppwinrt/pull/1623#issuecomment-5497350961 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| force-pushed | https://github.com/microsoft/cppwinrt/compare/13b4ca34c74fd32b535936af43cad10e763052eb..9aa93b22d705aa1ad569f78746d4e1beca29057c |
| 13b4ca3 | https://github.com/microsoft/cppwinrt/commit/13b4ca34c74fd32b535936af43cad10e763052eb |
| 9aa93b2 | https://github.com/microsoft/cppwinrt/commit/9aa93b22d705aa1ad569f78746d4e1beca29057c |
|
Compare
| https://github.com/microsoft/cppwinrt/compare/13b4ca34c74fd32b535936af43cad10e763052eb..9aa93b22d705aa1ad569f78746d4e1beca29057c |
| September 1, 2026 19:35 | https://github.com/microsoft/cppwinrt/pull/1623#event-30369654823 |
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| Sep 1, 2026 | https://github.com/microsoft/cppwinrt/pull/1623#event-30369696360 |
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| Sep 1, 2026 | https://github.com/microsoft/cppwinrt/pull/1623#issuecomment-5499377342 |
| #1499 | https://github.com/microsoft/cppwinrt/issues/1499 |
| #1499 | https://github.com/microsoft/cppwinrt/issues/1499 |
| #1585 | https://github.com/microsoft/cppwinrt/issues/1585 |
| #1621 | https://github.com/microsoft/cppwinrt/pull/1621 |
| #1622 | https://github.com/microsoft/cppwinrt/pull/1622 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
|
| https://github.com/DanielJump |
| Suppress non-virtual destructor warnings in the generated headers | https://github.com/microsoft/cppwinrt/pull/1623/commits/f38229977655d505d84497cc651c2da49af364c8 |
| f382299 | https://github.com/microsoft/cppwinrt/pull/1623/commits/f38229977655d505d84497cc651c2da49af364c8 |
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| force-pushed | https://github.com/microsoft/cppwinrt/compare/9aa93b22d705aa1ad569f78746d4e1beca29057c..f38229977655d505d84497cc651c2da49af364c8 |
| 9aa93b2 | https://github.com/microsoft/cppwinrt/commit/9aa93b22d705aa1ad569f78746d4e1beca29057c |
| f382299 | https://github.com/microsoft/cppwinrt/commit/f38229977655d505d84497cc651c2da49af364c8 |
|
Compare
| https://github.com/microsoft/cppwinrt/compare/9aa93b22d705aa1ad569f78746d4e1beca29057c..f38229977655d505d84497cc651c2da49af364c8 |
| September 1, 2026 20:27 | https://github.com/microsoft/cppwinrt/pull/1623#event-30372370300 |
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
| September 1, 2026 20:41 | https://github.com/microsoft/cppwinrt/pull/1623#event-30373129055 |
|
base_macros.h disables warnings without push/pop, leaking them into consumer translation units
#1624
| https://github.com/microsoft/cppwinrt/issues/1624 |
|
Bug: headers cannot be compiled at high warning levels (MSVC /Wall, clang)
#1620
| https://github.com/microsoft/cppwinrt/issues/1620 |
| https://github.com/DefaultRyan |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| October 19, 2026 20:29 | https://github.com/microsoft/cppwinrt/pull/1623#event-33682893821 |
| started reviewing | https://github.com/microsoft/cppwinrt/sessions/7c3578b9-2471-430e-8776-d6264a885f88 |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
| October 19, 2026 20:29 | https://github.com/microsoft/cppwinrt/pull/1623#event-33682943146 |
|
View session
| https://github.com/microsoft/cppwinrt/sessions/7c3578b9-2471-430e-8776-d6264a885f88 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Oct 19, 2026
| https://github.com/microsoft/cppwinrt/pull/1623#pullrequestreview-5577388048 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1623/files/f38229977655d505d84497cc651c2da49af364c8 |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/microsoft/cppwinrt/pull/1623#pullrequestreview-5577388048 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Namespace headers leave diagnostic pragmas unbalanced under WINRT_IMPORT_MODULE | https://github.com/microsoft/cppwinrt/pull/1623#discussion_r4318557123 |
| #1620 | https://github.com/microsoft/cppwinrt/issues/1620 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
| cppwinrt/code_writers.h | https://github.com/microsoft/cppwinrt/pull/1623/files/f38229977655d505d84497cc651c2da49af364c8#diff-dc5eb6a56812668d9c451d63ce9191f1468b5386f98dd655b10242b5a18e10b1 |
| https://github.com/DanielJump |
| Daniel Jump (DanielJump) | https://github.com/DanielJump |
|
Oct 30, 2026
| https://github.com/microsoft/cppwinrt/pull/1623#ref-pullrequest-6102488070 |
|
Enable all warnings for cppwinrt CI
#1640
| https://github.com/microsoft/cppwinrt/pull/1640 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/cppwinrt/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1623 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/microsoft/cppwinrt/pull/1623/files/f38229977655d505d84497cc651c2da49af364c8 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1623 |
|
| https://github.com/DanielJump |
|
| https://github.com/sylveon |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |