René's URL Explorer Experiment


Title: Fix race conditions in cancellable_promise by Clyraz · Pull Request #1599 · microsoft/cppwinrt · GitHub

Open Graph Title: Fix race conditions in cancellable_promise by Clyraz · Pull Request #1599 · microsoft/cppwinrt

X Title: Fix race conditions in cancellable_promise by Clyraz · Pull Request #1599 · microsoft/cppwinrt

Description: C++/WinRT. Contribute to microsoft/cppwinrt development by creating an account on GitHub.

Open Graph Description: The check in the revoke_canceller() method always succeeded on the second attempt, which led to segmentation faults if the cancellation callback ran for an extended period of time.

X Description: The check in the revoke_canceller() method always succeeded on the second attempt, which led to segmentation faults if the cancellation callback ran for an extended period of time.

Opengraph URL: https://github.com/microsoft/cppwinrt/pull/1599

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:072a7910-e883-610e-ef8c-b850df45dd93
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CE4:3CF916:2E7EF2:40EA19:6B005BFD
html-safe-nonced26b1b6d19504b643b1971ad93d43c5e8e08cf55c3003ad93605ada7258da807
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0U0OjNDRjkxNjoyRTdFRjI6NDBFQTE5OjZCMDA1QkZEIiwidmlzaXRvcl9pZCI6IjU4MDY1MzA1MjAyMTcwNTAxMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9288c913a0ef0900ea7922f2d641b8d67da0525d3bcac052b9685fef6f67c2e9
hovercard-subject-tagpull_request:3883174059
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1599/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57ceac2f271970ebb458c3ad6f944afa0084fb88cc67c53ea2f2db110fd44d63/microsoft/cppwinrt/pull/1599
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57ceac2f271970ebb458c3ad6f944afa0084fb88cc67c53ea2f2db110fd44d63/microsoft/cppwinrt/pull/1599
og:image:altThe check in the revoke_canceller() method always succeeded on the second attempt, which led to segmentation faults if the cancellation callback ran for an extended period of time.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameClyraz
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-cache
go-importgithub.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id68223326
octolytics-dimension-repository_nwomicrosoft/cppwinrt
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68223326
octolytics-dimension-repository_network_root_nwomicrosoft/cppwinrt
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/cppwinrt/pull/1599#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1599
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1599
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt
Reloadhttps://github.com/microsoft/cppwinrt/pull/1599
Reloadhttps://github.com/microsoft/cppwinrt/pull/1599
Reloadhttps://github.com/microsoft/cppwinrt/pull/1599
microsofthttps://github.com/microsoft
cppwinrthttps://github.com/microsoft/cppwinrt
Codehttps://github.com/microsoft/cppwinrt
Issues16 (16)https://github.com/microsoft/cppwinrt/issues
Pull requests37 (37)https://github.com/microsoft/cppwinrt/pulls
Discussionshttps://github.com/microsoft/cppwinrt/discussions
Actionshttps://github.com/microsoft/cppwinrt/actions
Security and qualityhttps://github.com/microsoft/cppwinrt/security
Insightshttps://github.com/microsoft/cppwinrt/insights
https://github.com/microsoft/cppwinrt
Clyrazhttps://github.com/Clyraz
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
Clyraz:cancellable_promise-fixhttps://github.com/Clyraz/cppwinrt/tree/cancellable_promise-fix
Conversationhttps://github.com/microsoft/cppwinrt/pull/1599
Commits3 (3)https://github.com/microsoft/cppwinrt/pull/1599/commits
Checkshttps://github.com/microsoft/cppwinrt/pull/1599/checks
Files changedhttps://github.com/microsoft/cppwinrt/pull/1599/files
Fix race conditions in cancellable_promisehttps://github.com/microsoft/cppwinrt/pull/1599#top
Clyrazhttps://github.com/Clyraz
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
Clyraz:cancellable_promise-fixhttps://github.com/Clyraz/cppwinrt/tree/cancellable_promise-fix
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
Jun 17, 2026https://github.com/microsoft/cppwinrt/pull/1599#issue-4682933460
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1599
https://github.com/Clyraz
Fix race conditions in cancellable_promisehttps://github.com/microsoft/cppwinrt/pull/1599/commits/14a1c7511b3081979084b5d78bbbf3f171466490
14a1c75https://github.com/microsoft/cppwinrt/pull/1599/commits/14a1c7511b3081979084b5d78bbbf3f171466490
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
June 18, 2026 18:30https://github.com/microsoft/cppwinrt/pull/1599#event-26925929417
https://github.com/Clyraz
Properly revoke cancellerhttps://github.com/microsoft/cppwinrt/pull/1599/commits/0031352e93f1d442d1ffeef97de79d90968178be
0031352https://github.com/microsoft/cppwinrt/pull/1599/commits/0031352e93f1d442d1ffeef97de79d90968178be
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
June 18, 2026 19:25https://github.com/microsoft/cppwinrt/pull/1599#event-26927897156
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
Jun 18, 2026https://github.com/microsoft/cppwinrt/pull/1599#issuecomment-4745444188
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1599
https://github.com/Clyraz
Format changeshttps://github.com/microsoft/cppwinrt/pull/1599/commits/f0bb08aef49e2f9ceaf76f632b4e7bfd0fdc3067
f0bb08ahttps://github.com/microsoft/cppwinrt/pull/1599/commits/f0bb08aef49e2f9ceaf76f632b4e7bfd0fdc3067
https://github.com/oldnewthing
Raymond Chen (oldnewthing)https://github.com/oldnewthing
Jul 22, 2026 https://github.com/microsoft/cppwinrt/pull/1599#ref-pullrequest-4945551387
Fix race condition in cancellation setup/teardown #1609 https://github.com/microsoft/cppwinrt/pull/1609
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Jul 22, 2026 https://github.com/microsoft/cppwinrt/pull/1599#pullrequestreview-4751323279
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1599/files/f0bb08aef49e2f9ceaf76f632b4e7bfd0fdc3067
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
https://github.com/microsoft/cppwinrt/pull/1599#pullrequestreview-4751323279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1599
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
Jul 22, 2026https://github.com/microsoft/cppwinrt/pull/1599#issuecomment-5045067662
#1609https://github.com/microsoft/cppwinrt/pull/1609
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1599
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
Jul 22, 2026https://github.com/microsoft/cppwinrt/pull/1599#event-28321879031
https://github.com/Clyraz
Clyrazhttps://github.com/Clyraz
July 22, 2026 15:14https://github.com/microsoft/cppwinrt/pull/1599#event-28333825742
https://github.co/hiddenchars
https://github.com/microsoft/cppwinrt/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1599
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak) https://github.com/ChrisGuzak
https://github.com/microsoft/cppwinrt/pull/1599/files/f0bb08aef49e2f9ceaf76f632b4e7bfd0fdc3067
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1599
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1599
https://github.com/Clyraz
https://github.com/ChrisGuzak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.