| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:41eea5c6-68eb-e230-39f2-eea4bb19ca37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 919C:3CF916:162F24:1EBE3D:6B0055A0 |
| html-safe-nonce | e9ec9a0979dc83a8f47a7b8f6414ba8f9f692c6a4b7928595b523376f8739f99 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTlDOjNDRjkxNjoxNjJGMjQ6MUVCRTNEOjZCMDA1NUEwIiwidmlzaXRvcl9pZCI6IjEyNjM4MDY2MjI3MDMwNDgwOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2da2cae9340818cdcc92582212729c1159b8cb00e983d2fc8c634133ab0c54e9 |
| hovercard-subject-tag | pull_request:2837921156 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1512/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/256de13fd4631790174ebea9d7c23c6245ed488b0e28dff1a429efc6016042bc/microsoft/cppwinrt/pull/1512 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/256de13fd4631790174ebea9d7c23c6245ed488b0e28dff1a429efc6016042bc/microsoft/cppwinrt/pull/1512 |
| og:image:alt | Fixes: #1511 #1376
TL;DR:
We are removing RoOriginate from the default winrt implementations of Map/MapView::Lookup, which improves TryLookup performance in the case of a key missing from the Map/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | antmor |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 68223326 |
| octolytics-dimension-repository_nwo | microsoft/cppwinrt |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68223326 |
| octolytics-dimension-repository_network_root_nwo | microsoft/cppwinrt |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/cppwinrt/pull/1512#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1512 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1512 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt |
| Reload | https://github.com/microsoft/cppwinrt/pull/1512 |
| Reload | https://github.com/microsoft/cppwinrt/pull/1512 |
| Reload | https://github.com/microsoft/cppwinrt/pull/1512 |
| microsoft | https://github.com/microsoft |
| cppwinrt | https://github.com/microsoft/cppwinrt |
| Code | https://github.com/microsoft/cppwinrt |
| Issues16 (16) | https://github.com/microsoft/cppwinrt/issues |
| Pull requests37 (37) | https://github.com/microsoft/cppwinrt/pulls |
| Discussions | https://github.com/microsoft/cppwinrt/discussions |
| Actions | https://github.com/microsoft/cppwinrt/actions |
| Security and quality | https://github.com/microsoft/cppwinrt/security |
| Insights | https://github.com/microsoft/cppwinrt/insights |
| https://github.com/microsoft/cppwinrt |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
| microsoft:master | https://github.com/microsoft/cppwinrt/tree/master |
| antmor:user/antmor/non_originating | https://github.com/antmor/cppwinrt/tree/user/antmor/non_originating |
| Conversation | https://github.com/microsoft/cppwinrt/pull/1512 |
| Commits21 (21) | https://github.com/microsoft/cppwinrt/pull/1512/commits |
| Checks | https://github.com/microsoft/cppwinrt/pull/1512/checks |
| Files changed | https://github.com/microsoft/cppwinrt/pull/1512/files |
| Remove throwing/originating errors in expected scenarios (Lookup/TryLookup and Cancel) | https://github.com/microsoft/cppwinrt/pull/1512#top |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
| microsoft:master | https://github.com/microsoft/cppwinrt/tree/master |
| antmor:user/antmor/non_originating | https://github.com/antmor/cppwinrt/tree/user/antmor/non_originating |
|
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Sep 17, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#issue-3427752082 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| #1511 | https://github.com/microsoft/cppwinrt/issues/1511 |
| #1376 | https://github.com/microsoft/cppwinrt/issues/1376 |
| https://private-user-images.githubusercontent.com/43587397/490765158-7b50ac9e-56a5-4f12-a502-8f55b37da64e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUxODQzMzIsIm5iZiI6MTc5NTE4NDAzMiwicGF0aCI6Ii80MzU4NzM5Ny80OTA3NjUxNTgtN2I1MGFjOWUtNTZhNS00ZjEyLWE1MDItOGY1NWIzN2RhNjRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIwVDE0MTM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkMWFkZGZmODg5ODc2YjNhMzUxYzcwN2UzM2FlZGQ1OTU4NjkwNWIyMjEyY2Q1ODQxMzI0MjA1MzVkZDg4NTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.eWohpJaUKXQ-oVsJvkDAkEZkmtfDslQPDOaQb-VQhYo |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| antmor | https://github.com/antmor |
| December 13, 2023 17:53 | https://github.com/microsoft/cppwinrt/pull/1512#commits-pushed-472e8d4 |
|
| https://github.com/antmor |
| non-originating error compiles | https://github.com/microsoft/cppwinrt/pull/1512/commits/472e8d4b2590cdbcda361695be4efb8f4c41e3aa |
| 472e8d4 | https://github.com/microsoft/cppwinrt/pull/1512/commits/472e8d4b2590cdbcda361695be4efb8f4c41e3aa |
|
| https://github.com/antmor |
| fix with test cases | https://github.com/microsoft/cppwinrt/pull/1512/commits/e358b9296d28b082ef14c14d13afdb0f23e502fd |
| e358b92 | https://github.com/microsoft/cppwinrt/pull/1512/commits/e358b9296d28b082ef14c14d13afdb0f23e502fd |
|
| https://github.com/antmor |
| and remove ignore | https://github.com/microsoft/cppwinrt/pull/1512/commits/a6ab125ae921dfd1fc9e98764cdf5b8ffe824625 |
| a6ab125 | https://github.com/microsoft/cppwinrt/pull/1512/commits/a6ab125ae921dfd1fc9e98764cdf5b8ffe824625 |
|
| https://github.com/antmor |
| add runsettings to run tests from visual studio tester, modified read… | https://github.com/microsoft/cppwinrt/pull/1512/commits/cefa5fa191b00c8eae228b1c512d4a590d740a57 |
| cefa5fa | https://github.com/microsoft/cppwinrt/pull/1512/commits/cefa5fa191b00c8eae228b1c512d4a590d740a57 |
|
| https://github.com/antmor |
| change map shouldOriginate to template parameter. Note, could be a br… | https://github.com/microsoft/cppwinrt/pull/1512/commits/a66ecd3099d3cf25bf0112c89e5d34f55fa637f3 |
| a66ecd3 | https://github.com/microsoft/cppwinrt/pull/1512/commits/a66ecd3099d3cf25bf0112c89e5d34f55fa637f3 |
|
| https://github.com/antmor |
| settle on avoid_originate as naming scheme | https://github.com/microsoft/cppwinrt/pull/1512/commits/3972237dd4052d4f62c57c7ec09f382a368237bd |
| 3972237 | https://github.com/microsoft/cppwinrt/pull/1512/commits/3972237dd4052d4f62c57c7ec09f382a368237bd |
|
| https://github.com/antmor |
| fix errors, more merging | https://github.com/microsoft/cppwinrt/pull/1512/commits/72689dadc2b989aee1f269cc2878d3e4890b5207 |
| 72689da | https://github.com/microsoft/cppwinrt/pull/1512/commits/72689dadc2b989aee1f269cc2878d3e4890b5207 |
|
| https://github.com/antmor |
| Merge branch 'microsoft-master' into user/antmor/non_originating | https://github.com/microsoft/cppwinrt/pull/1512/commits/815d734546144ac7d92b9289e27839c9b55cf1b9 |
| 815d734 | https://github.com/microsoft/cppwinrt/pull/1512/commits/815d734546144ac7d92b9289e27839c9b55cf1b9 |
|
| https://github.com/antmor |
| add a printf only to Lookup so we can add SFINAE or something like that. | https://github.com/microsoft/cppwinrt/pull/1512/commits/dd18558bbd253ca6939c120cc4de49a9aaa33475 |
| dd18558 | https://github.com/microsoft/cppwinrt/pull/1512/commits/dd18558bbd253ca6939c120cc4de49a9aaa33475 |
|
| https://github.com/antmor |
| weird templating magic required... still not working, has error | https://github.com/microsoft/cppwinrt/pull/1512/commits/0dfa235d519c4020c5624669c6f380a20738ef52 |
| 0dfa235 | https://github.com/microsoft/cppwinrt/pull/1512/commits/0dfa235d519c4020c5624669c6f380a20738ef52 |
|
| https://github.com/antmor |
| trylookup exists to avoid throwing an error, and let's avoid avoid_or… | https://github.com/microsoft/cppwinrt/pull/1512/commits/3f448142889800773b079a05138b2a3fa3ba1b7c |
| 3f44814 | https://github.com/microsoft/cppwinrt/pull/1512/commits/3f448142889800773b079a05138b2a3fa3ba1b7c |
|
| https://github.com/antmor |
| remove test. | https://github.com/microsoft/cppwinrt/pull/1512/commits/cfaa2a6de3483b499e29a5ee898e7f1549555e40 |
| cfaa2a6 | https://github.com/microsoft/cppwinrt/pull/1512/commits/cfaa2a6de3483b499e29a5ee898e7f1549555e40 |
| https://github.com/ChrisGuzak |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
|
Sep 17, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#ref-issue-3427369983 |
|
Bug:map_view_base Lookup failure case is several orders slower due to C++ exceptions
#1511
| https://github.com/microsoft/cppwinrt/issues/1511 |
|
| https://github.com/antmor |
| cleaned up and correctness. | https://github.com/microsoft/cppwinrt/pull/1512/commits/e69a7fe1dea8649d3bacfc08fe8413b00098e302 |
| e69a7fe | https://github.com/microsoft/cppwinrt/pull/1512/commits/e69a7fe1dea8649d3bacfc08fe8413b00098e302 |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| September 17, 2025 23:22 | https://github.com/microsoft/cppwinrt/pull/1512#event-19761311078 |
|
| https://github.com/antmor |
| undo changes to untouched files | https://github.com/microsoft/cppwinrt/pull/1512/commits/7051f24ffbf8e8bd9b58583c0cf564258b86157e |
| 7051f24 | https://github.com/microsoft/cppwinrt/pull/1512/commits/7051f24ffbf8e8bd9b58583c0cf564258b86157e |
| https://github.com/jonwis |
| Jon Wiswall (jonwis) | https://github.com/jonwis |
|
Sep 18, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3237414635 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e |
| Jon Wiswall (jonwis) | https://github.com/jonwis |
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3237414635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_collections_base.h | https://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e#diff-afa6c767046750490bd0b5bcc56d42cfbc13b9ce786a510d8143bd7b4c6fc9e8 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_error.h | https://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_meta.h | https://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
|
| https://github.com/antmor |
| spacing changes , change do declval. | https://github.com/microsoft/cppwinrt/pull/1512/commits/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7 |
| 7b0072a | https://github.com/microsoft/cppwinrt/pull/1512/commits/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7 |
| https://github.com/jonwis |
| Jon Wiswall (jonwis) | https://github.com/jonwis |
|
Sep 18, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3242219734 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7 |
| https://github.com/dmachaj |
| David Machaj (dmachaj) | https://github.com/dmachaj |
|
Sep 18, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3242359946 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7 |
| strings/base_error.h | https://github.com/microsoft/cppwinrt/pull/1512/files/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
|
| https://github.com/antmor |
| added special tag to parameter list to make sure not to break existin… | https://github.com/microsoft/cppwinrt/pull/1512/commits/783413a8cbb6bf73a7625d6ca422097472824e5c |
| 783413a | https://github.com/microsoft/cppwinrt/pull/1512/commits/783413a8cbb6bf73a7625d6ca422097472824e5c |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Jon Wiswall (jonwis) | https://github.com/jonwis |
| stale review | https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3242219734 |
| 783413a | https://github.com/microsoft/cppwinrt/commit/783413a8cbb6bf73a7625d6ca422097472824e5c |
| September 19, 2025 01:27 | https://github.com/microsoft/cppwinrt/pull/1512#event-19788014243 |
|
| https://github.com/antmor |
| address avoid_oritinate comment, no need for a different name, resuse… | https://github.com/microsoft/cppwinrt/pull/1512/commits/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
| 18a57a8 | https://github.com/microsoft/cppwinrt/pull/1512/commits/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
| https://github.com/dmachaj |
| David Machaj (dmachaj) | https://github.com/dmachaj |
|
Sep 19, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3247581260 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
| strings/base_error.h | https://github.com/microsoft/cppwinrt/pull/1512/files/783413a8cbb6bf73a7625d6ca422097472824e5c..18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/jonwis |
| Jon Wiswall (jonwis) | https://github.com/jonwis |
|
Sep 22, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3255283150 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
| https://github.com/oldnewthing |
| Raymond Chen (oldnewthing) | https://github.com/oldnewthing |
| Sep 24, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#issuecomment-3329344315 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/oldnewthing |
| Raymond Chen (oldnewthing) | https://github.com/oldnewthing |
|
Sep 24, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3263483128 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
| test/old_tests/UnitTests/TryLookup.cpp | https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5279740c132557803394e5cc43fb95136462ca979883c9decd474f639ec1e391 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_meta.h | https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322 |
| Raymond Chen (oldnewthing) | https://github.com/oldnewthing |
| Sep 24, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2376194462 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| antmor | https://github.com/antmor |
| Sep 24, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2376744358 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
| Sep 25, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380054071 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| antmor | https://github.com/antmor |
| Sep 25, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380535180 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/oldnewthing |
| Raymond Chen (oldnewthing) | https://github.com/oldnewthing |
|
Sep 24, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3263496295 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
| strings/base_error.h | https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_error.h | https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92 |
| Raymond Chen (oldnewthing) | https://github.com/oldnewthing |
| Sep 24, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2376208850 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| antmor | https://github.com/antmor |
| Sep 25, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380544810 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| antmor | https://github.com/antmor |
| Sep 25, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380548213 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_coroutine_foundation.h | https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-e96e81c177f6789b25f1054f13d150144772ab4721bc47f629d7700ba4c91a11 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Sep 24, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-19899597267 |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Sep 24, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-19899636008 |
|
| https://github.com/antmor |
| change out async to a new name, with it being true by default. | https://github.com/microsoft/cppwinrt/pull/1512/commits/2ee9368732ea9d84d4036d3eb650dc2f42c0a720 |
| 2ee9368 | https://github.com/microsoft/cppwinrt/pull/1512/commits/2ee9368732ea9d84d4036d3eb650dc2f42c0a720 |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Jon Wiswall (jonwis) | https://github.com/jonwis |
| David Machaj (dmachaj) | https://github.com/dmachaj |
| 2ee9368 | https://github.com/microsoft/cppwinrt/commit/2ee9368732ea9d84d4036d3eb650dc2f42c0a720 |
| September 25, 2025 01:08 | https://github.com/microsoft/cppwinrt/pull/1512#event-19906505537 |
| https://github.com/ChrisGuzak |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
|
Sep 25, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3269076194 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720 |
| strings/base_collections_base.h | https://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720#diff-afa6c767046750490bd0b5bcc56d42cfbc13b9ce786a510d8143bd7b4c6fc9e8 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/ChrisGuzak |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
|
Sep 25, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3269084038 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720 |
| strings/base_meta.h | https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322 |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
| Sep 25, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380054071 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| strings/base_meta.h | https://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
|
| https://github.com/antmor |
| Address hresult comments by adding tests and removing source_locatoin… | https://github.com/microsoft/cppwinrt/pull/1512/commits/050fa7a994336553b57c63463ff5126a78d37abc |
| 050fa7a | https://github.com/microsoft/cppwinrt/pull/1512/commits/050fa7a994336553b57c63463ff5126a78d37abc |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
| stale review | https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3269076194 |
| 050fa7a | https://github.com/microsoft/cppwinrt/commit/050fa7a994336553b57c63463ff5126a78d37abc |
| September 26, 2025 01:28 | https://github.com/microsoft/cppwinrt/pull/1512#event-19932097810 |
| https://github.com/dmachaj |
| David Machaj (dmachaj) | https://github.com/dmachaj |
|
Oct 3, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3300491914 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 14, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#issuecomment-3399520156 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
no-pr-activity
| https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity |
| Oct 14, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-20257732983 |
| https://github.com/ChrisGuzak |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
| Oct 15, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-20282320077 |
| https://github.com/ChrisGuzak |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
|
Oct 15, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3338014954 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07 |
| https://github.com/kennykerr |
| Kenny Kerr (kennykerr) | https://github.com/kennykerr |
|
no-pr-activity
| https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity |
| Oct 15, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-20295734730 |
| https://github.com/DefaultRyan |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
|
Oct 16, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3342820842 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/050fa7a994336553b57c63463ff5126a78d37abc |
| test/old_tests/UnitTests/TryLookup.cpp | https://github.com/microsoft/cppwinrt/pull/1512/files/050fa7a994336553b57c63463ff5126a78d37abc#diff-5279740c132557803394e5cc43fb95136462ca979883c9decd474f639ec1e391 |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
| Oct 16, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2434356979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
|
| https://github.com/ChrisGuzak |
| Merge branch 'master' into user/antmor/non_originating | https://github.com/microsoft/cppwinrt/pull/1512/commits/dc6777efcb172d9c9000110fe7640f8e9eae7f07 |
| dc6777e | https://github.com/microsoft/cppwinrt/pull/1512/commits/dc6777efcb172d9c9000110fe7640f8e9eae7f07 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 27, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#issuecomment-3449087240 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
no-pr-activity
| https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity |
| Oct 27, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-20513028871 |
|
| https://github.com/antmor |
| add unittest without specialization, make sure that the behaviour is … | https://github.com/microsoft/cppwinrt/pull/1512/commits/4632e57ac3c6995f10eea1b4b44b4ccff308bedf |
| 4632e57 | https://github.com/microsoft/cppwinrt/pull/1512/commits/4632e57ac3c6995f10eea1b4b44b4ccff308bedf |
| https://github.com/antmor |
| antmor | https://github.com/antmor |
| Chris Guzak (ChrisGuzak) | https://github.com/ChrisGuzak |
| David Machaj (dmachaj) | https://github.com/dmachaj |
| 4632e57 | https://github.com/microsoft/cppwinrt/commit/4632e57ac3c6995f10eea1b4b44b4ccff308bedf |
| October 28, 2025 23:34 | https://github.com/microsoft/cppwinrt/pull/1512#event-20566830833 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
no-pr-activity
| https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity |
| Oct 29, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-20567579706 |
| https://github.com/DefaultRyan |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
|
Oct 29, 2025
| https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3391468749 |
|
View reviewed changes
| https://github.com/microsoft/cppwinrt/pull/1512/files/4632e57ac3c6995f10eea1b4b44b4ccff308bedf |
| https://github.com/DefaultRyan |
| Ryan Shepherd (DefaultRyan) | https://github.com/DefaultRyan |
| dcaa98c | https://github.com/microsoft/cppwinrt/commit/dcaa98c8d2abeb47ab5ce9ef1f96171e93d0ff9b |
| Oct 30, 2025 | https://github.com/microsoft/cppwinrt/pull/1512#event-20616116549 |
| https://github.com/YexuanXiao |
| Yexuan Xiao (YexuanXiao) | https://github.com/YexuanXiao |
|
Mar 11, 2026
| https://github.com/microsoft/cppwinrt/pull/1512#ref-pullrequest-4034415439 |
|
Simplify the definition of the consume function
#1544
| https://github.com/microsoft/cppwinrt/pull/1544 |
|
originate_on_cancel(false) fails on the second co_await due to missed call, and does not work for IAsyncActions.
#1616
| https://github.com/microsoft/cppwinrt/pull/1616 |
|
Bug: should_originate_on_cancel does not cancel certain awaiters or duplicated actions.
#1617
| https://github.com/microsoft/cppwinrt/issues/1617 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/cppwinrt/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1512 |
|
| https://github.com/oldnewthing |
|
Raymond Chen (oldnewthing)
| https://github.com/oldnewthing |
|
| https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
|
| https://github.com/DefaultRyan |
|
Ryan Shepherd (DefaultRyan)
| https://github.com/DefaultRyan |
|
| https://github.com/microsoft/cppwinrt/pull/1512/files/4632e57ac3c6995f10eea1b4b44b4ccff308bedf |
|
| https://github.com/ChrisGuzak |
|
Chris Guzak (ChrisGuzak)
| https://github.com/ChrisGuzak |
|
| https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07 |
|
| https://github.com/jonwis |
|
Jon Wiswall (jonwis)
| https://github.com/jonwis |
|
| https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a |
|
| https://github.com/dmachaj |
|
David Machaj (dmachaj)
| https://github.com/dmachaj |
|
| https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
|
| https://github.com/ChrisGuzak |
|
Chris Guzak (ChrisGuzak)
| https://github.com/ChrisGuzak |
|
Bug:map_view_base Lookup failure case is several orders slower due to C++ exceptions
| https://github.com/microsoft/cppwinrt/issues/1511 |
| Please reload this page | https://github.com/microsoft/cppwinrt/pull/1512 |
|
| https://github.com/antmor |
|
| https://github.com/oldnewthing |
|
| https://github.com/ChrisGuzak |
|
| https://github.com/jonwis |
|
| https://github.com/DefaultRyan |
|
| https://github.com/dmachaj |
|
| https://github.com/kennykerr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |