René's URL Explorer Experiment


Title: Remove throwing/originating errors in expected scenarios (Lookup/TryLookup and Cancel) by antmor · Pull Request #1512 · microsoft/cppwinrt · GitHub

Open Graph Title: Remove throwing/originating errors in expected scenarios (Lookup/TryLookup and Cancel) by antmor · Pull Request #1512 · microsoft/cppwinrt

X Title: Remove throwing/originating errors in expected scenarios (Lookup/TryLookup and Cancel) by antmor · Pull Request #1512 · microsoft/cppwinrt

Description: C++/WinRT. Contribute to microsoft/cppwinrt development by creating an account on GitHub.

Open Graph Description: Fixes: #1511 #1376 TL;DR: We are removing RoOriginate from the default winrt implementations of Map/MapView::Lookup, which improves TryLookup performance in the case of a key missing from the Map/...

X Description: Fixes: #1511 #1376 TL;DR: We are removing RoOriginate from the default winrt implementations of Map/MapView::Lookup, which improves TryLookup performance in the case of a key missing from the Map/...

Opengraph URL: https://github.com/microsoft/cppwinrt/pull/1512

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:41eea5c6-68eb-e230-39f2-eea4bb19ca37
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id919C:3CF916:162F24:1EBE3D:6B0055A0
html-safe-noncee9ec9a0979dc83a8f47a7b8f6414ba8f9f692c6a4b7928595b523376f8739f99
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTlDOjNDRjkxNjoxNjJGMjQ6MUVCRTNEOjZCMDA1NUEwIiwidmlzaXRvcl9pZCI6IjEyNjM4MDY2MjI3MDMwNDgwOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2da2cae9340818cdcc92582212729c1159b8cb00e983d2fc8c634133ab0c54e9
hovercard-subject-tagpull_request:2837921156
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cppwinrt/1512/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/256de13fd4631790174ebea9d7c23c6245ed488b0e28dff1a429efc6016042bc/microsoft/cppwinrt/pull/1512
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/256de13fd4631790174ebea9d7c23c6245ed488b0e28dff1a429efc6016042bc/microsoft/cppwinrt/pull/1512
og:image:altFixes: #1511 #1376 TL;DR: We are removing RoOriginate from the default winrt implementations of Map/MapView::Lookup, which improves TryLookup performance in the case of a key missing from the Map/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameantmor
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/microsoft/cppwinrt git https://github.com/microsoft/cppwinrt.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id68223326
octolytics-dimension-repository_nwomicrosoft/cppwinrt
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68223326
octolytics-dimension-repository_network_root_nwomicrosoft/cppwinrt
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/cppwinrt/pull/1512#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1512
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1512
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcppwinrt
Reloadhttps://github.com/microsoft/cppwinrt/pull/1512
Reloadhttps://github.com/microsoft/cppwinrt/pull/1512
Reloadhttps://github.com/microsoft/cppwinrt/pull/1512
microsofthttps://github.com/microsoft
cppwinrthttps://github.com/microsoft/cppwinrt
Codehttps://github.com/microsoft/cppwinrt
Issues16 (16)https://github.com/microsoft/cppwinrt/issues
Pull requests37 (37)https://github.com/microsoft/cppwinrt/pulls
Discussionshttps://github.com/microsoft/cppwinrt/discussions
Actionshttps://github.com/microsoft/cppwinrt/actions
Security and qualityhttps://github.com/microsoft/cppwinrt/security
Insightshttps://github.com/microsoft/cppwinrt/insights
https://github.com/microsoft/cppwinrt
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
antmor:user/antmor/non_originatinghttps://github.com/antmor/cppwinrt/tree/user/antmor/non_originating
Conversationhttps://github.com/microsoft/cppwinrt/pull/1512
Commits21 (21)https://github.com/microsoft/cppwinrt/pull/1512/commits
Checkshttps://github.com/microsoft/cppwinrt/pull/1512/checks
Files changedhttps://github.com/microsoft/cppwinrt/pull/1512/files
Remove throwing/originating errors in expected scenarios (Lookup/TryLookup and Cancel)https://github.com/microsoft/cppwinrt/pull/1512#top
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
microsoft:masterhttps://github.com/microsoft/cppwinrt/tree/master
antmor:user/antmor/non_originatinghttps://github.com/antmor/cppwinrt/tree/user/antmor/non_originating
https://github.com/antmor
antmorhttps://github.com/antmor
Sep 17, 2025https://github.com/microsoft/cppwinrt/pull/1512#issue-3427752082
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
#1511https://github.com/microsoft/cppwinrt/issues/1511
#1376https://github.com/microsoft/cppwinrt/issues/1376
https://private-user-images.githubusercontent.com/43587397/490765158-7b50ac9e-56a5-4f12-a502-8f55b37da64e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUxODQzMzIsIm5iZiI6MTc5NTE4NDAzMiwicGF0aCI6Ii80MzU4NzM5Ny80OTA3NjUxNTgtN2I1MGFjOWUtNTZhNS00ZjEyLWE1MDItOGY1NWIzN2RhNjRlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIwVDE0MTM1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkMWFkZGZmODg5ODc2YjNhMzUxYzcwN2UzM2FlZGQ1OTU4NjkwNWIyMjEyY2Q1ODQxMzI0MjA1MzVkZDg4NTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.eWohpJaUKXQ-oVsJvkDAkEZkmtfDslQPDOaQb-VQhYo
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
antmorhttps://github.com/antmor
December 13, 2023 17:53https://github.com/microsoft/cppwinrt/pull/1512#commits-pushed-472e8d4
https://github.com/antmor
non-originating error compileshttps://github.com/microsoft/cppwinrt/pull/1512/commits/472e8d4b2590cdbcda361695be4efb8f4c41e3aa
472e8d4https://github.com/microsoft/cppwinrt/pull/1512/commits/472e8d4b2590cdbcda361695be4efb8f4c41e3aa
https://github.com/antmor
fix with test caseshttps://github.com/microsoft/cppwinrt/pull/1512/commits/e358b9296d28b082ef14c14d13afdb0f23e502fd
e358b92https://github.com/microsoft/cppwinrt/pull/1512/commits/e358b9296d28b082ef14c14d13afdb0f23e502fd
https://github.com/antmor
and remove ignorehttps://github.com/microsoft/cppwinrt/pull/1512/commits/a6ab125ae921dfd1fc9e98764cdf5b8ffe824625
a6ab125https://github.com/microsoft/cppwinrt/pull/1512/commits/a6ab125ae921dfd1fc9e98764cdf5b8ffe824625
https://github.com/antmor
add runsettings to run tests from visual studio tester, modified read…https://github.com/microsoft/cppwinrt/pull/1512/commits/cefa5fa191b00c8eae228b1c512d4a590d740a57
cefa5fahttps://github.com/microsoft/cppwinrt/pull/1512/commits/cefa5fa191b00c8eae228b1c512d4a590d740a57
https://github.com/antmor
change map shouldOriginate to template parameter. Note, could be a br…https://github.com/microsoft/cppwinrt/pull/1512/commits/a66ecd3099d3cf25bf0112c89e5d34f55fa637f3
a66ecd3https://github.com/microsoft/cppwinrt/pull/1512/commits/a66ecd3099d3cf25bf0112c89e5d34f55fa637f3
https://github.com/antmor
settle on avoid_originate as naming schemehttps://github.com/microsoft/cppwinrt/pull/1512/commits/3972237dd4052d4f62c57c7ec09f382a368237bd
3972237https://github.com/microsoft/cppwinrt/pull/1512/commits/3972237dd4052d4f62c57c7ec09f382a368237bd
https://github.com/antmor
fix errors, more merginghttps://github.com/microsoft/cppwinrt/pull/1512/commits/72689dadc2b989aee1f269cc2878d3e4890b5207
72689dahttps://github.com/microsoft/cppwinrt/pull/1512/commits/72689dadc2b989aee1f269cc2878d3e4890b5207
https://github.com/antmor
Merge branch 'microsoft-master' into user/antmor/non_originatinghttps://github.com/microsoft/cppwinrt/pull/1512/commits/815d734546144ac7d92b9289e27839c9b55cf1b9
815d734https://github.com/microsoft/cppwinrt/pull/1512/commits/815d734546144ac7d92b9289e27839c9b55cf1b9
https://github.com/antmor
add a printf only to Lookup so we can add SFINAE or something like that.https://github.com/microsoft/cppwinrt/pull/1512/commits/dd18558bbd253ca6939c120cc4de49a9aaa33475
dd18558https://github.com/microsoft/cppwinrt/pull/1512/commits/dd18558bbd253ca6939c120cc4de49a9aaa33475
https://github.com/antmor
weird templating magic required... still not working, has errorhttps://github.com/microsoft/cppwinrt/pull/1512/commits/0dfa235d519c4020c5624669c6f380a20738ef52
0dfa235https://github.com/microsoft/cppwinrt/pull/1512/commits/0dfa235d519c4020c5624669c6f380a20738ef52
https://github.com/antmor
trylookup exists to avoid throwing an error, and let's avoid avoid_or…https://github.com/microsoft/cppwinrt/pull/1512/commits/3f448142889800773b079a05138b2a3fa3ba1b7c
3f44814https://github.com/microsoft/cppwinrt/pull/1512/commits/3f448142889800773b079a05138b2a3fa3ba1b7c
https://github.com/antmor
remove test.https://github.com/microsoft/cppwinrt/pull/1512/commits/cfaa2a6de3483b499e29a5ee898e7f1549555e40
cfaa2a6https://github.com/microsoft/cppwinrt/pull/1512/commits/cfaa2a6de3483b499e29a5ee898e7f1549555e40
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Sep 17, 2025 https://github.com/microsoft/cppwinrt/pull/1512#ref-issue-3427369983
Bug:map_view_base Lookup failure case is several orders slower due to C++ exceptions #1511 https://github.com/microsoft/cppwinrt/issues/1511
https://github.com/antmor
cleaned up and correctness.https://github.com/microsoft/cppwinrt/pull/1512/commits/e69a7fe1dea8649d3bacfc08fe8413b00098e302
e69a7fehttps://github.com/microsoft/cppwinrt/pull/1512/commits/e69a7fe1dea8649d3bacfc08fe8413b00098e302
https://github.com/antmor
antmorhttps://github.com/antmor
September 17, 2025 23:22https://github.com/microsoft/cppwinrt/pull/1512#event-19761311078
https://github.com/antmor
undo changes to untouched fileshttps://github.com/microsoft/cppwinrt/pull/1512/commits/7051f24ffbf8e8bd9b58583c0cf564258b86157e
7051f24https://github.com/microsoft/cppwinrt/pull/1512/commits/7051f24ffbf8e8bd9b58583c0cf564258b86157e
https://github.com/jonwis
Jon Wiswall (jonwis)https://github.com/jonwis
Sep 18, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3237414635
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e
Jon Wiswall (jonwis)https://github.com/jonwis
https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3237414635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_collections_base.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e#diff-afa6c767046750490bd0b5bcc56d42cfbc13b9ce786a510d8143bd7b4c6fc9e8
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_error.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_meta.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/7051f24ffbf8e8bd9b58583c0cf564258b86157e#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/antmor
spacing changes , change do declval.https://github.com/microsoft/cppwinrt/pull/1512/commits/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7
7b0072ahttps://github.com/microsoft/cppwinrt/pull/1512/commits/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7
https://github.com/jonwis
Jon Wiswall (jonwis)https://github.com/jonwis
Sep 18, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3242219734
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7
https://github.com/dmachaj
David Machaj (dmachaj)https://github.com/dmachaj
Sep 18, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3242359946
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7
strings/base_error.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/7b0072a124a3cd81eebd5327e98bc2d640c1c3f7#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/antmor
added special tag to parameter list to make sure not to break existin…https://github.com/microsoft/cppwinrt/pull/1512/commits/783413a8cbb6bf73a7625d6ca422097472824e5c
783413ahttps://github.com/microsoft/cppwinrt/pull/1512/commits/783413a8cbb6bf73a7625d6ca422097472824e5c
https://github.com/antmor
antmorhttps://github.com/antmor
Jon Wiswall (jonwis)https://github.com/jonwis
stale reviewhttps://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3242219734
783413ahttps://github.com/microsoft/cppwinrt/commit/783413a8cbb6bf73a7625d6ca422097472824e5c
September 19, 2025 01:27https://github.com/microsoft/cppwinrt/pull/1512#event-19788014243
https://github.com/antmor
address avoid_oritinate comment, no need for a different name, resuse…https://github.com/microsoft/cppwinrt/pull/1512/commits/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
18a57a8https://github.com/microsoft/cppwinrt/pull/1512/commits/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
https://github.com/dmachaj
David Machaj (dmachaj)https://github.com/dmachaj
Sep 19, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3247581260
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
strings/base_error.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/783413a8cbb6bf73a7625d6ca422097472824e5c..18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/jonwis
Jon Wiswall (jonwis)https://github.com/jonwis
Sep 22, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3255283150
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
https://github.com/oldnewthing
Raymond Chen (oldnewthing)https://github.com/oldnewthing
Sep 24, 2025https://github.com/microsoft/cppwinrt/pull/1512#issuecomment-3329344315
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/oldnewthing
Raymond Chen (oldnewthing)https://github.com/oldnewthing
Sep 24, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3263483128
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
test/old_tests/UnitTests/TryLookup.cpphttps://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5279740c132557803394e5cc43fb95136462ca979883c9decd474f639ec1e391
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_meta.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322
Raymond Chen (oldnewthing)https://github.com/oldnewthing
Sep 24, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2376194462
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
antmorhttps://github.com/antmor
Sep 24, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2376744358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Sep 25, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380054071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
antmorhttps://github.com/antmor
Sep 25, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380535180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/oldnewthing
Raymond Chen (oldnewthing)https://github.com/oldnewthing
Sep 24, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3263496295
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
strings/base_error.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_error.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-5add4c0e63b0e367754e6363d3a77d0ab1860314f7e7a26eafa92b1b6a6a1f92
Raymond Chen (oldnewthing)https://github.com/oldnewthing
Sep 24, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2376208850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
antmorhttps://github.com/antmor
Sep 25, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380544810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
antmorhttps://github.com/antmor
Sep 25, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380548213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_coroutine_foundation.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-e96e81c177f6789b25f1054f13d150144772ab4721bc47f629d7700ba4c91a11
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/antmor
antmorhttps://github.com/antmor
Sep 24, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-19899597267
https://github.com/antmor
antmorhttps://github.com/antmor
Sep 24, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-19899636008
https://github.com/antmor
change out async to a new name, with it being true by default.https://github.com/microsoft/cppwinrt/pull/1512/commits/2ee9368732ea9d84d4036d3eb650dc2f42c0a720
2ee9368https://github.com/microsoft/cppwinrt/pull/1512/commits/2ee9368732ea9d84d4036d3eb650dc2f42c0a720
https://github.com/antmor
antmorhttps://github.com/antmor
Jon Wiswall (jonwis)https://github.com/jonwis
David Machaj (dmachaj)https://github.com/dmachaj
2ee9368https://github.com/microsoft/cppwinrt/commit/2ee9368732ea9d84d4036d3eb650dc2f42c0a720
September 25, 2025 01:08https://github.com/microsoft/cppwinrt/pull/1512#event-19906505537
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Sep 25, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3269076194
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720
strings/base_collections_base.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720#diff-afa6c767046750490bd0b5bcc56d42cfbc13b9ce786a510d8143bd7b4c6fc9e8
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Sep 25, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3269084038
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720
strings/base_meta.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Sep 25, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2380054071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
strings/base_meta.hhttps://github.com/microsoft/cppwinrt/pull/1512/files/2ee9368732ea9d84d4036d3eb650dc2f42c0a720#diff-babe47b8f30aff901c7c2cd0fb2cd56bbe808068e240c90be13555fd66bfe322
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/antmor
Address hresult comments by adding tests and removing source_locatoin…https://github.com/microsoft/cppwinrt/pull/1512/commits/050fa7a994336553b57c63463ff5126a78d37abc
050fa7ahttps://github.com/microsoft/cppwinrt/pull/1512/commits/050fa7a994336553b57c63463ff5126a78d37abc
https://github.com/antmor
antmorhttps://github.com/antmor
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
stale reviewhttps://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3269076194
050fa7ahttps://github.com/microsoft/cppwinrt/commit/050fa7a994336553b57c63463ff5126a78d37abc
September 26, 2025 01:28https://github.com/microsoft/cppwinrt/pull/1512#event-19932097810
https://github.com/dmachaj
David Machaj (dmachaj)https://github.com/dmachaj
Oct 3, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3300491914
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 14, 2025https://github.com/microsoft/cppwinrt/pull/1512#issuecomment-3399520156
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
no-pr-activity https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity
Oct 14, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-20257732983
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Oct 15, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-20282320077
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
Oct 15, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3338014954
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07
https://github.com/kennykerr
Kenny Kerr (kennykerr)https://github.com/kennykerr
no-pr-activity https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity
Oct 15, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-20295734730
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Oct 16, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3342820842
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/050fa7a994336553b57c63463ff5126a78d37abc
test/old_tests/UnitTests/TryLookup.cpphttps://github.com/microsoft/cppwinrt/pull/1512/files/050fa7a994336553b57c63463ff5126a78d37abc#diff-5279740c132557803394e5cc43fb95136462ca979883c9decd474f639ec1e391
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Oct 16, 2025https://github.com/microsoft/cppwinrt/pull/1512#discussion_r2434356979
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/ChrisGuzak
Merge branch 'master' into user/antmor/non_originatinghttps://github.com/microsoft/cppwinrt/pull/1512/commits/dc6777efcb172d9c9000110fe7640f8e9eae7f07
dc6777ehttps://github.com/microsoft/cppwinrt/pull/1512/commits/dc6777efcb172d9c9000110fe7640f8e9eae7f07
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 27, 2025https://github.com/microsoft/cppwinrt/pull/1512#issuecomment-3449087240
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
no-pr-activity https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity
Oct 27, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-20513028871
https://github.com/antmor
add unittest without specialization, make sure that the behaviour is …https://github.com/microsoft/cppwinrt/pull/1512/commits/4632e57ac3c6995f10eea1b4b44b4ccff308bedf
4632e57https://github.com/microsoft/cppwinrt/pull/1512/commits/4632e57ac3c6995f10eea1b4b44b4ccff308bedf
https://github.com/antmor
antmorhttps://github.com/antmor
Chris Guzak (ChrisGuzak)https://github.com/ChrisGuzak
David Machaj (dmachaj)https://github.com/dmachaj
4632e57https://github.com/microsoft/cppwinrt/commit/4632e57ac3c6995f10eea1b4b44b4ccff308bedf
October 28, 2025 23:34https://github.com/microsoft/cppwinrt/pull/1512#event-20566830833
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
no-pr-activity https://github.com/microsoft/cppwinrt/issues?q=state%3Aopen%20label%3Ano-pr-activity
Oct 29, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-20567579706
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
Oct 29, 2025 https://github.com/microsoft/cppwinrt/pull/1512#pullrequestreview-3391468749
View reviewed changes https://github.com/microsoft/cppwinrt/pull/1512/files/4632e57ac3c6995f10eea1b4b44b4ccff308bedf
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan)https://github.com/DefaultRyan
dcaa98chttps://github.com/microsoft/cppwinrt/commit/dcaa98c8d2abeb47ab5ce9ef1f96171e93d0ff9b
Oct 30, 2025https://github.com/microsoft/cppwinrt/pull/1512#event-20616116549
https://github.com/YexuanXiao
Yexuan Xiao (YexuanXiao)https://github.com/YexuanXiao
Mar 11, 2026 https://github.com/microsoft/cppwinrt/pull/1512#ref-pullrequest-4034415439
Simplify the definition of the consume function #1544 https://github.com/microsoft/cppwinrt/pull/1544
originate_on_cancel(false) fails on the second co_await due to missed call, and does not work for IAsyncActions. #1616 https://github.com/microsoft/cppwinrt/pull/1616
Bug: should_originate_on_cancel does not cancel certain awaiters or duplicated actions. #1617 https://github.com/microsoft/cppwinrt/issues/1617
https://github.co/hiddenchars
https://github.com/microsoft/cppwinrt/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcppwinrt%2Fpull%2F1512
https://github.com/oldnewthing
Raymond Chen (oldnewthing) https://github.com/oldnewthing
https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
https://github.com/DefaultRyan
Ryan Shepherd (DefaultRyan) https://github.com/DefaultRyan
https://github.com/microsoft/cppwinrt/pull/1512/files/4632e57ac3c6995f10eea1b4b44b4ccff308bedf
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak) https://github.com/ChrisGuzak
https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07
https://github.com/jonwis
Jon Wiswall (jonwis) https://github.com/jonwis
https://github.com/microsoft/cppwinrt/pull/1512/files/18a57a8a90ba63a8e7a4ee8622ba54f15d86063a
https://github.com/dmachaj
David Machaj (dmachaj) https://github.com/dmachaj
https://github.com/microsoft/cppwinrt/pull/1512/files/dc6777efcb172d9c9000110fe7640f8e9eae7f07
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/ChrisGuzak
Chris Guzak (ChrisGuzak) https://github.com/ChrisGuzak
Bug:map_view_base Lookup failure case is several orders slower due to C++ exceptions https://github.com/microsoft/cppwinrt/issues/1511
Please reload this pagehttps://github.com/microsoft/cppwinrt/pull/1512
https://github.com/antmor
https://github.com/oldnewthing
https://github.com/ChrisGuzak
https://github.com/jonwis
https://github.com/DefaultRyan
https://github.com/dmachaj
https://github.com/kennykerr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.