René's URL Explorer Experiment


Title: Prevent event loss when a disk write fails during Flush() by bmehta001 · Pull Request #1496 · microsoft/cpp_client_telemetry · GitHub

Open Graph Title: Prevent event loss when a disk write fails during Flush() by bmehta001 · Pull Request #1496 · microsoft/cpp_client_telemetry

X Title: Prevent event loss when a disk write fails during Flush() by bmehta001 · Pull Request #1496 · microsoft/cpp_client_telemetry

Description: 1DS C++ SDK. Contribute to microsoft/cpp_client_telemetry development by creating an account on GitHub.

Open Graph Description: Summary Fixes a latent event-loss bug in OfflineStorageHandler::Flush(), surfaced by Copilot's review of #1491. Flush() pulled records out of the in-memory queue with GetRecords() — which remov...

X Description: Summary Fixes a latent event-loss bug in OfflineStorageHandler::Flush(), surfaced by Copilot's review of #1491. Flush() pulled records out of the in-memory queue with GetRecords() — which r...

Opengraph URL: https://github.com/microsoft/cpp_client_telemetry/pull/1496

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e719a705-3f49-38a3-c1b4-61fd8ca7441d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE652:30AD7C:26575B0:360A083:6A4CE5EC
html-safe-nonce088d4d4b5705fb3c8926de60ead2510b4060c6454c4e60a3cfa6155da54c294c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjUyOjMwQUQ3QzoyNjU3NUIwOjM2MEEwODM6NkE0Q0U1RUMiLCJ2aXNpdG9yX2lkIjoiNjczNjIwODM5OTM4NDI0MTY0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb16f6520f183a37cc016a3883e077a98b71dd5b53f4769515ff65c6c8f272360
hovercard-subject-tagpull_request:3915664823
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/cpp_client_telemetry/1496/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9389a89cd9ec85803cb614eaea11a0fb3677afd76531510cac00dc08eb0f4600/microsoft/cpp_client_telemetry/pull/1496
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9389a89cd9ec85803cb614eaea11a0fb3677afd76531510cac00dc08eb0f4600/microsoft/cpp_client_telemetry/pull/1496
og:image:altSummary Fixes a latent event-loss bug in OfflineStorageHandler::Flush(), surfaced by Copilot's review of #1491. Flush() pulled records out of the in-memory queue with GetRecords() — which remov...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebmehta001
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-cache
go-importgithub.com/microsoft/cpp_client_telemetry git https://github.com/microsoft/cpp_client_telemetry.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id168430034
octolytics-dimension-repository_nwomicrosoft/cpp_client_telemetry
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id168430034
octolytics-dimension-repository_network_root_nwomicrosoft/cpp_client_telemetry
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec5a57f04eeb310f57c73fd6d751d957e2ca27ed2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/cpp_client_telemetry/pull/1496#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcpp_client_telemetry%2Fpull%2F1496
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcpp_client_telemetry%2Fpull%2F1496
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fcpp_client_telemetry
Reloadhttps://github.com/microsoft/cpp_client_telemetry/pull/1496
Reloadhttps://github.com/microsoft/cpp_client_telemetry/pull/1496
Reloadhttps://github.com/microsoft/cpp_client_telemetry/pull/1496
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
microsoft https://github.com/microsoft
cpp_client_telemetryhttps://github.com/microsoft/cpp_client_telemetry
Notifications https://github.com/login?return_to=%2Fmicrosoft%2Fcpp_client_telemetry
Fork 60 https://github.com/login?return_to=%2Fmicrosoft%2Fcpp_client_telemetry
Star 102 https://github.com/login?return_to=%2Fmicrosoft%2Fcpp_client_telemetry
Code https://github.com/microsoft/cpp_client_telemetry
Issues 109 https://github.com/microsoft/cpp_client_telemetry/issues
Pull requests 27 https://github.com/microsoft/cpp_client_telemetry/pulls
Discussions https://github.com/microsoft/cpp_client_telemetry/discussions
Actions https://github.com/microsoft/cpp_client_telemetry/actions
Models https://github.com/microsoft/cpp_client_telemetry/models
Security and quality 0 https://github.com/microsoft/cpp_client_telemetry/security
Insights https://github.com/microsoft/cpp_client_telemetry/pulse
Code https://github.com/microsoft/cpp_client_telemetry
Issues https://github.com/microsoft/cpp_client_telemetry/issues
Pull requests https://github.com/microsoft/cpp_client_telemetry/pulls
Discussions https://github.com/microsoft/cpp_client_telemetry/discussions
Actions https://github.com/microsoft/cpp_client_telemetry/actions
Models https://github.com/microsoft/cpp_client_telemetry/models
Security and quality https://github.com/microsoft/cpp_client_telemetry/security
Insights https://github.com/microsoft/cpp_client_telemetry/pulse
bmehta001https://github.com/bmehta001
microsoft:mainhttps://github.com/microsoft/cpp_client_telemetry/tree/main
bmehta001:bhamehta/fix-flush-reserve-confirmhttps://github.com/bmehta001/cpp_client_telemetry/tree/bhamehta/fix-flush-reserve-confirm
Conversationhttps://github.com/microsoft/cpp_client_telemetry/pull/1496
Commits7 (7)https://github.com/microsoft/cpp_client_telemetry/pull/1496/commits
Checkshttps://github.com/microsoft/cpp_client_telemetry/pull/1496/checks
Files changedhttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files
Prevent event loss when a disk write fails during Flush()https://github.com/microsoft/cpp_client_telemetry/pull/1496#top
bmehta001https://github.com/bmehta001
microsoft:mainhttps://github.com/microsoft/cpp_client_telemetry/tree/main
bmehta001:bhamehta/fix-flush-reserve-confirmhttps://github.com/bmehta001/cpp_client_telemetry/tree/bhamehta/fix-flush-reserve-confirm
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Jun 22, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1496#issue-4720937094
#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Prevent event loss when a disk write fails during Flush()https://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/5d509181c6ef768aedfadd63d56b9b20c950fb5d
5d50918https://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/5d509181c6ef768aedfadd63d56b9b20c950fb5d
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
code ownerhttps://github.com/microsoft/cpp_client_telemetry/blob/beba0e8e440e97f20f50e5fb51b2c9cc76cf19dc/.github/CODEOWNERS#L5
June 22, 2026 22:11https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27065622819
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 22, 2026 22:33https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27066284029
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/1bd3e4e2-8dd2-42a7-8308-b06f89a3d6c2
bmehta001https://github.com/bmehta001
June 22, 2026 22:34https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27066305235
View session https://github.com/microsoft/cpp_client_telemetry/sessions/1bd3e4e2-8dd2-42a7-8308-b06f89a3d6c2
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 22, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4548613506
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/5d509181c6ef768aedfadd63d56b9b20c950fb5d
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4548613506
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://github.com/microsoft/cpp_client_telemetry/new/main?filename=.github/instructions/*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
tests/unittests/OfflineStorageTests.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/5d509181c6ef768aedfadd63d56b9b20c950fb5d#diff-c76f594e21bb13ba56aa706512f3fab733c7572014bed1c7af296663369da7ea
tests/unittests/OfflineStorageTests.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/5d509181c6ef768aedfadd63d56b9b20c950fb5d#diff-c76f594e21bb13ba56aa706512f3fab733c7572014bed1c7af296663369da7ea
tests/unittests/OfflineStorageTests.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/5d509181c6ef768aedfadd63d56b9b20c950fb5d#diff-c76f594e21bb13ba56aa706512f3fab733c7572014bed1c7af296663369da7ea
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Address Copilot round-1 commentshttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/202e8c3d67e2a6894abe94038c8224a71fd7f7a1
202e8c3https://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/202e8c3d67e2a6894abe94038c8224a71fd7f7a1
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 22, 2026 22:44https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27066563059
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/0f835c96-3c7b-48a5-804e-3a6d77f9339a
bmehta001https://github.com/bmehta001
June 22, 2026 22:45https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27066606281
View session https://github.com/microsoft/cpp_client_telemetry/sessions/0f835c96-3c7b-48a5-804e-3a6d77f9339a
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 22, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4548668695
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/202e8c3d67e2a6894abe94038c8224a71fd7f7a1
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4548668695
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/202e8c3d67e2a6894abe94038c8224a71fd7f7a1#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/202e8c3d67e2a6894abe94038c8224a71fd7f7a1#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
tests/unittests/OfflineStorageTests.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/202e8c3d67e2a6894abe94038c8224a71fd7f7a1#diff-c76f594e21bb13ba56aa706512f3fab733c7572014bed1c7af296663369da7ea
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Address Copilot round-2 commentshttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/d79d6cf7be30368adcea42037ff55a12ef234d01
d79d6cfhttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/d79d6cf7be30368adcea42037ff55a12ef234d01
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 22, 2026 23:00https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27067030489
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/cfb6e07e-b9f0-48c3-825e-29af6257a2b2
bmehta001https://github.com/bmehta001
June 22, 2026 23:01https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27067041167
View session https://github.com/microsoft/cpp_client_telemetry/sessions/cfb6e07e-b9f0-48c3-825e-29af6257a2b2
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 22, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4548764146
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/d79d6cf7be30368adcea42037ff55a12ef234d01
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4548764146
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
tests/unittests/OfflineStorageTests.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/d79d6cf7be30368adcea42037ff55a12ef234d01#diff-c76f594e21bb13ba56aa706512f3fab733c7572014bed1c7af296663369da7ea
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/d79d6cf7be30368adcea42037ff55a12ef234d01#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Address Copilot round-3 commentshttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/342be951e1b7457fa853a198ed17fa5e016b00ea
342be95https://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/342be951e1b7457fa853a198ed17fa5e016b00ea
microsoft#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 23, 2026 01:30https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27070650758
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/b375598b-4085-4d4e-9a8c-252faf0dda1e
bmehta001https://github.com/bmehta001
June 23, 2026 01:31https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27070661060
View session https://github.com/microsoft/cpp_client_telemetry/sessions/b375598b-4085-4d4e-9a8c-252faf0dda1e
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 23, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549338074
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/342be951e1b7457fa853a198ed17fa5e016b00ea
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549338074
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/342be951e1b7457fa853a198ed17fa5e016b00ea#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Address Copilot round-4 comment: don't carry reservation lease onto diskhttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/9d1b92a315e505c1b81aa3d57119de5602ee2bd6
9d1b92ahttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/9d1b92a315e505c1b81aa3d57119de5602ee2bd6
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 23, 2026 01:40https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27070865953
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/fb01b8b4-55d9-4fff-8789-5333338ae66f
bmehta001https://github.com/bmehta001
June 23, 2026 01:41https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27070875946
View session https://github.com/microsoft/cpp_client_telemetry/sessions/fb01b8b4-55d9-4fff-8789-5333338ae66f
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 23, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549379190
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/9d1b92a315e505c1b81aa3d57119de5602ee2bd6
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549379190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
tests/unittests/OfflineStorageTests.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/9d1b92a315e505c1b81aa3d57119de5602ee2bd6#diff-c76f594e21bb13ba56aa706512f3fab733c7572014bed1c7af296663369da7ea
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Address Copilot round-5 comment: clarify test mechanism wordinghttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/123440ea084fd3c904da33a278d0268a11a0ddd2
123440ehttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/123440ea084fd3c904da33a278d0268a11a0ddd2
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 23, 2026 01:50https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27071066342
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/a138bdb0-408a-4359-81e3-89e30faf0147
bmehta001https://github.com/bmehta001
June 23, 2026 01:50https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27071074071
View session https://github.com/microsoft/cpp_client_telemetry/sessions/a138bdb0-408a-4359-81e3-89e30faf0147
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 23, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549427684
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/123440ea084fd3c904da33a278d0268a11a0ddd2
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549427684
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/123440ea084fd3c904da33a278d0268a11a0ddd2#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/123440ea084fd3c904da33a278d0268a11a0ddd2#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Address Copilot round-6: simplify Flush to drain-and-re-insert-failedhttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/ce957eeb3320556591a9fb6d744965cdbe3ac55d
ce957eehttps://github.com/microsoft/cpp_client_telemetry/pull/1496/commits/ce957eeb3320556591a9fb6d744965cdbe3ac55d
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Copilothttps://github.com/apps/copilot-pull-request-reviewer
June 23, 2026 02:05https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27071444502
started reviewinghttps://github.com/microsoft/cpp_client_telemetry/sessions/1f8a9ee8-689f-4dd3-afaa-292a905a25b7
bmehta001https://github.com/bmehta001
June 23, 2026 02:06https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27071453898
View session https://github.com/microsoft/cpp_client_telemetry/sessions/1f8a9ee8-689f-4dd3-afaa-292a905a25b7
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Jun 23, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549487347
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/ce957eeb3320556591a9fb6d744965cdbe3ac55d
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496#pullrequestreview-4549487347
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
lib/offline/OfflineStorageHandler.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/ce957eeb3320556591a9fb6d744965cdbe3ac55d#diff-2792c1c0259f93c39d87457b483b9856f5caec27462d88044fff0aa72bee39f2
lib/offline/OfflineStorage_SQLite.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1496/files/ce957eeb3320556591a9fb6d744965cdbe3ac55d#diff-19ce60ed5d6e68cfac824446cda6e18e5774527811749333e96584e3db1e12c8
bmehta001https://github.com/bmehta001
Jun 23, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#ref-commit-f1b3381
https://github.com/bmehta001
https://github.com/apps/github-copilot-cli
Prevent event loss when a disk write fails during Flush()https://github.com/bmehta001/cpp_client_telemetry/commit/f1b33810c5d46bccdf14a037ceb626b0f345c0cb
f1b3381https://github.com/bmehta001/cpp_client_telemetry/commit/f1b33810c5d46bccdf14a037ceb626b0f345c0cb
microsoft#1496https://github.com/microsoft/cpp_client_telemetry/pull/1496
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Jun 23, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1496#ref-pullrequest-4718334318
Offline storage: data-safety fixes + batched flush (empty-filter guard, store-failure propagation, event-loss fix, one-transaction flush) #1491 https://github.com/microsoft/cpp_client_telemetry/pull/1491
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Jun 23, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1496#issuecomment-4775468090
#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
#1491https://github.com/microsoft/cpp_client_telemetry/pull/1491
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
https://github.com/bmehta001
bmehta001https://github.com/bmehta001
Jun 23, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1496#event-27074117053
https://github.co/hiddenchars
https://github.com/microsoft/cpp_client_telemetry/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcpp_client_telemetry%2Fpull%2F1496
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
https://github.com/microsoft/cpp_client_telemetry/pull/1496/files/ce957eeb3320556591a9fb6d744965cdbe3ac55d
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1496
https://github.com/bmehta001
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.