René's URL Explorer Experiment


Title: Fix crash when HttpResponseDecoder receives non-JSON response by hanselip · Pull Request #1405 · microsoft/cpp_client_telemetry · GitHub

Open Graph Title: Fix crash when HttpResponseDecoder receives non-JSON response by hanselip · Pull Request #1405 · microsoft/cpp_client_telemetry

X Title: Fix crash when HttpResponseDecoder receives non-JSON response by hanselip · Pull Request #1405 · microsoft/cpp_client_telemetry

Description: 1DS C++ SDK. Contribute to microsoft/cpp_client_telemetry development by creating an account on GitHub.

Open Graph Description: Summary This PR fixes issue #1338 where the application crashes when HttpResponseDecoder::processBody receives a non-JSON HTTP response (e.g., HTML from captive portals or network sign-in pages). C...

X Description: Summary This PR fixes issue #1338 where the application crashes when HttpResponseDecoder::processBody receives a non-JSON HTTP response (e.g., HTML from captive portals or network sign-in pages). C...

Opengraph URL: https://github.com/microsoft/cpp_client_telemetry/pull/1405

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:862e65d9-2b3f-4567-2cb2-b7f354df2cae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1EC:24C6EB:197BCF1:247460E:6A4CDADD
html-safe-nonceb5a589d7609c9feef99503489e193a4aa88bc833ffb7514461a32291358eea87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUVDOjI0QzZFQjoxOTdCQ0YxOjI0NzQ2MEU6NkE0Q0RBREQiLCJ2aXNpdG9yX2lkIjoiNTk1NDY1MDk4MDAzMzAyNjc4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac056c677ac2b05a7000dff315737ed694ce9a3123880c0221b04d9ead8da4491f
hovercard-subject-tagpull_request:3204858581
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/cpp_client_telemetry/pull/1405
twitter:imagehttps://opengraph.githubassets.com/c07a6ef592bf1bb2fe6ea1c7cf5a66e655f648b66777fa2d09a0090ce20e14b9/microsoft/cpp_client_telemetry/pull/1405
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c07a6ef592bf1bb2fe6ea1c7cf5a66e655f648b66777fa2d09a0090ce20e14b9/microsoft/cpp_client_telemetry/pull/1405
og:image:altSummary This PR fixes issue #1338 where the application crashes when HttpResponseDecoder::processBody receives a non-JSON HTTP response (e.g., HTML from captive portals or network sign-in pages). C...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehanselip
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-cache
go-importgithub.com/microsoft/cpp_client_telemetry git https://github.com/microsoft/cpp_client_telemetry.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id168430034
octolytics-dimension-repository_nwomicrosoft/cpp_client_telemetry
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id168430034
octolytics-dimension-repository_network_root_nwomicrosoft/cpp_client_telemetry
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3eeb74f55ccd8a31bdaec6839577c592bbf7844c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/cpp_client_telemetry/pull/1405#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcpp_client_telemetry%2Fpull%2F1405
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcpp_client_telemetry%2Fpull%2F1405
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=microsoft%2Fcpp_client_telemetry
Reloadhttps://github.com/microsoft/cpp_client_telemetry/pull/1405
Reloadhttps://github.com/microsoft/cpp_client_telemetry/pull/1405
Reloadhttps://github.com/microsoft/cpp_client_telemetry/pull/1405
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
microsoft https://github.com/microsoft
cpp_client_telemetryhttps://github.com/microsoft/cpp_client_telemetry
Notifications https://github.com/login?return_to=%2Fmicrosoft%2Fcpp_client_telemetry
Fork 60 https://github.com/login?return_to=%2Fmicrosoft%2Fcpp_client_telemetry
Star 102 https://github.com/login?return_to=%2Fmicrosoft%2Fcpp_client_telemetry
Code https://github.com/microsoft/cpp_client_telemetry
Issues 109 https://github.com/microsoft/cpp_client_telemetry/issues
Pull requests 27 https://github.com/microsoft/cpp_client_telemetry/pulls
Discussions https://github.com/microsoft/cpp_client_telemetry/discussions
Actions https://github.com/microsoft/cpp_client_telemetry/actions
Models https://github.com/microsoft/cpp_client_telemetry/models
Security and quality 0 https://github.com/microsoft/cpp_client_telemetry/security
Insights https://github.com/microsoft/cpp_client_telemetry/pulse
Code https://github.com/microsoft/cpp_client_telemetry
Issues https://github.com/microsoft/cpp_client_telemetry/issues
Pull requests https://github.com/microsoft/cpp_client_telemetry/pulls
Discussions https://github.com/microsoft/cpp_client_telemetry/discussions
Actions https://github.com/microsoft/cpp_client_telemetry/actions
Models https://github.com/microsoft/cpp_client_telemetry/models
Security and quality https://github.com/microsoft/cpp_client_telemetry/security
Insights https://github.com/microsoft/cpp_client_telemetry/pulse
ThomsonTanhttps://github.com/ThomsonTan
mainhttps://github.com/microsoft/cpp_client_telemetry/tree/main
fix-json-parse-crashhttps://github.com/microsoft/cpp_client_telemetry/tree/fix-json-parse-crash
Conversationhttps://github.com/microsoft/cpp_client_telemetry/pull/1405
Commits4 (4)https://github.com/microsoft/cpp_client_telemetry/pull/1405/commits
Checkshttps://github.com/microsoft/cpp_client_telemetry/pull/1405/checks
Files changedhttps://github.com/microsoft/cpp_client_telemetry/pull/1405/files
Fix crash when HttpResponseDecoder receives non-JSON responsehttps://github.com/microsoft/cpp_client_telemetry/pull/1405#top
ThomsonTanhttps://github.com/ThomsonTan
mainhttps://github.com/microsoft/cpp_client_telemetry/tree/main
fix-json-parse-crashhttps://github.com/microsoft/cpp_client_telemetry/tree/fix-json-parse-crash
https://github.com/hanselip
hanseliphttps://github.com/hanselip
Jan 23, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1405#issue-3849199389
#1338https://github.com/microsoft/cpp_client_telemetry/issues/1338
#1338https://github.com/microsoft/cpp_client_telemetry/issues/1338
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/hanselip
hanseliphttps://github.com/hanselip
code ownerhttps://github.com/microsoft/cpp_client_telemetry/blob/97f7f8f473c880b1a9a60ed0089772fa190c4702/.github/CODEOWNERS#L5
January 23, 2026 21:01https://github.com/microsoft/cpp_client_telemetry/pull/1405#event-22252726769
https://github.com/lalitb
lalitbhttps://github.com/lalitb
Jan 28, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1405#pullrequestreview-3718195964
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1405/files
lib/http/HttpResponseDecoder.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1405/files#diff-1b71c279e48d4d128742d10273e4609d644fe6c33e74ff2ed14d6ba100e32508
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
Jan 28, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1405#pullrequestreview-3718318380
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1405/files
lib/http/HttpResponseDecoder.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1405/files#diff-1b71c279e48d4d128742d10273e4609d644fe6c33e74ff2ed14d6ba100e32508
ThomsonTanhttps://github.com/ThomsonTan
Jan 28, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1405#discussion_r2737948510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
hanseliphttps://github.com/hanselip
Jan 28, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1405#discussion_r2738407097
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
ab8790chttps://github.com/microsoft/cpp_client_telemetry/commit/ab8790cd2c6b06edf875160c5d8015e7476faa67
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
hanseliphttps://github.com/hanselip
Jan 28, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1405#ref-commit-ab8790c
https://github.com/claude
Address PRhttps://github.com/microsoft/cpp_client_telemetry/commit/ab8790cd2c6b06edf875160c5d8015e7476faa67
#1405https://github.com/microsoft/cpp_client_telemetry/pull/1405
review: use parse with exceptions disabledhttps://github.com/microsoft/cpp_client_telemetry/commit/ab8790cd2c6b06edf875160c5d8015e7476faa67
ab8790chttps://github.com/microsoft/cpp_client_telemetry/commit/ab8790cd2c6b06edf875160c5d8015e7476faa67
January 28, 2026 13:04https://github.com/microsoft/cpp_client_telemetry/pull/1405#commits-pushed-374a971
https://github.com/claude
https://github.com/ThomsonTan
Fix crash when HttpResponseDecoder receives non-JSON responsehttps://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/374a971743c8ea8be1278340c34f2e87f8a4a945
374a971https://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/374a971743c8ea8be1278340c34f2e87f8a4a945
#1338https://github.com/microsoft/cpp_client_telemetry/issues/1338
https://github.com/claude
https://github.com/ThomsonTan
Address PRhttps://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/ca99f1ced2e43f3ead9a876eb9ad1bbf7c748ee0
#1405https://github.com/microsoft/cpp_client_telemetry/pull/1405
review: use parse with exceptions disabledhttps://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/ca99f1ced2e43f3ead9a876eb9ad1bbf7c748ee0
ca99f1chttps://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/ca99f1ced2e43f3ead9a876eb9ad1bbf7c748ee0
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
force-pushedhttps://github.com/microsoft/cpp_client_telemetry/compare/ab8790cd2c6b06edf875160c5d8015e7476faa67..ca99f1ced2e43f3ead9a876eb9ad1bbf7c748ee0
ab8790chttps://github.com/microsoft/cpp_client_telemetry/commit/ab8790cd2c6b06edf875160c5d8015e7476faa67
ca99f1chttps://github.com/microsoft/cpp_client_telemetry/commit/ca99f1ced2e43f3ead9a876eb9ad1bbf7c748ee0
Compare https://github.com/microsoft/cpp_client_telemetry/compare/ab8790cd2c6b06edf875160c5d8015e7476faa67..ca99f1ced2e43f3ead9a876eb9ad1bbf7c748ee0
January 28, 2026 21:04https://github.com/microsoft/cpp_client_telemetry/pull/1405#event-22357882476
https://github.com/claude
Use iterators directly in parse() to avoid copying bodyhttps://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/f88a6415bd063572ed2264daad81cd913321b1f8
f88a641https://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/f88a6415bd063572ed2264daad81cd913321b1f8
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
Jan 29, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1405#pullrequestreview-3720655375
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1405/files/f88a6415bd063572ed2264daad81cd913321b1f8
lib/http/HttpResponseDecoder.cpphttps://github.com/microsoft/cpp_client_telemetry/pull/1405/files/f88a6415bd063572ed2264daad81cd913321b1f8#diff-1b71c279e48d4d128742d10273e4609d644fe6c33e74ff2ed14d6ba100e32508
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/claude
Remove unnecessary inner scope blockhttps://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/54de0177eec12df05b19632427b3f8fe78f86c5d
54de017https://github.com/microsoft/cpp_client_telemetry/pull/1405/commits/54de0177eec12df05b19632427b3f8fe78f86c5d
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
Feb 3, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1405#pullrequestreview-3742148588
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1405/files/54de0177eec12df05b19632427b3f8fe78f86c5d
https://github.com/lalitb
lalitbhttps://github.com/lalitb
Feb 3, 2026 https://github.com/microsoft/cpp_client_telemetry/pull/1405#pullrequestreview-3745456837
View reviewed changes https://github.com/microsoft/cpp_client_telemetry/pull/1405/files/54de0177eec12df05b19632427b3f8fe78f86c5d
https://github.com/hanselip
hanseliphttps://github.com/hanselip
Feb 3, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1405#issuecomment-3842729867
@ThomsonTanhttps://github.com/ThomsonTan
@lalitbhttps://github.com/lalitb
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
Feb 3, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1405#issuecomment-3842926400
@hanseliphttps://github.com/hanselip
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
54c9c5bhttps://github.com/microsoft/cpp_client_telemetry/commit/54c9c5b680bd31ac4b153422884e85fe3ff94db6
Feb 3, 2026https://github.com/microsoft/cpp_client_telemetry/pull/1405#event-22505539878
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/ThomsonTan
ThomsonTanhttps://github.com/ThomsonTan
February 3, 2026 18:25https://github.com/microsoft/cpp_client_telemetry/pull/1405#event-22505540590
https://github.co/hiddenchars
https://github.com/microsoft/cpp_client_telemetry/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcpp_client_telemetry%2Fpull%2F1405
https://github.com/ThomsonTan
ThomsonTan https://github.com/ThomsonTan
https://github.com/microsoft/cpp_client_telemetry/pull/1405/files/54de0177eec12df05b19632427b3f8fe78f86c5d
https://github.com/lalitb
lalitb https://github.com/lalitb
https://github.com/microsoft/cpp_client_telemetry/pull/1405/files/54de0177eec12df05b19632427b3f8fe78f86c5d
Crash when HttpResponseDecoder::processBody doesn't get JSON response https://github.com/microsoft/cpp_client_telemetry/issues/1338
Please reload this pagehttps://github.com/microsoft/cpp_client_telemetry/pull/1405
https://github.com/hanselip
https://github.com/ThomsonTan
https://github.com/lalitb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.