René's URL Explorer Experiment

Title: Fix loadContents not working issue when loading both non-empty and empty files in luis/qnamaker:build by feich-ms · Pull Request #925 · microsoft/botframework-cli · GitHub

Open Graph Title: Fix loadContents not working issue when loading both non-empty and empty files in luis/qnamaker:build by feich-ms · Pull Request #925 · microsoft/botframework-cli

X Title: Fix loadContents not working issue when loading both non-empty and empty files in luis/qnamaker:build by feich-ms · Pull Request #925 · microsoft/botframework-cli

Description: CLI Tools for the Microsoft Bot Framework. Contribute to microsoft/botframework-cli development by creating an account on GitHub.

Open Graph Description: Fix #924 to make loadContents function load files correctly when both non-empty and empty files are there at the same time. Tests are added. Composer reported issue since they have empty lu or qna ...

X Description: Fix #924 to make loadContents function load files correctly when both non-empty and empty files are there at the same time. Tests are added. Composer reported issue since they have empty lu or qna ...

Opengraph URL: https://github.com/microsoft/botframework-cli/pull/925

X: @github

direct link

Domain: github.com

route-pattern	/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controller	voltron_pull_requests_fragments
route-action	pull_request_layout
fetch-nonce	v2:4c0da094-83ed-29d5-554f-5a9e7144bce8
current-catalog-service-hash	ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id	A512:284E48:BD064:F348F:69903CA4
html-safe-nonce	5238ac8dda65f11c4d57a036ec8d0800e1faf0f631bd0335020c788e372a43d6
visitor-payload	eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTEyOjI4NEU0ODpCRDA2NDpGMzQ4Rjo2OTkwM0NBNCIsInZpc2l0b3JfaWQiOiIzNjk3OTM5OTQ4NTQxODUyODM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac	29579bbf4feba2d38471ad357c1fb422ffbb6c655f2fe4649cb6754b0902569b
hovercard-subject-tag	pull_request:463831962
github-keyboard-shortcuts	repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification	Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url	https://collector.github.com/github/collect
analytics-location	///voltron/pull_requests_fragments/pull_request_layout
fb:app_id	1401488693436528
apple-itunes-app	app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/botframework-cli/925/pull_request_layout
twitter:image	https://opengraph.githubassets.com/46eccaed20330dd4aa8b4a9797a627cfcd690dd46eeb19403589f1ec51801f3c/microsoft/botframework-cli/pull/925
twitter:card	summary_large_image
og:image	https://opengraph.githubassets.com/46eccaed20330dd4aa8b4a9797a627cfcd690dd46eeb19403589f1ec51801f3c/microsoft/botframework-cli/pull/925
og:image:alt	Fix #924 to make loadContents function load files correctly when both non-empty and empty files are there at the same time. Tests are added. Composer reported issue since they have empty lu or qna ...
og:image:width	1200
og:image:height	600
og:site_name	GitHub
og:type	object
og:author:username	feich-ms
hostname	github.com
expected-hostname	github.com
None	42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-control	no-cache
go-import	github.com/microsoft/botframework-cli git https://github.com/microsoft/botframework-cli.git
octolytics-dimension-user_id	6154722
octolytics-dimension-user_login	microsoft
octolytics-dimension-repository_id	187076818
octolytics-dimension-repository_nwo	microsoft/botframework-cli
octolytics-dimension-repository_public	true
octolytics-dimension-repository_is_fork	false
octolytics-dimension-repository_network_root_id	187076818
octolytics-dimension-repository_network_root_nwo	microsoft/botframework-cli
turbo-body-classes	logged-out env-production page-responsive
disable-turbo	false
browser-stats-url	https://api.github.com/_private/browser/stats
browser-errors-url	https://api.github.com/_private/browser/errors
release	3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-target	full
theme-color	#1e2327
color-scheme	light dark

Links:

Skip to content	https://github.com/microsoft/botframework-cli/pull/925#start-of-content
	https://github.com/
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotframework-cli%2Fpull%2F925
GitHub CopilotWrite better code with AI	https://github.com/features/copilot
GitHub SparkBuild and deploy intelligent apps	https://github.com/features/spark
GitHub ModelsManage and compare prompts	https://github.com/features/models
MCP RegistryNewIntegrate external tools	https://github.com/mcp
ActionsAutomate any workflow	https://github.com/features/actions
CodespacesInstant dev environments	https://github.com/features/codespaces
IssuesPlan and track work	https://github.com/features/issues
Code ReviewManage code changes	https://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilities	https://github.com/security/advanced-security
Code securitySecure your code as you build	https://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they start	https://github.com/security/advanced-security/secret-protection
Why GitHub	https://github.com/why-github
Documentation	https://docs.github.com
Blog	https://github.blog
Changelog	https://github.blog/changelog
Marketplace	https://github.com/marketplace
View all features	https://github.com/features
Enterprises	https://github.com/enterprise
Small and medium teams	https://github.com/team
Startups	https://github.com/enterprise/startups
Nonprofits	https://github.com/solutions/industry/nonprofits
App Modernization	https://github.com/solutions/use-case/app-modernization
DevSecOps	https://github.com/solutions/use-case/devsecops
DevOps	https://github.com/solutions/use-case/devops
CI/CD	https://github.com/solutions/use-case/ci-cd
View all use cases	https://github.com/solutions/use-case
Healthcare	https://github.com/solutions/industry/healthcare
Financial services	https://github.com/solutions/industry/financial-services
Manufacturing	https://github.com/solutions/industry/manufacturing
Government	https://github.com/solutions/industry/government
View all industries	https://github.com/solutions/industry
View all solutions	https://github.com/solutions
AI	https://github.com/resources/articles?topic=ai
Software Development	https://github.com/resources/articles?topic=software-development
DevOps	https://github.com/resources/articles?topic=devops
Security	https://github.com/resources/articles?topic=security
View all topics	https://github.com/resources/articles
Customer stories	https://github.com/customer-stories
Events & webinars	https://github.com/resources/events
Ebooks & reports	https://github.com/resources/whitepapers
Business insights	https://github.com/solutions/executive-insights
GitHub Skills	https://skills.github.com
Documentation	https://docs.github.com
Customer support	https://support.github.com
Community forum	https://github.com/orgs/community/discussions
Trust center	https://github.com/trust-center
Partners	https://github.com/partners
GitHub SponsorsFund open source developers	https://github.com/sponsors
Security Lab	https://securitylab.github.com
Maintainer Community	https://maintainers.github.com
Accelerator	https://github.com/accelerator
Archive Program	https://archiveprogram.github.com
Topics	https://github.com/topics
Trending	https://github.com/trending
Collections	https://github.com/collections
Enterprise platformAI-powered developer platform	https://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security features	https://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI features	https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support	https://github.com/premium-support
Pricing	https://github.com/pricing
Search syntax tips	https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentation	https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotframework-cli%2Fpull%2F925
Sign up	https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fbotframework-cli
Reload	https://github.com/microsoft/botframework-cli/pull/925
Reload	https://github.com/microsoft/botframework-cli/pull/925
Reload	https://github.com/microsoft/botframework-cli/pull/925
microsoft	https://github.com/microsoft
botframework-cli	https://github.com/microsoft/botframework-cli
Notifications	https://github.com/login?return_to=%2Fmicrosoft%2Fbotframework-cli
Fork 123	https://github.com/login?return_to=%2Fmicrosoft%2Fbotframework-cli
Star 179	https://github.com/login?return_to=%2Fmicrosoft%2Fbotframework-cli
Code	https://github.com/microsoft/botframework-cli
Issues 22	https://github.com/microsoft/botframework-cli/issues
Pull requests 1	https://github.com/microsoft/botframework-cli/pulls
Actions	https://github.com/microsoft/botframework-cli/actions
Projects 0	https://github.com/microsoft/botframework-cli/projects
Models	https://github.com/microsoft/botframework-cli/models
Security 0	https://github.com/microsoft/botframework-cli/security
Insights	https://github.com/microsoft/botframework-cli/pulse
Code	https://github.com/microsoft/botframework-cli
Issues	https://github.com/microsoft/botframework-cli/issues
Pull requests	https://github.com/microsoft/botframework-cli/pulls
Actions	https://github.com/microsoft/botframework-cli/actions
Projects	https://github.com/microsoft/botframework-cli/projects
Models	https://github.com/microsoft/botframework-cli/models
Security	https://github.com/microsoft/botframework-cli/security
Insights	https://github.com/microsoft/botframework-cli/pulse
feich-ms	https://github.com/feich-ms
master	https://github.com/microsoft/botframework-cli/tree/master
feich/fixEmptyFileIssue	https://github.com/microsoft/botframework-cli/tree/feich/fixEmptyFileIssue
Conversation	https://github.com/microsoft/botframework-cli/pull/925
Commits1 (1)	https://github.com/microsoft/botframework-cli/pull/925/commits
Checks	https://github.com/microsoft/botframework-cli/pull/925/checks
Files changed	https://github.com/microsoft/botframework-cli/pull/925/files
Fix loadContents not working issue when loading both non-empty and empty files in luis/qnamaker:build	https://github.com/microsoft/botframework-cli/pull/925#top
feich-ms	https://github.com/feich-ms
master	https://github.com/microsoft/botframework-cli/tree/master
feich/fixEmptyFileIssue	https://github.com/microsoft/botframework-cli/tree/feich/fixEmptyFileIssue
	https://github.com/feich-ms
feich-ms	https://github.com/feich-ms
Aug 6, 2020	https://github.com/microsoft/botframework-cli/pull/925#issue-674077367
Please reload this page	https://github.com/microsoft/botframework-cli/pull/925
#924	https://github.com/microsoft/botframework-cli/issues/924
Please reload this page	https://github.com/microsoft/botframework-cli/pull/925
	https://github.com/feich-ms
optimize logic when handling empty files	https://github.com/microsoft/botframework-cli/pull/925/commits/bdbfc08acd1d35b1838f551b96826b73903eb597
bdbfc08	https://github.com/microsoft/botframework-cli/pull/925/commits/bdbfc08acd1d35b1838f551b96826b73903eb597
	https://github.com/feich-ms
feich-ms	https://github.com/feich-ms
munozemilio	https://github.com/munozemilio
code owner	https://github.com/microsoft/botframework-cli/blob/789391bd01c70039735281c7eae4078a7f5a9f5c/.github/CODEOWNERS#L19
August 6, 2020 07:10	https://github.com/microsoft/botframework-cli/pull/925#event-3627700488
	https://github.com/feich-ms
feich-ms	https://github.com/feich-ms
alanlong9278	https://github.com/alanlong9278
boydc2014	https://github.com/boydc2014
vishwacsena	https://github.com/vishwacsena
August 6, 2020 07:10	https://github.com/microsoft/botframework-cli/pull/925#event-3627701167
	https://github.com/codecov-commenter
codecov-commenter	https://github.com/codecov-commenter
Aug 6, 2020	https://github.com/microsoft/botframework-cli/pull/925#issuecomment-669757701
Codecov	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=h1
#925	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=desc
master	https://codecov.io/gh/microsoft/botframework-cli/commit/789391bd01c70039735281c7eae4078a7f5a9f5c&el=desc
	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=tree
Impacted Files	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=tree
packages/lu/src/parser/lu/luMerger.js	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvbHUvc3JjL3BhcnNlci9sdS9sdU1lcmdlci5qcw==
packages/lu/src/parser/lubuild/builder.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvbHUvc3JjL3BhcnNlci9sdWJ1aWxkL2J1aWxkZXIudHM=
packages/lu/src/parser/qnabuild/builder.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvbHUvc3JjL3BhcnNlci9xbmFidWlsZC9idWlsZGVyLnRz
packages/lu/src/parser/utils/enums/CLI-errors.js	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvbHUvc3JjL3BhcnNlci91dGlscy9lbnVtcy9DTEktZXJyb3JzLmpz
packages/luis/src/commands/luis/index.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvbHVpcy9zcmMvY29tbWFuZHMvbHVpcy9pbmRleC50cw==
...kages/qnamaker/src/commands/qnamaker/kb/publish.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvcW5hbWFrZXIvc3JjL2NvbW1hbmRzL3FuYW1ha2VyL2tiL3B1Ymxpc2gudHM=
...aker/src/commands/qnamaker/endpointkeys/refresh.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvcW5hbWFrZXIvc3JjL2NvbW1hbmRzL3FuYW1ha2VyL2VuZHBvaW50a2V5cy9yZWZyZXNoLnRz
...atics/confusion_matrix/AppBinaryConfusionMatrix.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvZGlzcGF0Y2hlci9zcmMvbWF0aGVtYXRpY3MvY29uZnVzaW9uX21hdHJpeC9BcHBCaW5hcnlDb25mdXNpb25NYXRyaXgudHM=
...ematics/mathematics_helper/AppMathematicsHelper.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvZGlzcGF0Y2hlci9zcmMvbWF0aGVtYXRpY3MvbWF0aGVtYXRpY3NfaGVscGVyL0FwcE1hdGhlbWF0aWNzSGVscGVyLnRz
packages/qnamaker/src/utils/qnamakerbase.ts	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree#diff-cGFja2FnZXMvcW5hbWFrZXIvc3JjL3V0aWxzL3FuYW1ha2VyYmFzZS50cw==
59 more	https://codecov.io/gh/microsoft/botframework-cli/pull/925/diff?src=pr&el=tree-more
Continue to review full report at Codecov	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=continue
Click here to learn more	https://docs.codecov.io/docs/codecov-delta
Codecov	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=footer
789391b...bdbfc08	https://codecov.io/gh/microsoft/botframework-cli/pull/925?src=pr&el=lastupdated
comment docs	https://docs.codecov.io/docs/pull-request-comments
Please reload this page	https://github.com/microsoft/botframework-cli/pull/925
	https://github.com/boydc2014
boydc2014	https://github.com/boydc2014
Aug 6, 2020	https://github.com/microsoft/botframework-cli/pull/925#pullrequestreview-462351058
View reviewed changes	https://github.com/microsoft/botframework-cli/pull/925/files/bdbfc08acd1d35b1838f551b96826b73903eb597
	https://github.com/feich-ms
feich-ms	https://github.com/feich-ms
Aug 6, 2020	https://github.com/microsoft/botframework-cli/pull/925#issuecomment-669829238
@munozemilio	https://github.com/munozemilio
Please reload this page	https://github.com/microsoft/botframework-cli/pull/925
	https://github.com/feich-ms
feich-ms	https://github.com/feich-ms
9695b25	https://github.com/microsoft/botframework-cli/commit/9695b25d2dfd96ee315aa39774081c07ddfdc5d7
Aug 6, 2020	https://github.com/microsoft/botframework-cli/pull/925#event-3628276945
	https://github.com/feich-ms
feich-ms	https://github.com/feich-ms
August 6, 2020 09:46	https://github.com/microsoft/botframework-cli/pull/925#event-3628277343
	https://github.co/hiddenchars
	https://github.com/microsoft/botframework-cli/pull/{{ revealButtonHref }}
Sign up for free	https://github.com/join?source=comment-repo
Sign in	https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotframework-cli%2Fpull%2F925
	https://github.com/munozemilio
munozemilio	https://github.com/munozemilio
	https://github.com/vishwacsena
vishwacsena	https://github.com/vishwacsena
	https://github.com/alanlong9278
alanlong9278	https://github.com/alanlong9278
	https://github.com/boydc2014
boydc2014	https://github.com/boydc2014
	https://github.com/microsoft/botframework-cli/pull/925/files/bdbfc08acd1d35b1838f551b96826b73903eb597
loadContents function will fail when empty and non-empty lu or qna files list are provided	https://github.com/microsoft/botframework-cli/issues/924
Please reload this page	https://github.com/microsoft/botframework-cli/pull/925
	https://github.com/feich-ms
	https://github.com/codecov-commenter
	https://github.com/boydc2014
	https://github.com
Terms	https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy	https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security	https://github.com/security
Status	https://www.githubstatus.com/
Community	https://github.community/
Docs	https://docs.github.com/
Contact	https://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.