| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e084ca07-83e6-69ab-a52a-620783b9c9e8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 807E:F7C4C:E4B4CD:1332971:6B010AC1 |
| html-safe-nonce | 99dc35dfe852bf8ab9ede6968a1ebddf28155f8bcbc366dec709c633a819d75b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDdFOkY3QzRDOkU0QjRDRDoxMzMyOTcxOjZCMDEwQUMxIiwidmlzaXRvcl9pZCI6Ijc0MzY2ODIzNTUyMzE3NTQ5NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 695c8ed61b4255911ae3a255478c8cb959daeee824e0001613bac6d7f9e271df |
| hovercard-subject-tag | pull_request:209380458 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/microsoft/angular-react/pull/7/files |
| twitter:image | https://avatars.githubusercontent.com/u/260431?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/260431?s=400&v=4 |
| og:image:alt | Fixes #1 permanently.
Fixes issue were React nodes were removed from the DOM when they were still needed (i.e. Fabric's Pivot component - where PivotItem may not be in the DOM but still needed ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/microsoft/angular-react git https://github.com/microsoft/angular-react.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 144321557 |
| octolytics-dimension-repository_nwo | microsoft/angular-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 144321557 |
| octolytics-dimension-repository_network_root_nwo | microsoft/angular-react |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/angular-react/pull/7/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fangular-react%2Fpull%2F7%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fangular-react%2Fpull%2F7%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fangular-react |
| Reload | https://github.com/microsoft/angular-react/pull/7/files |
| Reload | https://github.com/microsoft/angular-react/pull/7/files |
| Reload | https://github.com/microsoft/angular-react/pull/7/files |
| microsoft | https://github.com/microsoft |
| angular-react | https://github.com/microsoft/angular-react |
| Code | https://github.com/microsoft/angular-react |
| Issues25 (25) | https://github.com/microsoft/angular-react/issues |
| Pull requests30 (30) | https://github.com/microsoft/angular-react/pulls |
| Actions | https://github.com/microsoft/angular-react/actions |
| Projects | https://github.com/microsoft/angular-react/projects |
| Wiki | https://github.com/microsoft/angular-react/wiki |
| Security and quality | https://github.com/microsoft/angular-react/security |
| Insights | https://github.com/microsoft/angular-react/insights |
| Ben Grynhaus (bengry) | https://github.com/bengry |
| master | https://github.com/microsoft/angular-react/tree/master |
| fix-unmounting-nodes | https://github.com/microsoft/angular-react/tree/fix-unmounting-nodes |
|
Conversation
0
| https://github.com/microsoft/angular-react/pull/7 |
|
Commits
12
| https://github.com/microsoft/angular-react/pull/7/commits |
|
Checks
0
| https://github.com/microsoft/angular-react/pull/7/checks |
|
Files changed
| https://github.com/microsoft/angular-react/pull/7/files |
| Please reload this page | https://github.com/microsoft/angular-react/pull/7/files |
|
Fix React nodes being removed from DOM when they are still needed
| https://github.com/microsoft/angular-react/pull/7/files#top |
|
Show all changes
12 commits
| https://github.com/microsoft/angular-react/pull/7/files |
|
1c938e7
POC
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/1c938e73886d2ceaf777752c8ba814930775801a |
|
b9b4f67
revert legacy render mode by default
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/b9b4f676c19b62995a2e308067947b520e089b22 |
|
0445891
Change TemplateRef render prop to not-recreate every time
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/04458912499d4e9744118d800349de91a53fb96b |
|
d98a54f
Change HTML render prop format to match Template renderer
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/d98a54f4874936b37912d9cea3603cf47c4887e5 |
|
f08d1db
amend 04458912499d4e9744118d800349de91a53fb96b
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/f08d1db06d861b7f772a132bd56da6194f1b22e6 |
|
6115e1c
amend d98a54f4874936b37912d9cea3603cf47c4887e5
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/6115e1cff98e16d19675783df7004d25d8bf5dfe |
|
144b776
Change ComponentRef rendenrer to match Template renderer
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/144b77606c6fe0214df8c3efc4e00fa4291e0ef2 |
|
8f3c89c
Change render props to not re-render when unneeded
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/8f3c89cfbe8db18bea291dc41945f9f64e108d3e |
|
d05d05a
Remove workaround for React root nodes not being removed when Angular…
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/d05d05a2a41f001878f2d23a705126ae3ea867c9 |
|
e7def80
Change ReactContent to not add already-mounted elements
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/e7def80812bc8cc10e5c66b3afd7a245ff9ce62b |
|
902ae07
Demo app changes
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/902ae07b782ff9957a78a44fbbe0556e99513480 |
|
0a13bee
Add cross-browser support for checking if a node is in the DOM
Aug 19, 2018
| https://github.com/microsoft/angular-react/pull/7/commits/0a13bee79ce34964d44d4bca340aa2e49720e056 |
|
Clear filters
| https://github.com/microsoft/angular-react/pull/7/files |
| Please reload this page | https://github.com/microsoft/angular-react/pull/7/files |
| Please reload this page | https://github.com/microsoft/angular-react/pull/7/files |
|
app.component.html
| https://github.com/microsoft/angular-react/pull/7/files#diff-0d7e95f0c9156aab8fe0e989247277c2486bb05b13ab0714cebb6c3677e008fc |
|
wrapper-component.ts
| https://github.com/microsoft/angular-react/pull/7/files#diff-a243f39484cff07e723bf2eedac170ab193ec54b9efa1966dc6d3fd0b0fc36a5 |
|
react-content.ts
| https://github.com/microsoft/angular-react/pull/7/files#diff-1b276bb294608bc701fc3b37942db1285594fd5e347f8e0ccc0467c25a0b6619 |
|
renderer.ts
| https://github.com/microsoft/angular-react/pull/7/files#diff-a1cf3b8e640a3b946247f98d5a2a9edd7f32d0012d28b2aee95b1d466b97a430 |
|
renderprop-helpers.ts
| https://github.com/microsoft/angular-react/pull/7/files#diff-c1a11ab849f4fae738777f8965a566b61f401a0ca9efc14c06a27e5a6d348587 |
|
dom-utils.ts
| https://github.com/microsoft/angular-react/pull/7/files#diff-13439f5909aa308fce14e67e49ab18fd024022667c052748c8ab4a34e052852b |
|
index.ts
| https://github.com/microsoft/angular-react/pull/7/files#diff-36b6bd0009d7e086c92f4d5b1e6cb40d1d5a1b883fbd187da60688b89877996b |
| apps/demo/src/app/app.component.html | https://github.com/microsoft/angular-react/pull/7/files#diff-0d7e95f0c9156aab8fe0e989247277c2486bb05b13ab0714cebb6c3677e008fc |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/apps/demo/src/app/app.component.html |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-0d7e95f0c9156aab8fe0e989247277c2486bb05b13ab0714cebb6c3677e008fc |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-0d7e95f0c9156aab8fe0e989247277c2486bb05b13ab0714cebb6c3677e008fc |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-0d7e95f0c9156aab8fe0e989247277c2486bb05b13ab0714cebb6c3677e008fc |
| libs/core/src/lib/components/wrapper-component.ts | https://github.com/microsoft/angular-react/pull/7/files#diff-a243f39484cff07e723bf2eedac170ab193ec54b9efa1966dc6d3fd0b0fc36a5 |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/libs/core/src/lib/components/wrapper-component.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a243f39484cff07e723bf2eedac170ab193ec54b9efa1966dc6d3fd0b0fc36a5 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a243f39484cff07e723bf2eedac170ab193ec54b9efa1966dc6d3fd0b0fc36a5 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a243f39484cff07e723bf2eedac170ab193ec54b9efa1966dc6d3fd0b0fc36a5 |
| libs/core/src/lib/renderer/react-content.ts | https://github.com/microsoft/angular-react/pull/7/files#diff-1b276bb294608bc701fc3b37942db1285594fd5e347f8e0ccc0467c25a0b6619 |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/libs/core/src/lib/renderer/react-content.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-1b276bb294608bc701fc3b37942db1285594fd5e347f8e0ccc0467c25a0b6619 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-1b276bb294608bc701fc3b37942db1285594fd5e347f8e0ccc0467c25a0b6619 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-1b276bb294608bc701fc3b37942db1285594fd5e347f8e0ccc0467c25a0b6619 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-1b276bb294608bc701fc3b37942db1285594fd5e347f8e0ccc0467c25a0b6619 |
| libs/core/src/lib/renderer/renderer.ts | https://github.com/microsoft/angular-react/pull/7/files#diff-a1cf3b8e640a3b946247f98d5a2a9edd7f32d0012d28b2aee95b1d466b97a430 |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/libs/core/src/lib/renderer/renderer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a1cf3b8e640a3b946247f98d5a2a9edd7f32d0012d28b2aee95b1d466b97a430 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a1cf3b8e640a3b946247f98d5a2a9edd7f32d0012d28b2aee95b1d466b97a430 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a1cf3b8e640a3b946247f98d5a2a9edd7f32d0012d28b2aee95b1d466b97a430 |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-a1cf3b8e640a3b946247f98d5a2a9edd7f32d0012d28b2aee95b1d466b97a430 |
| libs/core/src/lib/renderer/renderprop-helpers.ts | https://github.com/microsoft/angular-react/pull/7/files#diff-c1a11ab849f4fae738777f8965a566b61f401a0ca9efc14c06a27e5a6d348587 |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/libs/core/src/lib/renderer/renderprop-helpers.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
|
| https://github.com/microsoft/angular-react/pull/7/files#diff-c1a11ab849f4fae738777f8965a566b61f401a0ca9efc14c06a27e5a6d348587 |
| libs/core/src/lib/utils/dom/dom-utils.ts | https://github.com/microsoft/angular-react/pull/7/files#diff-13439f5909aa308fce14e67e49ab18fd024022667c052748c8ab4a34e052852b |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/libs/core/src/lib/utils/dom/dom-utils.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
| libs/core/src/lib/utils/dom/index.ts | https://github.com/microsoft/angular-react/pull/7/files#diff-36b6bd0009d7e086c92f4d5b1e6cb40d1d5a1b883fbd187da60688b89877996b |
|
View file
| https://github.com/microsoft/angular-react/blob/0a13bee79ce34964d44d4bca340aa2e49720e056/libs/core/src/lib/utils/dom/index.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/microsoft/angular-react/pull/7/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |