Title: Attribute validation can break the app if plugins have mutated the DOM · Issue #158 · microsoft/angular-react · GitHub
Open Graph Title: Attribute validation can break the app if plugins have mutated the DOM · Issue #158 · microsoft/angular-react
X Title: Attribute validation can break the app if plugins have mutated the DOM · Issue #158 · microsoft/angular-react
Description: Inside _passAttributesAsProps() there is a check to ensure that the DOM node that is being updated does not have style, class or key attributes. This code will throw if any of these attributes are found. This assumes that the application...
Open Graph Description: Inside _passAttributesAsProps() there is a check to ensure that the DOM node that is being updated does not have style, class or key attributes. This code will throw if any of these attributes are ...
X Description: Inside _passAttributesAsProps() there is a check to ensure that the DOM node that is being updated does not have style, class or key attributes. This code will throw if any of these attributes are ...
Opengraph URL: https://github.com/microsoft/angular-react/issues/158
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Attribute validation can break the app if plugins have mutated the DOM","articleBody":"Inside `_passAttributesAsProps()` there is a check to ensure that the DOM node that is being updated does not have `style`, `class` or `key` attributes. This code will throw if any of these attributes are found.\r\n\r\nThis assumes that the application is the only code that is writing to the DOM. In practice, many browser extensions will also mutate the DOM. This will cause angular-react to throw and break the application. \r\n\r\nThis check should be, at most, a warning in production code. \r\n\r\n# Test case\r\n\r\nRun this code in console. \r\n\r\n```javascript\r\nArray.from(document.querySelectorAll('body *')).forEach(n => n.setAttribute('style', n.getAttribute('style') || 'zoom: 1'))\r\n```\r\n\r\nThe next time that the Angular component is re-rendered, it will throw and break the application.","author":{"url":"https://github.com/joshduck","@type":"Person","name":"joshduck"},"datePublished":"2020-03-27T00:19:17Z","url":"https://github.com/microsoft/angular-react/issues/158"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d37ec51c-8d0d-b403-28e2-6418374ddd69 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B2F6:399E4B:B33AC8:EF6CDF:6B00F004 |
| html-safe-nonce | 405db35be3f4c8b99d5edf782b8bdb7cd4f80acde5e093c9107766bea1824d8b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkY2OjM5OUU0QjpCMzNBQzg6RUY2Q0RGOjZCMDBGMDA0IiwidmlzaXRvcl9pZCI6IjU5MTc5MjQ0MjI2Mzg5NTY1NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9d04057be274d68d22f4dfb1fa418a7cdf8751c6f8f39e696437c0cacdad0849 |
| hovercard-subject-tag | issue:588804854 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/angular-react/158/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6ee36834419ab403d80d1e156e58f50ac2fb9e4c7a457ed4209f68056b1a9259/microsoft/angular-react/issues/158 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6ee36834419ab403d80d1e156e58f50ac2fb9e4c7a457ed4209f68056b1a9259/microsoft/angular-react/issues/158 |
| og:image:alt | Inside _passAttributesAsProps() there is a check to ensure that the DOM node that is being updated does not have style, class or key attributes. This code will throw if any of these attributes are ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joshduck |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/angular-react git https://github.com/microsoft/angular-react.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 144321557 |
| octolytics-dimension-repository_nwo | microsoft/angular-react |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 144321557 |
| octolytics-dimension-repository_network_root_nwo | microsoft/angular-react |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width