René's URL Explorer Experiment


Title: When using React components inside Angular ones, they are attached to the root of the VDOM tree & not removed · Issue #1 · microsoft/angular-react · GitHub

Open Graph Title: When using React components inside Angular ones, they are attached to the root of the VDOM tree & not removed · Issue #1 · microsoft/angular-react

X Title: When using React components inside Angular ones, they are attached to the root of the VDOM tree & not removed · Issue #1 · microsoft/angular-react

Description: From Ben Grynhaus (@bengry) on July 22, 2018 7:57 When having the following structure: React -> (via ReactContent) Angular -> React, the inner React component is attached to the root of the VDOM: Instead of being nested under the ReactCo...

Open Graph Description: From Ben Grynhaus (@bengry) on July 22, 2018 7:57 When having the following structure: React -> (via ReactContent) Angular -> React, the inner React component is attached to the root of the VDOM: I...

X Description: From Ben Grynhaus (@bengry) on July 22, 2018 7:57 When having the following structure: React -> (via ReactContent) Angular -> React, the inner React component is attached to the root of the V...

Opengraph URL: https://github.com/microsoft/angular-react/issues/1

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"When using React components inside Angular ones, they are attached to the root of the VDOM tree & not removed","articleBody":"_From @bengry on July 22, 2018 7:57_\n\nWhen having the following structure: `React -> (via ReactContent) Angular -> React`,\r\nthe inner React component is attached to the root of the VDOM:\r\n![image](https://user-images.githubusercontent.com/260431/43043467-076332bc-8d9d-11e8-9304-58c0e021f96c.png)\r\n\r\nInstead of being nested under the `ReactContent` (seen above under the `div` with `key=\"run\"`), it's nested as a root node in the VDOM.\r\nThese nodes are also kept in the VDOM after the DOM element has been removed.\r\n\r\n[Demonstrated here](https://github.com/bengry/angular-react/tree/render-props-memory-leak).\r\n\r\nA workaround for this (but not a solution) by @xjerwa - in `AngularReactRendererFactory`:\r\n```typescript\r\nend() {\r\n    if (DEBUG) { console.log('RootRenderer > end > isRenderPending:', this.isRenderPending, 'reactRootNodes:', this.reactRootNodes); }\r\n    // Flush any pending React element render updates.  This cannot be done\r\n    // earlier (as is done for DOM elements) because React element props\r\n    // are ReadOnly.\r\n \r\n    // Potential fix: manually unmount ReactNodes that don't correspond to a DOM element\r\n    for (let i = 0; i \u003c this.reactRootNodes.length; i++) {\r\n      const node = this.reactRootNodes[i] as any;\r\n      if (!document.contains(node._parent) && ReactDOM.unmountComponentAtNode(node._parent)) {\r\n        this.reactRootNodes.splice(i--, 1);\r\n      }\r\n    }\r\n    // End potential fix\r\n \r\n    if (this.isRenderPending) {\r\n      // Remove root nodes that are pending destroy after render.\r\n      this.reactRootNodes = this.reactRootNodes.filter(node => !node.render().destroyPending);\r\n      this.isRenderPending = false;\r\n    }\r\n}\r\n````\r\n\n\n_Copied from original issue: benfeely/angular-react#13_","author":{"url":"https://github.com/bengry","@type":"Person","name":"bengry"},"datePublished":"2018-08-12T08:05:33Z","url":"https://github.com/microsoft/angular-react/issues/1"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:30bc5f0f-33ce-98f8-64fc-51a385143498
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAE82:EA06E:FBE8D9:14366B3:6B00FC86
html-safe-nonce5d4f85d1005b73334af9450dc73b91d6f1cd3b4a31bcba3c0a3c1345bbd3e98b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTgyOkVBMDZFOkZCRThEOToxNDM2NkIzOjZCMDBGQzg2IiwidmlzaXRvcl9pZCI6IjI4NTk2MzgyMzMwNDg4NzQxMTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbfa67bac29a64c21c4f91405538faa377f754a12a4b050a147a69011077f493a
hovercard-subject-tagissue:349793502
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/angular-react/1/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9a22fc2d0edaaeb6e34f4468c3703f6f7381a6fc46b2f16c30eec9f2e12e36ef/microsoft/angular-react/issues/1
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a22fc2d0edaaeb6e34f4468c3703f6f7381a6fc46b2f16c30eec9f2e12e36ef/microsoft/angular-react/issues/1
og:image:altFrom Ben Grynhaus (@bengry) on July 22, 2018 7:57 When having the following structure: React -> (via ReactContent) Angular -> React, the inner React component is attached to the root of the VDOM: I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebengry
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/microsoft/angular-react git https://github.com/microsoft/angular-react.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id144321557
octolytics-dimension-repository_nwomicrosoft/angular-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id144321557
octolytics-dimension-repository_network_root_nwomicrosoft/angular-react
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/angular-react/issues/1#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fangular-react%2Fissues%2F1
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fangular-react%2Fissues%2F1
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2Fangular-react
Reloadhttps://github.com/microsoft/angular-react/issues/1
Reloadhttps://github.com/microsoft/angular-react/issues/1
Reloadhttps://github.com/microsoft/angular-react/issues/1
microsofthttps://github.com/microsoft
angular-reacthttps://github.com/microsoft/angular-react
Codehttps://github.com/microsoft/angular-react
Issues25 (25)https://github.com/microsoft/angular-react/issues
Pull requests30 (30)https://github.com/microsoft/angular-react/pulls
Actionshttps://github.com/microsoft/angular-react/actions
Projectshttps://github.com/microsoft/angular-react/projects
Wikihttps://github.com/microsoft/angular-react/wiki
Security and qualityhttps://github.com/microsoft/angular-react/security
Insightshttps://github.com/microsoft/angular-react/insights
https://github.com/microsoft/angular-react
#7https://github.com/microsoft/angular-react/pull/7
When using React components inside Angular ones, they are attached to the root of the VDOM tree & not removedhttps://github.com/microsoft/angular-react/issues/1#top
#7https://github.com/microsoft/angular-react/pull/7
https://github.com/bengry
Ben Grynhaus (bengry)https://github.com/bengry
on Aug 12, 2018https://github.com/microsoft/angular-react/issues/1#issue-349793502
Ben Grynhaus (@bengry)https://github.com/bengry
https://user-images.githubusercontent.com/260431/43043467-076332bc-8d9d-11e8-9304-58c0e021f96c.png
Demonstrated herehttps://github.com/bengry/angular-react/tree/render-props-memory-leak
Jerry Wang (@xjerwa)https://github.com/xjerwa
benfeely/angular-react#13https://github.com/benfeely/angular-react/issues/13
Ben Grynhaus (bengry)https://github.com/bengry
completedhttps://github.com/microsoft/angular-react/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#7https://github.com/microsoft/angular-react/pull/7
on Aug 25, 2018https://github.com/microsoft/angular-react/issues/1#event-1808966336
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/angular-react/issues/1
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/angular-react/issues/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.