René's URL Explorer Experiment


Title: Attempt to fix #9919 - Intersecting discriminated union breaks type narrowing by gcnew · Pull Request #9939 · microsoft/TypeScript · GitHub

Open Graph Title: Attempt to fix #9919 - Intersecting discriminated union breaks type narrowing by gcnew · Pull Request #9939 · microsoft/TypeScript

X Title: Attempt to fix #9919 - Intersecting discriminated union breaks type narrowing by gcnew · Pull Request #9939 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Attempt to fix #9919 - Intersecting discriminated union breaks type narrowing by gcnew · Pull Request #9939 · microsoft/TypeScript

Open Graph Description: Fixes #9919. This PR adds support for correctly narrowing discriminated unions that are also intersected. As a side effect a type is now eligible for discrimination whenever it is a union or inters...

X Description: Fixes #9919. This PR adds support for correctly narrowing discriminated unions that are also intersected. As a side effect a type is now eligible for discrimination whenever it is a union or inters...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/9939

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:77886746-bd05-e4a8-8c92-3179fe92afd9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC942:326239:85AAD:BD258:6AFBE8FA
html-safe-nonce20f0cbec84e1426a265504af5a5788e557d195a5ef8c154d38f07353fccfe854
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTQyOjMyNjIzOTo4NUFBRDpCRDI1ODo2QUZCRThGQSIsInZpc2l0b3JfaWQiOiI2MzI3OTIzMDgyMDIwNzIzMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd485ca530b970909dfb220f8a79156c0eb33cd6e2ff116fcb4d19430448e2cd8
hovercard-subject-tagpull_request:78765304
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/9939/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bb5d7ecb2c1be851e0fc40d2cd0a66cb0a840838b1c3beac5859f3c97466d36c/microsoft/TypeScript/pull/9939
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb5d7ecb2c1be851e0fc40d2cd0a66cb0a840838b1c3beac5859f3c97466d36c/microsoft/TypeScript/pull/9939
og:image:altFixes #9919. This PR adds support for correctly narrowing discriminated unions that are also intersected. As a side effect a type is now eligible for discrimination whenever it is a union or inters...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegcnew
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/9939#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F9939
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F9939
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/9939
Reloadhttps://github.com/microsoft/TypeScript/pull/9939
Reloadhttps://github.com/microsoft/TypeScript/pull/9939
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests334 (334)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Marin Marinov (gcnew)https://github.com/gcnew
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
gcnew:discriminated-intersectionhttps://github.com/gcnew/TypeScript/tree/discriminated-intersection
Conversationhttps://github.com/microsoft/TypeScript/pull/9939
Commits3 (3)https://github.com/microsoft/TypeScript/pull/9939/commits
Checkshttps://github.com/microsoft/TypeScript/pull/9939/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/9939/files
Attempt to fix #9919 - Intersecting discriminated union breaks type narrowinghttps://github.com/microsoft/TypeScript/pull/9939#top
Marin Marinov (gcnew)https://github.com/gcnew
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
gcnew:discriminated-intersectionhttps://github.com/gcnew/TypeScript/tree/discriminated-intersection
https://github.com/gcnew
Marin Marinov (gcnew)https://github.com/gcnew
Jul 25, 2016https://github.com/microsoft/TypeScript/pull/9939#issue-167483546
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
#9919https://github.com/microsoft/TypeScript/issues/9919
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
Marin Marinov (gcnew)https://github.com/gcnew
July 26, 2016 01:28https://github.com/microsoft/TypeScript/pull/9939#commits-pushed-10ca5e4
https://github.com/gcnew
Fixed type narrowing when discrimited union is intersectedhttps://github.com/microsoft/TypeScript/pull/9939/commits/10ca5e4b1fa0c6108fae8e79cc85914a91b4577c
10ca5e4https://github.com/microsoft/TypeScript/pull/9939/commits/10ca5e4b1fa0c6108fae8e79cc85914a91b4577c
https://github.com/gcnew
Added tests for discriminated intersection typeshttps://github.com/microsoft/TypeScript/pull/9939/commits/5eec3c71e7c8e713ae8b4a112a87d6010b0a2be2
5eec3c7https://github.com/microsoft/TypeScript/pull/9939/commits/5eec3c71e7c8e713ae8b4a112a87d6010b0a2be2
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
Jul 25, 2016https://github.com/microsoft/TypeScript/pull/9939#issuecomment-235109635
Marin Marinov (@gcnew)https://github.com/gcnew
https://cla.microsoft.comhttps://cla.microsoft.com
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-required
Jul 25, 2016https://github.com/microsoft/TypeScript/pull/9939#event-734241093
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Jul 25, 2016https://github.com/microsoft/TypeScript/pull/9939#issuecomment-235111542
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
Jul 25, 2016https://github.com/microsoft/TypeScript/pull/9939#issuecomment-235114827
Marin Marinov (@gcnew)https://github.com/gcnew
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-signed https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-signed
cla-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-required
Jul 25, 2016https://github.com/microsoft/TypeScript/pull/9939#event-734263950
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Jul 26, 2016https://github.com/microsoft/TypeScript/pull/9939#issuecomment-235138100
Marin Marinov (@gcnew)https://github.com/gcnew
#9407https://github.com/microsoft/TypeScript/pull/9407
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
DanielRosenwasserhttps://github.com/DanielRosenwasser
Jul 26, 2016 https://github.com/microsoft/TypeScript/pull/9939#discussion-diff-72178954
View reviewed changes https://github.com/microsoft/TypeScript/pull/9939/files/5eec3c71e7c8e713ae8b4a112a87d6010b0a2be2#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/9939/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jul 26, 2016https://github.com/microsoft/TypeScript/pull/9939#discussion_r72178954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
Marin Marinov (gcnew)https://github.com/gcnew
Jul 26, 2016https://github.com/microsoft/TypeScript/pull/9939#discussion_r72253041
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/gcnew
Correctly narrow any blending of discriminated unions and intersectionshttps://github.com/microsoft/TypeScript/pull/9939/commits/32f0d5e2bf8c943b1dc54c66858f03e5ed9ade5e
32f0d5ehttps://github.com/microsoft/TypeScript/pull/9939/commits/32f0d5e2bf8c943b1dc54c66858f03e5ed9ade5e
https://github.com/gcnew
Marin Marinov (gcnew)https://github.com/gcnew
Jul 26, 2016https://github.com/microsoft/TypeScript/pull/9939#issuecomment-235286031
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
#9407https://github.com/microsoft/TypeScript/pull/9407
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Sep 14, 2016https://github.com/microsoft/TypeScript/pull/9939#event-788423671
https://github.com/gcnew
Marin Marinov (gcnew)https://github.com/gcnew
Oct 19, 2016https://github.com/microsoft/TypeScript/pull/9939#issuecomment-254686173
#11717https://github.com/microsoft/TypeScript/pull/11717
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/gcnew
Marin Marinov (gcnew)https://github.com/gcnew
Oct 19, 2016https://github.com/microsoft/TypeScript/pull/9939#event-828391721
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/9939#event-1689843689
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F9939
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/mhegazy
Mohamed Hegazy (mhegazy) https://github.com/mhegazy
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9939
https://github.com/gcnew
https://github.com/msftclas
https://github.com/RyanCavanaugh
https://github.com/ahejlsberg
https://github.com/DanielRosenwasser
https://github.com/mhegazy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.