René's URL Explorer Experiment


Title: Make overload resolution more elaborate by JsonFreeman · Pull Request #951 · microsoft/TypeScript · GitHub

Open Graph Title: Make overload resolution more elaborate by JsonFreeman · Pull Request #951 · microsoft/TypeScript

X Title: Make overload resolution more elaborate by JsonFreeman · Pull Request #951 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Make overload resolution more elaborate by JsonFreeman · Pull Request #951 · microsoft/TypeScript

Open Graph Description: This change adds some better error experience for overload resolution. It also fixes bug #807. One future goal that is not in this change: We should ideally instantiate all the signatures we give b...

X Description: This change adds some better error experience for overload resolution. It also fixes bug #807. One future goal that is not in this change: We should ideally instantiate all the signatures we give b...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/951

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3213dc16-5d02-5940-4338-afb062044aa2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id930C:3135A1:298B4F:3A0FCB:6B008956
html-safe-nonce2394a2311f6224eb13d046074564bc6ba160ad5ddb3be9e163fb53909f562ec4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzBDOjMxMzVBMToyOThCNEY6M0EwRkNCOjZCMDA4OTU2IiwidmlzaXRvcl9pZCI6IjU0MDUwNTE3MjIwMDk3MDg4ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ca9786bf60cd5599cd86740b8c76fda4a7440cdfbf7b4ab604bdf75c867b4b8
hovercard-subject-tagpull_request:23252154
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/951/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5ea9e7e0c6c521313d10af6c65c45d81fa29a807cface584754958799aa94283/microsoft/TypeScript/pull/951
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5ea9e7e0c6c521313d10af6c65c45d81fa29a807cface584754958799aa94283/microsoft/TypeScript/pull/951
og:image:altThis change adds some better error experience for overload resolution. It also fixes bug #807. One future goal that is not in this change: We should ideally instantiate all the signatures we give b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJsonFreeman
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/951#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F951
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F951
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/951
Reloadhttps://github.com/microsoft/TypeScript/pull/951
Reloadhttps://github.com/microsoft/TypeScript/pull/951
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests311 (311)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
masterhttps://github.com/microsoft/TypeScript/tree/master
overloadResolutionhttps://github.com/microsoft/TypeScript/tree/overloadResolution
Conversationhttps://github.com/microsoft/TypeScript/pull/951
Commits14 (14)https://github.com/microsoft/TypeScript/pull/951/commits
Checkshttps://github.com/microsoft/TypeScript/pull/951/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/951/files
Make overload resolution more elaboratehttps://github.com/microsoft/TypeScript/pull/951#top
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
masterhttps://github.com/microsoft/TypeScript/tree/master
overloadResolutionhttps://github.com/microsoft/TypeScript/tree/overloadResolution
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Oct 23, 2014https://github.com/microsoft/TypeScript/pull/951#issue-46665105
#807https://github.com/microsoft/TypeScript/issues/807
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/951
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
October 22, 2014 15:08https://github.com/microsoft/TypeScript/pull/951#commits-pushed-d3af1e3
https://github.com/JsonFreeman
Move overload resolution logic into chooseOverload functionhttps://github.com/microsoft/TypeScript/pull/951/commits/d3af1e3c4abf72d45d57da142b11ae670d896079
https://github.com/microsoft/TypeScript/commit/d3af1e3c4abf72d45d57da142b11ae670d896079#comments
d3af1e3https://github.com/microsoft/TypeScript/pull/951/commits/d3af1e3c4abf72d45d57da142b11ae670d896079
https://github.com/JsonFreeman
Begin refactoring overload resolution to collect more infohttps://github.com/microsoft/TypeScript/pull/951/commits/f6b7bfa948a33419116250a04e7e69e44c4ae6f6
https://github.com/microsoft/TypeScript/commit/f6b7bfa948a33419116250a04e7e69e44c4ae6f6#comments
f6b7bfahttps://github.com/microsoft/TypeScript/pull/951/commits/f6b7bfa948a33419116250a04e7e69e44c4ae6f6
https://github.com/JsonFreeman
Give different errors for different overload resolution issueshttps://github.com/microsoft/TypeScript/pull/951/commits/44f1ab07bf89a5123f226443cc557d1d6116230e
https://github.com/microsoft/TypeScript/commit/44f1ab07bf89a5123f226443cc557d1d6116230e#comments
44f1ab0https://github.com/microsoft/TypeScript/pull/951/commits/44f1ab07bf89a5123f226443cc557d1d6116230e
https://github.com/JsonFreeman
Revert the stuffing of instantiated signatures back into the candidat…https://github.com/microsoft/TypeScript/pull/951/commits/e8d5fdc286de4fe672973de744edbc85833124a2
https://github.com/microsoft/TypeScript/commit/e8d5fdc286de4fe672973de744edbc85833124a2#comments
e8d5fdchttps://github.com/microsoft/TypeScript/pull/951/commits/e8d5fdc286de4fe672973de744edbc85833124a2
https://github.com/JsonFreeman
Specify error message for type argument inference failinghttps://github.com/microsoft/TypeScript/pull/951/commits/47bded060e97a21934fddd730dabf472e2999286
https://github.com/microsoft/TypeScript/commit/47bded060e97a21934fddd730dabf472e2999286#comments
47bded0https://github.com/microsoft/TypeScript/pull/951/commits/47bded060e97a21934fddd730dabf472e2999286
https://github.com/JsonFreeman
Add test for bughttps://github.com/microsoft/TypeScript/pull/951/commits/25171857c598ad036696831894b4d5ddadeb5e21
#807https://github.com/microsoft/TypeScript/issues/807
2517185https://github.com/microsoft/TypeScript/pull/951/commits/25171857c598ad036696831894b4d5ddadeb5e21
https://github.com/JsonFreeman
Have inferArgumentTypes return the InferenceContexthttps://github.com/microsoft/TypeScript/pull/951/commits/05300a7efe607b7ec74816f8a7eb1a3b451a4bea
https://github.com/microsoft/TypeScript/commit/05300a7efe607b7ec74816f8a7eb1a3b451a4bea#comments
05300a7https://github.com/microsoft/TypeScript/pull/951/commits/05300a7efe607b7ec74816f8a7eb1a3b451a4bea
https://github.com/JsonFreeman
Report type argument inference errors on specific candidateshttps://github.com/microsoft/TypeScript/pull/951/commits/9865e09fb75c1a8688e6e38c2ee20b145f8dcc53
https://github.com/microsoft/TypeScript/commit/9865e09fb75c1a8688e6e38c2ee20b145f8dcc53#comments
9865e09https://github.com/microsoft/TypeScript/pull/951/commits/9865e09fb75c1a8688e6e38c2ee20b145f8dcc53
https://github.com/JsonFreeman
Merge branch 'master' into overloadResolutionhttps://github.com/microsoft/TypeScript/pull/951/commits/bfb63df56884e408a99c52f00916dda2dc30fb18
bfb63dfhttps://github.com/microsoft/TypeScript/pull/951/commits/bfb63df56884e408a99c52f00916dda2dc30fb18
https://github.com/JsonFreeman
Update baselineshttps://github.com/microsoft/TypeScript/pull/951/commits/431bf9a74632593d2afafb9bb5e86fe0c5c30ee3
https://github.com/microsoft/TypeScript/commit/431bf9a74632593d2afafb9bb5e86fe0c5c30ee3#comments
431bf9ahttps://github.com/microsoft/TypeScript/pull/951/commits/431bf9a74632593d2afafb9bb5e86fe0c5c30ee3
https://github.com/JsonFreeman
Address PR feedbackhttps://github.com/microsoft/TypeScript/pull/951/commits/7dc86837a3b140d5420671d58c2652dd898469bc
https://github.com/microsoft/TypeScript/commit/7dc86837a3b140d5420671d58c2652dd898469bc#comments
7dc8683https://github.com/microsoft/TypeScript/pull/951/commits/7dc86837a3b140d5420671d58c2652dd898469bc
https://github.com/JsonFreeman
Make chainedMessage, terminalMessage, and containingMessageChain opti…https://github.com/microsoft/TypeScript/pull/951/commits/962cde9fd629ef1d12bc86164f2d0b142814bcf3
https://github.com/microsoft/TypeScript/commit/962cde9fd629ef1d12bc86164f2d0b142814bcf3#comments
962cde9https://github.com/microsoft/TypeScript/pull/951/commits/962cde9fd629ef1d12bc86164f2d0b142814bcf3
https://github.com/JsonFreeman
Merge branch 'master' into overloadResolutionhttps://github.com/microsoft/TypeScript/pull/951/commits/d1079e40bf0f68f1f4ceab1cd53fc692d5c0592c
d1079e4https://github.com/microsoft/TypeScript/pull/951/commits/d1079e40bf0f68f1f4ceab1cd53fc692d5c0592c
ahejlsberghttps://github.com/ahejlsberg
Oct 27, 2014 https://github.com/microsoft/TypeScript/pull/951#discussion-diff-19438801
View reviewed changes https://github.com/microsoft/TypeScript/pull/951/files/d1079e40bf0f68f1f4ceab1cd53fc692d5c0592c#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/951/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Oct 27, 2014https://github.com/microsoft/TypeScript/pull/951#discussion_r19438801
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/951
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Oct 27, 2014https://github.com/microsoft/TypeScript/pull/951#discussion_r19439354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/951
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Oct 27, 2014 https://github.com/microsoft/TypeScript/pull/951#ref-issue-39483759
Issue a warning when generic type inference produces {} #360 https://github.com/microsoft/TypeScript/issues/360
https://github.com/JsonFreeman
More PR feedbackhttps://github.com/microsoft/TypeScript/pull/951/commits/d14228ed829d4bc5026faf86f72e509fd4ce4db5
d14228ehttps://github.com/microsoft/TypeScript/pull/951/commits/d14228ed829d4bc5026faf86f72e509fd4ce4db5
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Oct 27, 2014 https://github.com/microsoft/TypeScript/pull/951#ref-commit-c28fb0e
https://github.com/JsonFreeman
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/c28fb0e0fb60a61d95d84f527193d04a5f248ae8
#951https://github.com/microsoft/TypeScript/pull/951
from Microsoft/overloadResolutionhttps://github.com/microsoft/TypeScript/commit/c28fb0e0fb60a61d95d84f527193d04a5f248ae8
c28fb0ehttps://github.com/microsoft/TypeScript/commit/c28fb0e0fb60a61d95d84f527193d04a5f248ae8
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
c28fb0ehttps://github.com/microsoft/TypeScript/commit/c28fb0e0fb60a61d95d84f527193d04a5f248ae8
Oct 27, 2014https://github.com/microsoft/TypeScript/pull/951#event-184402486
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
October 27, 2014 23:20https://github.com/microsoft/TypeScript/pull/951#event-184402502
https://github.com/JsonFreeman
Jason Freeman (JsonFreeman)https://github.com/JsonFreeman
Oct 27, 2014 https://github.com/microsoft/TypeScript/pull/951#ref-issue-44744196
Overload resolution produces an incorrect error when type arguments don't satisfy the first overload #807 https://github.com/microsoft/TypeScript/issues/807
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 18, 2018https://github.com/microsoft/TypeScript/pull/951#event-1686910221
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F951
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/951
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/951
https://github.com/JsonFreeman
https://github.com/ahejlsberg
https://github.com/CyrusNajmabadi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.