René's URL Explorer Experiment


Title: Prevent renaming `this` parameters by sandersn · Pull Request #9171 · microsoft/TypeScript · GitHub

Open Graph Title: Prevent renaming `this` parameters by sandersn · Pull Request #9171 · microsoft/TypeScript

X Title: Prevent renaming `this` parameters by sandersn · Pull Request #9171 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Prevent renaming `this` parameters by sandersn · Pull Request #9171 · microsoft/TypeScript

Open Graph Description: Fixes #9037 I'm going to look into making the parser allow a ThisKeyword as a ParameterDeclaration, but I think this will turn out to be the right fix.

X Description: Fixes #9037 I'm going to look into making the parser allow a ThisKeyword as a ParameterDeclaration, but I think this will turn out to be the right fix.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/9171

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:278137e6-8915-5e35-03bf-44f7b04d4285
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8690:16D129:10B2942:17073FB:6AFA3FD5
html-safe-noncec7ab17b8c76c5d40518733fdc565f9a42f9be54a6500e48ba23ae529bd863be8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjkwOjE2RDEyOToxMEIyOTQyOjE3MDczRkI6NkFGQTNGRDUiLCJ2aXNpdG9yX2lkIjoiNDEyMDgzODM5MjkyMzE3NjkxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac754e99248efe9d7b03b35b5c824a1ea92e367fa9ff8c533b647d53584654fc44
hovercard-subject-tagpull_request:73824443
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/9171/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9acdde1b95cdc3f31767d4e70eccee11bf03ed902986093efbc79213ea07396d/microsoft/TypeScript/pull/9171
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9acdde1b95cdc3f31767d4e70eccee11bf03ed902986093efbc79213ea07396d/microsoft/TypeScript/pull/9171
og:image:altFixes #9037 I'm going to look into making the parser allow a ThisKeyword as a ParameterDeclaration, but I think this will turn out to be the right fix.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/9171#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F9171
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F9171
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/9171
Reloadhttps://github.com/microsoft/TypeScript/pull/9171
Reloadhttps://github.com/microsoft/TypeScript/pull/9171
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests340 (340)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
prevent-renaming-this-parameterhttps://github.com/microsoft/TypeScript/tree/prevent-renaming-this-parameter
Conversationhttps://github.com/microsoft/TypeScript/pull/9171
Commits1 (1)https://github.com/microsoft/TypeScript/pull/9171/commits
Checkshttps://github.com/microsoft/TypeScript/pull/9171/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/9171/files
Prevent renaming this parametershttps://github.com/microsoft/TypeScript/pull/9171#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
masterhttps://github.com/microsoft/TypeScript/tree/master
prevent-renaming-this-parameterhttps://github.com/microsoft/TypeScript/tree/prevent-renaming-this-parameter
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 14, 2016https://github.com/microsoft/TypeScript/pull/9171#issue-160298706
#9037https://github.com/microsoft/TypeScript/issues/9037
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9171
https://github.com/sandersn
Prevent renaming this parametershttps://github.com/microsoft/TypeScript/pull/9171/commits/58da6fbd7206406fdfdb25d99dab8a729fb13c4a
58da6fbhttps://github.com/microsoft/TypeScript/pull/9171/commits/58da6fbd7206406fdfdb25d99dab8a729fb13c4a
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Jun 14, 2016https://github.com/microsoft/TypeScript/pull/9171#event-692528950
mhegazyhttps://github.com/mhegazy
Jun 15, 2016 https://github.com/microsoft/TypeScript/pull/9171#discussion-diff-67081909
View reviewed changes https://github.com/microsoft/TypeScript/pull/9171/files/58da6fbd7206406fdfdb25d99dab8a729fb13c4a#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/9171/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 15, 2016https://github.com/microsoft/TypeScript/pull/9171#discussion_r67081909
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9171
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 15, 2016 https://github.com/microsoft/TypeScript/pull/9171#ref-issue-160506487
this in function paramter list not classified as a keyword #9197 https://github.com/microsoft/TypeScript/issues/9197
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 17, 2016 https://github.com/microsoft/TypeScript/pull/9171#ref-issue-159298683
this-function parameter can be renamed #9037 https://github.com/microsoft/TypeScript/issues/9037
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 21, 2016https://github.com/microsoft/TypeScript/pull/9171#issuecomment-227508993
#9270https://github.com/microsoft/TypeScript/pull/9270
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9171
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 21, 2016https://github.com/microsoft/TypeScript/pull/9171#event-699380872
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
June 21, 2016 17:39https://github.com/microsoft/TypeScript/pull/9171#event-699409800
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/9171#event-1689839441
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F9171
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9171
this-function parameter can be renamed https://github.com/microsoft/TypeScript/issues/9037
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/9171
https://github.com/sandersn
https://github.com/mhegazy
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.