René's URL Explorer Experiment


Title: Fix primitive narrowing by weswigham · Pull Request #8993 · microsoft/TypeScript · GitHub

Open Graph Title: Fix primitive narrowing by weswigham · Pull Request #8993 · microsoft/TypeScript

X Title: Fix primitive narrowing by weswigham · Pull Request #8993 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix primitive narrowing by weswigham · Pull Request #8993 · microsoft/TypeScript

Open Graph Description: Fixes #7224. Fixes #7441. This is a re-submission of #7235 without the inversion of the type flag - meaning it simply adds all primitive types and intersection types to the narrowable types list. A...

X Description: Fixes #7224. Fixes #7441. This is a re-submission of #7235 without the inversion of the type flag - meaning it simply adds all primitive types and intersection types to the narrowable types list. A...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/8993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b6b9ce96-fcda-26f6-5cab-9266b889ff51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4FE:34BA36:2511F2:34268D:6AFBF3E9
html-safe-nonceedd7016856016d9df875ba7cfb00730f22ce428baa54ae5ad24a8647f42766bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEZFOjM0QkEzNjoyNTExRjI6MzQyNjhEOjZBRkJGM0U5IiwidmlzaXRvcl9pZCI6Ijc4OTI4MTc4ODkzNDA0MjEwOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac30069404e89207c78c9d011be6a63de6f0d11bcff6b718d43c7ea1423078fbf9
hovercard-subject-tagpull_request:72769739
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/8993/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c3f580127738ec783ac28fbd862f900b8cff3d32a4241c9dc5fc9c5667f6f9fa/microsoft/TypeScript/pull/8993
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c3f580127738ec783ac28fbd862f900b8cff3d32a4241c9dc5fc9c5667f6f9fa/microsoft/TypeScript/pull/8993
og:image:altFixes #7224. Fixes #7441. This is a re-submission of #7235 without the inversion of the type flag - meaning it simply adds all primitive types and intersection types to the narrowable types list. A...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/8993#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8993
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8993
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/8993
Reloadhttps://github.com/microsoft/TypeScript/pull/8993
Reloadhttps://github.com/microsoft/TypeScript/pull/8993
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:refix-primitive-narrowinghttps://github.com/weswigham/TypeScript/tree/refix-primitive-narrowing
Conversationhttps://github.com/microsoft/TypeScript/pull/8993
Commits2 (2)https://github.com/microsoft/TypeScript/pull/8993/commits
Checkshttps://github.com/microsoft/TypeScript/pull/8993/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/8993/files
Fix primitive narrowinghttps://github.com/microsoft/TypeScript/pull/8993#top
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
weswigham:refix-primitive-narrowinghttps://github.com/weswigham/TypeScript/tree/refix-primitive-narrowing
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#issue-158763655
#7224https://github.com/microsoft/TypeScript/issues/7224
#7441https://github.com/microsoft/TypeScript/issues/7441
#7235https://github.com/microsoft/TypeScript/pull/7235
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Nathan Shively-Sanders (@sandersn)https://github.com/sandersn
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
Wesley Wigham (weswigham)https://github.com/weswigham
June 6, 2016 12:52https://github.com/microsoft/TypeScript/pull/8993#commits-pushed-9761c3b
https://github.com/weswigham
Revert "Revert "Merge pull requesthttps://github.com/microsoft/TypeScript/pull/8993/commits/9761c3be9710a2ce16430f237183dce9ae160dbc
microsoft#7235https://github.com/microsoft/TypeScript/pull/7235
from weswigham/narr…https://github.com/microsoft/TypeScript/pull/8993/commits/9761c3be9710a2ce16430f237183dce9ae160dbc
9761c3bhttps://github.com/microsoft/TypeScript/pull/8993/commits/9761c3be9710a2ce16430f237183dce9ae160dbc
fc3e040https://github.com/weswigham/TypeScript/commit/fc3e040c5167868ed623612e8f33fb3beedf73b1
https://github.com/weswigham
Use inclusive flag, as originally done, but include almost everythinghttps://github.com/microsoft/TypeScript/pull/8993/commits/26b1ab499c21713fd360a42e52bf9e9f171df4cc
26b1ab4https://github.com/microsoft/TypeScript/pull/8993/commits/26b1ab499c21713fd360a42e52bf9e9f171df4cc
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-already-signed https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-already-signed
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#event-683392444
sandersnhttps://github.com/sandersn
Jun 6, 2016 https://github.com/microsoft/TypeScript/pull/8993#discussion-diff-65962339
View reviewed changes https://github.com/microsoft/TypeScript/pull/8993/files/26b1ab499c21713fd360a42e52bf9e9f171df4cc#diff-9c755f1e369e71547ffee2ed300c0a7a1253595fc32fdcd7bfa9584f8a82b1f4
tests/cases/conformance/expressions/typeGuards/typeGuardNarrowsPrimitiveIntersection.tshttps://github.com/microsoft/TypeScript/pull/8993/files#diff-9c755f1e369e71547ffee2ed300c0a7a1253595fc32fdcd7bfa9584f8a82b1f4
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#discussion_r65962339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#discussion_r65978857
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#issuecomment-224104596
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#issuecomment-224106028
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
bfafecchttps://github.com/microsoft/TypeScript/commit/bfafecca0c0a4c5b72fac0e86cfa15fb9a6faed2
Jun 6, 2016https://github.com/microsoft/TypeScript/pull/8993#event-683541271
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
June 6, 2016 22:18https://github.com/microsoft/TypeScript/pull/8993#event-683541330
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 6, 2016 https://github.com/microsoft/TypeScript/pull/8993#ref-pullrequest-136318404
Fix #7224, #7441 - Replace TypeFlags.Narrowable #7235 https://github.com/microsoft/TypeScript/pull/7235
https://github.com/zpdDG4gta8XKpMCd
ZpdDG4gta (zpdDG4gta8XKpMCd)https://github.com/zpdDG4gta8XKpMCd
Jun 7, 2016https://github.com/microsoft/TypeScript/pull/8993#issuecomment-224127290
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
Jun 7, 2016https://github.com/microsoft/TypeScript/pull/8993#issuecomment-224160959
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
https://github.com/yortus
Troy Gerwien (yortus)https://github.com/yortus
Jun 8, 2016 https://github.com/microsoft/TypeScript/pull/8993#ref-issue-135027723
Errors issued for working code due to narrowing behaviour #7160 https://github.com/microsoft/TypeScript/issues/7160
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/8993#event-1689838221
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8993
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8993
https://github.com/weswigham
https://github.com/sandersn
https://github.com/zpdDG4gta8XKpMCd
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.