René's URL Explorer Experiment


Title: Refactor navigation bar · Pull Request #8958 · microsoft/TypeScript · GitHub

Open Graph Title: Refactor navigation bar · Pull Request #8958 · microsoft/TypeScript

X Title: Refactor navigation bar · Pull Request #8958 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Refactor navigation bar · Pull Request #8958 · microsoft/TypeScript

Open Graph Description: Fixes #8779, #5258, #4191, and #8218. Gets us closer to #7523 (combines TS and JS code paths for navigation bar).

X Description: Fixes #8779, #5258, #4191, and #8218. Gets us closer to #7523 (combines TS and JS code paths for navigation bar).

Opengraph URL: https://github.com/microsoft/TypeScript/pull/8958

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ef5c4093-9272-8d15-014f-162942f0f00e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA2E:C8BDE:8BD0CA:C2D082:6AFA0B9B
html-safe-nonce243dbf94b29495de860b4bd70e568c1afe7eb67c7c07cd0ca77233edab042f1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTJFOkM4QkRFOjhCRDBDQTpDMkQwODI6NkFGQTBCOUIiLCJ2aXNpdG9yX2lkIjoiMjc4NjAzODY1NTU1NjkxNDA3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac71f37b02068fd34b2b918a37e5325e46eb42c46d7b2633e26934d10a903bd9de
hovercard-subject-tagpull_request:72525375
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/8958/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d2dd754f4bfd3a53c66a0b6578e7cecd83ed54344b469af89290e4cc5fd80ca/microsoft/TypeScript/pull/8958
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d2dd754f4bfd3a53c66a0b6578e7cecd83ed54344b469af89290e4cc5fd80ca/microsoft/TypeScript/pull/8958
og:image:altFixes #8779, #5258, #4191, and #8218. Gets us closer to #7523 (combines TS and JS code paths for navigation bar).
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/8958#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8958
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8958
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/8958
Reloadhttps://github.com/microsoft/TypeScript/pull/8958
Reloadhttps://github.com/microsoft/TypeScript/pull/8958
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests338 (338)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Deleted user (ghost)https://github.com/ghost
masterhttps://github.com/microsoft/TypeScript/tree/master
navbar_refactor_2.0https://github.com/microsoft/TypeScript/tree/navbar_refactor_2.0
Conversationhttps://github.com/microsoft/TypeScript/pull/8958
Commits12 (12)https://github.com/microsoft/TypeScript/pull/8958/commits
Checkshttps://github.com/microsoft/TypeScript/pull/8958/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/8958/files
Refactor navigation barhttps://github.com/microsoft/TypeScript/pull/8958#top
Deleted user (ghost)https://github.com/ghost
masterhttps://github.com/microsoft/TypeScript/tree/master
navbar_refactor_2.0https://github.com/microsoft/TypeScript/tree/navbar_refactor_2.0
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
Jun 3, 2016https://github.com/microsoft/TypeScript/pull/8958#issue-158393063
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
#8779https://github.com/microsoft/TypeScript/issues/8779
#5258https://github.com/microsoft/TypeScript/issues/5258
#4191https://github.com/microsoft/TypeScript/issues/4191
#8218https://github.com/microsoft/TypeScript/issues/8218
#7523https://github.com/microsoft/TypeScript/issues/7523
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
Refactor navigation barhttps://github.com/microsoft/TypeScript/pull/8958/commits/11b72913932acee42b2c20a64c62763640b128eb
11b7291https://github.com/microsoft/TypeScript/pull/8958/commits/11b72913932acee42b2c20a64c62763640b128eb
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Jun 3, 2016https://github.com/microsoft/TypeScript/pull/8958#event-681283548
Navigation bar class expression #8648 https://github.com/microsoft/TypeScript/pull/8648
Navbar refactor #8865 https://github.com/microsoft/TypeScript/pull/8865
force-pushedhttps://github.com/microsoft/TypeScript/compare/11b72913932acee42b2c20a64c62763640b128eb..89a5d6d98e1040c8355f7c4c527222d2353571a8
11b7291https://github.com/microsoft/TypeScript/commit/11b72913932acee42b2c20a64c62763640b128eb
89a5d6dhttps://github.com/microsoft/TypeScript/commit/89a5d6d98e1040c8355f7c4c527222d2353571a8
Compare https://github.com/microsoft/TypeScript/compare/11b72913932acee42b2c20a64c62763640b128eb..89a5d6d98e1040c8355f7c4c527222d2353571a8
June 3, 2016 15:46https://github.com/microsoft/TypeScript/pull/8958#event-681308572
Fix locale compare for node 0.10https://github.com/microsoft/TypeScript/pull/8958/commits/077489269a4ae661b6e22e6628e6bbfd0c3503f4
0774892https://github.com/microsoft/TypeScript/pull/8958/commits/077489269a4ae661b6e22e6628e6bbfd0c3503f4
force-pushedhttps://github.com/microsoft/TypeScript/compare/89a5d6d98e1040c8355f7c4c527222d2353571a8..077489269a4ae661b6e22e6628e6bbfd0c3503f4
89a5d6dhttps://github.com/microsoft/TypeScript/commit/89a5d6d98e1040c8355f7c4c527222d2353571a8
0774892https://github.com/microsoft/TypeScript/commit/077489269a4ae661b6e22e6628e6bbfd0c3503f4
Compare https://github.com/microsoft/TypeScript/compare/89a5d6d98e1040c8355f7c4c527222d2353571a8..077489269a4ae661b6e22e6628e6bbfd0c3503f4
June 3, 2016 16:07https://github.com/microsoft/TypeScript/pull/8958#event-681334893
Jun 3, 2016 https://github.com/microsoft/TypeScript/pull/8958#ref-commit-cc5b103
Fix localeCompare differences in node versionshttps://github.com/microsoft/TypeScript/commit/cc5b103b2ee59a61241cd8cc942497f048f7012b
https://github.com/microsoft/TypeScript/commit/cc5b103b2ee59a61241cd8cc942497f048f7012b#comments
cc5b103https://github.com/microsoft/TypeScript/commit/cc5b103b2ee59a61241cd8cc942497f048f7012b
June 3, 2016 09:32https://github.com/microsoft/TypeScript/pull/8958#commits-pushed-eae7ca7
Fix lint errorhttps://github.com/microsoft/TypeScript/pull/8958/commits/eae7ca787f4195c1f2447c0670f12a6e78f41a3a
eae7ca7https://github.com/microsoft/TypeScript/pull/8958/commits/eae7ca787f4195c1f2447c0670f12a6e78f41a3a
Remove call to isDeclaration; since we use a different idea of a de…https://github.com/microsoft/TypeScript/pull/8958/commits/19ce6f712616c987f503debf40cb83d84db93a76
19ce6f7https://github.com/microsoft/TypeScript/pull/8958/commits/19ce6f712616c987f503debf40cb83d84db93a76
Add more testshttps://github.com/microsoft/TypeScript/pull/8958/commits/981a9836ecd0c822b2524ebbe7aca508993f307e
981a983https://github.com/microsoft/TypeScript/pull/8958/commits/981a9836ecd0c822b2524ebbe7aca508993f307e
Fix namehttps://github.com/microsoft/TypeScript/pull/8958/commits/56b91fdbd422b1c8d0d498d0733d1c45a99cb921
56b91fdhttps://github.com/microsoft/TypeScript/pull/8958/commits/56b91fdbd422b1c8d0d498d0733d1c45a99cb921
Merge branch 'master' into navbar_refactor_2.0https://github.com/microsoft/TypeScript/pull/8958/commits/99b361a601c78d620fa2917079e102f6294fe9ad
99b361ahttps://github.com/microsoft/TypeScript/pull/8958/commits/99b361a601c78d620fa2917079e102f6294fe9ad
Fix testhttps://github.com/microsoft/TypeScript/pull/8958/commits/902a667097e2cad04b3bdea433c575f87929e472
902a667https://github.com/microsoft/TypeScript/pull/8958/commits/902a667097e2cad04b3bdea433c575f87929e472
Jun 6, 2016 https://github.com/microsoft/TypeScript/pull/8958#ref-issue-149793768
TypeScript symbols is empty inside closure (like jQuery plugins) #8218 https://github.com/microsoft/TypeScript/issues/8218
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 9, 2016https://github.com/microsoft/TypeScript/pull/8958#event-687612696
weswighamhttps://github.com/weswigham
Jun 9, 2016 https://github.com/microsoft/TypeScript/pull/8958#discussion-diff-66493377
View reviewed changes https://github.com/microsoft/TypeScript/pull/8958/files/902a667097e2cad04b3bdea433c575f87929e472#diff-6740404ec2d88bc50e64dc4a0ef5896878c4d848b0a52900c205be6844654f8f
src/services/navigationBar.tshttps://github.com/microsoft/TypeScript/pull/8958/files#diff-6740404ec2d88bc50e64dc4a0ef5896878c4d848b0a52900c205be6844654f8f
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 9, 2016https://github.com/microsoft/TypeScript/pull/8958#discussion_r66493377
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
Respond to PR commentshttps://github.com/microsoft/TypeScript/pull/8958/commits/1c9e64b0f2ce20517ea82047e9f82c011ca268e1
1c9e64bhttps://github.com/microsoft/TypeScript/pull/8958/commits/1c9e64b0f2ce20517ea82047e9f82c011ca268e1
weswighamhttps://github.com/weswigham
Jun 10, 2016 https://github.com/microsoft/TypeScript/pull/8958#discussion-diff-66655593
View reviewed changes https://github.com/microsoft/TypeScript/pull/8958/files/1c9e64b0f2ce20517ea82047e9f82c011ca268e1#diff-6740404ec2d88bc50e64dc4a0ef5896878c4d848b0a52900c205be6844654f8f
src/services/navigationBar.tshttps://github.com/microsoft/TypeScript/pull/8958/files#diff-6740404ec2d88bc50e64dc4a0ef5896878c4d848b0a52900c205be6844654f8f
Wesley Wigham (weswigham)https://github.com/weswigham
Jun 10, 2016https://github.com/microsoft/TypeScript/pull/8958#discussion_r66655593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 10, 2016https://github.com/microsoft/TypeScript/pull/8958#discussion_r66686704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
Deleted user (ghost)https://github.com/ghost
Jun 13, 2016https://github.com/microsoft/TypeScript/pull/8958#discussion_r66786443
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jun 10, 2016https://github.com/microsoft/TypeScript/pull/8958#issuecomment-225316272
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
June 13, 2016 06:10https://github.com/microsoft/TypeScript/pull/8958#commits-pushed-2f5f7e4
Respond to some PR commentshttps://github.com/microsoft/TypeScript/pull/8958/commits/2f5f7e46d3396109954e80cd4cc732257fd1e037
2f5f7e4https://github.com/microsoft/TypeScript/pull/8958/commits/2f5f7e46d3396109954e80cd4cc732257fd1e037
Improve performancehttps://github.com/microsoft/TypeScript/pull/8958/commits/7eb3ce6ac86ba295d4172b8bb3d4d21fa1d69ed3
7eb3ce6https://github.com/microsoft/TypeScript/pull/8958/commits/7eb3ce6ac86ba295d4172b8bb3d4d21fa1d69ed3
Jun 13, 2016 https://github.com/microsoft/TypeScript/pull/8958#ref-pullrequest-160022767
Add test for jsdoc in navigation bar #9140 https://github.com/microsoft/TypeScript/pull/9140
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8958
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
https://github.com/weswigham
Wesley Wigham (weswigham) https://github.com/weswigham
Navigation bar: functions nested in methods https://github.com/microsoft/TypeScript/issues/8779
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8958
https://github.com/mhegazy
https://github.com/weswigham
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.