René's URL Explorer Experiment


Title: Fix #7590: Allow 'readonly' to be used in constructor parameters · Pull Request #8555 · microsoft/TypeScript · GitHub

Open Graph Title: Fix #7590: Allow 'readonly' to be used in constructor parameters · Pull Request #8555 · microsoft/TypeScript

X Title: Fix #7590: Allow 'readonly' to be used in constructor parameters · Pull Request #8555 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix #7590: Allow 'readonly' to be used in constructor parameters · Pull Request #8555 · microsoft/TypeScript

Open Graph Description: Fixes #7590

X Description: Fixes #7590

Opengraph URL: https://github.com/microsoft/TypeScript/pull/8555

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:344e99a3-27a5-6b0f-c1c8-e971f97e3a1e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC548:1DB641:4A429E:61C572:6B00C96D
html-safe-noncede454dee19b57aa56f8451a742fa17913c71a56aa3c3f8839c43e3be414a3a17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTQ4OjFEQjY0MTo0QTQyOUU6NjFDNTcyOjZCMDBDOTZEIiwidmlzaXRvcl9pZCI6IjY2ODcwMjI3MzQ1Njk5NDk1NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac94d5c93684075c07e7bc524bec31ac7324ba371952d80a884524fefd6d4ca752
hovercard-subject-tagpull_request:69694890
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/8555/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a1d1a25816e2fbaf2ddccc4744887cc40a406b1028c05d582cce6daae493209/microsoft/TypeScript/pull/8555
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a1d1a25816e2fbaf2ddccc4744887cc40a406b1028c05d582cce6daae493209/microsoft/TypeScript/pull/8555
og:image:altFixes #7590
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseef013399cf0a3c324bea644a685d7c1e0f06b5b7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/8555#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8555
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8555
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/8555
Reloadhttps://github.com/microsoft/TypeScript/pull/8555
Reloadhttps://github.com/microsoft/TypeScript/pull/8555
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
masterhttps://github.com/microsoft/TypeScript/tree/master
readonly_ctrhttps://github.com/microsoft/TypeScript/tree/readonly_ctr
Conversationhttps://github.com/microsoft/TypeScript/pull/8555
Commits6 (6)https://github.com/microsoft/TypeScript/pull/8555/commits
Checkshttps://github.com/microsoft/TypeScript/pull/8555/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/8555/files
Fix #7590: Allow 'readonly' to be used in constructor parametershttps://github.com/microsoft/TypeScript/pull/8555#top
masterhttps://github.com/microsoft/TypeScript/tree/master
readonly_ctrhttps://github.com/microsoft/TypeScript/tree/readonly_ctr
https://github.com/ghost
Deleted user (ghost)https://github.com/ghost
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issue-154276038
#7590https://github.com/microsoft/TypeScript/issues/7590
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Fixhttps://github.com/microsoft/TypeScript/pull/8555/commits/ad2634e34309954b80ed6f2ed1d5d8de3460dc5d
#7590https://github.com/microsoft/TypeScript/issues/7590
: Allow 'readonly' to be used in constructor parametershttps://github.com/microsoft/TypeScript/pull/8555/commits/ad2634e34309954b80ed6f2ed1d5d8de3460dc5d
ad2634ehttps://github.com/microsoft/TypeScript/pull/8555/commits/ad2634e34309954b80ed6f2ed1d5d8de3460dc5d
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218500003
Andy (Andrewkraft) (@Andy-MS)https://github.com/Andy-MS
https://cla.microsoft.comhttps://cla.microsoft.com
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#event-657370659
DanielRosenwasserhttps://github.com/DanielRosenwasser
May 11, 2016 https://github.com/microsoft/TypeScript/pull/8555#discussion-diff-62880761
View reviewed changes https://github.com/microsoft/TypeScript/pull/8555/files/ad2634e34309954b80ed6f2ed1d5d8de3460dc5d#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/8555/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#discussion_r62880761
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Change name from ConstructorParameterModifier to ParameterPropertyMod…https://github.com/microsoft/TypeScript/pull/8555/commits/a9742c58610db0785b051f7da3c668ce5ade72a6
a9742c5https://github.com/microsoft/TypeScript/pull/8555/commits/a9742c58610db0785b051f7da3c668ce5ade72a6
yuithttps://github.com/yuit
May 11, 2016 https://github.com/microsoft/TypeScript/pull/8555#discussion-diff-62885657
View reviewed changes https://github.com/microsoft/TypeScript/pull/8555/files/a9742c58610db0785b051f7da3c668ce5ade72a6#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
src/compiler/types.tshttps://github.com/microsoft/TypeScript/pull/8555/files#diff-e9fd483341eea176a38fbd370590e1dc65ce2d9bf70bfd317c5407f04dba9560
Yui (yuit)https://github.com/yuit
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#discussion_r62885657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#discussion_r62901481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Yui (yuit)https://github.com/yuit
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#discussion_r62937844
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/yuit
Yui (yuit)https://github.com/yuit
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218523394
Spechttps://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#831-constructor-parameters
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
yuithttps://github.com/yuit
May 11, 2016 https://github.com/microsoft/TypeScript/pull/8555#discussion-diff-62886368
View reviewed changes https://github.com/microsoft/TypeScript/pull/8555/files/a9742c58610db0785b051f7da3c668ce5ade72a6#diff-be27f26d0ad642f4d967d85a0629143d099de93686649f14fb8b2a4ddeda0699
...nce/classes/constructorDeclarations/constructorParameters/readonlyInConstructorParameters.tshttps://github.com/microsoft/TypeScript/pull/8555/files#diff-be27f26d0ad642f4d967d85a0629143d099de93686649f14fb8b2a4ddeda0699
Yui (yuit)https://github.com/yuit
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#discussion_r62886368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Deleted user (ghost)https://github.com/ghost
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#discussion_r62888737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218549253
https://github.com/Microsoft/TypeScript/blob/master/tests/cases/compiler/declarationEmit_protectedMembers.tshttps://github.com/Microsoft/TypeScript/blob/master/tests/cases/compiler/declarationEmit_protectedMembers.ts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218549654
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218611082
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 11, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218611101
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 12, 2016https://github.com/microsoft/TypeScript/pull/8555#issuecomment-218631380
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
May 12, 2016 07:07https://github.com/microsoft/TypeScript/pull/8555#commits-pushed-02f2ed7
Add declaration emit tests for readonly parameter propertyhttps://github.com/microsoft/TypeScript/pull/8555/commits/02f2ed798f3e5b5e72ab4a5fd8df83c01cdf8f47
02f2ed7https://github.com/microsoft/TypeScript/pull/8555/commits/02f2ed798f3e5b5e72ab4a5fd8df83c01cdf8f47
Don't report error twice for readonly in methodhttps://github.com/microsoft/TypeScript/pull/8555/commits/40afe4a4dd5b398c5882069488e3bab4b7976f27
40afe4ahttps://github.com/microsoft/TypeScript/pull/8555/commits/40afe4a4dd5b398c5882069488e3bab4b7976f27
Remove duplicate check for misplaced parameter properties (taken care…https://github.com/microsoft/TypeScript/pull/8555/commits/ce596732ab11f98546848847e489619e9d6e2ef4
ce59673https://github.com/microsoft/TypeScript/pull/8555/commits/ce596732ab11f98546848847e489619e9d6e2ef4
Add test for lambda parameter named 'readonly'https://github.com/microsoft/TypeScript/pull/8555/commits/22ee90a744d123c5123ac198e4255f94a3ae5720
22ee90ahttps://github.com/microsoft/TypeScript/pull/8555/commits/22ee90a744d123c5123ac198e4255f94a3ae5720
force-pushedhttps://github.com/microsoft/TypeScript/compare/c32227d16c7b0310df17b64cb3b1fe494115c92e..22ee90a744d123c5123ac198e4255f94a3ae5720
c32227dhttps://github.com/microsoft/TypeScript/commit/c32227d16c7b0310df17b64cb3b1fe494115c92e
22ee90ahttps://github.com/microsoft/TypeScript/commit/22ee90a744d123c5123ac198e4255f94a3ae5720
Compare https://github.com/microsoft/TypeScript/compare/c32227d16c7b0310df17b64cb3b1fe494115c92e..22ee90a744d123c5123ac198e4255f94a3ae5720
May 12, 2016 14:08https://github.com/microsoft/TypeScript/pull/8555#event-658636314
May 12, 2016 https://github.com/microsoft/TypeScript/pull/8555#ref-issue-154492581
Update spec to allow readonly in parameter properties #8575 https://github.com/microsoft/TypeScript/issues/8575
7806de0https://github.com/microsoft/TypeScript/commit/7806de0f45aca97515344a9c8e905660fd8ec461
May 12, 2016https://github.com/microsoft/TypeScript/pull/8555#event-658912155
May 12, 2016 17:29https://github.com/microsoft/TypeScript/pull/8555#event-658912185
May 12, 2016 https://github.com/microsoft/TypeScript/pull/8555#ref-commit-b1cd3de
Use NodeFlags.ParameterPropertyModifier rather than NodeFLags.Accessi…https://github.com/microsoft/TypeScript/commit/b1cd3de89ce307b5543102307bc511fdfde2e123
b1cd3dehttps://github.com/microsoft/TypeScript/commit/b1cd3de89ce307b5543102307bc511fdfde2e123
#8555https://github.com/microsoft/TypeScript/pull/8555
May 12, 2016 https://github.com/microsoft/TypeScript/pull/8555#ref-pullrequest-154573814
Use NodeFlags.ParameterPropertyModifier rather than NodeFlags.AccessibilityModifier to detect parameter properties #8583 https://github.com/microsoft/TypeScript/pull/8583
https://github.com/dsherret
David Sherret (dsherret)https://github.com/dsherret
Aug 7, 2016 https://github.com/microsoft/TypeScript/pull/8555#ref-issue-155366833
Support readonly modifier dsherret/ts-type-info#160 https://github.com/dsherret/ts-type-info/issues/160
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/8555#event-1689835306
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8555
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8555
https://github.com/msftclas
https://github.com/yuit
https://github.com/mhegazy
https://github.com/DanielRosenwasser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.