René's URL Explorer Experiment


Title: Add support for completions inside string literals by mhegazy · Pull Request #8428 · microsoft/TypeScript · GitHub

Open Graph Title: Add support for completions inside string literals by mhegazy · Pull Request #8428 · microsoft/TypeScript

X Title: Add support for completions inside string literals by mhegazy · Pull Request #8428 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Add support for completions inside string literals by mhegazy · Pull Request #8428 · microsoft/TypeScript

Open Graph Description: Fixes #606 This supports completions in string literals in the following locations: argument to a call expression whose target parameter has a StringLiteralType declare function f(a: "A"...

X Description: Fixes #606 This supports completions in string literals in the following locations: argument to a call expression whose target parameter has a StringLiteralType declare function f(a: "A&...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/8428

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ecfd5694-d2f9-3e65-011d-45caea386a79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE964:3B4E04:24029D:329B1A:6AFBF412
html-safe-noncec406ceb95d29e68e9bd51bcc434b7e408183761b079e46006cb5910815a3ef36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTY0OjNCNEUwNDoyNDAyOUQ6MzI5QjFBOjZBRkJGNDEyIiwidmlzaXRvcl9pZCI6IjgyMDQ3NjM3MzQ4NzA4NDg1MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7bdf2663d5cb598ba92ae19d8fd1da03257c47ead84694d01bc986b3b084b6d8
hovercard-subject-tagpull_request:68639402
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/8428/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d502cd948e4a6e5af0bdd036d139f6619f1df91452fecaf66b305d56f2fcf3c5/microsoft/TypeScript/pull/8428
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d502cd948e4a6e5af0bdd036d139f6619f1df91452fecaf66b305d56f2fcf3c5/microsoft/TypeScript/pull/8428
og:image:altFixes #606 This supports completions in string literals in the following locations: argument to a call expression whose target parameter has a StringLiteralType declare function f(a: "A"...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhegazy
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/8428#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8428
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8428
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/8428
Reloadhttps://github.com/microsoft/TypeScript/pull/8428
Reloadhttps://github.com/microsoft/TypeScript/pull/8428
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests335 (335)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/pulse
https://github.com/microsoft/TypeScript
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
masterhttps://github.com/microsoft/TypeScript/tree/master
stringLiteralCompletionshttps://github.com/microsoft/TypeScript/tree/stringLiteralCompletions
Conversationhttps://github.com/microsoft/TypeScript/pull/8428
Commits12 (12)https://github.com/microsoft/TypeScript/pull/8428/commits
Checkshttps://github.com/microsoft/TypeScript/pull/8428/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/8428/files
Add support for completions inside string literalshttps://github.com/microsoft/TypeScript/pull/8428#top
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
masterhttps://github.com/microsoft/TypeScript/tree/master
stringLiteralCompletionshttps://github.com/microsoft/TypeScript/tree/stringLiteralCompletions
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 2, 2016https://github.com/microsoft/TypeScript/pull/8428#issue-152670369
#606https://github.com/microsoft/TypeScript/issues/606
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 2, 2016 16:29https://github.com/microsoft/TypeScript/pull/8428#commits-pushed-21587aa
https://github.com/mhegazy
Rewrite isInStringLiteral to accomodate for unterminated stringshttps://github.com/microsoft/TypeScript/pull/8428/commits/21587aaae3be8bf7840ab8be66793d4d4b32e1f2
21587aahttps://github.com/microsoft/TypeScript/pull/8428/commits/21587aaae3be8bf7840ab8be66793d4d4b32e1f2
https://github.com/mhegazy
Refactor signatureHelp to expose helper functionshttps://github.com/microsoft/TypeScript/pull/8428/commits/0a277a1c601153c355dc76454cfebd770bf4cea9
0a277a1https://github.com/microsoft/TypeScript/pull/8428/commits/0a277a1c601153c355dc76454cfebd770bf4cea9
https://github.com/mhegazy
Add support for completion in string literalshttps://github.com/microsoft/TypeScript/pull/8428/commits/060f2a85637efdc79c7af3126fc8cef25d87a241
060f2a8https://github.com/microsoft/TypeScript/pull/8428/commits/060f2a85637efdc79c7af3126fc8cef25d87a241
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
May 2, 2016https://github.com/microsoft/TypeScript/pull/8428#event-648269213
https://github.com/mhegazy
Remove unused checkhttps://github.com/microsoft/TypeScript/pull/8428/commits/7b0d664394c3a3742e6c52d9fec65e3f3e445267
7b0d664https://github.com/microsoft/TypeScript/pull/8428/commits/7b0d664394c3a3742e6c52d9fec65e3f3e445267
DanielRosenwasserhttps://github.com/DanielRosenwasser
May 3, 2016 https://github.com/microsoft/TypeScript/pull/8428#discussion-diff-61841103
View reviewed changes https://github.com/microsoft/TypeScript/pull/8428/files/7b0d664394c3a3742e6c52d9fec65e3f3e445267#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/8428/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61841103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61939464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#issuecomment-216446839
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
DanielRosenwasserhttps://github.com/DanielRosenwasser
May 3, 2016 https://github.com/microsoft/TypeScript/pull/8428#discussion-diff-61841480
View reviewed changes https://github.com/microsoft/TypeScript/pull/8428/files/7b0d664394c3a3742e6c52d9fec65e3f3e445267#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/8428/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61841480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61934447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016 12:18https://github.com/microsoft/TypeScript/pull/8428#commits-pushed-4464a41
https://github.com/mhegazy
Merge branch 'master' into stringLiteralCompletionshttps://github.com/microsoft/TypeScript/pull/8428/commits/4464a416753d8d0f786effbb0f44a180ca443668
4464a41https://github.com/microsoft/TypeScript/pull/8428/commits/4464a416753d8d0f786effbb0f44a180ca443668
https://github.com/mhegazy
Use const instead of lethttps://github.com/microsoft/TypeScript/pull/8428/commits/291ad3360751ee0669912fe5d55ba2f3461fd7c7
291ad33https://github.com/microsoft/TypeScript/pull/8428/commits/291ad3360751ee0669912fe5d55ba2f3461fd7c7
https://github.com/mhegazy
Fix errorhttps://github.com/microsoft/TypeScript/pull/8428/commits/e5a32b71aa537e2c5b241b5b0e6f60895ea1cea6
e5a32b7https://github.com/microsoft/TypeScript/pull/8428/commits/e5a32b71aa537e2c5b241b5b0e6f60895ea1cea6
https://github.com/mhegazy
Formatting changeshttps://github.com/microsoft/TypeScript/pull/8428/commits/02f30ff04c5559da41de9d3a28f3c8fb8a3c00b6
02f30ffhttps://github.com/microsoft/TypeScript/pull/8428/commits/02f30ff04c5559da41de9d3a28f3c8fb8a3c00b6
https://github.com/mhegazy
Use shorthand propertieshttps://github.com/microsoft/TypeScript/pull/8428/commits/b9ab4d3e08115516bd099c54aa04c81ca4f59a57
b9ab4d3https://github.com/microsoft/TypeScript/pull/8428/commits/b9ab4d3e08115516bd099c54aa04c81ca4f59a57
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#issuecomment-216643472
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#issuecomment-216643533
Yui (@yuit)https://github.com/yuit
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
yuithttps://github.com/yuit
May 3, 2016 https://github.com/microsoft/TypeScript/pull/8428#discussion-diff-61949231
View reviewed changes https://github.com/microsoft/TypeScript/pull/8428/files/b9ab4d3e08115516bd099c54aa04c81ca4f59a57#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/8428/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Yui (yuit)https://github.com/yuit
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61949231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61964740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
https://github.com/yuit
Yui (yuit)https://github.com/yuit
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#issuecomment-216660795
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
yuithttps://github.com/yuit
May 3, 2016 https://github.com/microsoft/TypeScript/pull/8428#discussion-diff-61954052
View reviewed changes https://github.com/microsoft/TypeScript/pull/8428/files/0a277a1c601153c355dc76454cfebd770bf4cea9..060f2a85637efdc79c7af3126fc8cef25d87a241#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
src/services/services.tshttps://github.com/microsoft/TypeScript/pull/8428/files#diff-2dc319893c8723737436e91a4ec39b69623ee0bbeebf0b260778015d79d97632
Yui (yuit)https://github.com/yuit
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61954052
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 3, 2016https://github.com/microsoft/TypeScript/pull/8428#discussion_r61964983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
https://github.com/mhegazy
Merge branch 'master' into stringLiteralCompletionshttps://github.com/microsoft/TypeScript/pull/8428/commits/f657e3c88f91643a5e3156d6655ddf61f28eecc4
f657e3chttps://github.com/microsoft/TypeScript/pull/8428/commits/f657e3c88f91643a5e3156d6655ddf61f28eecc4
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
May 16, 2016 https://github.com/microsoft/TypeScript/pull/8428#ref-issue-155038592
Validate indexed properties #8620 https://github.com/microsoft/TypeScript/issues/8620
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
June 8, 2016 13:19https://github.com/microsoft/TypeScript/pull/8428#commits-pushed-9027da4
https://github.com/mhegazy
Merge branch 'master' into stringLiteralCompletionshttps://github.com/microsoft/TypeScript/pull/8428/commits/9027da4d17db78b34cfd252f70f762e0f4b435cb
9027da4https://github.com/microsoft/TypeScript/pull/8428/commits/9027da4d17db78b34cfd252f70f762e0f4b435cb
https://github.com/mhegazy
Add commentshttps://github.com/microsoft/TypeScript/pull/8428/commits/cc5dd5bf797dddb75304eedff9fd9aa61d39d7b1
cc5dd5bhttps://github.com/microsoft/TypeScript/pull/8428/commits/cc5dd5bf797dddb75304eedff9fd9aa61d39d7b1
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
17b5415https://github.com/microsoft/TypeScript/commit/17b5415f8c8c4ac38cdccd15b55fc4ae184af267
Jun 8, 2016https://github.com/microsoft/TypeScript/pull/8428#event-686497383
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
June 8, 2016 21:42https://github.com/microsoft/TypeScript/pull/8428#event-686497429
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F8428
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/8428
https://github.com/mhegazy
https://github.com/DanielRosenwasser
https://github.com/yuit
https://github.com/Thaina
https://github.com/vladima
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.