René's URL Explorer Experiment


Title: Fix find all references for salsa by zhengbli · Pull Request #6632 · microsoft/TypeScript · GitHub

Open Graph Title: Fix find all references for salsa by zhengbli · Pull Request #6632 · microsoft/TypeScript

X Title: Fix find all references for salsa by zhengbli · Pull Request #6632 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Fix find all references for salsa by zhengbli · Pull Request #6632 · microsoft/TypeScript

Open Graph Description: Issue: currently "find all reference" would return no results if called on exported properties in JavaScript file. For example: After the fix:

X Description: Issue: currently "find all reference" would return no results if called on exported properties in JavaScript file. For example: After the fix:

Opengraph URL: https://github.com/microsoft/TypeScript/pull/6632

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7a96e6ed-44a3-6263-2865-3162cd42fb5a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD286:2F9718:19DC405:22A4997:6B015ED5
html-safe-noncec020fff17a0f07d11f427e7cc99d1b4677e7f6b6061612ae62cd6dca1e32b73b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjg2OjJGOTcxODoxOURDNDA1OjIyQTQ5OTc6NkIwMTVFRDUiLCJ2aXNpdG9yX2lkIjoiNjY5OTI1NTY1MTgzMjUyMDQwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbf1fe48f1925151983ecea12643687ccc410005ede9bfcd7c0938388f2099f31
hovercard-subject-tagpull_request:57297422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/6632/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c6bb2619b418b4d02b4e6f16de6c2f148e26027d5bd8043627f2037aebea822/microsoft/TypeScript/pull/6632
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c6bb2619b418b4d02b4e6f16de6c2f148e26027d5bd8043627f2037aebea822/microsoft/TypeScript/pull/6632
og:image:altIssue: currently "find all reference" would return no results if called on exported properties in JavaScript file. For example: After the fix:
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhengbli
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/6632#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F6632
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F6632
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/6632
Reloadhttps://github.com/microsoft/TypeScript/pull/6632
Reloadhttps://github.com/microsoft/TypeScript/pull/6632
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Zhengbo Li (zhengbli)https://github.com/zhengbli
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
zhengbli:fixFindAllRefForSalsahttps://github.com/zhengbli/TypeScript/tree/fixFindAllRefForSalsa
Conversationhttps://github.com/microsoft/TypeScript/pull/6632
Commits7 (7)https://github.com/microsoft/TypeScript/pull/6632/commits
Checkshttps://github.com/microsoft/TypeScript/pull/6632/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/6632/files
Fix find all references for salsahttps://github.com/microsoft/TypeScript/pull/6632#top
Zhengbo Li (zhengbli)https://github.com/zhengbli
microsoft:masterhttps://github.com/microsoft/TypeScript/tree/master
zhengbli:fixFindAllRefForSalsahttps://github.com/zhengbli/TypeScript/tree/fixFindAllRefForSalsa
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
Jan 27, 2016https://github.com/microsoft/TypeScript/pull/6632#issue-128989077
https://cloud.githubusercontent.com/assets/1171301/12600088/ba6c1f72-c44b-11e5-9a64-a6a3b6a55e7d.PNG
https://cloud.githubusercontent.com/assets/1171301/12600104/d1d68116-c44b-11e5-949b-5ec0a3bb766b.PNG
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
Fix find all references for salsahttps://github.com/microsoft/TypeScript/pull/6632/commits/e4ab2db9fb88520e81427e2c6f252fdbb717dcf8
e4ab2dbhttps://github.com/microsoft/TypeScript/pull/6632/commits/e4ab2db9fb88520e81427e2c6f252fdbb717dcf8
https://github.com/msftclas
Microsoft Contribution License Agreements (msftclas)https://github.com/msftclas
cla-not-required https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3Acla-not-required
Jan 27, 2016https://github.com/microsoft/TypeScript/pull/6632#event-527345806
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 27, 2016https://github.com/microsoft/TypeScript/pull/6632#issuecomment-175455424
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Jan 27, 2016https://github.com/microsoft/TypeScript/pull/6632#issuecomment-175761990
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
Fix for thisPropertyhttps://github.com/microsoft/TypeScript/pull/6632/commits/b389e9c61984f1ac303e3382b2d3ceaa9a8e0b84
b389e9chttps://github.com/microsoft/TypeScript/pull/6632/commits/b389e9c61984f1ac303e3382b2d3ceaa9a8e0b84
Salsa cross TS-JS find all references does not work #6647 https://github.com/microsoft/TypeScript/issues/6647
Salsa: renaming in TypeScript does not rename in JavaScript #6648 https://github.com/microsoft/TypeScript/issues/6648
January 27, 2016 13:26https://github.com/microsoft/TypeScript/pull/6632#commits-pushed-9a6815f
add testshttps://github.com/microsoft/TypeScript/pull/6632/commits/9a6815f3c7887c757cbe5a56dc6f6b4e67f6d2bc
9a6815fhttps://github.com/microsoft/TypeScript/pull/6632/commits/9a6815f3c7887c757cbe5a56dc6f6b4e67f6d2bc
Merge branch 'master' ofhttps://github.com/microsoft/TypeScript/pull/6632/commits/10f9a85730e87ac0399a6a3585db6e53b6058060
https://github.com/Microsoft/TypeScripthttps://github.com/Microsoft/TypeScript
into…https://github.com/microsoft/TypeScript/pull/6632/commits/10f9a85730e87ac0399a6a3585db6e53b6058060
10f9a85https://github.com/microsoft/TypeScript/pull/6632/commits/10f9a85730e87ac0399a6a3585db6e53b6058060
Fix build errorhttps://github.com/microsoft/TypeScript/pull/6632/commits/646e46e022cddbfe31655ce5f0a40b7603dcca0b
646e46ehttps://github.com/microsoft/TypeScript/pull/6632/commits/646e46e022cddbfe31655ce5f0a40b7603dcca0b
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
Jan 27, 2016https://github.com/microsoft/TypeScript/pull/6632#issuecomment-175870120
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
Ryan Cavanaugh (@RyanCavanaugh)https://github.com/RyanCavanaugh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
Jan 27, 2016 https://github.com/microsoft/TypeScript/pull/6632#ref-issue-129292950
Salsa - reference search across commonjs fails #6682 https://github.com/microsoft/TypeScript/issues/6682
Merge branch 'master' ofhttps://github.com/microsoft/TypeScript/pull/6632/commits/5ced4c401f97c6d77093443d79ba447fca4c8f91
https://github.com/Microsoft/TypeScripthttps://github.com/Microsoft/TypeScript
into…https://github.com/microsoft/TypeScript/pull/6632/commits/5ced4c401f97c6d77093443d79ba447fca4c8f91
5ced4c4https://github.com/microsoft/TypeScript/pull/6632/commits/5ced4c401f97c6d77093443d79ba447fca4c8f91
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
Jan 27, 2016 https://github.com/microsoft/TypeScript/pull/6632#ref-issue-129230394
Salsa does not highlight object properties across methods #6664 https://github.com/microsoft/TypeScript/issues/6664
billtihttps://github.com/billti
Jan 28, 2016 https://github.com/microsoft/TypeScript/pull/6632#discussion-diff-51152598
View reviewed changes https://github.com/microsoft/TypeScript/pull/6632/files/646e46e022cddbfe31655ce5f0a40b7603dcca0b#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
src/compiler/checker.tshttps://github.com/microsoft/TypeScript/pull/6632/files#diff-d9ab6589e714c71e657f601cf30ff51dfc607fc98419bf72e04f6b0fa92cc4b8
Bill Ticehurst (billti)https://github.com/billti
Jan 28, 2016https://github.com/microsoft/TypeScript/pull/6632#discussion_r51152598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
https://github.com/billti
Bill Ticehurst (billti)https://github.com/billti
Jan 28, 2016https://github.com/microsoft/TypeScript/pull/6632#issuecomment-176287498
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
DanielRosenwasserhttps://github.com/DanielRosenwasser
Jan 28, 2016 https://github.com/microsoft/TypeScript/pull/6632#discussion-diff-51159989
View reviewed changes https://github.com/microsoft/TypeScript/pull/6632/files/646e46e022cddbfe31655ce5f0a40b7603dcca0b#diff-50605796e3d2bc72702c63c37fefe6adec99b1ddff4c6d68e8aca2dd10669e91
tests/cases/fourslash/renameJsExports.tshttps://github.com/microsoft/TypeScript/pull/6632/files#diff-50605796e3d2bc72702c63c37fefe6adec99b1ddff4c6d68e8aca2dd10669e91
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 28, 2016https://github.com/microsoft/TypeScript/pull/6632#discussion_r51159989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Jan 28, 2016https://github.com/microsoft/TypeScript/pull/6632#issuecomment-176309719
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
Add more tests and commentshttps://github.com/microsoft/TypeScript/pull/6632/commits/bf897c29393e7e7ee92a71e123e502ca3d0ba12f
bf897c2https://github.com/microsoft/TypeScript/pull/6632/commits/bf897c29393e7e7ee92a71e123e502ca3d0ba12f
Zhengbo Li (zhengbli)https://github.com/zhengbli
Jan 28, 2016 https://github.com/microsoft/TypeScript/pull/6632#ref-commit-31bf103
Merge pull requesthttps://github.com/microsoft/TypeScript/commit/31bf103212555030a8d94b98a90b4c350ac85ab9
#6632https://github.com/microsoft/TypeScript/pull/6632
from zhengbli/fixFindAllRefForSalsahttps://github.com/microsoft/TypeScript/commit/31bf103212555030a8d94b98a90b4c350ac85ab9
31bf103https://github.com/microsoft/TypeScript/commit/31bf103212555030a8d94b98a90b4c350ac85ab9
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
31bf103https://github.com/microsoft/TypeScript/commit/31bf103212555030a8d94b98a90b4c350ac85ab9
Jan 28, 2016https://github.com/microsoft/TypeScript/pull/6632#event-530248342
https://github.com/zhengbli
Zhengbo Li (zhengbli)https://github.com/zhengbli
January 28, 2016 19:44https://github.com/microsoft/TypeScript/pull/6632#event-530248408
https://github.com/billti
Bill Ticehurst (billti)https://github.com/billti
Feb 4, 2016 https://github.com/microsoft/TypeScript/pull/6632#ref-pullrequest-131443002
Port6632 #6904 https://github.com/microsoft/TypeScript/pull/6904
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Jun 19, 2018https://github.com/microsoft/TypeScript/pull/6632#event-1689634619
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F6632
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/6632
https://github.com/zhengbli
https://github.com/DanielRosenwasser
https://github.com/mhegazy
https://github.com/billti
https://github.com/msftclas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.