René's URL Explorer Experiment


Title: Move to file: fix detection of references to globals that shouldn't be moved by andrewbranch · Pull Request #60450 · microsoft/TypeScript · GitHub

Open Graph Title: Move to file: fix detection of references to globals that shouldn't be moved by andrewbranch · Pull Request #60450 · microsoft/TypeScript

X Title: Move to file: fix detection of references to globals that shouldn't be moved by andrewbranch · Pull Request #60450 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Move to file: fix detection of references to globals that shouldn't be moved by andrewbranch · Pull Request #60450 · microsoft/TypeScript

Open Graph Description: Fixes #59799 Fixes #60408 Closes #60173 Closes #60410 isGlobalType was a red herring; it was implemented incorrectly but it never mattered if something was a global type. What we actually care abou...

X Description: Fixes #59799 Fixes #60408 Closes #60173 Closes #60410 isGlobalType was a red herring; it was implemented incorrectly but it never mattered if something was a global type. What we actually care abou...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/60450

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5e547ba2-5bb3-a293-291f-e7a323b57a4b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7D2:24429C:6BDA00:8C3E5A:6A5FFBE7
html-safe-nonce75179b3fe795a3f38f997f756e98d57c4ac52c1bc87bb9c7bd680a6d3ffcd3a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0QyOjI0NDI5Qzo2QkRBMDA6OEMzRTVBOjZBNUZGQkU3IiwidmlzaXRvcl9pZCI6IjIwMzQzNzYzODkzMDEzNjAzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace27bdc52ddeec1c641470c5ab68aa761d14fe4d311dcc922e20f58477ddf1b04
hovercard-subject-tagpull_request:2168115748
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/60450/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/72218a6d5837f5d29f8ce34bed806457168fa5164acd7c464e19d5d8600b2a28/microsoft/TypeScript/pull/60450
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/72218a6d5837f5d29f8ce34bed806457168fa5164acd7c464e19d5d8600b2a28/microsoft/TypeScript/pull/60450
og:image:altFixes #59799 Fixes #60408 Closes #60173 Closes #60410 isGlobalType was a red herring; it was implemented incorrectly but it never mattered if something was a global type. What we actually care abou...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandrewbranch
hostnamegithub.com
expected-hostnamegithub.com
None79522f2cee5c5409f33a714312a1a68d41ad77a807626020d980fb1eb81def07
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3df4fbea9b6b5ead5c6724a99dc5f5b62caa864b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/60450#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60450
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60450
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/60450
Reloadhttps://github.com/microsoft/TypeScript/pull/60450
Reloadhttps://github.com/microsoft/TypeScript/pull/60450
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 30 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
andrewbranchhttps://github.com/andrewbranch
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
andrewbranch:bug/59799https://github.com/andrewbranch/TypeScript/tree/bug/59799
Conversationhttps://github.com/microsoft/TypeScript/pull/60450
Commits10 (10)https://github.com/microsoft/TypeScript/pull/60450/commits
Checkshttps://github.com/microsoft/TypeScript/pull/60450/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/60450/files
Move to file: fix detection of references to globals that shouldn't be movedhttps://github.com/microsoft/TypeScript/pull/60450#top
andrewbranchhttps://github.com/andrewbranch
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
andrewbranch:bug/59799https://github.com/andrewbranch/TypeScript/tree/bug/59799
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60450#issue-2641938709
#59799https://github.com/microsoft/TypeScript/issues/59799
#60408https://github.com/microsoft/TypeScript/issues/60408
#60173https://github.com/microsoft/TypeScript/pull/60173
#60410https://github.com/microsoft/TypeScript/pull/60410
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
iisaduanhttps://github.com/iisaduan
October 7, 2024 16:00https://github.com/microsoft/TypeScript/pull/60450#commits-pushed-a20bcb8
https://github.com/iisaduan
only skip imports for symbols that may be global types if they are no…https://github.com/microsoft/TypeScript/pull/60450/commits/a20bcb87da4d287bdb177588bdcbd1dd98ea3263
a20bcb8https://github.com/microsoft/TypeScript/pull/60450/commits/a20bcb87da4d287bdb177588bdcbd1dd98ea3263
https://github.com/iisaduan
add paste test, rename tests, fix isGlobalTypehttps://github.com/microsoft/TypeScript/pull/60450/commits/7112af8747533c046f7322a8fb9bb906a014ecbb
7112af8https://github.com/microsoft/TypeScript/pull/60450/commits/7112af8747533c046f7322a8fb9bb906a014ecbb
https://github.com/iisaduan
fix isGlobalType againhttps://github.com/microsoft/TypeScript/pull/60450/commits/9bbf9babafd16cfbf9b5f6119417b7aa65314306
9bbf9bahttps://github.com/microsoft/TypeScript/pull/60450/commits/9bbf9babafd16cfbf9b5f6119417b7aa65314306
https://github.com/iisaduan
add testhttps://github.com/microsoft/TypeScript/pull/60450/commits/5fd1bef2ea42cac367ed8489c6e135bca3e183fe
5fd1befhttps://github.com/microsoft/TypeScript/pull/60450/commits/5fd1bef2ea42cac367ed8489c6e135bca3e183fe
https://github.com/iisaduan
add testhttps://github.com/microsoft/TypeScript/pull/60450/commits/38b06af685748c0fc0f6f16dfbec1d253bc40692
38b06afhttps://github.com/microsoft/TypeScript/pull/60450/commits/38b06af685748c0fc0f6f16dfbec1d253bc40692
https://github.com/iisaduan
Merge branch 'main' ofhttps://github.com/microsoft/TypeScript/pull/60450/commits/4e9562c06bed98223d7543d611a11d9dcd955480
https://github.com/iisaduan/TypeScripthttps://github.com/iisaduan/TypeScript
into mo…https://github.com/microsoft/TypeScript/pull/60450/commits/4e9562c06bed98223d7543d611a11d9dcd955480
4e9562chttps://github.com/microsoft/TypeScript/pull/60450/commits/4e9562c06bed98223d7543d611a11d9dcd955480
https://github.com/iisaduan
update tests for improved quote behaviorshttps://github.com/microsoft/TypeScript/pull/60450/commits/a8f8da01e31a4a3e132f81807d490a18f274864b
a8f8da0https://github.com/microsoft/TypeScript/pull/60450/commits/a8f8da01e31a4a3e132f81807d490a18f274864b
https://github.com/iisaduan
make sure resolved symbol is same symbolhttps://github.com/microsoft/TypeScript/pull/60450/commits/58118b201d99be3c80305b90a88d7cc580267851
58118b2https://github.com/microsoft/TypeScript/pull/60450/commits/58118b201d99be3c80305b90a88d7cc580267851
https://github.com/andrewbranch
Don’t touch merged globalshttps://github.com/microsoft/TypeScript/pull/60450/commits/d0d3dc05d34074f06c45b4b750d1546fba308aa3
d0d3dc0https://github.com/microsoft/TypeScript/pull/60450/commits/d0d3dc05d34074f06c45b4b750d1546fba308aa3
https://github.com/Andarist
https://github.com/andrewbranch
Allow imports with the same names as global types to be moved by refa…https://github.com/microsoft/TypeScript/pull/60450/commits/4d1abeea3bef87acf4611fffc91a2bc2103596e8
4d1abeehttps://github.com/microsoft/TypeScript/pull/60450/commits/4d1abeea3bef87acf4611fffc91a2bc2103596e8
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
andrewbranchhttps://github.com/andrewbranch
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60450#event-15190478612
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60450#event-15190479266
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
iisaduanhttps://github.com/iisaduan
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60450#event-15190480021
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60450#event-15190480792
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60450#event-15190502113
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
iisaduanhttps://github.com/iisaduan
navya9singhhttps://github.com/navya9singh
November 7, 2024 19:16https://github.com/microsoft/TypeScript/pull/60450#event-15190502477
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
Nov 15, 2024 https://github.com/microsoft/TypeScript/pull/60450#pullrequestreview-2439784578
View reviewed changes https://github.com/microsoft/TypeScript/pull/60450/files/4d1abeea3bef87acf4611fffc91a2bc2103596e8
iisaduanhttps://github.com/iisaduan
https://github.com/microsoft/TypeScript/pull/60450#pullrequestreview-2439784578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
b3c67d3https://github.com/microsoft/TypeScript/commit/b3c67d32020a3015fe068fbcb1dcfb18aedcaad3
Nov 15, 2024https://github.com/microsoft/TypeScript/pull/60450#event-15318516494
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
Nov 15, 2024https://github.com/microsoft/TypeScript/pull/60450#issuecomment-2480039832
@typescript-bothttps://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Nov 15, 2024https://github.com/microsoft/TypeScript/pull/60450#issuecomment-2480039976
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
✅ Startedhttps://github.com/microsoft/TypeScript/actions/runs/11864323453
✅ Resultshttps://github.com/microsoft/TypeScript/pull/60450#issuecomment-2480043001
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
November 15, 2024 22:21https://github.com/microsoft/TypeScript/pull/60450#event-15318517343
typescript-bothttps://github.com/typescript-bot
Nov 15, 2024 https://github.com/microsoft/TypeScript/pull/60450#ref-commit-65d15f1
https://github.com/andrewbranch
https://github.com/iisaduan
https://github.com/Andarist
https://github.com/typescript-bot
Move to file: fix detection of references to globals that shouldn't b…https://github.com/microsoft/TypeScript/commit/65d15f18064e555b8d48b875df7a7e448725f3a3
65d15f1https://github.com/microsoft/TypeScript/commit/65d15f18064e555b8d48b875df7a7e448725f3a3
#60450https://github.com/microsoft/TypeScript/pull/60450
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Nov 15, 2024 https://github.com/microsoft/TypeScript/pull/60450#ref-pullrequest-2663323876
🤖 Pick PR #60450 (Move to file: fix detection of refe...) into release-5.7 #60513 https://github.com/microsoft/TypeScript/pull/60513
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Nov 15, 2024https://github.com/microsoft/TypeScript/pull/60450#issuecomment-2480043001
@andrewbranchhttps://github.com/andrewbranch
#60513https://github.com/microsoft/TypeScript/pull/60513
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
DanielRosenwasserhttps://github.com/DanielRosenwasser
Nov 18, 2024 https://github.com/microsoft/TypeScript/pull/60450#ref-commit-0503a63
https://github.com/typescript-bot
https://github.com/andrewbranch
https://github.com/iisaduan
https://github.com/Andarist
🤖 Pick PRhttps://github.com/microsoft/TypeScript/commit/0503a630fdc1478a63fe8bcb9bea2d6d927fcca4
#60450https://github.com/microsoft/TypeScript/pull/60450
(Move to file: fix detection of refe...) into releas…https://github.com/microsoft/TypeScript/commit/0503a630fdc1478a63fe8bcb9bea2d6d927fcca4
0503a63https://github.com/microsoft/TypeScript/commit/0503a630fdc1478a63fe8bcb9bea2d6d927fcca4
#60513https://github.com/microsoft/TypeScript/pull/60513
https://github.com/aramikuto
aramikutohttps://github.com/aramikuto
Dec 18, 2024 https://github.com/microsoft/TypeScript/pull/60450#ref-issue-2744596204
Refactoring 'Move to file' imports undefined from source file #60783 https://github.com/microsoft/TypeScript/issues/60783
https://github.com/sandersn
sandersnhttps://github.com/sandersn
PR Backloghttps://github.com/orgs/microsoft/projects/1252
Apr 22, 2025https://github.com/microsoft/TypeScript/pull/60450#event-17355489120
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 15, 2025https://github.com/microsoft/TypeScript/pull/60450#event-20307059713
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60450
https://github.com/iisaduan
iisaduan https://github.com/iisaduan
https://github.com/microsoft/TypeScript/pull/60450/files/4d1abeea3bef87acf4611fffc91a2bc2103596e8
https://github.com/navya9singh
navya9singh https://github.com/navya9singh
https://github.com/andrewbranch
andrewbranch https://github.com/andrewbranch
https://github.com/iisaduan
iisaduan https://github.com/iisaduan
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
"Move to a new file" refactor was recently broken for some import names https://github.com/microsoft/TypeScript/issues/60408
Import named Disposable is not moved when moving code to another file https://github.com/microsoft/TypeScript/issues/59799
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60450
https://github.com/andrewbranch
https://github.com/typescript-bot
https://github.com/iisaduan
https://github.com/sandersn
https://github.com/Andarist
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.