| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:066d0b71-5d03-8438-ba37-8c46f3fdecca |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6BE:37F8F:195EA:236BA:6A601CB3 |
| html-safe-nonce | 6a3445f7be3a993db6b2cdc2b8d30ab0eaed9aae74f6496749bbc3c274844329 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkJFOjM3RjhGOjE5NUVBOjIzNkJBOjZBNjAxQ0IzIiwidmlzaXRvcl9pZCI6IjE2NjYwMTAzMTY4OTAxODQ4ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fdd4bc4831a55a6378e413a28471ec6b631e911ad6599408041851d602c69ffc |
| hovercard-subject-tag | pull_request:2131319145 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/60268/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e019e7fc7ce6c9800ea4725d6863791dad4825fa5fe90271ca3a9073e1b6d202/microsoft/TypeScript/pull/60268 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e019e7fc7ce6c9800ea4725d6863791dad4825fa5fe90271ca3a9073e1b6d202/microsoft/TypeScript/pull/60268 |
| og:image:alt | A version of #56941 without any of the extra stuff for checking conditional expressions. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabritto |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7e86a727ba4abf81d0638c5ead57286c17d3b2706f57813445c4316d8e848673 |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f13d8ac548fb76838b3d703c7fe2100887547d0e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/60268#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60268 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60268 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/60268 |
| Reload | https://github.com/microsoft/TypeScript/pull/60268 |
| Reload | https://github.com/microsoft/TypeScript/pull/60268 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
30
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| gabritto | https://github.com/gabritto |
| main | https://github.com/microsoft/TypeScript/tree/main |
| gabritto/d2-nocond | https://github.com/microsoft/TypeScript/tree/gabritto/d2-nocond |
| Conversation | https://github.com/microsoft/TypeScript/pull/60268 |
| Commits93 (93) | https://github.com/microsoft/TypeScript/pull/60268/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/60268/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/60268/files |
| Narrow generic conditional and indexed access return types when checking return statements, no conditional expression support | https://github.com/microsoft/TypeScript/pull/60268#top |
| gabritto | https://github.com/gabritto |
| main | https://github.com/microsoft/TypeScript/tree/main |
| gabritto/d2-nocond | https://github.com/microsoft/TypeScript/tree/gabritto/d2-nocond |
|
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#issue-2596117931 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| #56941 | https://github.com/microsoft/TypeScript/pull/56941 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| gabritto | https://github.com/gabritto |
| May 15, 2023 18:15 | https://github.com/microsoft/TypeScript/pull/60268#commits-pushed-0d393e3 |
|
| https://github.com/gabritto |
| WIP: custom instantiation | https://github.com/microsoft/TypeScript/pull/60268/commits/0d393e324acb8353d386b4723756e914feefbd27 |
| 0d393e3 | https://github.com/microsoft/TypeScript/pull/60268/commits/0d393e324acb8353d386b4723756e914feefbd27 |
|
| https://github.com/gabritto |
| fix more things | https://github.com/microsoft/TypeScript/pull/60268/commits/a1d9f89f5054034899d8ffd467898407223a3201 |
| a1d9f89 | https://github.com/microsoft/TypeScript/pull/60268/commits/a1d9f89f5054034899d8ffd467898407223a3201 |
|
| https://github.com/gabritto |
| latest fixes | https://github.com/microsoft/TypeScript/pull/60268/commits/b9495a988e79515a8f411b210ef25f6532d1d4ee |
| b9495a9 | https://github.com/microsoft/TypeScript/pull/60268/commits/b9495a988e79515a8f411b210ef25f6532d1d4ee |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/d2 | https://github.com/microsoft/TypeScript/pull/60268/commits/81cdee5ee98570d1944295359f50eb1c4ed27334 |
| 81cdee5 | https://github.com/microsoft/TypeScript/pull/60268/commits/81cdee5ee98570d1944295359f50eb1c4ed27334 |
|
| https://github.com/gabritto |
| fix bare type parameter instantiation | https://github.com/microsoft/TypeScript/pull/60268/commits/af57b3469c8e064595209ebb4cef120bbf8fda9c |
| af57b34 | https://github.com/microsoft/TypeScript/pull/60268/commits/af57b3469c8e064595209ebb4cef120bbf8fda9c |
|
| https://github.com/gabritto |
| change binder. BROKEN | https://github.com/microsoft/TypeScript/pull/60268/commits/01152a0df832520205c9b3498ed315ee89a9efef |
| 01152a0 | https://github.com/microsoft/TypeScript/pull/60268/commits/01152a0df832520205c9b3498ed315ee89a9efef |
|
| https://github.com/gabritto |
| fix binder change | https://github.com/microsoft/TypeScript/pull/60268/commits/eac319203a0da13ff58b0d7e0858e7f9ec4129f0 |
| eac3192 | https://github.com/microsoft/TypeScript/pull/60268/commits/eac319203a0da13ff58b0d7e0858e7f9ec4129f0 |
|
| https://github.com/gabritto |
| clean up + tests | https://github.com/microsoft/TypeScript/pull/60268/commits/199ecd028f0a0427d3bf1795b382db8661ef39b8 |
| 199ecd0 | https://github.com/microsoft/TypeScript/pull/60268/commits/199ecd028f0a0427d3bf1795b382db8661ef39b8 |
|
| https://github.com/gabritto |
| WIP | https://github.com/microsoft/TypeScript/pull/60268/commits/d0e85d0c5afc393b93cb50761492565985fa820b |
| d0e85d0 | https://github.com/microsoft/TypeScript/pull/60268/commits/d0e85d0c5afc393b93cb50761492565985fa820b |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/d2 | https://github.com/microsoft/TypeScript/pull/60268/commits/23e3d33042674a5857dc24916656dce42c89e786 |
| 23e3d33 | https://github.com/microsoft/TypeScript/pull/60268/commits/23e3d33042674a5857dc24916656dce42c89e786 |
|
| https://github.com/gabritto |
| defer conditional unless narrowing | https://github.com/microsoft/TypeScript/pull/60268/commits/d9ac1027a371842567bc1f3e8bcfa594ea763915 |
| d9ac102 | https://github.com/microsoft/TypeScript/pull/60268/commits/d9ac1027a371842567bc1f3e8bcfa594ea763915 |
|
| https://github.com/gabritto |
| don't skip jsdoc type assertions | https://github.com/microsoft/TypeScript/pull/60268/commits/b4910f45f8d9b1a44ae714e5ef0be865594ec292 |
| b4910f4 | https://github.com/microsoft/TypeScript/pull/60268/commits/b4910f45f8d9b1a44ae714e5ef0be865594ec292 |
|
| https://github.com/gabritto |
| more fixes | https://github.com/microsoft/TypeScript/pull/60268/commits/6258bc0ae2fcb900ab93a116afb934f4b5ca726f |
| 6258bc0 | https://github.com/microsoft/TypeScript/pull/60268/commits/6258bc0ae2fcb900ab93a116afb934f4b5ca726f |
|
| https://github.com/gabritto |
| WIP: account for pre-existing mapping | https://github.com/microsoft/TypeScript/pull/60268/commits/de3428d887b21a2836e791ed60383e89e78886a7 |
| de3428d | https://github.com/microsoft/TypeScript/pull/60268/commits/de3428d887b21a2836e791ed60383e89e78886a7 |
|
| https://github.com/gabritto |
| only narrow when we take a true branch of a conditional | https://github.com/microsoft/TypeScript/pull/60268/commits/04980d3e7bfc2457d305cdb5df3a0e3dd2a8a1bc |
| 04980d3 | https://github.com/microsoft/TypeScript/pull/60268/commits/04980d3e7bfc2457d305cdb5df3a0e3dd2a8a1bc |
|
| https://github.com/gabritto |
| small fix + new tests | https://github.com/microsoft/TypeScript/pull/60268/commits/e60a625288302f2aceca6d53effe68089a4064b6 |
| e60a625 | https://github.com/microsoft/TypeScript/pull/60268/commits/e60a625288302f2aceca6d53effe68089a4064b6 |
|
| https://github.com/gabritto |
| fix optional parameter handling and shadowing | https://github.com/microsoft/TypeScript/pull/60268/commits/ee2d1bad15f115ac7c0f213ace2bcfb8118909d7 |
| ee2d1ba | https://github.com/microsoft/TypeScript/pull/60268/commits/ee2d1bad15f115ac7c0f213ace2bcfb8118909d7 |
|
| https://github.com/gabritto |
| fix skip parentheses | https://github.com/microsoft/TypeScript/pull/60268/commits/b8ce4903dac236e2f426bc5f0d4555c71592e46c |
| b8ce490 | https://github.com/microsoft/TypeScript/pull/60268/commits/b8ce4903dac236e2f426bc5f0d4555c71592e46c |
|
| https://github.com/gabritto |
| fix updates to binder, cleanup in checker | https://github.com/microsoft/TypeScript/pull/60268/commits/24397676014f3e4b5b6ffbe112a57e33c9f293d4 |
| 2439767 | https://github.com/microsoft/TypeScript/pull/60268/commits/24397676014f3e4b5b6ffbe112a57e33c9f293d4 |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/d2 | https://github.com/microsoft/TypeScript/pull/60268/commits/3f504f4fbc1caf9c10814d48d8897a34f8a34dec |
| 3f504f4 | https://github.com/microsoft/TypeScript/pull/60268/commits/3f504f4fbc1caf9c10814d48d8897a34f8a34dec |
|
| https://github.com/gabritto |
| HasFlowNode update & fixes | https://github.com/microsoft/TypeScript/pull/60268/commits/5e8ca3ebdbf0cde7bdaf03e79fbc7d627fe0c09a |
| 5e8ca3e | https://github.com/microsoft/TypeScript/pull/60268/commits/5e8ca3ebdbf0cde7bdaf03e79fbc7d627fe0c09a |
|
| https://github.com/gabritto |
| cleanup; always check conditional expression's condition inside retur… | https://github.com/microsoft/TypeScript/pull/60268/commits/534cc38847246051ff301bd1401b65abc023e71b |
| 534cc38 | https://github.com/microsoft/TypeScript/pull/60268/commits/534cc38847246051ff301bd1401b65abc023e71b |
|
| https://github.com/gabritto |
| update test after merging | https://github.com/microsoft/TypeScript/pull/60268/commits/1dc9ab55c873cf6a4f00990526df9843ec7456d6 |
| 1dc9ab5 | https://github.com/microsoft/TypeScript/pull/60268/commits/1dc9ab55c873cf6a4f00990526df9843ec7456d6 |
|
| https://github.com/gabritto |
| maybe make binder change faster | https://github.com/microsoft/TypeScript/pull/60268/commits/a94bc2316c91750d032229c00326c4abe334c500 |
| a94bc23 | https://github.com/microsoft/TypeScript/pull/60268/commits/a94bc2316c91750d032229c00326c4abe334c500 |
|
| https://github.com/gabritto |
| don't narrow if conditional has infer type params | https://github.com/microsoft/TypeScript/pull/60268/commits/046b53c3a67ce63ff3bc1e5b007e16eff1877a3b |
| 046b53c | https://github.com/microsoft/TypeScript/pull/60268/commits/046b53c3a67ce63ff3bc1e5b007e16eff1877a3b |
|
| https://github.com/gabritto |
| don't walk up parents when binding conditional expression | https://github.com/microsoft/TypeScript/pull/60268/commits/5a83feb3e66e62a6adacc80c555ee14f3709f56d |
| 5a83feb | https://github.com/microsoft/TypeScript/pull/60268/commits/5a83feb3e66e62a6adacc80c555ee14f3709f56d |
|
| https://github.com/gabritto |
| add promise and generator tests | https://github.com/microsoft/TypeScript/pull/60268/commits/1ac4a588ec22c9ab53ce558e806a66688b90546e |
| 1ac4a58 | https://github.com/microsoft/TypeScript/pull/60268/commits/1ac4a588ec22c9ab53ce558e806a66688b90546e |
|
| https://github.com/gabritto |
| get rid of cast | https://github.com/microsoft/TypeScript/pull/60268/commits/db219a3f54e5dd88c906637aeac956fbec6cf3bf |
| db219a3 | https://github.com/microsoft/TypeScript/pull/60268/commits/db219a3f54e5dd88c906637aeac956fbec6cf3bf |
|
| https://github.com/gabritto |
| add indexed access tests | https://github.com/microsoft/TypeScript/pull/60268/commits/56792a1c03510bd3c9587f4229181c97b6568014 |
| 56792a1 | https://github.com/microsoft/TypeScript/pull/60268/commits/56792a1c03510bd3c9587f4229181c97b6568014 |
|
| https://github.com/gabritto |
| WIP | https://github.com/microsoft/TypeScript/pull/60268/commits/b292bd8dea0f602c558f0dcb05701ae36ac1d9ed |
| b292bd8 | https://github.com/microsoft/TypeScript/pull/60268/commits/b292bd8dea0f602c558f0dcb05701ae36ac1d9ed |
| gabritto | https://github.com/gabritto |
| September 9, 2024 13:41 | https://github.com/microsoft/TypeScript/pull/60268#commits-pushed-10403cf |
|
| https://github.com/gabritto |
| refactoring | https://github.com/microsoft/TypeScript/pull/60268/commits/10403cff5dbd75ac4880e17cdc7a9d6f181c8d02 |
| 10403cf | https://github.com/microsoft/TypeScript/pull/60268/commits/10403cff5dbd75ac4880e17cdc7a9d6f181c8d02 |
|
| https://github.com/gabritto |
| switch reference detection algorithm | https://github.com/microsoft/TypeScript/pull/60268/commits/99d3cd5350a8d8d31bbcfbfefa1e5f060f13eab1 |
| 99d3cd5 | https://github.com/microsoft/TypeScript/pull/60268/commits/99d3cd5350a8d8d31bbcfbfefa1e5f060f13eab1 |
|
| https://github.com/gabritto |
| refactor and add more tests | https://github.com/microsoft/TypeScript/pull/60268/commits/39d2f2bc1ddb80ffb8ab0322614214168399fe29 |
| 39d2f2b | https://github.com/microsoft/TypeScript/pull/60268/commits/39d2f2bc1ddb80ffb8ab0322614214168399fe29 |
|
| https://github.com/gabritto |
| remove unused | https://github.com/microsoft/TypeScript/pull/60268/commits/42f7a2d07f0dc48415f2a1f31f1a256b598a0ddd |
| 42f7a2d | https://github.com/microsoft/TypeScript/pull/60268/commits/42f7a2d07f0dc48415f2a1f31f1a256b598a0ddd |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/d2-detect | https://github.com/microsoft/TypeScript/pull/60268/commits/678d2e00218d4a4f65c891c0bd663bc68623e1d1 |
| 678d2e0 | https://github.com/microsoft/TypeScript/pull/60268/commits/678d2e00218d4a4f65c891c0bd663bc68623e1d1 |
|
| https://github.com/gabritto |
| update baselines | https://github.com/microsoft/TypeScript/pull/60268/commits/7e1fe01f6b76bec603ff9b32adadbcacd24f41d8 |
| 7e1fe01 | https://github.com/microsoft/TypeScript/pull/60268/commits/7e1fe01f6b76bec603ff9b32adadbcacd24f41d8 |
|
| https://github.com/gabritto |
| refactor and fix validation of conditional return type | https://github.com/microsoft/TypeScript/pull/60268/commits/bbaf88f900a31237ed1e0362c327f181ea34d19b |
| bbaf88f | https://github.com/microsoft/TypeScript/pull/60268/commits/bbaf88f900a31237ed1e0362c327f181ea34d19b |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/d2-detect | https://github.com/microsoft/TypeScript/pull/60268/commits/a8200ecd93c7914311a5168d17164f7a93f267b4 |
| a8200ec | https://github.com/microsoft/TypeScript/pull/60268/commits/a8200ecd93c7914311a5168d17164f7a93f267b4 |
|
| https://github.com/gabritto |
| fmt | https://github.com/microsoft/TypeScript/pull/60268/commits/47d8d3f929a21f0755ce9fbf6a8d0f7d63571d05 |
| 47d8d3f | https://github.com/microsoft/TypeScript/pull/60268/commits/47d8d3f929a21f0755ce9fbf6a8d0f7d63571d05 |
|
| https://github.com/gabritto |
| cache intermediate results for conditional validation | https://github.com/microsoft/TypeScript/pull/60268/commits/228148d5d044fcef4752ccbd3baac93cf1be567e |
| 228148d | https://github.com/microsoft/TypeScript/pull/60268/commits/228148d5d044fcef4752ccbd3baac93cf1be567e |
|
| https://github.com/gabritto |
| take mapper into consideration when validating conditional type | https://github.com/microsoft/TypeScript/pull/60268/commits/76718d8755052f30d4f794e5d3a4c454e962b75d |
| 76718d8 | https://github.com/microsoft/TypeScript/pull/60268/commits/76718d8755052f30d4f794e5d3a4c454e962b75d |
|
| https://github.com/gabritto |
| refactor | https://github.com/microsoft/TypeScript/pull/60268/commits/20b79eb8c8bdaf77a8a594ddd1d94646d7fc3d87 |
| 20b79eb | https://github.com/microsoft/TypeScript/pull/60268/commits/20b79eb8c8bdaf77a8a594ddd1d94646d7fc3d87 |
|
| https://github.com/gabritto |
| don't skip jsdoc type assertions | https://github.com/microsoft/TypeScript/pull/60268/commits/3788ada9b9fb9dfdf92041455e1854c065bda2b8 |
| 3788ada | https://github.com/microsoft/TypeScript/pull/60268/commits/3788ada9b9fb9dfdf92041455e1854c065bda2b8 |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/d2-detect | https://github.com/microsoft/TypeScript/pull/60268/commits/2569804d0c7f2ff94ff2aab9ea82218c0a127000 |
| 2569804 | https://github.com/microsoft/TypeScript/pull/60268/commits/2569804d0c7f2ff94ff2aab9ea82218c0a127000 |
|
| https://github.com/gabritto |
| experiment: always set flow node in cond expr | https://github.com/microsoft/TypeScript/pull/60268/commits/827962fab3a2dd03279dc0562c3be3cb7d6df151 |
| 827962f | https://github.com/microsoft/TypeScript/pull/60268/commits/827962fab3a2dd03279dc0562c3be3cb7d6df151 |
|
| https://github.com/gabritto |
| support jsdoc | https://github.com/microsoft/TypeScript/pull/60268/commits/4e773730b7b75e4600c7b22bc07345bfa89cc18b |
| 4e77373 | https://github.com/microsoft/TypeScript/pull/60268/commits/4e773730b7b75e4600c7b22bc07345bfa89cc18b |
|
| https://github.com/gabritto |
| add more jsdoc tests | https://github.com/microsoft/TypeScript/pull/60268/commits/c076dda4e80d622e2bae1e32cae92bd275091047 |
| c076dda | https://github.com/microsoft/TypeScript/pull/60268/commits/c076dda4e80d622e2bae1e32cae92bd275091047 |
|
| https://github.com/gabritto |
| remove support for conditional expressions | https://github.com/microsoft/TypeScript/pull/60268/commits/156d52bef4fa171fe352be1e3eb01061cf09acdb |
| 156d52b | https://github.com/microsoft/TypeScript/pull/60268/commits/156d52bef4fa171fe352be1e3eb01061cf09acdb |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| gabritto | https://github.com/gabritto |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#event-14709037269 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#event-14709037348 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#issuecomment-2421016632 |
| @typescript-bot | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#issuecomment-2421016701 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=163942 |
| 👀 Results | https://github.com/microsoft/TypeScript/pull/60268#issuecomment-2421064260 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#issuecomment-2421064260 |
| @gabritto | https://github.com/gabritto |
| Download Benchmarks | https://typescript.visualstudio.com/TypeScript/_build/results?buildId=163942&view=artifacts |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Oct 18, 2024 | https://github.com/microsoft/TypeScript/pull/60268#event-14709802996 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
|
Oct 18, 2024
| https://github.com/microsoft/TypeScript/pull/60268#ref-pullrequest-2064587329 |
|
Narrow generic conditional and indexed access return types when checking return statements
#56941
| https://github.com/microsoft/TypeScript/pull/56941 |
| https://github.com/Andarist |
| Andarist | https://github.com/Andarist |
| Nov 30, 2024 | https://github.com/microsoft/TypeScript/pull/60268#issuecomment-2508935553 |
| @gabritto | https://github.com/gabritto |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| Dec 2, 2024 | https://github.com/microsoft/TypeScript/pull/60268#event-15496317547 |
| https://github.com/gabritto |
| gabritto | https://github.com/gabritto |
| August 25, 2025 18:37 | https://github.com/microsoft/TypeScript/pull/60268#event-19328202688 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Feb 25, 2026 | https://github.com/microsoft/TypeScript/pull/60268#event-23077500629 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60268 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com/gabritto |
|
gabritto
| https://github.com/gabritto |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/60268 |
|
| https://github.com/gabritto |
|
| https://github.com/typescript-bot |
|
| https://github.com/Andarist |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |