René's URL Explorer Experiment


Title: moveToFile: fix check for global name resolving by iisaduan · Pull Request #60173 · microsoft/TypeScript · GitHub

Open Graph Title: moveToFile: fix check for global name resolving by iisaduan · Pull Request #60173 · microsoft/TypeScript

X Title: moveToFile: fix check for global name resolving by iisaduan · Pull Request #60173 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - moveToFile: fix check for global name resolving by iisaduan · Pull Request #60173 · microsoft/TypeScript

Open Graph Description: Fixes #59799. Fixes isGlobalType, which was added in #58811.

X Description: Fixes #59799. Fixes isGlobalType, which was added in #58811.

Opengraph URL: https://github.com/microsoft/TypeScript/pull/60173

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b2240084-c048-405f-10c3-df5fab572ce3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88B2:3730FD:1F79CB1:2D72ADC:6A60ABB7
html-safe-nonceb9231bc9082a99ff37e3e961fd05e6af36a9963c84a7dd444c6a9ca2387120bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEIyOjM3MzBGRDoxRjc5Q0IxOjJENzJBREM6NkE2MEFCQjciLCJ2aXNpdG9yX2lkIjoiMjA0NzQyOTkxMjcyMzIzNzgxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc4a9ab6d706fd718dd35a8019b2d83bcb77c0f31515beb2e0562cae563423414
hovercard-subject-tagpull_request:2113927136
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/60173/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1cdef2f35693950e9f65553ef651e1f9464d50d1b365bcdad4674a7149b33931/microsoft/TypeScript/pull/60173
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1cdef2f35693950e9f65553ef651e1f9464d50d1b365bcdad4674a7149b33931/microsoft/TypeScript/pull/60173
og:image:altFixes #59799. Fixes isGlobalType, which was added in #58811.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameiisaduan
hostnamegithub.com
expected-hostnamegithub.com
None66af895cfa11168648b21cb54f2bdc3b0587503cc95c3040344b93f2cd4f9e08
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb2efb079bef4751afb19e51eb8a7bfb7a46dd1a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/60173#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60173
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60173
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/60173
Reloadhttps://github.com/microsoft/TypeScript/pull/60173
Reloadhttps://github.com/microsoft/TypeScript/pull/60173
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 30 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
iisaduanhttps://github.com/iisaduan
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
iisaduan:movetofile-globalhttps://github.com/iisaduan/TypeScript/tree/movetofile-global
Conversationhttps://github.com/microsoft/TypeScript/pull/60173
Commits8 (8)https://github.com/microsoft/TypeScript/pull/60173/commits
Checkshttps://github.com/microsoft/TypeScript/pull/60173/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/60173/files
moveToFile: fix check for global name resolving https://github.com/microsoft/TypeScript/pull/60173#top
iisaduanhttps://github.com/iisaduan
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
iisaduan:movetofile-globalhttps://github.com/iisaduan/TypeScript/tree/movetofile-global
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
Oct 8, 2024https://github.com/microsoft/TypeScript/pull/60173#issue-2574230772
#59799https://github.com/microsoft/TypeScript/issues/59799
#58811https://github.com/microsoft/TypeScript/pull/58811
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
iisaduanhttps://github.com/iisaduan
October 7, 2024 16:00https://github.com/microsoft/TypeScript/pull/60173#commits-pushed-a20bcb8
https://github.com/iisaduan
only skip imports for symbols that may be global types if they are no…https://github.com/microsoft/TypeScript/pull/60173/commits/a20bcb87da4d287bdb177588bdcbd1dd98ea3263
a20bcb8https://github.com/microsoft/TypeScript/pull/60173/commits/a20bcb87da4d287bdb177588bdcbd1dd98ea3263
https://github.com/iisaduan
add paste test, rename tests, fix isGlobalTypehttps://github.com/microsoft/TypeScript/pull/60173/commits/7112af8747533c046f7322a8fb9bb906a014ecbb
7112af8https://github.com/microsoft/TypeScript/pull/60173/commits/7112af8747533c046f7322a8fb9bb906a014ecbb
https://github.com/iisaduan
fix isGlobalType againhttps://github.com/microsoft/TypeScript/pull/60173/commits/9bbf9babafd16cfbf9b5f6119417b7aa65314306
9bbf9bahttps://github.com/microsoft/TypeScript/pull/60173/commits/9bbf9babafd16cfbf9b5f6119417b7aa65314306
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
iisaduanhttps://github.com/iisaduan
Oct 8, 2024https://github.com/microsoft/TypeScript/pull/60173#event-14562995856
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Oct 8, 2024https://github.com/microsoft/TypeScript/pull/60173#event-14562995963
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
andrewbranchhttps://github.com/andrewbranch
gabrittohttps://github.com/gabritto
navya9singhhttps://github.com/navya9singh
October 8, 2024 21:19https://github.com/microsoft/TypeScript/pull/60173#event-14562998722
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
Oct 8, 2024https://github.com/microsoft/TypeScript/pull/60173#issuecomment-2400995523
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
Oct 8, 2024https://github.com/microsoft/TypeScript/pull/60173#event-14563967287
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
Oct 8, 2024https://github.com/microsoft/TypeScript/pull/60173#event-14563967571
https://github.com/iisaduan
add testhttps://github.com/microsoft/TypeScript/pull/60173/commits/5fd1bef2ea42cac367ed8489c6e135bca3e183fe
5fd1befhttps://github.com/microsoft/TypeScript/pull/60173/commits/5fd1bef2ea42cac367ed8489c6e135bca3e183fe
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
Oct 14, 2024 https://github.com/microsoft/TypeScript/pull/60173#pullrequestreview-2367158021
View reviewed changes https://github.com/microsoft/TypeScript/pull/60173/files/5fd1bef2ea42cac367ed8489c6e135bca3e183fe
src/services/refactors/moveToFile.tshttps://github.com/microsoft/TypeScript/pull/60173/files/5fd1bef2ea42cac367ed8489c6e135bca3e183fe#diff-9fd1565ec50d1dc61c5267c87fd4d9436b74a6a41a6dccdac0660bcb2ae85e9c
andrewbranchhttps://github.com/andrewbranch
Oct 14, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1799812783
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
iisaduanhttps://github.com/iisaduan
Oct 14, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1799910332
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
andrewbranchhttps://github.com/andrewbranch
Oct 14, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1799920893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
iisaduanhttps://github.com/iisaduan
Oct 14, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1799961078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@navya9singhhttps://github.com/navya9singh
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
DanielRosenwasserhttps://github.com/DanielRosenwasser
Oct 14, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1800221856
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@andrewbranchhttps://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
andrewbranchhttps://github.com/andrewbranch
Oct 15, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1800253008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
iisaduanhttps://github.com/iisaduan
Oct 15, 2024https://github.com/microsoft/TypeScript/pull/60173#discussion_r1800260126
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@DanielRosenwasserhttps://github.com/DanielRosenwasser
@andrewbranchhttps://github.com/andrewbranch
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
iisaduanhttps://github.com/iisaduan
October 14, 2024 12:00https://github.com/microsoft/TypeScript/pull/60173#commits-pushed-38b06af
https://github.com/iisaduan
add testhttps://github.com/microsoft/TypeScript/pull/60173/commits/38b06af685748c0fc0f6f16dfbec1d253bc40692
38b06afhttps://github.com/microsoft/TypeScript/pull/60173/commits/38b06af685748c0fc0f6f16dfbec1d253bc40692
https://github.com/iisaduan
Merge branch 'main' ofhttps://github.com/microsoft/TypeScript/pull/60173/commits/4e9562c06bed98223d7543d611a11d9dcd955480
https://github.com/iisaduan/TypeScripthttps://github.com/iisaduan/TypeScript
into mo…https://github.com/microsoft/TypeScript/pull/60173/commits/4e9562c06bed98223d7543d611a11d9dcd955480
4e9562chttps://github.com/microsoft/TypeScript/pull/60173/commits/4e9562c06bed98223d7543d611a11d9dcd955480
https://github.com/iisaduan
update tests for improved quote behaviorshttps://github.com/microsoft/TypeScript/pull/60173/commits/a8f8da01e31a4a3e132f81807d490a18f274864b
a8f8da0https://github.com/microsoft/TypeScript/pull/60173/commits/a8f8da01e31a4a3e132f81807d490a18f274864b
https://github.com/iisaduan
make sure resolved symbol is same symbolhttps://github.com/microsoft/TypeScript/pull/60173/commits/58118b201d99be3c80305b90a88d7cc580267851
58118b2https://github.com/microsoft/TypeScript/pull/60173/commits/58118b201d99be3c80305b90a88d7cc580267851
https://github.com/iisaduan
iisaduanhttps://github.com/iisaduan
Nov 7, 2024 https://github.com/microsoft/TypeScript/pull/60173#ref-pullrequest-2632822119
Allow imports with the same names as global types to be moved by refactoring #60410 https://github.com/microsoft/TypeScript/pull/60410
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
Nov 7, 2024 https://github.com/microsoft/TypeScript/pull/60173#ref-pullrequest-2641938709
Move to file: fix detection of references to globals that shouldn't be moved #60450 https://github.com/microsoft/TypeScript/pull/60450
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Fix Available https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
Nov 7, 2024https://github.com/microsoft/TypeScript/pull/60173#event-15190481398
https://github.com/andrewbranch
andrewbranchhttps://github.com/andrewbranch
#60450 https://github.com/microsoft/TypeScript/pull/60450
Nov 15, 2024https://github.com/microsoft/TypeScript/pull/60173#event-15318516663
https://github.com/sandersn
sandersnhttps://github.com/sandersn
PR Backloghttps://github.com/orgs/microsoft/projects/1252
Apr 22, 2025https://github.com/microsoft/TypeScript/pull/60173#event-17355454131
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/60173#event-20309761608
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F60173
https://github.com/DanielRosenwasser
DanielRosenwasser https://github.com/DanielRosenwasser
https://github.com/microsoft/TypeScript/pull/60173/files/a8f8da01e31a4a3e132f81807d490a18f274864b
https://github.com/andrewbranch
andrewbranch https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/60173/files/5fd1bef2ea42cac367ed8489c6e135bca3e183fe
https://github.com/gabritto
gabritto https://github.com/gabritto
https://github.com/navya9singh
navya9singh https://github.com/navya9singh
https://github.com/iisaduan
iisaduan https://github.com/iisaduan
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
Fix Available https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Import named Disposable is not moved when moving code to another file https://github.com/microsoft/TypeScript/issues/59799
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/60173
https://github.com/iisaduan
https://github.com/DanielRosenwasser
https://github.com/andrewbranch
https://github.com/sandersn
https://github.com/typescript-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.