René's URL Explorer Experiment


Title: Simplify mergeEmitNode by jakebailey · Pull Request #59613 · microsoft/TypeScript · GitHub

Open Graph Title: Simplify mergeEmitNode by jakebailey · Pull Request #59613 · microsoft/TypeScript

X Title: Simplify mergeEmitNode by jakebailey · Pull Request #59613 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Simplify mergeEmitNode by jakebailey · Pull Request #59613 · microsoft/TypeScript

Open Graph Description: @armanio123 and I noticed in #59332 that simply copying leadingComments/trailingComments and force overwriting (rather than concatenating) fixes the comment duplication problem from #59332. Reading...

X Description: @armanio123 and I noticed in #59332 that simply copying leadingComments/trailingComments and force overwriting (rather than concatenating) fixes the comment duplication problem from #59332. Reading...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/59613

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a0e1a0b3-c25d-45ce-4640-4d21a3705e63
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED82:E1E8C:D1B3EB:127B469:6A61CB5E
html-safe-nonce9ca9a65cfac7c8ef8158257d29a8d7d07131ac6a7bdf87ad2e0da7c40607914b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDgyOkUxRThDOkQxQjNFQjoxMjdCNDY5OjZBNjFDQjVFIiwidmlzaXRvcl9pZCI6Ijg1NDIyNTA2MzczODcyMzE2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacadfc0288c369e6ae09e44aff6321d975fdb584ac70e10cf8f587ed94c1ff2e74
hovercard-subject-tagpull_request:2016045867
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/59613/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59613
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59613
og:image:alt@armanio123 and I noticed in #59332 that simply copying leadingComments/trailingComments and force overwriting (rather than concatenating) fixes the comment duplication problem from #59332. Reading...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Noneb2de8c74e5e61e893155ba46ee41bc66170c1644cb795adefa8386d490f7781c
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1866027ded575df8a15c731dd8b9986c9483ceb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/59613#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59613
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59613
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/59613
Reloadhttps://github.com/microsoft/TypeScript/pull/59613
Reloadhttps://github.com/microsoft/TypeScript/pull/59613
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
microsoft https://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Notifications https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Fork 13.6k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Star 110k https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript
Code https://github.com/microsoft/TypeScript
Issues 5k+ https://github.com/microsoft/TypeScript/issues
Pull requests 21 https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality 0 https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
Code https://github.com/microsoft/TypeScript
Issues https://github.com/microsoft/TypeScript/issues
Pull requests https://github.com/microsoft/TypeScript/pulls
Actions https://github.com/microsoft/TypeScript/actions
Projects https://github.com/microsoft/TypeScript/projects
Models https://github.com/microsoft/TypeScript/models
Wiki https://github.com/microsoft/TypeScript/wiki
Security and quality https://github.com/microsoft/TypeScript/security
Insights https://github.com/microsoft/TypeScript/pulse
jakebaileyhttps://github.com/jakebailey
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
jakebailey:simplify-mergeEmitNodehttps://github.com/jakebailey/TypeScript/tree/simplify-mergeEmitNode
Conversationhttps://github.com/microsoft/TypeScript/pull/59613
Commits2 (2)https://github.com/microsoft/TypeScript/pull/59613/commits
Checkshttps://github.com/microsoft/TypeScript/pull/59613/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/59613/files
Simplify mergeEmitNodehttps://github.com/microsoft/TypeScript/pull/59613#top
jakebaileyhttps://github.com/jakebailey
microsoft:mainhttps://github.com/microsoft/TypeScript/tree/main
jakebailey:simplify-mergeEmitNodehttps://github.com/jakebailey/TypeScript/tree/simplify-mergeEmitNode
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Aug 12, 2024https://github.com/microsoft/TypeScript/pull/59613#issue-2462081283
@armanio123https://github.com/armanio123
#59332https://github.com/microsoft/TypeScript/pull/59332
#59332https://github.com/microsoft/TypeScript/pull/59332
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/jakebailey
Simplify mergeEmitNodehttps://github.com/microsoft/TypeScript/pull/59613/commits/cf6e6ce7b844287f6f810d494d9b8f6bc725adaa
cf6e6cehttps://github.com/microsoft/TypeScript/pull/59613/commits/cf6e6ce7b844287f6f810d494d9b8f6bc725adaa
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
armanio123https://github.com/armanio123
rbucktonhttps://github.com/rbuckton
August 12, 2024 23:51https://github.com/microsoft/TypeScript/pull/59613#event-13855880335
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
jakebaileyhttps://github.com/jakebailey
Aug 12, 2024https://github.com/microsoft/TypeScript/pull/59613#event-13855880515
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Aug 12, 2024https://github.com/microsoft/TypeScript/pull/59613#event-13855880569
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Aug 12, 2024https://github.com/microsoft/TypeScript/pull/59613#issuecomment-2285088731
@typescript-bothttps://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Aug 12, 2024https://github.com/microsoft/TypeScript/pull/59613#issuecomment-2285088791
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=163243
👀 Resultshttps://github.com/microsoft/TypeScript/pull/59613#issuecomment-2285123975
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Aug 12, 2024 https://github.com/microsoft/TypeScript/pull/59613#pullrequestreview-2234201302
View reviewed changes https://github.com/microsoft/TypeScript/pull/59613/files/cf6e6ce7b844287f6f810d494d9b8f6bc725adaa
src/compiler/factory/nodeFactory.tshttps://github.com/microsoft/TypeScript/pull/59613/files/cf6e6ce7b844287f6f810d494d9b8f6bc725adaa#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80
jakebaileyhttps://github.com/jakebailey
Aug 12, 2024https://github.com/microsoft/TypeScript/pull/59613#discussion_r1714483501
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
rbucktonhttps://github.com/rbuckton
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#discussion_r1715863189
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/jakebailey
Fix linthttps://github.com/microsoft/TypeScript/pull/59613/commits/44f6caf6328fd4e24c6191e012e28fe5eb1509d7
44f6cafhttps://github.com/microsoft/TypeScript/pull/59613/commits/44f6caf6328fd4e24c6191e012e28fe5eb1509d7
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Aug 12, 2024 https://github.com/microsoft/TypeScript/pull/59613#ref-pullrequest-2414616702
Added typeToTypeNode with truncation #59332 https://github.com/microsoft/TypeScript/pull/59332
https://github.com/typescript-bot
typescript-bothttps://github.com/typescript-bot
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#issuecomment-2285123975
@jakebaileyhttps://github.com/jakebailey
Download Benchmarkshttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=163243&view=artifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#issuecomment-2287034794
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
Aug 13, 2024 https://github.com/microsoft/TypeScript/pull/59613#pullrequestreview-2236480833
View reviewed changes https://github.com/microsoft/TypeScript/pull/59613/files/44f6caf6328fd4e24c6191e012e28fe5eb1509d7
src/compiler/factory/nodeFactory.tshttps://github.com/microsoft/TypeScript/pull/59613/files/cf6e6ce7b844287f6f810d494d9b8f6bc725adaa#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80
rbucktonhttps://github.com/rbuckton
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#discussion_r1715863189
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
src/compiler/factory/nodeFactory.tshttps://github.com/microsoft/TypeScript/pull/59613/files/44f6caf6328fd4e24c6191e012e28fe5eb1509d7#diff-db6fa105c495d655ffce5b52d0f5abaa1d59947ce2fa102ee023de15d15a0b80
rbucktonhttps://github.com/rbuckton
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#discussion_r1715876430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
jakebaileyhttps://github.com/jakebailey
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#discussion_r1715892817
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#59332https://github.com/microsoft/TypeScript/pull/59332
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
armanio123https://github.com/armanio123
Aug 13, 2024https://github.com/microsoft/TypeScript/pull/59613#discussion_r1715906365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
Aug 15, 2024https://github.com/microsoft/TypeScript/pull/59613#issuecomment-2292040819
#59332https://github.com/microsoft/TypeScript/pull/59332
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
Aug 15, 2024https://github.com/microsoft/TypeScript/pull/59613#issuecomment-2292138623
#59332https://github.com/microsoft/TypeScript/pull/59332
#59332 (comment)https://github.com/microsoft/TypeScript/pull/59332#discussion_r1718920733
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/jakebailey
jakebaileyhttps://github.com/jakebailey
Aug 15, 2024https://github.com/microsoft/TypeScript/pull/59613#event-13901935521
https://github.com/rbuckton
rbucktonhttps://github.com/rbuckton
Aug 15, 2024 https://github.com/microsoft/TypeScript/pull/59613#ref-pullrequest-2468990987
Do not overwrite original pointer when indirectly points to location #59647 https://github.com/microsoft/TypeScript/pull/59647
https://github.com/sandersn
sandersnhttps://github.com/sandersn
PR Backloghttps://github.com/orgs/microsoft/projects/1252
Apr 22, 2025https://github.com/microsoft/TypeScript/pull/59613#event-17355446431
https://github.com/microsoft
microsofthttps://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/59613#event-20309761323
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59613
https://github.com/armanio123
armanio123 https://github.com/armanio123
https://github.com/rbuckton
rbuckton https://github.com/rbuckton
https://github.com/microsoft/TypeScript/pull/59613/files/44f6caf6328fd4e24c6191e012e28fe5eb1509d7
https://github.com/jakebailey
jakebailey https://github.com/jakebailey
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59613
https://github.com/jakebailey
https://github.com/typescript-bot
https://github.com/rbuckton
https://github.com/armanio123
https://github.com/sandersn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.