René's URL Explorer Experiment


Title: Enable existing commit characters in certain locations where `isNewIdentifier` is true by gabritto · Pull Request #59523 · microsoft/TypeScript · GitHub

Open Graph Title: Enable existing commit characters in certain locations where `isNewIdentifier` is true by gabritto · Pull Request #59523 · microsoft/TypeScript

X Title: Enable existing commit characters in certain locations where `isNewIdentifier` is true by gabritto · Pull Request #59523 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Enable existing commit characters in certain locations where `isNewIdentifier` is true by gabritto · Pull Request #59523 · microsoft/TypeScript

Open Graph Description: Fixes #31244. Fixes #25691. As I said in #59339, our existing behavior, implemented based on vscode's behavior, is that whenever isNewIdentifierLocation is true, we disable all commit character...

X Description: Fixes #31244. Fixes #25691. As I said in #59339, our existing behavior, implemented based on vscode's behavior, is that whenever isNewIdentifierLocation is true, we disable all commit chara...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/59523

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b12a7a41-3b4e-07d7-0db0-2046b5e6e7c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7EA:17FB7:2AA4C:358A6:6B00F37C
html-safe-noncebac625ecef41e7b71d738868fcda6759f231dfc3e4d59143893440bfb8119dd0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0VBOjE3RkI3OjJBQTRDOjM1OEE2OjZCMDBGMzdDIiwidmlzaXRvcl9pZCI6IjY1Mjc2NjE0MjE5MTA2MTkwMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbb297a5d3b17ea7a1a1fc2ea8d94f15744d2b3200f023c33c823623b490d65fd
hovercard-subject-tagpull_request:2001582911
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/59523/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59523
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59523
og:image:altFixes #31244. Fixes #25691. As I said in #59339, our existing behavior, implemented based on vscode's behavior, is that whenever isNewIdentifierLocation is true, we disable all commit character...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabritto
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/59523#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59523
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59523
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/59523
Reloadhttps://github.com/microsoft/TypeScript/pull/59523
Reloadhttps://github.com/microsoft/TypeScript/pull/59523
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
mainhttps://github.com/microsoft/TypeScript/tree/main
gabritto/issue31244https://github.com/microsoft/TypeScript/tree/gabritto/issue31244
Conversationhttps://github.com/microsoft/TypeScript/pull/59523
Commits8 (8)https://github.com/microsoft/TypeScript/pull/59523/commits
Checkshttps://github.com/microsoft/TypeScript/pull/59523/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/59523/files
Enable existing commit characters in certain locations where isNewIdentifier is truehttps://github.com/microsoft/TypeScript/pull/59523#top
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
mainhttps://github.com/microsoft/TypeScript/tree/main
gabritto/issue31244https://github.com/microsoft/TypeScript/tree/gabritto/issue31244
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Aug 2, 2024https://github.com/microsoft/TypeScript/pull/59523#issue-2445828661
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
#31244https://github.com/microsoft/TypeScript/issues/31244
#25691https://github.com/microsoft/TypeScript/issues/25691
#59339https://github.com/microsoft/TypeScript/pull/59339
microsoft/vscode#223541https://github.com/microsoft/vscode/pull/223541
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
July 31, 2024 14:48https://github.com/microsoft/TypeScript/pull/59523#commits-pushed-8e20fa9
https://github.com/gabritto
Enable commit characters in more positionshttps://github.com/microsoft/TypeScript/pull/59523/commits/8e20fa9a3d2b273c0374453525b0644f547c18dd
8e20fa9https://github.com/microsoft/TypeScript/pull/59523/commits/8e20fa9a3d2b273c0374453525b0644f547c18dd
https://github.com/gabritto
add comma to more placeshttps://github.com/microsoft/TypeScript/pull/59523/commits/bf2fb947753dff617262968096dd50e269c22ceb
bf2fb94https://github.com/microsoft/TypeScript/pull/59523/commits/bf2fb947753dff617262968096dd50e269c22ceb
https://github.com/gabritto
set commit characters for dot completion casehttps://github.com/microsoft/TypeScript/pull/59523/commits/719f8244e1af687d7f031e782087850dbbedb435
719f824https://github.com/microsoft/TypeScript/pull/59523/commits/719f8244e1af687d7f031e782087850dbbedb435
https://github.com/gabritto
fixes and tests to global caseshttps://github.com/microsoft/TypeScript/pull/59523/commits/22424c6aa1be087519e9ef053a5640b1913a5b03
22424c6https://github.com/microsoft/TypeScript/pull/59523/commits/22424c6aa1be087519e9ef053a5640b1913a5b03
https://github.com/gabritto
add test for existing import and export caseshttps://github.com/microsoft/TypeScript/pull/59523/commits/d52d13cbbec7e4b1ac49b1e90e15b5ca69f9c143
d52d13chttps://github.com/microsoft/TypeScript/pull/59523/commits/d52d13cbbec7e4b1ac49b1e90e15b5ca69f9c143
https://github.com/gabritto
refactorhttps://github.com/microsoft/TypeScript/pull/59523/commits/bfab059a87913cc538747c1a8198953c01e6bbfe
bfab059https://github.com/microsoft/TypeScript/pull/59523/commits/bfab059a87913cc538747c1a8198953c01e6bbfe
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Aug 2, 2024https://github.com/microsoft/TypeScript/pull/59523#event-13747197511
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Aug 2, 2024https://github.com/microsoft/TypeScript/pull/59523#event-13747197605
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Aug 2, 2024https://github.com/microsoft/TypeScript/pull/59523#event-13747198314
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
August 2, 2024 15:29https://github.com/microsoft/TypeScript/pull/59523#commits-pushed-9063257
https://github.com/gabritto
Merge branch 'main' into gabritto/issue31244https://github.com/microsoft/TypeScript/pull/59523/commits/90632577f520154eb6904fa79fa6837c891f0534
9063257https://github.com/microsoft/TypeScript/pull/59523/commits/90632577f520154eb6904fa79fa6837c891f0534
https://github.com/gabritto
don't mutate commit charactershttps://github.com/microsoft/TypeScript/pull/59523/commits/73fed551a4eb9e791ae1a9b46d8257be5ee80f05
73fed55https://github.com/microsoft/TypeScript/pull/59523/commits/73fed551a4eb9e791ae1a9b46d8257be5ee80f05
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
August 3, 2024 00:02https://github.com/microsoft/TypeScript/pull/59523#event-13747626698
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Isabel Duan (iisaduan)https://github.com/iisaduan
August 3, 2024 00:02https://github.com/microsoft/TypeScript/pull/59523#event-13747628323
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Aug 3, 2024https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266282142
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 3, 2024https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266282184
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=163138
✅ Resultshttps://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266283972
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Aug 3, 2024https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266283972
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
an installable tgzhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163138/artifacts?artifactName=tgz&fileId=4C1EFBDE2A0665C56E75E44A26218F8291D850382E267E20EB350493D7B12E0202&fileName=/typescript-5.6.0-insiders.20240803.tgz
for this buildhttps://www.typescriptlang.org/play?ts=5.6.0-pr-59523-2
npmhttps://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.6.0-pr-59523-2
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
Aug 3, 2024 https://github.com/microsoft/TypeScript/pull/59523#ref-pullrequest-2445928099
Add custom eslint rule 'no-array-mutating-method-expressions' #59526 https://github.com/microsoft/TypeScript/pull/59526
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Aug 5, 2024 https://github.com/microsoft/TypeScript/pull/59523#pullrequestreview-2219535549
View reviewed changes https://github.com/microsoft/TypeScript/pull/59523/files/73fed551a4eb9e791ae1a9b46d8257be5ee80f05
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Aug 6, 2024https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2271893783
thishttps://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266283972
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
1e7889chttps://github.com/microsoft/TypeScript/commit/1e7889c6976a7c818bbaa32ab9e30a477d8657a7
Aug 19, 2024https://github.com/microsoft/TypeScript/pull/59523#event-13935459610
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
August 19, 2024 20:24https://github.com/microsoft/TypeScript/pull/59523#event-13935459991
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/59523#event-20309761304
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59523
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/59523/files/73fed551a4eb9e791ae1a9b46d8257be5ee80f05
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
https://github.com/iisaduan
Isabel Duan (iisaduan) https://github.com/iisaduan
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Milestone Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22
Suggestions not accepted when using commit characters https://github.com/microsoft/TypeScript/issues/31244
isNewIdentifierLocation is always set to true inside function call https://github.com/microsoft/TypeScript/issues/25691
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59523
https://github.com/gabritto
https://github.com/typescript-bot
https://github.com/andrewbranch
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.