| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b12a7a41-3b4e-07d7-0db0-2046b5e6e7c4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7EA:17FB7:2AA4C:358A6:6B00F37C |
| html-safe-nonce | bac625ecef41e7b71d738868fcda6759f231dfc3e4d59143893440bfb8119dd0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0VBOjE3RkI3OjJBQTRDOjM1OEE2OjZCMDBGMzdDIiwidmlzaXRvcl9pZCI6IjY1Mjc2NjE0MjE5MTA2MTkwMDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bb297a5d3b17ea7a1a1fc2ea8d94f15744d2b3200f023c33c823623b490d65fd |
| hovercard-subject-tag | pull_request:2001582911 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/59523/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59523 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59523 |
| og:image:alt | Fixes #31244.
Fixes #25691.
As I said in #59339, our existing behavior, implemented based on vscode's behavior, is that whenever isNewIdentifierLocation is true, we disable all commit character... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gabritto |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/microsoft/TypeScript/pull/59523#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59523 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59523 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/59523 |
| Reload | https://github.com/microsoft/TypeScript/pull/59523 |
| Reload | https://github.com/microsoft/TypeScript/pull/59523 |
| microsoft | https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
| Code | https://github.com/microsoft/TypeScript |
| Issues5k (5k) | https://github.com/microsoft/TypeScript/issues |
| Pull requests308 (308) | https://github.com/microsoft/TypeScript/pulls |
| Actions | https://github.com/microsoft/TypeScript/actions |
| Projects | https://github.com/microsoft/TypeScript/projects |
| Wiki | https://github.com/microsoft/TypeScript/wiki |
| Security and quality | https://github.com/microsoft/TypeScript/security |
| Insights | https://github.com/microsoft/TypeScript/insights |
| https://github.com/microsoft/TypeScript |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| main | https://github.com/microsoft/TypeScript/tree/main |
| gabritto/issue31244 | https://github.com/microsoft/TypeScript/tree/gabritto/issue31244 |
| Conversation | https://github.com/microsoft/TypeScript/pull/59523 |
| Commits8 (8) | https://github.com/microsoft/TypeScript/pull/59523/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/59523/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/59523/files |
| Enable existing commit characters in certain locations where isNewIdentifier is true | https://github.com/microsoft/TypeScript/pull/59523#top |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| main | https://github.com/microsoft/TypeScript/tree/main |
| gabritto/issue31244 | https://github.com/microsoft/TypeScript/tree/gabritto/issue31244 |
|
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Aug 2, 2024 | https://github.com/microsoft/TypeScript/pull/59523#issue-2445828661 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| #31244 | https://github.com/microsoft/TypeScript/issues/31244 |
| #25691 | https://github.com/microsoft/TypeScript/issues/25691 |
| #59339 | https://github.com/microsoft/TypeScript/pull/59339 |
| microsoft/vscode#223541 | https://github.com/microsoft/vscode/pull/223541 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| July 31, 2024 14:48 | https://github.com/microsoft/TypeScript/pull/59523#commits-pushed-8e20fa9 |
|
| https://github.com/gabritto |
| Enable commit characters in more positions | https://github.com/microsoft/TypeScript/pull/59523/commits/8e20fa9a3d2b273c0374453525b0644f547c18dd |
| 8e20fa9 | https://github.com/microsoft/TypeScript/pull/59523/commits/8e20fa9a3d2b273c0374453525b0644f547c18dd |
|
| https://github.com/gabritto |
| add comma to more places | https://github.com/microsoft/TypeScript/pull/59523/commits/bf2fb947753dff617262968096dd50e269c22ceb |
| bf2fb94 | https://github.com/microsoft/TypeScript/pull/59523/commits/bf2fb947753dff617262968096dd50e269c22ceb |
|
| https://github.com/gabritto |
| set commit characters for dot completion case | https://github.com/microsoft/TypeScript/pull/59523/commits/719f8244e1af687d7f031e782087850dbbedb435 |
| 719f824 | https://github.com/microsoft/TypeScript/pull/59523/commits/719f8244e1af687d7f031e782087850dbbedb435 |
|
| https://github.com/gabritto |
| fixes and tests to global cases | https://github.com/microsoft/TypeScript/pull/59523/commits/22424c6aa1be087519e9ef053a5640b1913a5b03 |
| 22424c6 | https://github.com/microsoft/TypeScript/pull/59523/commits/22424c6aa1be087519e9ef053a5640b1913a5b03 |
|
| https://github.com/gabritto |
| add test for existing import and export cases | https://github.com/microsoft/TypeScript/pull/59523/commits/d52d13cbbec7e4b1ac49b1e90e15b5ca69f9c143 |
| d52d13c | https://github.com/microsoft/TypeScript/pull/59523/commits/d52d13cbbec7e4b1ac49b1e90e15b5ca69f9c143 |
|
| https://github.com/gabritto |
| refactor | https://github.com/microsoft/TypeScript/pull/59523/commits/bfab059a87913cc538747c1a8198953c01e6bbfe |
| bfab059 | https://github.com/microsoft/TypeScript/pull/59523/commits/bfab059a87913cc538747c1a8198953c01e6bbfe |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Aug 2, 2024 | https://github.com/microsoft/TypeScript/pull/59523#event-13747197511 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
| Aug 2, 2024 | https://github.com/microsoft/TypeScript/pull/59523#event-13747197605 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Aug 2, 2024 | https://github.com/microsoft/TypeScript/pull/59523#event-13747198314 |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| August 2, 2024 15:29 | https://github.com/microsoft/TypeScript/pull/59523#commits-pushed-9063257 |
|
| https://github.com/gabritto |
| Merge branch 'main' into gabritto/issue31244 | https://github.com/microsoft/TypeScript/pull/59523/commits/90632577f520154eb6904fa79fa6837c891f0534 |
| 9063257 | https://github.com/microsoft/TypeScript/pull/59523/commits/90632577f520154eb6904fa79fa6837c891f0534 |
|
| https://github.com/gabritto |
| don't mutate commit characters | https://github.com/microsoft/TypeScript/pull/59523/commits/73fed551a4eb9e791ae1a9b46d8257be5ee80f05 |
| 73fed55 | https://github.com/microsoft/TypeScript/pull/59523/commits/73fed551a4eb9e791ae1a9b46d8257be5ee80f05 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| August 3, 2024 00:02 | https://github.com/microsoft/TypeScript/pull/59523#event-13747626698 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Daniel Rosenwasser (DanielRosenwasser) | https://github.com/DanielRosenwasser |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
| Isabel Duan (iisaduan) | https://github.com/iisaduan |
| August 3, 2024 00:02 | https://github.com/microsoft/TypeScript/pull/59523#event-13747628323 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Aug 3, 2024 | https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266282142 |
| TypeScript Bot (@typescript-bot) | https://github.com/typescript-bot |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Aug 3, 2024 | https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266282184 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| ✅ Started | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=163138 |
| ✅ Results | https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266283972 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| https://github.com/typescript-bot |
| TypeScript Bot (typescript-bot) | https://github.com/typescript-bot |
| Aug 3, 2024 | https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266283972 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| Gabriela Araujo Britto (@gabritto) | https://github.com/gabritto |
| an installable tgz | https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/163138/artifacts?artifactName=tgz&fileId=4C1EFBDE2A0665C56E75E44A26218F8291D850382E267E20EB350493D7B12E0202&fileName=/typescript-5.6.0-insiders.20240803.tgz |
| for this build | https://www.typescriptlang.org/play?ts=5.6.0-pr-59523-2 |
| npm | https://www.npmjs.com/package/@typescript-deploys/pr-build/v/5.6.0-pr-59523-2 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| https://github.com/jakebailey |
| Jake Bailey (jakebailey) | https://github.com/jakebailey |
|
Aug 3, 2024
| https://github.com/microsoft/TypeScript/pull/59523#ref-pullrequest-2445928099 |
|
Add custom eslint rule 'no-array-mutating-method-expressions'
#59526
| https://github.com/microsoft/TypeScript/pull/59526 |
| https://github.com/andrewbranch |
| Andrew Branch (andrewbranch) | https://github.com/andrewbranch |
|
Aug 5, 2024
| https://github.com/microsoft/TypeScript/pull/59523#pullrequestreview-2219535549 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/59523/files/73fed551a4eb9e791ae1a9b46d8257be5ee80f05 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| Aug 6, 2024 | https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2271893783 |
| this | https://github.com/microsoft/TypeScript/pull/59523#issuecomment-2266283972 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| 1e7889c | https://github.com/microsoft/TypeScript/commit/1e7889c6976a7c818bbaa32ab9e30a477d8657a7 |
| Aug 19, 2024 | https://github.com/microsoft/TypeScript/pull/59523#event-13935459610 |
| https://github.com/gabritto |
| Gabriela Araujo Britto (gabritto) | https://github.com/gabritto |
| August 19, 2024 20:24 | https://github.com/microsoft/TypeScript/pull/59523#event-13935459991 |
| https://github.com/microsoft |
| Microsoft (microsoft) | https://github.com/microsoft |
| Oct 16, 2025 | https://github.com/microsoft/TypeScript/pull/59523#event-20309761304 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59523 |
|
| https://github.com/andrewbranch |
|
Andrew Branch (andrewbranch)
| https://github.com/andrewbranch |
|
| https://github.com/microsoft/TypeScript/pull/59523/files/73fed551a4eb9e791ae1a9b46d8257be5ee80f05 |
|
| https://github.com/DanielRosenwasser |
|
Daniel Rosenwasser (DanielRosenwasser)
| https://github.com/DanielRosenwasser |
|
| https://github.com/iisaduan |
|
Isabel Duan (iisaduan)
| https://github.com/iisaduan |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
|
| https://github.com/gabritto |
|
Gabriela Araujo Britto (gabritto)
| https://github.com/gabritto |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Milestone Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Milestone%20Bug%22 |
|
Suggestions not accepted when using commit characters
| https://github.com/microsoft/TypeScript/issues/31244 |
|
isNewIdentifierLocation is always set to true inside function call
| https://github.com/microsoft/TypeScript/issues/25691 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59523 |
|
| https://github.com/gabritto |
|
| https://github.com/typescript-bot |
|
| https://github.com/andrewbranch |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |