René's URL Explorer Experiment


Title: Use spread when converting completion entry to protocol format by gabritto · Pull Request #59412 · microsoft/TypeScript · GitHub

Open Graph Title: Use spread when converting completion entry to protocol format by gabritto · Pull Request #59412 · microsoft/TypeScript

X Title: Use spread when converting completion entry to protocol format by gabritto · Pull Request #59412 · microsoft/TypeScript

Description: TypeScript is a superset of JavaScript that compiles to clean JavaScript output. - Use spread when converting completion entry to protocol format by gabritto · Pull Request #59412 · microsoft/TypeScript

Open Graph Description: This avoids a problem that's happened in the past where we add a new property to the internal completion entry type, but forget to set it when converting it to the protocol completion entry for...

X Description: This avoids a problem that's happened in the past where we add a new property to the internal completion entry type, but forget to set it when converting it to the protocol completion entry...

Opengraph URL: https://github.com/microsoft/TypeScript/pull/59412

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:852a77cd-f152-2a66-358e-72484c4662ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9D8:882E2:CC5FEC:10F129C:6B00F378
html-safe-nonce141995281e7f185385f16c493ee68921f87f170ac73f22639fe17afc12273adb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUQ4Ojg4MkUyOkNDNUZFQzoxMEYxMjlDOjZCMDBGMzc4IiwidmlzaXRvcl9pZCI6IjY1MjUwMDIxMjMxNjY5NzQ2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac920ea07e26fa3d0ab8e928db29bb709374bd9935343154db2a8cee8817a3f376
hovercard-subject-tagpull_request:1986220880
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/59412/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59412
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c38c1473cfdc1d93f5491bb57cdadd564b932269ff57d7a21522dad10eea3bf0/microsoft/TypeScript/pull/59412
og:image:altThis avoids a problem that's happened in the past where we add a new property to the internal completion entry type, but forget to set it when converting it to the protocol completion entry for...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabritto
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/pull/59412#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59412
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59412
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/pull/59412
Reloadhttps://github.com/microsoft/TypeScript/pull/59412
Reloadhttps://github.com/microsoft/TypeScript/pull/59412
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
mainhttps://github.com/microsoft/TypeScript/tree/main
gabritto/entryprotocolhttps://github.com/microsoft/TypeScript/tree/gabritto/entryprotocol
Conversationhttps://github.com/microsoft/TypeScript/pull/59412
Commits1 (1)https://github.com/microsoft/TypeScript/pull/59412/commits
Checkshttps://github.com/microsoft/TypeScript/pull/59412/checks
Files changedhttps://github.com/microsoft/TypeScript/pull/59412/files
Use spread when converting completion entry to protocol formathttps://github.com/microsoft/TypeScript/pull/59412#top
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
mainhttps://github.com/microsoft/TypeScript/tree/main
gabritto/entryprotocolhttps://github.com/microsoft/TypeScript/tree/gabritto/entryprotocol
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issue-2428453544
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
#59339https://github.com/microsoft/TypeScript/pull/59339
#59410https://github.com/microsoft/TypeScript/pull/59410
#36063https://github.com/microsoft/TypeScript/pull/36063
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/gabritto
use spread when converting completion entry to protocol formathttps://github.com/microsoft/TypeScript/pull/59412/commits/88a3a6ca8adb9b855e87635af119d87221edde0a
88a3a6chttps://github.com/microsoft/TypeScript/pull/59412/commits/88a3a6ca8adb9b855e87635af119d87221edde0a
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#event-13636261421
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#event-13636261523
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248924407
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
July 24, 2024 21:23https://github.com/microsoft/TypeScript/pull/59412#event-13636525950
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248925971
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
TypeScript Bot (@typescript-bot)https://github.com/typescript-bot
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248926031
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162988
👀 Resultshttps://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248978170
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162987
✅ Resultshttps://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248947238
✅ Startedhttps://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_build/results?buildId=162986
👀 Resultshttps://github.com/microsoft/TypeScript/pull/59412#issuecomment-2249075455
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
July 24, 2024 21:24https://github.com/microsoft/TypeScript/pull/59412#event-13636539933
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248947238
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2248978170
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
Download Benchmarkshttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162988&view=artifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Jul 24, 2024 https://github.com/microsoft/TypeScript/pull/59412#pullrequestreview-2197918282
View reviewed changes https://github.com/microsoft/TypeScript/pull/59412/files/88a3a6ca8adb9b855e87635af119d87221edde0a
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2249075455
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
elastic/kibanahttps://github.com/elastic/kibana
artifact folderhttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162986&view=artifacts&type=publishedArtifacts
artifact folderhttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162986&view=artifacts&type=publishedArtifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Jul 24, 2024https://github.com/microsoft/TypeScript/pull/59412#issuecomment-2249075460
Gabriela Araujo Britto (@gabritto)https://github.com/gabritto
calcom/cal.comhttps://github.com/calcom/cal.com
artifact folderhttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162986&view=artifacts&type=publishedArtifacts
artifact folderhttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162986&view=artifacts&type=publishedArtifacts
backstage/backstagehttps://github.com/backstage/backstage
artifact folderhttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162986&view=artifacts&type=publishedArtifacts
artifact folderhttps://typescript.visualstudio.com/TypeScript/_build/results?buildId=162986&view=artifacts&type=publishedArtifacts
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat)https://github.com/sheetalkamat
Jul 25, 2024 https://github.com/microsoft/TypeScript/pull/59412#pullrequestreview-2198004377
View reviewed changes https://github.com/microsoft/TypeScript/pull/59412/files/88a3a6ca8adb9b855e87635af119d87221edde0a
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
f8336d1https://github.com/microsoft/TypeScript/commit/f8336d1479c9909d9850931a619f2ed7e884f0fc
Jul 25, 2024https://github.com/microsoft/TypeScript/pull/59412#event-13637720247
https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
July 25, 2024 00:29https://github.com/microsoft/TypeScript/pull/59412#event-13637720527
https://github.com/microsoft
Microsoft (microsoft)https://github.com/microsoft
Oct 16, 2025https://github.com/microsoft/TypeScript/pull/59412#event-20309761243
https://github.co/hiddenchars
https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59412
https://github.com/andrewbranch
Andrew Branch (andrewbranch) https://github.com/andrewbranch
https://github.com/microsoft/TypeScript/pull/59412/files/88a3a6ca8adb9b855e87635af119d87221edde0a
https://github.com/sheetalkamat
Sheetal Nandi (sheetalkamat) https://github.com/sheetalkamat
https://github.com/microsoft/TypeScript/pull/59412/files/88a3a6ca8adb9b855e87635af119d87221edde0a
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) https://github.com/DanielRosenwasser
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/gabritto
Gabriela Araujo Britto (gabritto) https://github.com/gabritto
Author: Team https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22
For Uncommitted Bug https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22
Please reload this pagehttps://github.com/microsoft/TypeScript/pull/59412
https://github.com/gabritto
https://github.com/typescript-bot
https://github.com/andrewbranch
https://github.com/sheetalkamat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.