| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5d1f6f04-cf01-20f6-44a6-f1d1655d532d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5A2:1E7974:3DC604:53893E:6A5FCA55 |
| html-safe-nonce | 0af1049a39d1f12129074ff193ada9f604fa69ed826bc71c0618c99c4c5c4d1f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUEyOjFFNzk3NDozREM2MDQ6NTM4OTNFOjZBNUZDQTU1IiwidmlzaXRvcl9pZCI6IjU3OTQ2MjQxNzkzNzIyODA0MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7a40b94360d3837b03e8c5611dd8c7a2c5ebac14970e0cec29c93613b48a347a |
| hovercard-subject-tag | pull_request:1962749760 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/TypeScript/59223/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0d3a194e313aa15f2c751a5433e045fc11862446f2f20d20877bf710a3c237da/microsoft/TypeScript/pull/59223 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0d3a194e313aa15f2c751a5433e045fc11862446f2f20d20877bf710a3c237da/microsoft/TypeScript/pull/59223 |
| og:image:alt | After #58854, build mode proceeds even if there were errors. However, in our codebase we use noEmitOnError.
If I stick a random type error in src/compiler/types.ts, then run the build, I end up wit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jakebailey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8b098704642cd5473d3dc9d5d8023399a68de27a0492776c4517d75af6710ead |
| turbo-cache-control | no-cache |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d9cb40632285451ad16923c07a6f2debe8279086 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/TypeScript/pull/59223#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59223 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59223 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2FTypeScript |
| Reload | https://github.com/microsoft/TypeScript/pull/59223 |
| Reload | https://github.com/microsoft/TypeScript/pull/59223 |
| Reload | https://github.com/microsoft/TypeScript/pull/59223 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
|
microsoft
| https://github.com/microsoft |
| TypeScript | https://github.com/microsoft/TypeScript |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Fork
13.6k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Star
110k
| https://github.com/login?return_to=%2Fmicrosoft%2FTypeScript |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
5k+
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
29
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
0
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
|
Code
| https://github.com/microsoft/TypeScript |
|
Issues
| https://github.com/microsoft/TypeScript/issues |
|
Pull requests
| https://github.com/microsoft/TypeScript/pulls |
|
Actions
| https://github.com/microsoft/TypeScript/actions |
|
Projects
| https://github.com/microsoft/TypeScript/projects |
|
Models
| https://github.com/microsoft/TypeScript/models |
|
Wiki
| https://github.com/microsoft/TypeScript/wiki |
|
Security and quality
| https://github.com/microsoft/TypeScript/security |
|
Insights
| https://github.com/microsoft/TypeScript/pulse |
| jakebailey | https://github.com/jakebailey |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| jakebailey:disable-no-emit-on-error | https://github.com/jakebailey/TypeScript/tree/disable-no-emit-on-error |
| Conversation | https://github.com/microsoft/TypeScript/pull/59223 |
| Commits1 (1) | https://github.com/microsoft/TypeScript/pull/59223/commits |
| Checks | https://github.com/microsoft/TypeScript/pull/59223/checks |
| Files changed | https://github.com/microsoft/TypeScript/pull/59223/files |
| Disable noEmitOnError | https://github.com/microsoft/TypeScript/pull/59223#top |
| jakebailey | https://github.com/jakebailey |
| microsoft:main | https://github.com/microsoft/TypeScript/tree/main |
| jakebailey:disable-no-emit-on-error | https://github.com/jakebailey/TypeScript/tree/disable-no-emit-on-error |
|
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| Jul 10, 2024 | https://github.com/microsoft/TypeScript/pull/59223#issue-2401146220 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
| #58854 | https://github.com/microsoft/TypeScript/pull/58854 |
| https://github.com/microsoft/TypeScript/actions/runs/9868392724/job/27250345885?pr=59217 | https://github.com/microsoft/TypeScript/actions/runs/9868392724/job/27250345885?pr=59217 |
| #58854 (comment) | https://github.com/microsoft/TypeScript/pull/58854#issuecomment-2168694162 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
|
| https://github.com/jakebailey |
| Disable noEmitOnError | https://github.com/microsoft/TypeScript/pull/59223/commits/9052686e10d6bb7b40cae0d3dde43e39303ba213 |
| 9052686 | https://github.com/microsoft/TypeScript/pull/59223/commits/9052686e10d6bb7b40cae0d3dde43e39303ba213 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| sheetalkamat | https://github.com/sheetalkamat |
| July 10, 2024 16:01 | https://github.com/microsoft/TypeScript/pull/59223#event-13458668703 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
| jakebailey | https://github.com/jakebailey |
| Jul 10, 2024 | https://github.com/microsoft/TypeScript/pull/59223#event-13458669585 |
| https://github.com/typescript-bot |
| typescript-bot | https://github.com/typescript-bot |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Jul 10, 2024 | https://github.com/microsoft/TypeScript/pull/59223#event-13458669792 |
| https://github.com/sheetalkamat |
| sheetalkamat | https://github.com/sheetalkamat |
|
Jul 10, 2024
| https://github.com/microsoft/TypeScript/pull/59223#pullrequestreview-2169757400 |
|
View reviewed changes
| https://github.com/microsoft/TypeScript/pull/59223/files/9052686e10d6bb7b40cae0d3dde43e39303ba213 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| Jul 10, 2024 | https://github.com/microsoft/TypeScript/pull/59223#issuecomment-2221025896 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
| @sheetalkamat | https://github.com/sheetalkamat |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| 2fd707d | https://github.com/microsoft/TypeScript/commit/2fd707d850fa112e5d9f35797ee6145066c3d44d |
| Jul 10, 2024 | https://github.com/microsoft/TypeScript/pull/59223#event-13459423709 |
| https://github.com/jakebailey |
| jakebailey | https://github.com/jakebailey |
| July 10, 2024 16:59 | https://github.com/microsoft/TypeScript/pull/59223#event-13459424700 |
| https://github.com/sheetalkamat |
| sheetalkamat | https://github.com/sheetalkamat |
| Jul 10, 2024 | https://github.com/microsoft/TypeScript/pull/59223#issuecomment-2221123449 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
| https://github.com/sandersn |
| sandersn | https://github.com/sandersn |
| PR Backlog | https://github.com/orgs/microsoft/projects/1252 |
| Apr 22, 2025 | https://github.com/microsoft/TypeScript/pull/59223#event-17355400163 |
| https://github.com/microsoft |
| microsoft | https://github.com/microsoft |
| Oct 16, 2025 | https://github.com/microsoft/TypeScript/pull/59223#event-20309761123 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fpull%2F59223 |
|
| https://github.com/sheetalkamat |
|
sheetalkamat
| https://github.com/sheetalkamat |
|
| https://github.com/microsoft/TypeScript/pull/59223/files/9052686e10d6bb7b40cae0d3dde43e39303ba213 |
|
| https://github.com/jakebailey |
|
jakebailey
| https://github.com/jakebailey |
|
Author: Team
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Author%3A%20Team%22 |
|
For Uncommitted Bug
| https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22For%20Uncommitted%20Bug%22 |
| Please reload this page | https://github.com/microsoft/TypeScript/pull/59223 |
|
| https://github.com/jakebailey |
|
| https://github.com/sheetalkamat |
|
| https://github.com/sandersn |
|
| https://github.com/typescript-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |